Commit Graph
13221 Commits
Author SHA1 Message Date
Tim Jacomb 8f978a960b Merge pull request #4681 from Vlatombe/JENKINS-62006 2020-05-01 20:40:39 +01:00
Tim Jacomb 1837293356 JENKINS-61208 Allow system read to view more admin monitors (#4685) 2020-05-01 12:01:30 +01:00
Raihaan Shouhell 05dd40953f Merge pull request #4694 from daniel-beck/better-signature-logging
Better logging for signature validation
2020-05-01 17:43:10 +08:00
Wadeck Follonier b911b0466c [JENKINS-60866] Un-inline JavaScript from ReverseProxySetupMonitor (#4626)
* [JENKINS-60866] Un-inline JavaScript from ReverseProxySetupMonitor

* Also un-inlining CSS

* Arrow to function

* Differentiate css-class and js-class

* The forgotten one
2020-04-29 20:30:02 +08:00
Raihaan Shouhell c3e2f20d4c Merge pull request #4655 from dwnusbaum/JENKINS-61841-rebased
[JENKINS-61841] Limit the number of exceptions stored by CompositeIOException
2020-04-29 19:00:38 +08:00
Raihaan Shouhell 6b5930817b Merge pull request #4687 from daniel-beck/fix-ExtensionComponent-compareTo
[JENKINS-62056] Fix ExtensionComponent#compareTo
2020-04-29 19:00:04 +08:00
Daniel Beck 0e91195844 Better logging for signature validation 2020-04-29 02:55:39 +02:00
Raihaan Shouhell ab5616712a Merge pull request #4686 from daniel-beck/signup-warning
Add form validation warning when signup is enabled
2020-04-28 20:36:31 +08:00
Daniel Beck 5c58f82c0d [JENKINS-62056] Fix ExtensionComponent#compareTo 2020-04-25 23:27:23 +02:00
Daniel Beck eee345b0e5 Add form validation warning when signup is enabled 2020-04-25 19:12:54 +02:00
Tim Jacomb 58771040b4 Merge pull request #4664 from StefanSpieker/spotbugs_performance 2020-04-25 14:26:17 +01:00
Tim Jacomb aa3ad0664a Fix available tab sort order and support popularity outside 0..1 range (#4675) 2020-04-25 14:25:20 +01:00
Tim JacombandDaniel Beck 072b36de7d JENKINS-61207 System read - logs (#4530)
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-04-25 14:24:57 +01:00
Raihaan Shouhell 9278c1668d Merge pull request #4667 from StefanSpieker/hudsonExceptionNote
Removed unused deprecated HudsonExceptionNote
2020-04-25 18:06:04 +08:00
Raihaan Shouhell b56c767f44 Merge pull request #4677 from jglick/numExecutors
Slave.numExecutors should default to 1
2020-04-25 18:03:43 +08:00
Vincent Latombe 25c8cb6be5 Fix reviews 2020-04-22 13:51:20 +02:00
Vincent Latombe 85974f3ec5 [JENKINS-62006] Move getChannelToMaster to a separate class
This should avoid classloading issues I've seen, such as

Caused by: java.lang.NoClassDefFoundError:
javax/servlet/ServletException
  at hudson.util.ProcessTree.get(ProcessTree.java:432)
...
2020-04-22 12:58:06 +02:00
Daniel Beck a54823769a Fix Available tab sort order and support popularity outside 0..1 range 2020-04-21 23:46:45 +02:00
Daniel Beck 2741ffb3b6 Reduce code duplication in SystemProperties
This will replace a rarely seen log message saying "not found" with
one that says "default: ... => null", but that seems OK.
2020-04-21 22:03:55 +02:00
Wadeck FollonierandJeff Thompson 3b85c0a877 [JENKINS-61738][2] Session hijacking protection hardening (#4615)
* [JENKINS-61738] Session hijacking protection hardening

* Workaround bad test

* Better approach in terms of test

* Get rid of small whitespace

* Update core/src/main/java/hudson/WebAppMain.java

Co-Authored-By: Jeff Thompson <37345299+jeffret-b@users.noreply.github.com>

* Update war/src/main/webapp/WEB-INF/web.xml

Co-Authored-By: Jeff Thompson <37345299+jeffret-b@users.noreply.github.com>

* Use release companion PR

Co-authored-by: Jeff Thompson <37345299+jeffret-b@users.noreply.github.com>
2020-04-21 13:27:11 -06:00
Jesse Glick 16bde8a6f5 Slave.numExecutors should default to 1 2020-04-21 15:19:19 -04:00
HelenandHelen Spry c78b8e3411 Refactoring CLICommand.java (#4641)
* extracted duplicated code in method

* removed unnecessary assignments

* added back variable to reduce duplication and changed name of method

Co-authored-by: Helen Spry <spry@Helens-MacBook-Pro.local>
2020-04-21 22:50:44 +08:00
Stefan Spieker c7564f8596 removed unused imports 2020-04-19 20:53:35 +02:00
Tim Jacomb 29a91111a9 Merge pull request #4533 from timja/system-read-admin-monitors
JENKINS-61208 System read - admin monitor pattern
2020-04-19 10:34:54 +01:00
Tim Jacomb 06fc7b12ec Merge pull request #4519 from timja/system-read-tool-configuration
JEP-224 System read - Global tool configuration
2020-04-19 10:34:22 +01:00
Tim Jacomb e4c034f128 Merge pull request #4588 from daniel-beck/popularity
Sort available plugins by popularity
2020-04-19 10:33:25 +01:00
Daniel Beck 0d948792fd Merge pull request #4654 from daniel-beck/fix-isDevelopment-comment
Fix comment about when this is set
2020-04-19 01:44:12 +02:00
Tim Jacomb 2a5cb24ec0 Merge pull request #4657 from daniel-beck/redirect-groovy-view-to-login
[JENKINS-61905] Forward Groovy view permission errors to login
2020-04-18 21:12:45 +01:00
Stefan Spieker e1a36801c0 removed outdated comment 2020-04-18 17:23:04 +02:00
Stefan Spieker 41bb5cb7b8 removed unused deprecated HudsonExceptionNote 2020-04-18 17:17:14 +02:00
Stefan Spieker cef21719e4 minor spotbugs performance improvement 2020-04-18 14:14:20 +02:00
Daniel Beck 5695e3a182 More Javadoc to help implementers, simplify code a bit 2020-04-17 22:30:16 +02:00
Devin Nusbaum 341ffa9f11 [JENKINS-61481] Note the number of discarded exceptions in the message of the CompositeIOException 2020-04-16 17:01:54 -04:00
Daniel Beck a6ebf3b4bf Merge branch 'master' into popularity 2020-04-16 16:41:36 +02:00
Daniel Beck 44abe70831 Skip the loop 2020-04-16 13:22:07 +02:00
Rishabh BudhouliyaandMark Waite be1e2bea7e [JENKINS-61711] Fix validateExecutable to allow Git plugin global config correctly report git executable in PATH (#4653)
* Fix git not in path for Git plugin global config
Git Client Plugin global configuration allows addition of git implementations using GitTool
The field Path was not able to identify git executable. The fix involves changing prefix with
File.seperator instead of File.pathSeperator. This allows Jenkins to find the git exec at the
already existing path.

* Tests added to validate JENKINS-61711 fix

* Improve hamcrest comparison in FormValidationTest

Co-Authored-By: Mark Waite <mark.earl.waite@gmail.com>

* Import matchers for `not`

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2020-04-16 09:35:41 +02:00
Daniel Beck 2bf9fc2130 [JENKINS-61905] Forward Groovy view permission errors to login 2020-04-15 01:59:46 +02:00
Devin Nusbaum acb2ff00de [JENKINS-61841] Limit the number of exceptions stored by CompositeIOException 2020-04-14 17:48:15 -04:00
Daniel Beck ba2d460ad4 Fix comment about when this is set 2020-04-14 22:54:08 +02:00
Raihaan Shouhell d7b0a9d699 Merge pull request #4638 from jglick/Slave.labels
Removing apparently unused Slave.labels
2020-04-14 09:03:02 +08:00
Oleg Nenashev 7e40e1e396 Merge pull request #4609 from StefanSpieker/spotbugs_cookie
Set httpOnly and secure on cookies to fix spotbugs issue
2020-04-12 14:07:19 +02:00
Tim Jacomb 9bb02ecfa3 Merge pull request #4586 from daniel-beck/manage-context-menu-titles
Add section titles to Manage Jenkins context menu
2020-04-12 10:12:44 +01:00
Oleg Nenashev 60cb47fcf8 Merge pull request #4557 from timja/timezone-property
Make TimeZoneProperty compatible with JCasc
2020-04-11 13:21:01 +02:00
Oleg Nenashev c0bacad9b2 Merge pull request #4621 from jglick/SLAVE_LOG_HANDLER-parameters
An agent log record with numeric params could be unformattable on the master
2020-04-11 13:11:10 +02:00
Oleg Nenashev 13966d2c0d Merge pull request #4636 from jvz/commons-codec-cleanup
Commons codec cleanup
2020-04-11 13:09:08 +02:00
Oleg Nenashev e4619ebbbc Merge pull request #4617 from jglick/ExtensionFinder-logging
Reduce log level on notice about optional extensions
2020-04-11 13:08:41 +02:00
Oleg Nenashev 55aa46e66d Merge pull request #4632 from jglick/LogTaskListener-annotations
Fixing console annotation masking in LogTaskListener
2020-04-11 13:08:11 +02:00
Tim JacombandDaniel Beck 9b4a62c716 JENKINS-61203 System read - Plugin Manager (#4518)
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-04-09 22:36:46 +01:00
Jesse Glick f7e2d65062 Removing apparently unused Slave.labels 2020-04-09 11:30:49 -04:00
Matt Sicker baa1dc5b9a Use standard Java Base64 class
Signed-off-by: Matt Sicker <boards@gmail.com>
2020-04-08 15:25:16 -05:00