Commit Graph
19505 Commits
Author SHA1 Message Date
Basil Crow 9edaffcf7b Use functionality from XStream2 where possible (#8504) 2023-09-20 20:48:04 +02:00
Pierre Beitz af260cb526 [chore] Remove useless TODO (#8501) 2023-09-20 20:47:44 +02:00
Jesse Glick e996d0cd53 Optimization for AbstractLazyLoadRunMap.loadNumberOnDisk (#8494) 2023-09-20 20:46:09 +02:00
Jesse Glick 3e1747eca6 [JENKINS-72016] Define a thread pool for ProxyConfiguration’s HttpClient (#8490)
* Define a thread pool for `ProxyConfiguration`’s `HttpClient`

* Skip test on Windows https://github.com/jenkinsci/jenkins/pull/8490#issuecomment-1720108881
2023-09-20 20:45:14 +02:00
Vincent Latombe 7d285718c2 LogRecorder programmatic deletion support (#8489)
* Add programmatic deletion support for LogRecorder.
* Also added event handling through SaveableListener whenever it gets deleted.
2023-09-20 20:44:29 +02:00
Basil Crow b7920ec5ea Remove finalization from RegistryKey (#8488) 2023-09-20 20:44:04 +02:00
Basil Crow 807243e6bf Remove usages of deprecated ThreadDeath (#8487) 2023-09-20 20:43:47 +02:00
Basil Crow febca34a3d Migrate from deprecated finalization API to Java 9+ API (#8486)
* Migrate from deprecated finalization API to Java 9+ API

* Use non-deprecated JTH method
2023-09-20 20:43:16 +02:00
Jesse Glick 2a07b98e9c StringIndexOutOfBoundsException in AbstractItem.getUrl (#8481) 2023-09-20 20:42:26 +02:00
Yaroslav Afenkin f21cf875dc Merge branch 'security-master' 2023-09-12 17:59:34 +03:00
Markus Winter d41b0f5807 [JENKINS-71983] allow symbols in MenuItem#withIconClass (#8471)
[JENKINS-71983] fix symbols in MenuItem#withIconClass

when a symbol is passed to MenuItem#withIconClass the symbol is now
properly displayed
2023-09-10 13:02:44 +02:00
Markus Winter 6b00394d85 Prevent scrolling for textarea preview (#8472)
prevent scrolling for preview

Prevent that when clicking on preview for a textarea, the page scrolls
to the top and the url changed.
2023-09-10 13:01:04 +02:00
Jan FaracikandAlexander Brandes 30540d76d3 Move Node monitoring option to app bar (#8381)
* Init

* Update index.jelly

* Update index.jelly

* Add description

* Add description

* Fix test

* Update ComputerSetTest.java

---------

Co-authored-by: Alexander Brandes <mc.cache@web.de>
2023-09-08 21:49:43 -06:00
Vincent Latombe 2971155ccb Make branding overridable in signin/login page (#8462)
* Move resources from DefaultSimplePageDecorator to SimplePageDecorator to ease implementation.
2023-09-08 21:48:51 -06:00
Markus Winter 54c79f1e7d update badge documentation (#8469)
* badge documentation

Include in the badge documentation that it can be used in <l:task links

Set type for the badge attribute of lib/form/task

* fix javadoc
2023-09-08 21:48:18 -06:00
Basil CrowandVincent Latombe 830cb8addc Avoid usage of Guava from ProcessTree (#8467)
* Avoid usage of Guava from `ProcessTree`

* Update core/src/main/java/hudson/util/ProcessTree.java

Co-authored-by: Vincent Latombe <vincent@latombe.net>

---------

Co-authored-by: Vincent Latombe <vincent@latombe.net>
2023-09-08 21:47:38 -06:00
Kevin-CB f06bb88201 [SECURITY-3073] 2023-09-06 11:17:31 +00:00
Kevin-CB df7c4ccda8 [SECURITY-3072] 2023-09-06 11:17:25 +00:00
Yaroslav Afenkin 4bf648811f [SECURITY-3245] 2023-09-06 11:17:19 +00:00
Daniel Beck b8ac8cd4c5 [SECURITY-3261] 2023-09-06 11:17:14 +00:00
Mümin Köykıran 582184f7c0 [JENKINS-71958] Update scriptConsole_tr.properties (#8460)
Update scriptConsole_tr.properties

* The Turkish translation of the "Run" parameter has been corrected.
2023-09-04 18:54:43 +02:00
Vincent Latombe e79ac42baa Merge pull request #8448 from Vlatombe/labelAtomSet-robustness
Label parsing robustness fix
2023-09-02 11:49:37 +02:00
Mustafa Ulu c98e76b5ae Turkish localization fixes for the new job page (#8446) 2023-09-01 18:01:19 -06:00
Basil Crow 33dc1fb2b4 [JENKINS-71950] List plugins in deterministic order (#8453)
List plugins in deterministic order
2023-09-01 18:00:06 -06:00
Daniel BeckandDaniel Beck 95373a96f7 Add telemetry for security-related settings (#8440)
* Add telemetry for security-related settings

* Actually include component information

* FindBugs, also TcpSlaveAgentListener can be null

---------

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2023-08-31 20:14:11 +02:00
Vincent LatombeandDaniel Beck 9a9cac88d3 Apply suggestions from code review
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2023-08-31 13:56:57 +02:00
Vincent Latombe 7cbb82cdc2 Fix spotbugs/checkstyle 2023-08-31 13:24:13 +02:00
Vincent Latombe 4a708e2b0a In case an extension of Slave overrides readResolve but does not call its super implementation
recover from it, and issue a warning to raise a bug against the impacted plugin.
2023-08-31 09:44:22 +02:00
Markus WinterandTim Jacomb 0c71e4105c Replace hetero-list YUI button and menu with new style button and Tippy.js menu (#8418)
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
2023-08-30 10:00:45 -07:00
Basil Crow 6e39c5b0c9 Side-port test cleanup from jenkinsci/remoting#587 (#8414) 2023-08-29 19:01:55 +02:00
Mark Waite 53d10fd754 Add more operating system end of life dates (#8438)
Users have reported bugs on additional operating systems that are already
end of life, like Ubuntu 20.10.  Include outdated Ubuntu operating
systems in the list so that the users are warned.

https://endoflife.date/ubuntu

Red Hat Enterprise Linux 9 has released along with its derivatives,
AlmaLinux, Rocky Linux, and Oracle Linux.  Include them in the end of
life data.

https://endoflife.date/rhel

https://endoflife.date/almalinux
https://endoflife.date/oraclelinux
https://endoflife.date/rocky-linux
2023-08-29 18:59:55 +02:00
Vincent LatombeandJesse Glick 7b1dfd8d83 Initialize default view earlier in the init process. (#8413)
* Initialize default view earlier in the init process.

Perform the default view initialization next to loading the
configuration from disk.

This is more consistent as the primary view and views are cleared just
before loading from disk, which leads to a temporary inconsistent state while
Jenkins initializes.

* Update core/src/main/java/jenkins/model/Jenkins.java

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

* View initialization should happen even when the config file doesn't exist.

* Add a test

---------

Co-authored-by: Jesse Glick <jglick@cloudbees.com>
2023-08-29 18:59:14 +02:00
Tim Jacomb d7da362feb Add Appearance system configuration page (#8403)
* Add `Appearance` system configuration page

* Use one-column layout

* Add developer guidance
2023-08-29 09:32:38 +01:00
Daniel BeckandDaniel Beck 560246958b Rename adjunct files to more easily associate with elements (#8423)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2023-08-27 21:21:24 -06:00
Daniel BeckandDaniel Beck 2ef05c510e Minor correction in UpdateCenter restart UI internals (#8419)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2023-08-27 21:20:49 -06:00
Daniel BeckandDaniel Beck 262e65cdff Fix PCT problem of #8250 (#8426)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2023-08-25 14:19:48 +01:00
16bf84c330 [JENKINS-71087] Nicer 404 error pages (#8250)
* Nicer 404 error pages

* Fix test, expose custom error message on 404 pages

* Record the current user to show an appropriate 404 page

* 404 simple page for the resource domain

the resource domain has no access to the static resources like
javascript and css. Open the images in the filter so we can at least
show an image.
Do not show the hint about not found or permission when accessing the
static-files url from the regular domain.

* Minor fixes and improvements

- Be more restrictive, only allow the specific image on simple 404
- Make extra resources work with non-empty resources path
- Do not redirect to 404 page after login from regular 404 page
- Remove 'Error:' prefix for friendlier page appearance
- Include favicon etc. resources in simple 404 page

* Fall back to 'Not Found' when accessing error pages directly

Also reformat

* Add 404 page tests

* Revert change to ResourceDomainTest

* Move test out of JenkinsTest, make parameterized for different contexts

* Return to the 404'd page after login by using 'from' session attribute

* Prevent 'REST API' link from showing on the error page

* Assert specific message on resource domain

* Remove obsolete commented out line

* Add Javadoc

---------

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
Co-authored-by: Markus Winter <m.winter@sap.com>
2023-08-23 07:27:21 +01:00
Vincent Latombe 76bfee23a0 Optimize Label parsing calls (#8395)
* Optimize Label#parse for simple label

For a simple label, this speeds up lookup of an existing simple label (no expression used):  16ns vs 106ns (6x faster)

* Fix reviews

* Fix include

* Avoid parsing label every time getAssignedLabels is called

* Store Set<LabelAtom> at Node descendants level
* Compute it whenever labelString is updated

* Fix spotbugs / test issue

* Make it restricted
2023-08-23 07:26:24 +01:00
Basil Crow 6b6d84670d Revert "Replace hetero-list YUI button and menu with new style button and tippy.js menu" (#8412)
Revert "Replace hetero-list YUI button and menu with new style button and tippy.js menu (#8340)"

This broke:

- org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SecureGroovyScriptTest
- hudson.plugins.textfinder.TextFinderPublisherFreestyleTest#createTextFinderViaWebClient

This reverts commit c1a6c6c9dd.
2023-08-21 19:27:31 -07:00
Markus WinterandTim Jacomb c1a6c6c9dd Replace hetero-list YUI button and menu with new style button and tippy.js menu (#8340)
* refresh hetero-list UI

use new button style
replace the YUI menu with a tippy menu

* fix lint errors

* avoid blanks

* prettier

* keep button in div

* fix test

* fix test #2

* convert inputs to buttons for plugins

* prettier

* remove unnecessary style definition

* remove adjunct

* adjust filter

---------

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
2023-08-21 23:27:55 +02:00
Daniel BeckandDaniel Beck ee02eec256 [JENKINS-71848] Remove admin monitors popup from /manage/ again (#8388)
[JENKINS-71848] Remove admin monitors popup from /manage/ again

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2023-08-21 23:25:19 +02:00
Jan Faracik e9886db619 Move app bar for plugins (#8376)
* Move app bar for plugins, make sidebar sticky

* Update _updateSite.js

* Remove sticky side panel
2023-08-21 23:23:41 +02:00
Jesse Glick 7f3fa048ca [JENKINS-61452] Tolerate corrupt Base64 in PlainTextConsoleOutputStream (#8378) 2023-08-19 18:08:49 +01:00
Jan Faracik 2c28368086 Remove 'track-mouse' JS (#8391) 2023-08-19 18:08:21 +01:00
Daniel BeckandDaniel Beck 4ef934e4c4 [JENKINS-71833] Fix link to job in slow trigger admin monitor (#8387)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2023-08-18 16:36:45 +02:00
Mysterious_DevandOlivier Lamy 02fbe762ad Many French translations for plugin panels (#8382)
Co-authored-by: Olivier Lamy <olamy@apache.org>
2023-08-18 16:36:16 +02:00
Mustafa Ulu 5c723b6673 Turkish localization fixes for the job configuration page (#8368) 2023-08-18 16:35:07 +02:00
83085bac00 Display a notice when there are plugins installed or updates available (#8208)
Co-authored-by: Alexander Brandes <brandes.alexander@web.de>
Co-authored-by: Alexander Brandes <mc.cache@web.de>
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
2023-08-15 15:38:32 +01:00
a8a144d72a Update the design of the content blocks (#8363)
Co-authored-by: Tim Jacomb <timjacomb1@gmail.com>
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
2023-08-15 15:38:20 +01:00
Jan Faracik dfb83f6d15 Deprecate findAncestor and findAncestorClass (#8357) 2023-08-15 15:37:55 +01:00