https://svn.dev.java.net/svn/hudson/branches/rc
........
r29309 | kohsuke | 2010-03-26 14:44:45 -0700 (Fri, 26 Mar 2010) | 1 line
Work around for http://n4.nabble.com/hudson-logging-LogRecorderManagerTest-failing-tp1589811p1589811.html
........
r29310 | kohsuke | 2010-03-26 14:45:29 -0700 (Fri, 26 Mar 2010) | 1 line
unnecessary boxing
........
r29311 | kohsuke | 2010-03-26 16:00:41 -0700 (Fri, 26 Mar 2010) | 1 line
fixed a stability in the test.
........
r29421 | kohsuke | 2010-03-29 11:40:37 -0700 (Mon, 29 Mar 2010) | 1 line
improving the test stability
........
r29449 | kohsuke | 2010-03-29 18:08:26 -0700 (Mon, 29 Mar 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_353
........
r29451 | kohsuke | 2010-03-29 18:08:46 -0700 (Mon, 29 Mar 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
r29459 | kohsuke | 2010-03-29 19:20:42 -0700 (Mon, 29 Mar 2010) | 1 line
updated changelog as a part of the release
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29490 71c3de6d-444a-0410-be80-ed276b4c234a
Merged revisions 27137,27564,27566-27567,27578,27586,27599,27603,27606-27609,27611,27616,27626-27632,27640,27654-27656,27687,27701,27801,27816,27819,27843-27845,28087,28158-28161 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/HUDSON-2137
........
r27137 | kohsuke | 2010-02-08 08:46:16 -0800 (Mon, 08 Feb 2010) | 1 line
experimenting with abstractions
........
r27564 | kohsuke | 2010-02-16 07:58:26 -0800 (Tue, 16 Feb 2010) | 1 line
bundling makes it easier for caller to handle ConsoleAnnotator
........
r27566 | kohsuke | 2010-02-16 08:49:48 -0800 (Tue, 16 Feb 2010) | 1 line
this should work with Runs, not AbstractBuilds
........
r27567 | kohsuke | 2010-02-16 08:54:06 -0800 (Tue, 16 Feb 2010) | 1 line
simplified
........
r27578 | kohsuke | 2010-02-16 12:26:11 -0800 (Tue, 16 Feb 2010) | 1 line
still a work in progress, but committing once to pull in trunk changes
........
r27586 | kohsuke | 2010-02-16 14:35:37 -0800 (Tue, 16 Feb 2010) | 1 line
making more progress
........
r27599 | kohsuke | 2010-02-16 19:22:01 -0800 (Tue, 16 Feb 2010) | 2 lines
hooking up the side that writes annotations.
still a work in progress.
........
r27603 | kohsuke | 2010-02-16 23:43:35 -0800 (Tue, 16 Feb 2010) | 3 lines
what appears to me as the first cut of hooking up the reader side of the annotations.
I haven't even run it yet --- this just passed the compilation, and I'm calling it a day.
........
r27606 | kohsuke | 2010-02-17 09:15:16 -0800 (Wed, 17 Feb 2010) | 1 line
demo instance hook up
........
r27607 | kohsuke | 2010-02-17 11:27:02 -0800 (Wed, 17 Feb 2010) | 3 lines
one more utility method.
I never understood what the point of letting the skip method skip less.
........
r27608 | kohsuke | 2010-02-17 11:56:23 -0800 (Wed, 17 Feb 2010) | 3 lines
- moved LargeText subtype to its own class
- skipping log output was done incorrectly --- it had to skip N bytes where it was skipping N chars.
- hooked up console annotations for completed builds.
........
r27609 | kohsuke | 2010-02-17 12:01:46 -0800 (Wed, 17 Feb 2010) | 1 line
copyright header
........
r27611 | kohsuke | 2010-02-17 13:18:10 -0800 (Wed, 17 Feb 2010) | 1 line
introduced a mechanism to register extension during an unit test.
........
r27616 | kohsuke | 2010-02-17 13:38:12 -0800 (Wed, 17 Feb 2010) | 1 line
test case for console annotations
........
r27626 | kohsuke | 2010-02-17 15:23:06 -0800 (Wed, 17 Feb 2010) | 1 line
removing test ConsoleAnnotator as I write tests as tests
........
r27627 | kohsuke | 2010-02-17 16:06:13 -0800 (Wed, 17 Feb 2010) | 1 line
added a multi-phase cooperative locking mechanism useful during the debugging
........
r27628 | kohsuke | 2010-02-17 16:06:41 -0800 (Wed, 17 Feb 2010) | 1 line
testing progressive log annotation
........
r27629 | kohsuke | 2010-02-17 16:20:32 -0800 (Wed, 17 Feb 2010) | 1 line
adding a test for ConsoleAnnotation that's explicitly placed.
........
r27630 | kohsuke | 2010-02-17 16:23:02 -0800 (Wed, 17 Feb 2010) | 1 line
removing test ConsoleAnnotation as I write tests as tests
........
r27631 | kohsuke | 2010-02-17 16:28:50 -0800 (Wed, 17 Feb 2010) | 1 line
tweaking the abstraction a bit.
........
r27632 | kohsuke | 2010-02-17 16:44:21 -0800 (Wed, 17 Feb 2010) | 1 line
parameterized the context type so that this can be used in places other than the build console output, such as polling logs, slave logs, and so on.
........
r27640 | kohsuke | 2010-02-17 17:27:52 -0800 (Wed, 17 Feb 2010) | 1 line
bug fix
........
r27654 | kohsuke | 2010-02-17 22:53:04 -0800 (Wed, 17 Feb 2010) | 1 line
doc improvement
........
r27655 | kohsuke | 2010-02-17 22:53:59 -0800 (Wed, 17 Feb 2010) | 1 line
doc improvement
........
r27656 | kohsuke | 2010-02-17 23:10:42 -0800 (Wed, 17 Feb 2010) | 1 line
test case for adjacent tags
........
r27687 | kohsuke | 2010-02-19 14:39:21 -0800 (Fri, 19 Feb 2010) | 1 line
introduced a facotry and descriptor. This allows them to define configuration pages, allow users to disable/enable them, plus define custom behaviors.
........
r27701 | kohsuke | 2010-02-19 18:23:52 -0800 (Fri, 19 Feb 2010) | 1 line
defining a mechanism for ConsoleAnnotatorFactory and ConsoleAnnotationDescriptor to define script.js and have them imported into the console output page
........
r27801 | kohsuke | 2010-02-22 11:59:16 -0800 (Mon, 22 Feb 2010) | 1 line
now embedding annotations inside the console output log file.
........
r27816 | kohsuke | 2010-02-22 15:45:04 -0800 (Mon, 22 Feb 2010) | 1 line
introduced a convenience method for unit tests
........
r27819 | kohsuke | 2010-02-22 17:37:05 -0800 (Mon, 22 Feb 2010) | 5 lines
As an example of using embedded console annotations, implementing Ant target invocation outlines.
It might be better to make the concept of outline more generally reusable, so that different kinds of outlines can be placed into the same container element for a single hierarchical representation.
Still a work in progress.
........
r27843 | kohsuke | 2010-02-23 16:12:13 -0800 (Tue, 23 Feb 2010) | 1 line
for now, disable this for production usage, until I work out a better UI.
........
r27844 | kohsuke | 2010-02-23 19:08:00 -0800 (Tue, 23 Feb 2010) | 1 line
started working on annotating exception.
........
r27845 | kohsuke | 2010-02-23 19:08:33 -0800 (Tue, 23 Feb 2010) | 1 line
more TODOs for myself
........
r28087 | kohsuke | 2010-03-01 10:03:55 -0800 (Mon, 01 Mar 2010) | 1 line
formatting changes
........
r28158 | kohsuke | 2010-03-02 17:00:00 -0800 (Tue, 02 Mar 2010) | 1 line
ConsoleAnnotation and ConsoleAnnotator are too confusing.
........
r28159 | kohsuke | 2010-03-02 17:02:02 -0800 (Tue, 02 Mar 2010) | 1 line
doc improvement
........
r28160 | kohsuke | 2010-03-02 17:05:14 -0800 (Tue, 02 Mar 2010) | 1 line
more doc improvements.
........
r28161 | kohsuke | 2010-03-02 17:11:59 -0800 (Tue, 02 Mar 2010) | 1 line
more doc improvement
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28173 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r27147 | kohsuke | 2010-02-08 11:10:47 -0800 (Mon, 08 Feb 2010) | 1 line
[FIXED HUDSON-5536] in 1.345 and added a test case.
........
r27149 | kohsuke | 2010-02-08 12:01:18 -0800 (Mon, 08 Feb 2010) | 1 line
added a backward compatibility measure to expose variables in both forms
........
r27150 | kohsuke | 2010-02-08 12:02:19 -0800 (Mon, 08 Feb 2010) | 1 line
forgot to commit this(?)
........
r27151 | kohsuke | 2010-02-08 12:24:51 -0800 (Mon, 08 Feb 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_345
........
r27153 | kohsuke | 2010-02-08 12:25:04 -0800 (Mon, 08 Feb 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27154 71c3de6d-444a-0410-be80-ed276b4c234a
https://www.dev.java.net/svn/hudson/branches/test-result-refactor
........
r24854 | bshine | 2009-12-22 12:52:32 -0800 (Tue, 22 Dec 2009) | 82 lines
Generalize the junit-specific TestResult class into AbstractTestResult,
and allow plugins to contribute test result parsers that generate
AbstractTestResult subclasses.
In order to support the increasing variety of test result file formats, we
have added two extension points:
* AbstractTestResult: a class that represents a general concept of a test
result, without any language or implementation specifics.
* AbstractTestResultParser: an API for parsing test result files and
producing an instance of a concrete subclass of AbstractTestResult
AbstractModelObject
\
TestObject
\
AbstractTestResult is-a ExtensionPoint
\
|-- CaseResult
|
|-- SimpleCaseResult
|
|-- TabulatedResult
\
|-- ClassResult
|
|-- MetaTabulatedResult
\
|-- TestResult
|
|-- PackageResult
AbstractTestResultParser is-a ExtensionPoint
\
JUnitParser
We have refactored the JUnit result publishing system so that it is "just"
a subclass of AbstractTestResult. We have promoted functionality into
AbstractTestResult from TestResult; we have also promoted jelly resources
from TestResult up to AbstractTestResult. Together, these changes make it
possible -- without much code -- to add a test result parser and a test
result publisher that can participate in the test result ecosystem. See,
for instance, TrivialTestResult, with its two supporting classes,
TrivialTestResultAction and TrivialTestResultRecorder.
We have moved the format-agnostic classes in the test result system into
the hudson.tasks.test package, from hudson.tasks.junit:
TestObject
MetaTabulatedResult
TabulatedResult
We have attempted at every step to preserve backwards compatibility both
with the existing APIs and with test results stored by earlier versions of
Hudson. Numerous tests verify that the old APIs and historical data are
still readable; all of the tests in hudson.tasks.junit operate on stored
builds and test results created by Hudson around version 1.320. These
tests have been created and expanded to exercise the HTML ui and the XML
api of the test result publishing system, as well as the underlying java
logic.
hudson.tasks.junit.CaseResultTest
hudson.tasks.junit.JUnitParserTest
hudson.tasks.junit.JUnitResultArchiverTest
hudson.tasks.junit.TestResultLinksTest
hudson.tasks.junit.TestResultPublishingTest
This checkin also includes several smaller changes that were enacted in the course of this work:
Added convenience/utility methods
- HudsonTestCase.java
Added a read-only textbox.
- core/src/main/resources/lib/form/readOnlyTextbox.jelly
Added a standalone builder that touches all files in the workspace.
- TouchBuilder.java
Added a test: testUnwrappedLongString
- src/test/java/hudson/model/ApiTest.java
........
r24862 | bshine | 2009-12-22 17:30:04 -0800 (Tue, 22 Dec 2009) | 1 line
Recreate the hudson.tasks.junit.TestObject class, and adapt the TestResultAction.Data class to be friendly to the refactoring. This makes the claim plugin and the junit-attachments plugin compile and pass tests against this branch.
........
r24946 | bshine | 2009-12-24 21:59:14 -0800 (Thu, 24 Dec 2009) | 1 line
Getting rid of some TODOs that don't apply anymore. The TODOs that remain are meaningful.
........
r25411 | kohsuke | 2010-01-05 18:14:15 -0800 (Tue, 05 Jan 2010) | 3 lines
Cosmetic change. It's not necessary to define our own constant for empty list when there's already one in JDK.
I also think creating and wasting singleton list as needed is probably better use of memory than having a singleton list tied in memory for every CaseResult. It improves cognitive overhead for people reading the code, and modern GCs are very good at handling short-lived objects, and I don't see this method called in a busy loop.
........
r25418 | kohsuke | 2010-01-05 18:37:17 -0800 (Tue, 05 Jan 2010) | 1 line
pushed the get/setDescription implemention up to the AbstractTestResultAction. I believe the default implementation is sufficient for most purposes, and typical subtypes don't want to bother with the details that descriptions are actually persisted by the owning Action instead of in TestObjects.
........
r25419 | kohsuke | 2010-01-05 18:59:29 -0800 (Tue, 05 Jan 2010) | 1 line
we should allow the parse method to be called outside of the build, so this should be TaskListener.
........
r25478 | kohsuke | 2010-01-07 11:44:34 -0800 (Thu, 07 Jan 2010) | 14 lines
The ExtensionPoint interface primarily serves as a marker to call attention of the plugin developers as to where to hook into Hudson. Since the act of implementing AbstractTestResultParser naturally make them to implement AbstractTestResult, I'm removing the ExtensionPoint marker from this abstract class.
The all() method is removed after the following discussion:
>> - I propose we remove AbstractTestResult.all(). I don't think being
>> able
>> to enumerate AbstractTestResult subtypes buy us anything, since those
>> can only be instantiated by parsers that intimately know how to
>> instantiate them properly. Or did I miss the purpose of this?
>
> I put in the all method because it was suggested by the wiki:
> "You also need to define the static "all" method..."
> http://wiki.hudson-ci.org/display/HUDSON/Defining+a+new+extension+point
> so I don't have a problem with removing it.
........
r25699 | bshine | 2010-01-11 16:34:12 -0800 (Mon, 11 Jan 2010) | 1 line
Removed a test that exercised AbstractTestResult.all(), because that API has been removed.
........
r25701 | bshine | 2010-01-11 17:05:40 -0800 (Mon, 11 Jan 2010) | 1 line
Don't test getDescription() on a TrivialTestResult because the TrivialTestResult doesn't actually implement a description.
........
r25770 | bshine | 2010-01-13 11:52:27 -0800 (Wed, 13 Jan 2010) | 1 line
Added a failing test to demonstrate bug HUDSON-5246, inter-build diffs for junit test results are wrong.
........
r25832 | bshine | 2010-01-14 13:50:15 -0800 (Thu, 14 Jan 2010) | 1 line
The id field was accidentally declared here; it was also declared in hudson.tasks.test.TestObject. This id field here is always hidden by the id field in the more-concrete TestObject. Therefore, I'm removing this field.
........
r25834 | bshine | 2010-01-14 13:55:10 -0800 (Thu, 14 Jan 2010) | 5 lines
Fixes bugs with getPreviousResult:
HUDSON-5269 TestResult.getPreviousResult returns null when it shouldn't
HUDSON-5246 test-result-refactor branch: inter-build diffs for junit test results are wrong
........
r26401 | kohsuke | 2010-01-25 17:24:51 -0800 (Mon, 25 Jan 2010) | 7 lines
renamed:
AbstractTestResultParser -> TestResultParser
AbstractTestResult -> TestResult
This discussion is in http://n4.nabble.com/Review-requested-Test-Result-Refactoring-td978100.html#a978100
The conclusion of this renaming proposal isn't clear, but I'm assuming it's OK.
........
r26402 | kohsuke | 2010-01-25 17:27:57 -0800 (Mon, 25 Jan 2010) | 1 line
elsewhere in Hudson it's the "display name" that indicates a human readable name that programs don't try to interpret.
........
r26403 | kohsuke | 2010-01-25 17:31:38 -0800 (Mon, 25 Jan 2010) | 1 line
typo
........
r26404 | kohsuke | 2010-01-25 17:35:41 -0800 (Mon, 25 Jan 2010) | 1 line
doc improvement.
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26406 71c3de6d-444a-0410-be80-ed276b4c234a
java.lang.AssertionError: Hudson is still doing something after 30000ms: queue=[] building=[snap-dep-test-down #2]
at org.jvnet.hudson.test.HudsonTestCase.waitUntilNoActivityUpTo(HudsonTestCase.java:801)
at org.jvnet.hudson.test.HudsonTestCase.waitUntilNoActivity(HudsonTestCase.java:772)
at hudson.maven.MavenSnapshotTriggerTest.testMixedTransitiveSnapshotTrigger(MavenSnapshotTriggerTest.java:69)
at org.jvnet.hudson.test.HudsonTestCase.runTest(HudsonTestCase.java:310)
at com.sun.maven.junit.LocalTestCaseRunner.runTests(LocalTestCaseRunner.java:100)
at com.sun.maven.junit.LocalTestCaseRunner.runTestCase(LocalTestCaseRunner.java:51)
at hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:274)
at hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:255)
at hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:215)
at hudson.remoting.UserRequest.perform(UserRequest.java:104)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:250)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24847 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r23689 | kohsuke | 2009-11-12 15:35:27 -0800 (Thu, 12 Nov 2009) | 1 line
improved diagnosability
........
r23690 | kohsuke | 2009-11-12 18:03:42 -0800 (Thu, 12 Nov 2009) | 1 line
adding a probe to diagnose a sporadic test failure
........
r23691 | kohsuke | 2009-11-12 18:14:21 -0800 (Thu, 12 Nov 2009) | 1 line
I think this is causing a test failure in ExtendedReadPermissionTest, as the existing alice/bob/charlie users prevent the data on the disk from loading.
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23692 71c3de6d-444a-0410-be80-ed276b4c234a