Commit Graph
48 Commits
Author SHA1 Message Date
kohsuke 8eeeb69e1a improve diagnosability.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2571 71c3de6d-444a-0410-be80-ed276b4c234a
2007-03-22 23:25:34 +00:00
kohsuke 8820c0208c fixed a dead lock. Request.call() shouldn't block in wait() while keeping the Channel lock.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2350 71c3de6d-444a-0410-be80-ed276b4c234a
2007-03-06 19:44:15 +00:00
kohsuke 09388df912 fixed a dead lock.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2345 71c3de6d-444a-0410-be80-ed276b4c234a
2007-03-05 17:53:27 +00:00
kohsuke a92734e8ab support flush.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2323 71c3de6d-444a-0410-be80-ed276b4c234a
2007-03-04 04:37:16 +00:00
kohsuke 7581341b30 buffering causes deadlocks
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2322 71c3de6d-444a-0410-be80-ed276b4c234a
2007-03-04 02:10:38 +00:00
kohsuke 400bbdaf5b moved the code to locate the source jar file.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2291 71c3de6d-444a-0410-be80-ed276b4c234a
2007-03-01 05:37:02 +00:00
kohsuke 696c4f1ac0 improved the error reporting.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2242 71c3de6d-444a-0410-be80-ed276b4c234a
2007-02-22 01:43:24 +00:00
kohsuke 64dd2b64b5 refactored for better reusability.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2241 71c3de6d-444a-0410-be80-ed276b4c234a
2007-02-22 01:42:11 +00:00
kohsuke 8aac70529d there was apparently some kind of race condition, because occasionally test fails trying to call close once too many (that is, one channel (X) sends CloseCommand to the other (Y), which sends back CloseCommand to X, and somehow X sends one more CloseCommand to Y, causing an exception below.)
I thought the use of the 'close' field and synchronization is enough to guard against this condition, but apparently it's not. I added one more 'closing' field, which seems to fix the problem.
It just doesn't feel right when you fix the issue without getting to the bottom, but the concurrency bug is hard to reproduce and I'm exhausted.
----
forking a new process
Feb 15, 2007 6:09:30 AM hudson.remoting.Channel$CloseCommand execute
SEVERE: close command failed
java.io.IOException: Pipe closed
        at java.io.PipedInputStream.checkStateForReceive(PipedInputStream.java:190)
        at java.io.PipedInputStream.receive(PipedInputStream.java:156)
        at java.io.PipedOutputStream.write(PipedOutputStream.java:129)
        at java.io.ObjectOutputStream$BlockDataOutputStream.drain(ObjectOutputStream.java:1682)
        at java.io.ObjectOutputStream$BlockDataOutputStream.setBlockDataMode(ObjectOutputStream.java:1591)
        at java.io.ObjectOutputStream.writeNonProxyDesc(ObjectOutputStream.java:1173)
        at java.io.ObjectOutputStream.writeClassDesc(ObjectOutputStream.java:1127)
        at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1284)
        at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1079)
        at java.io.ObjectOutputStream.writeFatalException(ObjectOutputStream.java:1398)
        at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:305)
        at hudson.remoting.Channel.send(Channel.java:183)
        at hudson.remoting.Channel.close(Channel.java:347)
        at hudson.remoting.Channel$CloseCommand.execute(Channel.java:329)
        at hudson.remoting.Channel$ReaderThread.run(Channel.java:372)
Feb 15, 2007 6:09:30 AM hudson.remoting.Channel$ReaderThread run
SEVERE: I/O error in channel
java.io.EOFException
        at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2498)
        at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1273)
        at java.io.ObjectInputStream.readObject(ObjectInputStream.java:348)
        at hudson.remoting.Channel$ReaderThread.run(Channel.java:366)
channel started


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2217 71c3de6d-444a-0410-be80-ed276b4c234a
2007-02-15 15:06:04 +00:00
kohsuke 253d7732ee added code to track the origin of the call across remote systems.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2216 71c3de6d-444a-0410-be80-ed276b4c234a
2007-02-15 15:03:13 +00:00
kohsuke cec26f9009 trying to mimic the UserRequest class to see if that works.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2215 71c3de6d-444a-0410-be80-ed276b4c234a
2007-02-15 14:11:36 +00:00
kohsuke 274ea9c68e fixed a bug. when the ProxyOutputStream stream is already closed, calling write() will just cause a failure.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2214 71c3de6d-444a-0410-be80-ed276b4c234a
2007-02-15 14:11:10 +00:00
kohsuke e83b388e6d improved the error message.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2213 71c3de6d-444a-0410-be80-ed276b4c234a
2007-02-15 14:10:21 +00:00
kohsuke 7b8e851e31 fixed a test.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2212 71c3de6d-444a-0410-be80-ed276b4c234a
2007-02-15 13:55:10 +00:00
kohsuke 8c0a56f4ae fixed a bug in the remoting support where the proxy returned from export() didn't work correctly if it uses user-defined classes as parameter values and return types.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2202 71c3de6d-444a-0410-be80-ed276b4c234a
2007-02-13 14:47:21 +00:00
kohsuke 862a646c7d bug fix in the remoting mechanism.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2126 71c3de6d-444a-0410-be80-ed276b4c234a
2007-02-09 20:28:06 +00:00
kohsuke fe21d5c141 fixed a horrible horrible memory leak.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1807 71c3de6d-444a-0410-be80-ed276b4c234a
2007-01-19 19:27:34 +00:00
kohsuke 2f66019cf7 trying to fix a bug where the slave agent doesn't terminate itself even when the connection is lost.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1765 71c3de6d-444a-0410-be80-ed276b4c234a
2007-01-15 17:46:46 +00:00
ramapulavarthi 2a5e9bcce6 Fixed a bug where the wrong classloader was used to de-serialize the response object.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1735 71c3de6d-444a-0410-be80-ed276b4c234a
2007-01-12 02:43:24 +00:00
ramapulavarthi 98e7aa7d7f Fixed a bug in handling exception thrown from UserRequest. The exception could be an instance of the user class, so it needs to be sent over on UserResponse, not the underlying Response.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1734 71c3de6d-444a-0410-be80-ed276b4c234a
2007-01-12 02:35:32 +00:00
kohsuke fbc918b1f5 doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1711 71c3de6d-444a-0410-be80-ed276b4c234a
2007-01-08 17:18:16 +00:00
kohsuke f391d39411 added a test for resource support.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1599 71c3de6d-444a-0410-be80-ed276b4c234a
2007-01-03 05:57:45 +00:00
kohsuke 31ff889357 implemented resource support.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1598 71c3de6d-444a-0410-be80-ed276b4c234a
2007-01-03 05:57:34 +00:00
kohsuke 19860fa070 merging remoting-integration branch
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1523 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-29 19:15:53 +00:00
kohsuke 4cabee9f18 typo fixes.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1396 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-20 19:20:31 +00:00
kohsuke 183e0e5344 implemented another channel for doing computation locally.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1379 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-19 14:53:48 +00:00
kohsuke 8ddb883ead doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1375 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-18 17:59:06 +00:00
kohsuke 55c17e37ca doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1374 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-18 17:50:52 +00:00
kohsuke bffee52115 EXC is not thrown right away.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1373 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-18 17:50:08 +00:00
kohsuke 747c3415af doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1372 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-18 17:49:28 +00:00
kohsuke 782f2cec39 doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1371 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-18 17:33:41 +00:00
kohsuke 160627c655 doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1370 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-18 17:27:37 +00:00
kohsuke 48ecb45ba3 doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1369 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-18 17:16:40 +00:00
kohsuke 04ce51875c implemented unexport of pipes.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1368 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-18 17:15:50 +00:00
kohsuke 5d3e48f6a8 adding alias Future interface to keep the signature compatibility.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1347 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-17 01:08:09 +00:00
kohsuke d44598f896 I guess this is really a bug in JDK without easy workaround.
Mustang compiles this file, so reverting back.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1317 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-13 23:46:07 +00:00
kohsuke 4f66123164 how about this?
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1316 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-13 23:30:51 +00:00
kohsuke 1f56e154a9 how about this?
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1315 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-13 23:27:31 +00:00
kohsuke a8e75ec967 does this make the compiler happier?
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1314 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-13 23:21:48 +00:00
kohsuke 482f9a0795 bug fixes. ObjectOutputStream needs to be flushed for certain kind of stream, like process stream, or else we'll dead-lock.
expanded tests.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1306 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-13 06:11:30 +00:00
kohsuke 2631e2f4ca added code for testing different channel configuration by using the same test code.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1304 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-13 02:39:54 +00:00
kohsuke 9222fdbcc1 completed pipe implementation.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1303 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-13 01:57:04 +00:00
kohsuke 1e87dd07c3 reimplemented pipe for better performance. test now runs in 2.3sec down from 17sec before.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1300 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-12 19:34:50 +00:00
kohsuke 04b15b9a21 adding a test for pipe.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1299 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-12 19:00:18 +00:00
kohsuke d249d5246d bug fix.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1298 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-12 18:34:43 +00:00
kohsuke 2b1d175375 implemented asynchronous invocation.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1297 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-12 18:12:55 +00:00
kohsuke 91879ec86d making more progress.
- implemented the remote method call.
- class loader export mechanism is now consolidated with the general object export mechanism.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1296 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-12 17:02:25 +00:00
kohsuke cf2eb25dee added preliminary version of the remoting infrastructure.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1294 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-12 07:00:56 +00:00