Commit Graph
13 Commits
Author SHA1 Message Date
Basil Crow 95e85495ca Enable AvoidStarImport Checkstyle check (#5420) 2021-04-28 17:28:39 +08:00
StefanSpiekerandMark Waite dcc9a924d8 Converting tests to junit5 (#4699)
* started converting tests to junit5

* replaced TempFolder with JUnit TempDir

* migrated some test classes to JUnit5

* migrated a parameterized testclass to junit5

* Update core/pom.xml

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>

* replaced junit4 with junit5-vintage engine

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2020-07-20 23:14:21 +02:00
Basil Crow d27f5e03f0 Replace usages of deprecated org.junit.Assert.assertThat with usages of
non-deprecated org.hamcrest.MatcherAssert.assertThat
2020-05-09 15:40:14 -07:00
Basil Crow 1b62f74585 Remove star imports of org.junit.Assert 2020-05-09 15:39:40 -07:00
Stefan Spieker 2a4cebb44a minor improvements to unit tests 2019-10-02 22:33:43 +02:00
Raihaan Shouhell 89702627a2 Fix annotations and remove unused imports (#4190) 2019-09-07 22:57:04 +02:00
Stephen Connolly f0cd7ae8ff [JENKINS-42934] Avoid using new FileInputStream / new FileOutputStream 2017-03-20 12:50:46 +00:00
Oleg Nenashev 96c97860b0 [FIXED JENKINS-37332] - Prevent File descriptor leaks when reading manifests from JARs (#2516)
* [JENKINS-37332] - Improve diagnostics of non-closed streams during reading of the manifests in PluginManager

* [JENKINS-37332] - Leakless processing of JarUrlConnection during Manifest parsing

* [JENKINS-37332] - Also implement leak-safe method for retrieving file modification date

* [JENKINS-37332] - Add spotcheck methods for manifest file access + Javadoc

* [JENKINS-37332] - Also test multi-line and empty attributes in the test
2016-08-21 00:00:41 +02:00
Jesse Glick f60bde00ab Merge branch 'security' into security-rc
Conflicts:
	core/src/main/java/hudson/PluginManager.java
	core/src/test/java/hudson/PluginManagerTest.java
2015-02-27 13:50:21 -05:00
James Nord b8c9841c30 [SECURITY-167] Plugin manager was also vulnerable.
Although the plugiun manager was vulnerable getting information
out of Jenkins was harder - however it would still be possible to
do bad things such as reading from /dev/zero on Linux
2015-02-27 18:18:23 +00:00
Jesse Glick b415b467fb Replacing Util.createTempDir with the standard TemporaryFolder rule in some tests. 2014-12-17 15:04:45 -05:00
Kohsuke Kawaguchi 2c97fe227a exposing this code to outside 2012-12-31 08:47:26 -08:00
Jesse Glick 2658f36994 Basic implementation of prevalidateConfig working. 2012-09-14 14:56:10 -04:00