Changes to enable Jenkins to use either the standard, current dom4j release or the Jenkins-custom fork. This allows us to separately remove the fork and reference the standard one.
* Need to have only one copy of SystemCommandLanguage among detached plugins.
* Removing some cases from LoadDetachedPluginsTest which were sensitive to particular versions of detached plugins and thus hard to maintain.
Already had to do one such change in 84f939cebd and now upgradeFromJenkins2WithNewerDependency began failing after a war/pom.xml change.
* Proof of concept catching exceptions for java 11 removed classes
* Add ClassLoader to a lot of places. Backup
* Commenting out wip stuff, change packages, count hits findClass
* Improvements, sending and tests
* Removing the catcher from chain to make funcional tests work
* Removing ignored places and a bit of cleaning
* Cleaning unused code after removing the catcher from the chain
* Remove imports cleaning to avoid extra changes
* Cleaning and explaining comments
* Explaining comments
* fix javadoc
* [JENKINS-57223] Address feedback from Matt Sicker. Improve in concurrency
* [JENKINS-57223] Search on cause and suppressed exceptions and fix on name reported
* [JENKINS-57223] Add cycles control on exceptions and refactor reporting method
* [JENKINS-57223] Add trim to class name comparison
* [JENKINS-57223] Address Oleg's feedback and some improvements
* Avoid sending CNFE when ignored later in code
* Disable when running on Java 8 and a test
* Avoid sending empty events
* [JENKINS-57223] Polish assertion after printing all missing classes in logs
* [JENKINS-57223] Avoid extra if and add curly braces
* [JENKINS-57223] Better comment about time window check
This validates that the performance regression itself - redundant calls
to loadUserByUsername() - is also fixed besides simply the
implementation details of the user seed and session.
Signed-off-by: Matt Sicker <boards@gmail.com>
This fixes the remember me service to link the user seed to a
corresponding HTTP session. By doing so, this should significantly
reduce the number of calls to loadUserDetails().
Signed-off-by: Matt Sicker <boards@gmail.com>
* Implied dependencies on detached plugins were not being marked optional despite being listed in optionalDependencies, confusing the calculation of optionalDependents in resolveDependentPlugins.
* Javadoc improvements based on code exploration.
* [JENKINS-33843] Do not consider optional dependencies for purposes of disabling plugins.
* PluginManagerInstalledGUITest updated to reflect new behavior.
* IntelliJ/Groovy: deprecation
This is pretty useless as getSecurityKey is also deprecated
* IntelliJ/Groovy: deprecation
Resolve ApiTokenFilter is deprecated
* IntelliJ/Groovy: Semicolons are Optional
* This import is required by a bean/hudson.util.spring.BeanBuilder
* Do not warn repeatedly of the same missing update site dependency.
This happens when locally testing split plugins (despite their presence in WEB-INF/detached-plugins/*.hpi).
(cherry picked from commit 918a0fd221)
* Detached plugins must be kept up to date with security advisories.
(cherry picked from commit e08d28a698)
* Load detached plugins which are implicit dependencies of other plugins at startup, even if the update center was not used.
(cherry picked from commit ad7a36001d)
* Adjusted expected version after e08d28a698.
(cherry picked from commit 84f939cebd)
* e08d28a698 exposed tests which had been incorrectly storing plugins as *.hpi rather than *.jpi.
(cherry picked from commit a0abad7ec4)
* Test failure after ad7a36001d.
(cherry picked from commit 0084e8dbdd)
* Another test failure after ad7a36001d30a6174b25e616fc3c215dd24919d1; fewer installDetachedPlugin calls are now required.
(cherry picked from commit b65bb54e99)
Agent implementers use onOnline to perform actions after an agent
put online. The API specifies that execeptions thrown by this
method will not put an agent offline. However, the default
implementation does exactly that.
This change clarifies the API to say all exceptions will be logged
and hardens setChannel against exceptions during onOnline.
NOTE: Errors will still cause an agent to go offline as they are
generally fatal conditions.
Also added tests to verify the behavior.
* JENKINS-11888 Add stop-job CLI command
* JENKINS-11888 Add license headers
* JENKINS-11888 Review fix
* JENKINS-11888 Fix review
* JENKINS-11888 Remove moved files from cli package
* JENKINS-11888 Fix logging
* JENKINS-11888 Collect jobs list before stopping any builds
* JENKINS-11888 Refactor isBuilding check
* JENKINS-11888 Add Restricted annotation for StopBuildsCommand
* JENKINS-11888 Make cli output more responsive
* JENKINS-11888 Remove single quote for job name
* JENKINS-11888 Add semicolon
* JENKINS-11888 Handle exception for executor.doStop
* JENKINS-11888 Rework test to use JenkinsRule
* JENKINS-11888 Remove semicolons from CLI output
* JENKINS-11888 Fix tests for windows platform
* JENKINS-11888 Write message about exception in one line
* JENKINS-11888 Fix output on not founded job
* JENKINS-11888 Improve tests
* JENKINS-11888 Use fullDisplayName for job name
* JENKINS-11888 Use single quotes for build and job names
* JENKINS-11888 Cleanup exceptions throwing
* JENKINS-11888 Add test checking second job will be stopped if first stop failed
* [JENKINS-56477] New "isCompatible" method avoiding all plugins w/ warns
Previous version was only checking "isCompatibleWithInstalledVersion", but there were several other cases that had to be checked
* [JENKINS-56477] Added issue annotation to isPluginUpdateCompatible test
* [JENKINS-56477] Factored out getUpdateSite, init method used by 2 tests
Also removed the "sites" list from the init, since it seemed it was not being used, only using the specific site created from the external json
* [JENKINS-56477] Added a new option for plugin selection: "compatible"
Now users can select "All", "Compatible" or "None"
* [JENKINS-56477] checkPluginsWithoutWarnings also unchecks now
Useful if the user first clicks "Select All" and now wants to "Select Compatible" only.
* [JENKINS-56477] Added unit test for "UpdateSite.Plugin.isCompatible"
The UpdateSite class and its internal classes (e.g. Plugin) are a bit tricky to unit-test. Using some stubs to set the necessary context for the test to run
* [JENKINS-56477] "mock-maker-inline" incompatible w/ other tests
Had to remove the unit test checking "pluginUpdateNotCompatible. It needed "mock-maker-inline" config to mock/spy the Plugin class (which is final), but that mockito config caused conflicts with pre-existing tests.
* [JENKINS-56477] Simplifying condition to check the candidate checkbox
* [JENKINS-56477] Method overload with param should not be exported
* [JENKINS-56477] Javadoc for isCompatible(). Overloaded ver. restricted
Also switched the call in table.jelly to the overloaded version of isCompatible, since a "cache" var was available in the context (and was being already used by calls to the internal methods to show the warnings)
* Removed empty line.
Trivial change to force re-execution of pipeline.
* [JENKINS-56477] "isCompatible" set to @Restricted for now
This method is currently only being used by the Jenkins UI, so we are not being exposing it to plugins nor exporting it. If in the future that need emerges, this can be changed
Kohsuke Kawaguchi