- Removed "failed to launch" message from ComputerLauncher/main.jelly
This message was always shown, even if slave was offline for other reasons.
- Instead, added new OfflineCause.LaunchFailed which is set in SlaveComputer if channel
is not set after calling launcher. Now this shows the "failed to launch" message.
- Moved/copied existing translations for these strings to their new locations.
- Expanded message for in-demand strategy to say "will be relaunched when needed"
- Added text explanation and fixed display of exception for ChannelTermination cause
- Use class="warning" for default display of OfflineCause
- Added some @Override annotations
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23876 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r23689 | kohsuke | 2009-11-12 15:35:27 -0800 (Thu, 12 Nov 2009) | 1 line
improved diagnosability
........
r23690 | kohsuke | 2009-11-12 18:03:42 -0800 (Thu, 12 Nov 2009) | 1 line
adding a probe to diagnose a sporadic test failure
........
r23691 | kohsuke | 2009-11-12 18:14:21 -0800 (Thu, 12 Nov 2009) | 1 line
I think this is causing a test failure in ExtendedReadPermissionTest, as the existing alice/bob/charlie users prevent the data on the disk from loading.
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23692 71c3de6d-444a-0410-be80-ed276b4c234a
Nov 9, 2009 1:46:11 PM hudson.remoting.Channel$ReaderThread run
SEVERE: I/O error in channel This side of the channel
java.io.IOException: Write end dead
at java.io.PipedInputStream.read(PipedInputStream.java:294)
at java.io.ObjectInputStream$PeekInputStream.peek(ObjectInputStream.java:2249)
at java.io.ObjectInputStream$BlockDataInputStream.peek(ObjectInputStream.java:2542)
at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2552)
at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1297)
at java.io.ObjectInputStream.readObject(ObjectInputStream.java:351)
at hudson.remoting.Channel$ReaderThread.run(Channel.java:849)
Nov 9, 2009 1:46:11 PM hudson.remoting.Request$2 run
SEVERE: Failed to send back a reply
java.io.IOException: Read end dead
at java.io.PipedInputStream.checkStateForReceive(PipedInputStream.java:246)
at java.io.PipedInputStream.receive(PipedInputStream.java:210)
at java.io.PipedOutputStream.write(PipedOutputStream.java:132)
at java.io.ObjectOutputStream$BlockDataOutputStream.drain(ObjectOutputStream.java:1838)
at java.io.ObjectOutputStream$BlockDataOutputStream.setBlockDataMode(ObjectOutputStream.java:1747)
at java.io.ObjectOutputStream.writeNonProxyDesc(ObjectOutputStream.java:1249)
at java.io.ObjectOutputStream.writeClassDesc(ObjectOutputStream.java:1203)
at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1387)
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1150)
at java.io.ObjectOutputStream.writeFatalException(ObjectOutputStream.java:1538)
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:329)
at hudson.remoting.Channel.send(Channel.java:413)
at hudson.remoting.Request$2.run(Request.java:282)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
The thread dump indicates that the test thread is stuck at british.join(), because British channel reader thread is still alive. I remember PipedInput|OutputStream being not truly multi-thread aware, so changing it to our own version to see if that fixes the problem without my digging further.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23625 71c3de6d-444a-0410-be80-ed276b4c234a
Deadlocked threads from Tom Huybrechts
----
"Channel reader thread: build-tr-01" Id=6188858 BLOCKED on hudson.remoting.UserRequest@7641246a owned by "Executor #1 for build-tr-01 : executing ORBIS_HAP_Core-Java5 #213 / waiting for hudson.remoting.Channel@560c2a29:build-tr-01" Id=379
at hudson.remoting.Request.onCompleted(Request.java:223)
- blocked on hudson.remoting.UserRequest@7641246a
at hudson.remoting.Request.abort(Request.java:231)
at hudson.remoting.Channel.terminate(Channel.java:596)
- locked java.util.Hashtable@49c47d9e
- locked hudson.remoting.Channel@560c2a29
at hudson.remoting.Channel$ReaderThread.run(Channel.java:871)
Executor #1 for build-tr-01 : executing ORBIS_HAP_Core-Java5 #213 / waiting for hudson.remoting.Channel@560c2a29:build-tr-01" Id=379 BLOCKED on hudson.remoting.Channel@560c2a29 owned by "Channel reader thread: build-tr-01" Id=6188858
at hudson.remoting.Channel.send(Channel.java:409)
- blocked on hudson.remoting.Channel@560c2a29
at hudson.remoting.Request.call(Request.java:127)
- locked hudson.remoting.UserRequest@7641246a
at hudson.remoting.Channel.call(Channel.java:549)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23476 71c3de6d-444a-0410-be80-ed276b4c234a
"pool-10-thread-6 / waiting for hudson.remoting.Channel@39a5b0:winxpie7.sfbay.sun.com" Id=579896 WAITING on hudson.remoting.UserRequest@3b4670
at java.lang.Object.wait(Native Method)
- waiting on hudson.remoting.UserRequest@3b4670
at java.lang.Object.wait(Object.java:485)
at hudson.remoting.Request.call(Request.java:116)
at hudson.remoting.Channel.call(Channel.java:536)
at hudson.slaves.SlaveComputer.setChannel(SlaveComputer.java:305)
at hudson.plugins.sshslaves.SSHLauncher.startSlave(SSHLauncher.java:220)
at hudson.plugins.sshslaves.SSHLauncher.launch(SSHLauncher.java:180)
- locked hudson.plugins.sshslaves.SSHLauncher@985bc4
at hudson.slaves.SlaveComputer$1.call(SlaveComputer.java:175)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
Number of locked synchronizers = 1
- java.util.concurrent.locks.ReentrantLock$NonfairSync@14f0686
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21665 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r21385 | kohsuke | 2009-09-02 15:41:39 -0700 (Wed, 02 Sep 2009) | 1 line
Fixed a random test failure, which was caused by PingThread detecting communication problem while it's being orderly shut down.
........
r21386 | kohsuke | 2009-09-02 15:41:57 -0700 (Wed, 02 Sep 2009) | 1 line
indentation fix.
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21387 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r21368 | kohsuke | 2009-09-02 13:14:25 -0700 (Wed, 02 Sep 2009) | 33 lines
wait until the channel terminates normally to avoid random test failures like this:
junit.framework.AssertionFailedError: exit code should have been 0 expected:<0> but was:<255>
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:285)
at junit.framework.Assert.assertEquals(Assert.java:64)
at junit.framework.Assert.assertEquals(Assert.java:201)
at hudson.remoting.ChannelRunner$Fork.stop(ChannelRunner.java:141)
at hudson.remoting.RmiTestBase.tearDown(RmiTestBase.java:53)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21371 71c3de6d-444a-0410-be80-ed276b4c234a
I moved the capability exchange to the preamble negotiation to avoid this problem.
----
java.lang.NullPointerException
at hudson.remoting.UserRequest._serialize(UserRequest.java:136)
at hudson.remoting.UserRequest.perform(UserRequest.java:118)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:236)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21132 71c3de6d-444a-0410-be80-ed276b4c234a
https://www.dev.java.net/svn/hudson/branches/rc
........
r20928 | kohsuke | 2009-08-19 14:47:13 -0700 (Wed, 19 Aug 2009) | 1 line
test bug fix.
........
r20929 | kohsuke | 2009-08-19 14:48:23 -0700 (Wed, 19 Aug 2009) | 1 line
bumped up to a new version that has a trouble-shooting hook for resetting cached views
........
r20939 | kohsuke | 2009-08-19 15:20:57 -0700 (Wed, 19 Aug 2009) | 1 line
picking up subversion 1.5
........
r20974 | kohsuke | 2009-08-20 11:50:04 -0700 (Thu, 20 Aug 2009) | 3 lines
Hudson can make mistakes in binding plugins to their right /plugin/NAME/ URLs.
(<a href="http://www.nabble.com/Custom-Plugin---No-external-resources-available-td25064554.html">report</a>)
........
r20975 | kohsuke | 2009-08-20 12:05:11 -0700 (Thu, 20 Aug 2009) | 1 line
Build history AJX update was buggy.
........
r20988 | kohsuke | 2009-08-20 17:01:57 -0700 (Thu, 20 Aug 2009) | 3 lines
Hudson wasn't working on WebLogic on Windows.
(<a href="http://www.nabble.com/Re%3A-Hudson-on-Weblogic-10.3-td25038378.html#a25043415">report</a>)
........
r21009 | kohsuke | 2009-08-21 14:21:35 -0700 (Fri, 21 Aug 2009) | 1 line
[maven-release-plugin] prepare release hudson-
........
r21011 | kohsuke | 2009-08-21 14:22:00 -0700 (Fri, 21 Aug 2009) | 1 line
[maven-release-plugin] prepare for next development iteration
........
r21015 | kohsuke | 2009-08-21 16:00:17 -0700 (Fri, 21 Aug 2009) | 1 line
updated changelog as a part of the release
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21095 71c3de6d-444a-0410-be80-ed276b4c234a