Commit Graph
2201 Commits
Author SHA1 Message Date
kohsuke 995ca2382c simplified by using a convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9401 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:03:19 +00:00
kohsuke c30c3a80ac added a convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9400 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:02:55 +00:00
kohsuke fc0f23c017 no need to do this inside the loop, although not that it hurts
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9399 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:01:52 +00:00
kohsuke 0cf3e83a52 bug fix. This needs to be kept across the doRun method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9398 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 22:01:25 +00:00
kohsuke ec0bd15ff6 noted
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9397 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 21:48:04 +00:00
kohsuke d83a256540 simplified
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9395 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 21:45:56 +00:00
kohsuke 9c546d6d7c Creating a package to host slave related code.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9394 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 21:45:31 +00:00
kohsuke 375cca85ed Creating a package to host slave related code.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9393 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 21:42:57 +00:00
kohsuke 295650c008 doc improvements
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9392 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 21:39:40 +00:00
kohsuke 924d0c4be4 launch should be asynchronous by default.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9390 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:31:30 +00:00
kohsuke 408294a8e3 pointless empty line
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9389 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:28:42 +00:00
kohsuke 0f3f6658ca pass more structured logger
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9388 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:28:31 +00:00
kohsuke 21faaf7a61 doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9387 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:28:04 +00:00
kohsuke d5752b8a41 The term used in Hudson for this is 'launch', not 'start', so making it consistent.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9386 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:17:54 +00:00
kohsuke acfb32adaa doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9385 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:15:17 +00:00
kohsuke b18553d6a9 Better encapsulation by hiding numRetryAttempt entirely inside ComputerImpl.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9384 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:13:23 +00:00
kohsuke 5694fb050e refactoring to remove redundant parameters.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9383 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:12:36 +00:00
kohsuke d6419f1cf6 rolling back my 9366 to bring Stephen's slave related changes to the main line
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9382 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:10:09 +00:00
kohsuke 36c60b320b rolling back my 9366 to bring Stephen's slave related changes to the main line
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9381 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-18 17:07:24 +00:00
kohsuke d618dcbd76 Rolling back 9328,9331,9352-9354 as I still wanted to make some adjustments to them
before they are merged into the main line.



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9366 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-17 17:54:45 +00:00
stephenconnolly 53db09e20d Make the slave availability strategy actually do stuff!
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9354 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-17 10:14:05 +00:00
stephenconnolly a3fe9ae91d Make the slave availability strategy actually do stuff!
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9353 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-17 10:09:52 +00:00
stephenconnolly c32b011d31 Making slave availability a strategy extension point
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9352 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-17 09:54:13 +00:00
kohsuke d1e5182170 [FIXED HUDSON-1696] applied a patch. Be more lenient in comparing a version. Fixed in 1.216.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9334 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-16 19:06:38 +00:00
kohsuke 4645b8def8 handling the comparison little more carefully so that it can work with some "broken" CVS clients.
See http://www.nabble.com/Problem-with-polling-CVS%2C-from-version-1.181-tt15799926.html

Pasted below for convenience:

------
 finally got time to do a little debugging. I didn't know what to look for
but this is what I found:

The call on isUpdatable in pollChanges returns false (not true as you said),
and it enters the if-statement which returns true.

Inside isUpdatable it enters the instance of the FileCallable object dir, 
and the method invoke which returns false because isUpdatableModule is
false.

isUpdatableModule  recognize module
(C:\workspaces\Hudson\main\war\work\jobs\MyProject_TEST\workspace\MyProject)
as a file and not a directory.
from  isUpdatableModule  it enters checkContents where it compares the
strings s and content. 

Thees two strings are not equal (which they maybe should be?): 
s = :pserver:usid@cvsserver:d:\cvsrepo 
contents = :pserver:usid:uspwd@cvsserver:d:\cvsrepo

This, in the end, makes isUpdatable return false, as far as I can tell.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9332 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-16 18:42:44 +00:00
kohsuke 6d2d9a7803 use a dedicated List type
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9331 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-16 17:26:47 +00:00
kohsuke 47d481f88d Allowed workspace directory to be customized.
See http://www.nabble.com/Customize-Workspace-directory-tt17194310.html

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9330 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-16 17:03:13 +00:00
stephenconnolly 948b6c0c33 Merging first round of UI changes require to enable plugable slave start mechanisms (which will be required in order to allow VMware/Xen slave starting)
Also splitting the configuration of slaves out from the configuration of everything else.

Hopefully this should not break stuff!

(Works for me!)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9328 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-16 12:07:35 +00:00
kohsuke 887b0163c1 fixed a bug where the distributed build setting fails to persist (!!)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9299 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-16 05:00:06 +00:00
kohsuke 99bec6c1fa added support for PuTTY key format
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9266 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-15 18:34:45 +00:00
kohsuke f3d2424476 corrected the comment.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9245 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-14 22:06:49 +00:00
kohsuke 3b2ffa3ebf [fixed] redeployment stopped working. In 1.214. (issue #1671)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9243 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-14 22:03:03 +00:00
kohsuke d32fcc4e61 typo
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9242 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-14 21:58:36 +00:00
dwdyer 910b3dae95 Fix for incorrect test result links when project name contains spaces (ISSUE#1666).
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9224 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-13 19:01:39 +00:00
kohsuke 0e71696034 [fixed] A slave may still run on Java5 even when the master runs on Java6. In 1.214. (issue #1568)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9208 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-13 01:34:40 +00:00
kohsuke fa3424ca2b doci mprovement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9207 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-13 01:33:15 +00:00
kohsuke 197a3012e4 Rolling back the previous fix.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9206 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-13 01:09:19 +00:00
kohsuke 6502ced79c clarified the default behavior of the newInstance method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9205 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-13 00:57:09 +00:00
kohsuke c0dca14599 improved the robustness in case of failed rename (issue #1662)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9106 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-11 03:22:41 +00:00
kohsuke 5166e6f36c supported HTTP DELETE on jobs
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9104 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-11 03:05:55 +00:00
mdonohue 680d4a42a4 Add a renameTo method to the FilePath class
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9078 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-08 04:48:09 +00:00
redsolo 82780ed40e Accessing workspace no longer throws NPE if last used slave is offline (issue #1657)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9069 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-07 20:42:06 +00:00
redsolo e2871c00a2 [fixed] Workspace link generates NPE when workspace contains files that Hudson can not access (issue #1633)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9065 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-07 19:32:42 +00:00
kohsuke e987d2709b It's not obvious to me if the race condition could ever occur, but Rama and I experienced a very suspicious failure once, and we are hoping that this would fix it.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9018 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-03 00:31:13 +00:00
kohsuke 51492cc788 infer default Hudson URL little more eagerly.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9002 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-01 22:55:40 +00:00
kohsuke cf218bbc22 In lower resolution systems, create smaller test trend chart.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9000 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-01 22:12:34 +00:00
redsolo b3f8f5369b [fixed] Added "View workspace" permission to the matrix based security. (issue #434)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@8998 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-01 21:59:49 +00:00
kohsuke da529b0344 adding a probe to better diagnose the missing Content-Length header issue.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@8996 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-01 17:01:22 +00:00
redsolo 6317d1e158 [fixed] More help when configuring new slaves (issue #1530)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@8991 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-01 08:55:26 +00:00
kohsuke 3e3ebd1cfb not used
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@8988 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-01 00:12:54 +00:00