Commit Graph
2051 Commits
Author SHA1 Message Date
Jesse Glick 99dc53d3bb Merge pull request #1899 from jglick/PropertiesTestSuite
Verify that *.properties do not have duplicated keys
2015-11-04 11:28:34 -05:00
Vincent Latombe 3909f5acc4 Fix a NPE while trying to compare two data bound beans with null
Iterable field.
2015-11-04 10:56:32 +01:00
Jesse Glick b0003b196c Another random failure. 2015-11-03 11:27:49 -05:00
Jesse Glick 3c246567c6 Verify that *.properties do not have duplicated keys. 2015-11-03 10:42:27 -05:00
Oleg Nenashev 0a56c1d507 Merge pull request #1882 from pjanouse/JENKINS-31098
[JENKINS-31098] Deletage remove a node back to Computer.doDoDelete()
2015-10-24 14:10:27 +03:00
Ing. Pavel Janousek 04a874ac95 [JENKINS-31098] Deletage remove a node back to Computer.doDoDelete() 2015-10-22 14:32:53 +02:00
Jesse Glick fcb94afd0d Updated some tests. 2015-10-21 15:03:10 -04:00
Jesse Glick 6aabbbd282 Provide a default implementation of Descriptor.getDisplayName. 2015-10-21 12:38:25 -04:00
Vincent Latombe 07e83a0e8c Trim display name before applying it and add tests
The current implementation is not robust against blank display name
2015-10-21 17:34:25 +02:00
Oleg Nenashev 67879ab232 Merge pull request #1855 from csimons/fix-rename-trailing-whitespace
[FIXED JENKINS-30502] trim job name upon rename
2015-10-17 21:57:16 +03:00
Oleg Nenashev 725b6afeac [FIXED JENKINS-30730] Prevent ClassCastException in Abstractbuild::reportError() if the build step is not Publisher.
This pull request integrates https://github.com/jenkinsci/jenkins/pulls/1851, which is a reworked version of https://github.com/jenkinsci/jenkins/pull/1846 from @fbelzunc (no original codelines left)
2015-10-17 20:55:16 +03:00
tfennelly 2ec3ffcd53 Merge branch 'master' into JENKINS-26445-pagination-search 2015-10-09 12:28:19 +01:00
Christopher Simons 89ce85dfc8 [FIXED JENKINS-30502] trim job name upon rename
If a job is renamed to a string with trailing whitespace, exceptions are
thrown as the application attempts to rename the job directory in the
file system, and the job can be neither deleted nor renamed again
through the UI. This problem occurs only when renaming a job, and not
when initially creating a job, because job names are trimmed when first
created.  This change trims the job name for rename operations as well,
so that the name-setting behavior is consistent across create/update
operations and inadvertent leading/trailing whitespace is removed before
it can cause problems.
2015-10-08 14:42:31 -04:00
Oleg Nenashev e370009200 Merge pull request #1839 from pjanouse/JENKINS-30521
[JENKINS-30521] reload-job CLI command moved from Core to CLI
2015-10-07 13:16:09 +03:00
Jesse Glick 31450b894c Merge pull request #1853 from jglick/CommandLauncherTest-flaky
CommandLauncherTest is flaky
2015-10-06 10:27:38 -04:00
tfennelly 95ca3da67d Merge branch 'master' into plugin-manager-dependants
* master:
  Update the changelog by new merges:
  [FIXED JENKINS-30569] HistoryWidget: fix JS syntax error
  [FIXED JENKINS-29014] render API link conditional on getApi() presence
  [JENKINS-21720] JS alert preventig to leave a configuration page even without formulary changes
  add ctags file 'tags' to .gitignore
  [maven-release-plugin] prepare release jenkins-1.632
  [FIXED JENKINS-29888] Handling all exceptions returned by logRotator
  [JENKINS-30742] Fixed possible NPE in AbstractProject.resolveForCLI()
2015-10-06 10:50:40 +01:00
Oleg Nenashev 236198883b Merge pull request #1849 from pjanouse/JENKINS-30742
[JENKINS-30742] Fixed possible NPE in AbstractProject.resolveForCLI()
2015-10-06 12:05:56 +03:00
tfennelly a8e83c3c2d Tweaks based on review comments 2015-10-06 09:44:11 +01:00
tfennelly 955eb7274a Merge branch 'master' into plugin-manager-dependants
* master: (58 commits)
  Changelog: Replace the PR reference by the JIRA issue reference
  Noting https://github.com/jenkinsci/jenkins/pull/1818
  Noting https://github.com/jenkinsci/jenkins/pull/1804
  [JENKINS-30002] Improve Util.isOverridden
  Noting #1842
  [FIXED JENKINS-30777] this concludes the fix
  [JENKINS-30777] also allow slaves to decorate logger
  [JENKINS-30777] Generalized the signature to work with Run, not just AbstractBuild.
  Diamond operator
  [FIXED JENKINS-29876] CheckForNull job in ReverseBuildTrigger
  Noting JENKINS-30084 in changelog
  [JENKINS-30084] remove extra space
  [JENKINS-30084] address feedbacks
  [JENKINS-30084] indent back
  [JENKINS-30084] fixing test
  [JENKINS-30084] fixing test
  [JENKINS-30084] enhancing test case
  [JENKINS-30084] test added to make sure a flyweight task can be blocked at last minute
  [JENKINS-30084] fix regression when flyweight task is blocked by upstream/downstream project
  [JENKINS-30084] some more polish
  ...
2015-10-05 18:51:35 +01:00
tfennelly 8dbee7b949 Added a few tests 2015-10-05 18:50:35 +01:00
Jesse Glick 263021f35e Typo. 2015-10-05 11:30:36 -04:00
Jesse Glick df7c3f0b79 commandSuceedsWithoutChannel [sic] is flaky.
For example https://ci.jenkins-ci.org/job/jenkins_main_trunk/4281/testReport/hudson.slaves/CommandLauncherTest/commandSuceedsWithoutChannel/
java.lang.AssertionError: 
Expected: a string containing "ERROR: Process terminated with exit code 0"
     but: was "… Launching slave agent
$ true
ERROR: Unable to launch the slave agent for dummy
…java.io.EOFException: unexpected stream termination
	at hudson.remoting.ChannelBuilder.negotiate(ChannelBuilder.java:333)
	at hudson.remoting.ChannelBuilder.build(ChannelBuilder.java:282)
	at hudson.slaves.SlaveComputer.setChannel(SlaveComputer.java:365)
	at hudson.slaves.CommandLauncher.launch(CommandLauncher.java:130)
	at hudson.slaves.SlaveComputer$1.call(SlaveComputer.java:238)
	at jenkins.util.ContextResettingExecutorService$2.call(ContextResettingExecutorService.java:46)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
	at java.util.concurrent.FutureTask.run(FutureTask.java:166)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
	at java.lang.Thread.run(Thread.java:722)
"
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
	at hudson.slaves.CommandLauncherTest.commandSuceedsWithoutChannel(CommandLauncherTest.java:67)
2015-10-05 11:30:23 -04:00
Ing. Pavel Janousek 18833611b1 [JENKINS-30521] reload-job CLI command moved from Core to CLI 2015-10-05 10:56:29 +02:00
Oleg Nenashev 339dd4ace5 Merge pull request #1842 from KostyaSha/patch-3
[FIXED JENKINS-29876] CheckForNull job in ReverseBuildTrigger
2015-10-03 22:53:13 +03:00
Kohsuke Kawaguchi 4c4367113f [JENKINS-30777] also allow slaves to decorate logger 2015-10-02 16:33:34 -07:00
Kanstantsin Shautsou 45e4e99026 [FIXED JENKINS-29876] CheckForNull job in ReverseBuildTrigger 2015-10-02 15:54:06 +03:00
Ing. Pavel Janousek 37c5656f2c [JENKINS-30742] Fixed possible NPE in AbstractProject.resolveForCLI() 2015-10-02 14:45:36 +02:00
Stephen Connolly 5a5f9c5d10 Merge pull request #1815 from varmenise/OSS-192
[FIXED JENKINS-30084] FlyWeightTasks tied to a label will not cause node provisioning and will be blocked forever.

When a flyweighttask is limited to run on a specific label (e.g. matrix project set restrict where this project can run) if there are no nodes with that label available when it enters the queue then it will immediately move to blocked.
As it is blocked the Node provisioner will not attempt to create any slaves, so the project will sit in the queue forever (or until some other project allocates a slave with the correct label).
2015-10-02 09:19:40 +01:00
Valentina Armenise 8d113a1067 [JENKINS-30084] address feedbacks 2015-10-02 09:53:35 +02:00
Valentina Armenise 37a372d154 [JENKINS-30084] fixing test 2015-10-02 09:53:35 +02:00
Valentina Armenise 562c0e5f00 [JENKINS-30084] fixing test 2015-10-02 09:53:35 +02:00
Valentina Armenise 3b4c09e4e9 [JENKINS-30084] enhancing test case 2015-10-02 09:53:34 +02:00
Valentina Armenise e33f3f62db [JENKINS-30084] test added to make sure a flyweight task can be blocked at last minute 2015-10-02 09:53:34 +02:00
Valentina Armenise 65d1fe5b1d [JENKINS-30084] some more polish 2015-10-02 09:53:33 +02:00
Valentina Armenise e1904e02d4 [JENKINS-30084] some stylish changes 2015-10-02 09:53:33 +02:00
Valentina Armenise a19c7936bf [JENKINS-30084] cleanup 2015-10-02 09:53:32 +02:00
Valentina Armenise cfef72b1b2 [JENKINS-30084] cleanup 2015-10-02 09:53:32 +02:00
Valentina Armenise 50ae0f4da9 [JENKINS-30084] cleanup 2015-10-02 09:53:31 +02:00
Valentina Armenise 9a24957247 [JENKINS-30084] new comment for test 2015-10-02 09:53:31 +02:00
Valentina Armenise 53f909620d [JENKINS-30084] new location and implementation of the test 2015-10-02 09:53:31 +02:00
Valentina Armenise 750cdb64bf [JENKINS-30084] updated references of Jenkins Issue 2015-10-02 09:53:30 +02:00
Valentina Armenise a5a2c45d2e [JENKINS-30084] added test case 2015-10-02 09:53:30 +02:00
Oliver Gondža fca99dcc14 Merge pull request #1843 from olivergondza/JENKINS-30705
[FIXED JENKINS-30705] Optimize TagCloud calculation
2015-10-01 19:13:30 +02:00
Oliver Gondža 05382a6da7 Use JUnit4 for JNLPLauncherTest to get support for assumptions 2015-10-01 13:28:23 +02:00
Oliver Gondža 3990384257 Do not skip tests silently 2015-10-01 08:58:31 +02:00
Oliver Gondža 52f9172c69 [JENKINS-30705] Reset cache for exact results in unittest 2015-09-30 17:15:41 +02:00
Oliver Gondža 699d2b22ad Merge pull request #1840 from pjanouse/JENKINS-30613
[JENKINS-30613] Code clean-up
2015-09-24 09:05:27 +02:00
Ing. Pavel Janousek 9588a09610 [JENKINS-30613] Code clean-up 2015-09-23 15:40:32 +02:00
Jesse Glick 43f4b2b570 Merge pull request #1826 from jglick/ClosedByInterruptException
[JENKINS-30395] Occasional ClosedByInterruptException
2015-09-17 14:28:01 -04:00
Vojtech Juranek 8f29260b17 [FIXED JENKINS-29507] Make JenkinsRule useable on systems without glibc 2015-09-17 19:56:51 +02:00