<!-- Comment:
A great PR typically begins with the line below.
Replace XXXXX with the numeric part of the issue ID you created in Jira.
Note that if you want your changes backported into LTS, you need to
create a Jira issue. See
https://www.jenkins.io/download/lts/#backporting-process for more
information.
-->
See JENKINS-75100
Now that the [disable by default of
YUI](https://github.com/jenkinsci/jenkins/pull/10045) has been released
for ~1 month with no complaints its time to start thinking about
removing YUI itself.
We're passed the baseline cut-off for the next LTS which was what
@MarkEWaite requested that I wait for before removing YUI fully
What I've left:
* I've removed CSS where I think its safe but I haven't removed all
mentions of `yui`.
* `l:yui` I've changed it to do nothing but its used in a few
unmaintained plugins, I could remove this, thoughts?
* There's a few TODOs that say they could be cleaned up after yui was
removed for the component, but hasn't been done yet
ATH passed:
https://github.com/jenkinsci/acceptance-test-harness/pull/1884
Bom: https://github.com/jenkinsci/bom/pull/4176
<!-- Comment:
If the issue is not fully described in Jira, add more information here
(justification, pull request links, etc.).
* We do not require Jira issues for minor improvements.
* Bug fixes should have a Jira issue to facilitate the backporting
process.
* Major new features should have a Jira issue.
-->
### Testing done
Clicked around a number of pages and didn't see anything wrong.
<!-- Comment:
Provide a clear description of how this change was tested.
At minimum this should include proof that a computer has executed the
changed lines.
Ideally this should include an automated test or an explanation as to
why this change has no tests.
Note that automated test coverage is less than complete, so a successful
PR build does not necessarily imply that a computer has executed the
changed lines.
If automated test coverage does not exist for the lines you are
changing, you must describe the scenario(s) in which you manually tested
the change.
For frontend changes, include screenshots of the relevant page(s) before
and after the change.
For refactoring and code cleanup changes, exercise the code before and
after the change and verify the behavior remains the same.
-->
### Proposed changelog entries
- Remove the Yahoo! User Interface library
<!-- Comment:
The changelog entry should be in the imperative mood; e.g., write "do
this"/"return that" rather than "does this"/"returns that".
For examples, see: https://www.jenkins.io/changelog/
Do not include the Jira issue in the changelog entry.
Include the Jira issue in the description of the pull request so that
the changelog generator can find it and include it in the generated
changelog.
You may add multiple changelog entries if applicable by adding a new
entry to the list, e.g.
- First changelog entry
- Second changelog entry
-->
### Proposed upgrade guidelines
N/A
<!-- Comment:
Leave the proposed upgrade guidelines in the pull request with the "N/A"
value if no upgrade guidelines are needed.
The changelog generator relies on the presence of the upgrade guidelines
section as part of its data extraction process.
-->
```[tasklist]
### Submitter checklist
- [ ] The Jira issue, if it exists, is well-described.
- [ ] The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.
- [ ] There is automated testing or an explanation as to why this change has no tests.
- [ ] New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.
- [ ] New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.
- [ ] New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).
- [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
- [ ] For new APIs and extension points, there is a link to at least one consumer.
```
### Desired reviewers
@mention
<!-- Comment:
If you need an accelerated review process by the community (e.g., for
critical bugs), mention @jenkinsci/core-pr-reviewers.
-->
Before the changes are marked as `ready-for-merge`:
```[tasklist]
### Maintainer checklist
- [ ] There are at least two (2) approvals for the pull request and no outstanding requests for change.
- [ ] Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
- [ ] Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.
- [ ] Proper changelog labels are set so that the changelog can be generated automatically.
- [ ] If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).
- [ ] If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).
```
* Remove usages of StringUtils#containsIgnoreCase
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#removeStart StringUtils#removeEnd
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#defaultString
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#defaultIfBlank
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#isAlphanumeric
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils.EMPTY
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#split
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#startsWithIgnoreCase
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#countMatches
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#endsWithAny
Signed-off-by: Bob Du <i@bobdu.cc>
* fix spotbugs warning
Signed-off-by: Bob Du <i@bobdu.cc>
* Use Objects.toString
Signed-off-by: Bob Du <i@bobdu.cc>
* revert unrelated change
Signed-off-by: Bob Du <i@bobdu.cc>
---------
Signed-off-by: Bob Du <i@bobdu.cc>
* [JENKINS-60866] Apply Stapler update for CSP-compliant st:bind
* [JENKINS-60866] Make renderOnDemand CSP-compliant
* Thanks Spotless
* Make Stapler incrementals work
* Update Stapler to new incremental
* Fixup bad merge
* Update Stapler, add test demonstrating st:bind working
* Address review feedback
* Add test for null bind, update Stapler
* Checkstyle
* More tests
* Use released Stapler
---------
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
Co-authored-by: Basil Crow <me@basilcrow.com>
* [JENKINS-71965] fix timezone in build history
the timezone shown was always the daylight saving time when the users
selected timezone has daylight saving. The change will now consider the
actual timestamp of the build to determine if it was in daylight saving
time to properly calculate the timezone to show.
* make locale aware
* [JENKINS-71715] Allow plugins with alternate build log visualizations to handle console links from core and other plugins
* [JENKINS-71715] Apply suggestions with ordinal extension and @since TODO
* [JENKINS-71715] Public @Extension
* Add or fix @since todo
we usually don't put versions but put todo instead and these versions get resolved _after_ merges.
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
* [JENKINS-71715] Apply suggestions from reviews
* [JENKINS-71715] Switch ConsoleURLProvider to interface and add Functions.getContextRelativeUrl
* [JENKINS-71715] Refactor ConsoleUrlProvider API and add Functions.getConsoleUrl method for use in Jelly files
* [JENKINS-71715] Fix casing of ConsoleURLProvider.java
* [JENKINS-71715] Add global and per-user configuration options for ConsoleUrlProvider
* [JENKINS-71715] Fix Javadoc reference
* [JENKINS-71715] Remove outdated TODO comment
* [JENKINS-71715] Miscellaneous updates based on review feedback
* [JENKINS-71715] Fix Javadoc links
* [JENKINS-71715] Update console links for build list and build time trend widgets
* [JENKINS-71715] Functions.getConsoleUrl must take Queue.Executable instead of Run
* [JENKINS-71715] Simplify test using WebClient.executeOnServer
* [JENKINS-71715] Add constructor
* [JENKINS-71715] Preserve old behavior of p:console-link as a fallback for atypical consumers
* [JENKINS-71715] Ignore invalid URLs and consult global providers if user providers fail to provide a valid URL
* [JENKINS-71715] Move ConsoleUrlProviderGlobalConfiguration into AppearanceCategory
* [JENKINS-71715] Hide AppearanceGlobalConfiguration if ConsoleUrlProviderGlobalConfiguration is disabled and would be the only option on the page
* [JENKINS-71715] Update help text and Javadoc based on review feedback, and filter out default provider in global config
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
* [JENKINS-71715] getProvidersDescriptors can be an instance method
---------
Co-authored-by: Baptiste Mathus <bmathus@gmail.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Co-authored-by: Devin Nusbaum <dnusbaum@cloudbees.com>
Co-authored-by: Devin Nusbaum <dwnusbaum@users.noreply.github.com>
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
* missing 'alt' attribute added
* missing 'alt' attribute added
* replaced 'new URL' to 'new URI' per Java 11 target codebase
* Revert "replaced 'new URL' to 'new URI' per Java 11 target codebase"
This reverts commit aeef4c1e4b.
* replaced deprecated URL() with URI#.toURL()
* updated code per review
* updated
* updated code
* added back file
* Update core/src/main/java/hudson/cli/InstallPluginCommand.java
Co-authored-by: James Nord <jtnord@users.noreply.github.com>
* Update core/src/main/java/hudson/TcpSlaveAgentListener.java
remove non required as per suggestion
Co-authored-by: James Nord <jtnord@users.noreply.github.com>
* Update core/src/main/java/hudson/model/UpdateSite.java
Co-authored-by: James Nord <jtnord@users.noreply.github.com>
* Update core/src/main/java/hudson/model/UpdateSite.java
* Spotless
---------
Co-authored-by: Alexander Brandes <mc.cache@web.de>
Co-authored-by: James Nord <jtnord@users.noreply.github.com>
* Updating the descriptions for the escape/encode functions
Adding explanations and examples to the encode and escape functions
* Updated description for encode
I have edited some of the descriptions to bring them in line with the documentation over on husdon.Util
* Changed leading and trailing spaces on encode
I left one space at the end and added a note to say how a blank space is rendered
* Removed trailing whitespace to satisfy checkstyle
* Preserve formatting and escape HTML tags
* Update core/src/main/java/hudson/Functions.java
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
* Changed escaping on examples so they rendered properly in the javadoc
I was tempted to use {@literal &} notation but this added blank spaces, making the examples look strange. Instead I have used the &amp; notation.
* Update core/src/main/java/hudson/Functions.java
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
* Update core/src/main/java/hudson/Functions.java
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
* Update core/src/main/java/hudson/Functions.java
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
* Update core/src/main/java/hudson/Functions.java
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
* Update core/src/main/java/hudson/Functions.java
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
* Update core/src/main/java/hudson/Functions.java
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
---------
Co-authored-by: Alexander Brandes <mc.cache@web.de>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Kris Stern