OpenSource/jenkins
1
0 Fork 0
mirror of https://github.com/jenkinsci/jenkins.git synced 2026-11-10 02:26:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
27,914 Commits 55 Branches 1,940 Tags
a026f89ecfd4752b288097f8aba53aecdf93ab24
Commit Graph
200 Commits
Author SHA1 Message Date
Francisco Fernández f6ef70a8d4 [JENKINS-54310] java.io.IOException: Stream is closed when the CLI has not read entirely the input (#3708) 
* [JENKINS-54310] read the input at once

* [JENKINS-54310] reading as String

* [JENKINS-54310] Change the approach for those CLI that open a shell
 2018-11-07 10:08:52 +03:00
Josh Soref 0aea34735d cli: Fix up usage message (#3676) 
The properties file naively assumed that leading spaces would be honored.
-- They are not. To get some indentation, one needs to escape a space first.

Further, for no particular reason, the last paragraph had a hard wrap.

Finally, since this commit has to reindent the entire block, fix the alignment of the `:`s
for most of the options.
(-auth is a mess and should be rewritten)
 2018-10-09 09:20:34 +02:00
Oleg Nenashev 56c6571d73 [JENKINS-53792] - Update CLI help to advertise usage of credential files (#3684) 
* [JENKINS-53792] - Update CLI help to advertise usage of credential files

* [JENKINS-53792] - Use redirect as suggested by @daniel-beck
 2018-10-07 19:19:36 +02:00
Francisco Fernández e998a7808f [JENKINS-53792] Env vars to configure CLI -auth option (#3653) 
* [JENKINS-53792] Add env vars for auth option

* [JENKINS-53792] Fix encoding after first commit

* [JENKINS-53792] Better readability

* [JENKINS-53792] Refactor and use the ApiToken

* [JENKINS-53792] Fix encoding
 2018-10-06 16:05:38 +02:00
Oleg Nenashev 0795e89b30 Merge pull request #3642 from oleg-nenashev/build/javadoc-tt-tag 
Javadoc: cleanup `tt` tags from Javadoc (prohibited in JDK11)
 2018-09-21 19:10:21 -07:00
Oleg Nenashev b5be66014c [JENKINS-53693] - Update PowerMock and Mockito to a Java11-compatible version (#3637) 
* [JENKINS-53693] - Update PowerMock and Mockito to a Java11-compatible version

* [JENKINS-53693] - Fix tests which depend on mocking

* [JENKINS-53693] - Apply fixes to PowerMock
 2018-09-21 19:08:35 -07:00
Oleg Nenashev d9d31f9914 Cleanup Javadoc errors in hudson.cli.PrivateKeyProvider (fails in Java 11) 2018-09-21 17:47:03 -07:00
Jesse Glick 0268cc9929 Remove ${build.version} property in favor of ${project.version}. 2018-05-09 15:17:02 -04:00
Oleg Nenashev bb89137596 Merge pull request #3338 from oleg-nenashev/findbugs/JENKINS-50064 
Cleanup FindBugs in CLI + some refactoring
 2018-03-18 06:59:38 +01:00
Jesse Glick f9e4df59d5 Merge branch 'master' into anonymous-warning-JENKINS-49994 2018-03-12 12:24:31 -04:00
Oleg Nenashev 5e0e553353 [JENKINS-50064] - Suppress FindBugs warning in CLI, switch to the medium level 2018-03-10 21:54:43 +01:00
Jesse Glick d94049cc71 https://github.com/kohsuke/localizer/pull/11 actually works now. 2018-03-09 12:51:56 -05:00
Jesse Glick 73b16084f9 [JENKINS-49994] Warn about Remoting serialization of anonymous inner classes and their ilk. 2018-03-07 14:52:34 -05:00
Jesse Glick d3645f7dfe Updating Powermock and Objenesis to avoid Mockito/Hamcrest library mismatches. 2017-12-08 10:44:58 -05:00
Gentle Yang 8bb8057e8d update to the newest version 2017-11-27 21:33:23 +08:00
Gentle Yang 125cf9d8f1 Create Messages_zh_CN.properties 2017-11-25 22:07:19 +08:00
Alessandro Menti 2934c7b945 Update the Italian localization 2017-10-12 20:34:05 +02:00
Jesse Glick 5e84c5470f [JENKINS-18114] Fixing CLI crumbs (#3019) 
* [JENKINS-18114] The CLI client already asks for a crumb; we just to actually serve it, from CrumbIssuer.RestrictedApi.

* serveCliActionToAnonymousUserWithoutPermissions() was checking some stuff better checked by authentication(), and was failing since this fake client was not passing a crumb.

* Bring back CliCrumbExclusion, needed for anonymous use with no read access, and just let the client stop asking for a crumb.

* Added FullDuplexHttpServiceTest; useful to have a simple, self-contained demonstration of the HTTP Duplex transport.
 2017-09-22 11:55:52 +03:00
Jesse Glick dc06c3f03b [FIXED JENKINS-46659] Avoid Jetty timeouts by sending a ping-like packet every 10s while a CLI command is running. 2017-09-09 15:45:26 -04:00
Jesse Glick 00956ff9da [JENKINS-39738, JENKINS-43668] - Pick up SSHD module including sshd-core 1.6.0 (#2853) 
* Pick up SSHD module including sshd-core 1.4.0.

* [FIXED JENKINS-39738] Picking up https://github.com/jenkinsci/sshd-module/commit/bb6963453086edef4e600abb2740182cd2f4ade0

* Picking up Apache SSHD 1.6.0 & Jenkins sshd module 2.0.
 2017-07-08 01:01:01 +02:00
Oliver Gondža 662df37426 Resolving the redirect is OK to fail 2017-06-19 13:22:25 +02:00
Oliver Gondža d9cb39f95f Use authorization to resolve redirect 2017-06-19 12:52:18 +02:00
Oliver Gondža 552d2835cc Address review comment 2017-06-19 09:34:44 +02:00
Oliver Gondža 741be05517 [FIXED JENKINS-44361] Follow HTTP redirects while initiating CLI connection 2017-05-23 15:16:04 +02:00
Stephen Connolly 3871d7778e [JENKINS-43531] Plugins may not be expecting InvalidPathException 
- Plugins should really be expecting it, but as historically they have not, may as well convert to IOE for them
 2017-04-19 14:04:33 +01:00
Jesse Glick 7c16d8dc46 Fix Javadoc generation on JDK 8. 2017-04-11 09:26:45 -04:00
Jesse Glick 729016989e [FIXED JENKINS-41745] Merged #2795: non-Remoting-based CLI. 2017-04-07 20:08:05 -04:00
Jesse Glick 0f87e10a69 @oleg-nenashev requested this be decoupled from https://github.com/jenkinsci/sshd-module/pull/10. 2017-04-07 11:29:21 -04:00
Jesse Glick f3da0e498f Minor review comments from @oleg-nenashev. 2017-04-07 10:22:06 -04:00
Jesse Glick 6ffc57ae79 Verifying that PlainCLIProtocol ignores unrecognized opcodes, so long as it has received well-formed frames. 2017-04-06 15:58:23 -04:00
Jesse Glick 9150d5b563 Suppress an idle timeout from Jetty which would otherwise interfere with interactive commands. 2017-04-06 15:30:53 -04:00
Jesse Glick c41c97b3a2 @stephenc requested documentation of the deprecated FullDuplexHttpStream constructor, and as it turns out it did not work. 2017-04-06 11:40:19 -04:00
Jesse Glick 724ebbcc50 Improved error message displayed when using -http against a pre-JENKINS-41745 server. 2017-04-05 18:42:33 -04:00
Jesse Glick da581599fd -http mode broke when the user omitted the mandatory final / in the Jenkins URL. 2017-04-05 18:28:37 -04:00
Jesse Glick 3939820c5f Using logger as suggested by @rsandell. 2017-04-05 09:53:14 -04:00
Jesse Glick 7bca0a1eef Refined implementation of -logger. 2017-04-05 09:48:56 -04:00
Jesse Glick 9fc59bf251 Finally figured out how to suppress the ReadPendingException from Jetty. 
Something¹ seems to interrupt the HTTP duplex service thread,
and Jetty apparently deals poorly with interruptions.
So introduce an extra sleep to soak up the interrupt.

¹Who? http://stackoverflow.com/questions/2126997/who-is-calling-the-java-thread-interrupt-method-if-im-not#comment40865453_2127397
 2017-04-04 19:15:03 -04:00
Jesse Glick 3b92399db8 Tested Jetty 9.4.3.v20170317 but ReadPendingException’s did not disappear. 2017-04-04 14:50:46 -04:00
Jesse Glick fb311c687f Suppress a meaningless ClosedChannelException thrown by Jetty when killing a client. 2017-04-04 14:01:57 -04:00
Jesse Glick 03aa2a1f17 Simpler to catch ReadPendingException in just one place. 2017-04-04 13:48:21 -04:00
Jesse Glick 4c1910a10b Silence an annoying message. 2017-04-04 13:24:20 -04:00
Jesse Glick c74999f00c Found a race condition which could explain random CI hangs of CLIActionTest.authenticate. 2017-04-04 11:26:57 -04:00
Jesse Glick 71d7562db6 Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-04 11:03:59 -04:00
Jesse Glick 9812db70d3 Improved handling of stream closure. 
Making interrupt of `build -s` work in `-http` mode.
Does not solve `ReadPendingException`s.
 2017-04-03 18:52:59 -04:00
Jesse Glick f1689367c3 Test failure on Windows, perhaps specific to filesystem type of TemporaryFolder. 
java.nio.file.FileSystemException: …\.ssh\known_hosts: Incorrect function.
        at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86)
        at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:90)
        at sun.nio.fs.WindowsAclFileAttributeView.getFileSecurity(WindowsAclFileAttributeView.java:88)
        at sun.nio.fs.WindowsAclFileAttributeView.getOwner(WindowsAclFileAttributeView.java:121)
        at sun.nio.fs.FileOwnerAttributeViewImpl.getOwner(FileOwnerAttributeViewImpl.java:91)
        at java.nio.file.Files.getOwner(Files.java:2079)
        at org.apache.sshd.common.util.io.IoUtils.getFileOwner(IoUtils.java:272)
        at org.apache.sshd.common.util.io.ModifiableFileWatcher.validateStrictConfigFilePermissions(ModifiableFileWatcher.java:240)
        at org.apache.sshd.client.keyverifier.DefaultKnownHostsServerKeyVerifier.reloadKnownHosts(DefaultKnownHostsServerKeyVerifier.java:79)
        at org.apache.sshd.client.keyverifier.KnownHostsServerKeyVerifier.verifyServerKey(KnownHostsServerKeyVerifier.java:161)
        at …
Interactive testing of known_hosts on XP works as expected.
 2017-04-03 17:06:53 -04:00
Oleg Nenashev 33f458d358 Merge pull request #2519 from oleg-nenashev/findbugs/JENKINS-36720-medium-level-fb 
[JENKINS-36720] - Cleanup of SOME medium FindBugs issues
 2017-04-03 22:45:34 +02:00
Jesse Glick 466d74d15e Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-03 12:54:04 -04:00
Daniel Beck bde09f70af Merge pull request #2816 from stephenc/jenkins-42934 
[JENKINS-42934] Avoid using new FileInputStream / new FileOutputStream
 2017-03-30 12:46:10 +02:00
Jesse Glick 60632c0e98 Added -strictHostKey option to CLI in -ssh mode. 
[FIXED JENKINS-33595] Picks up https://github.com/jenkinsci/sshd-module/pull/11
to turn off SSHD by default, but expose it to tests which wish to enable it.
 2017-03-24 17:12:05 -04:00
Jesse Glick e69ba0f024 Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-03-24 15:26:59 -04:00