* JENKINS-42319: Fix broken compareTo method of Run
Previous implementation relied on fact that users always compare run
objects with same parent. But this is not always the case.
So, it was not safe to put runs from different parents to TreeSet, i.e.
* Make comparasion more performance friendly
* [FIX JENKINS-40053]: Use english as default-locale, so the ResourceBundleUtilTest runs also on systems with other default os locales.
* [FIX JENKINS-40053]: Cleanup Locale after test to avoid impact on other tests.
* [FIX JENKINS-40053]: Use english as default-locale only in the required test method.
* [FIX JENKINS-40053]: Cleanup unused imports.
* [FIX JENKINS-36044]: Added default locale to XMLUtilsTest so that it runs independent from the host OS locale.
* [FIX JENKINS-36044]: Cleanup default-locale after test, to avoid impact to other tests.
* [FIX JENKINS-36044]: Make test language indepedent.
* [FIX JENKINS-36044]: Cleanup unused imports.
* Allows customization in seconds, not minutes
* Allows customization of the ping timeout (before, you could set a
custom interval, but the timeout would always be PingThread's 4
minute default)
This also drops the serialVersionUID from ChannelPinger.SetUpRemotePing;
without one provided, the JVM will generate one on demand which is
sufficient for the purposes here since these are never persisted and
master & slave run the same compiled code. (And it demonstrably works
since countless other MasterToSlaveCallables fail to specify their own
custom IDs)
* Add some tests to current behaviour of getLog method
* getLog(maxLines) reads only last maxLines lines now
It should speed up and reduce memory consumption for some plugins (i.e.
Email-ext Plugin).
Also now this method could be used to get last lines of build output in efficient manner.
* Fix issues from code review
- We cannot modify `replaceAction` to return the dirty flag, in fact most callers probably don't care... but if you do care, we now provide `addOrReplaceAction`
- Clarify the javadocs to reflect that these methods are not going to affect actions added by transient action factories
* [JENKINS-36871] Switch to the new JnlpProtocolHandler based implementation
Todo
- [ ] Restore the cookie behaviour (but done right this time)
- [ ] Perhaps investigate issuing clients with TLS certificates (but would require a UI for managing them)
* [JENKINS-36871] License headers and javadocs
* [JENKINS-36871] Restore cookie handling
* [JENKINS-36871] Integrating Agent discovery components
* [JENKINS-36871] Pick up remoting 3.0-SNAPSHOT
* [JENKINS-36871] Pick up newer snapshot
* [JENKINS-36871] Oleg wants to log an exception that cannot happen
* Test Windows junctions before Java 7 symlink
Apparently Java 7 (and later) do not count Windows junctions as
symlinks. When you drill down into the BasicFileAttributes structure,
reparse points are only counted under isOther. So, since we already
have code that properly detects Windows Junctions, let's use that first
and then fallback to the Java 7 code.
* Add comment for change & link bug.
* Add test case
* Switch to Functions.isWindows().
* Use non-deprecated APIs for tmp file/dir mgmt
* Add better debugging.
* Allow spaces in junction name & dir name.
To do that, it was easier to use ProcessBuilder vs building up the correct
string in code to send to cmd.exe.
Also, I'll note that according to http://ss64.com/nt/syntax-internal.html,
mklink is in internal cmd.exe command. So, it must be invoked through
"cmd.exe /c" for it to work.
* Remove comment mentioning bug number.
* Remove debugging output, per Baptiste's request
* Add newline at end of file.
* Make sure that the junction was removed.
* Use assertEquals to show retcode of Process.waitFor.
* Fix compilation errors by importing functions
* [JENKINS-37332] - Improve diagnostics of non-closed streams during reading of the manifests in PluginManager
* [JENKINS-37332] - Leakless processing of JarUrlConnection during Manifest parsing
* [JENKINS-37332] - Also implement leak-safe method for retrieving file modification date
* [JENKINS-37332] - Add spotcheck methods for manifest file access + Javadoc
* [JENKINS-37332] - Also test multi-line and empty attributes in the test
* [FIXED JENKINS-31791] Optimize BuildHistoryWidget
Refactor HistoryPageFilter to lazily evaluate an iterable of previous
runs, instead of instantiating a super long list of builds.
Instantiating the whole list can be problematic with lots of
historical builds especially if disk IO is slow.
Daniel Beck