Commit Graph
7138 Commits
Author SHA1 Message Date
Jesse Glick a614cd5b05 [FIXED JENKINS-17125] FingerprintAction no longer need persist the build field thanks to new RunAction2. 2013-06-05 16:02:36 -04:00
Jesse Glick d964d07220 @since 2013-06-05 09:06:07 -04:00
Jesse Glick 07b377cd4a Comment. 2013-06-04 20:09:06 -04:00
Jesse Glick 06b92a49bf [FIXED JENKINS-15587] Do not issue a warning about unparsable build timestamps if it is just a number, i.e. failed symlink. 2013-06-04 19:24:28 -04:00
Jesse Glick 91a62d6574 [FIXED JENKINS-18193] NPE thrown when Jenkins failed to initialize.
Not really solving anything here—there is no plausible implementation that could run under these circumstances—
but at least reporting the problem more clearly.
2013-06-04 14:43:13 -04:00
Jesse Glick 638537d0c4 @CheckForNull 2013-06-04 14:29:46 -04:00
Jesse Glick fc45c84551 Merge pull request #746 from saschpe/master-jenkins-16276
[JENKINS-16276] and various fixes for related exceptions
2013-06-03 11:13:36 -07:00
Kohsuke Kawaguchi c8a6dac2f9 defer the resolution
Otherwise it might try to access a Descriptor that's not yet registered.
2013-06-03 07:47:58 -07:00
Sascha Peilicke 1c00d3f65b Fix exception in MatrixBuild.java:371
Happens when build has no parent:

15:06:14 FATAL: null
15:06:14 java.lang.NullPointerException
15:06:14    at hudson.matrix.MatrixBuild$MatrixBuildExecution.doRun(MatrixBuild.java:371)
15:06:14    at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:580)
15:06:14    at hudson.model.Run.execute(Run.java:1575)
15:06:14    at hudson.matrix.MatrixBuild.run(MatrixBuild.java:304)
15:06:14    at hudson.model.ResourceController.execute(ResourceController.java:88)
15:06:14    at hudson.model.Executor.run(Executor.java:237)
15:06:14    at hudson.model.OneOffExecutor.run(OneOffExecutor.java:66)
2013-06-03 12:58:01 +02:00
Jesse Glick e86ab7204b Suppressing some known-good instances of an idiom otherwise warned about by NetBeans plugin for Jenkins. 2013-05-31 15:05:15 -04:00
Jesse Glick eff5635b75 [JENKINS-15587] Diagnostics. 2013-05-31 14:51:07 -04:00
Jesse Glick 6509ed9ecc Merge branch 'master' of github.com:jenkinsci/jenkins 2013-05-31 14:36:59 -04:00
Jesse Glick 2a1d1631bd [FIXED JENKINS-14351] jna-posix → jnr-posix upgrade (opt in). 2013-05-31 14:36:15 -04:00
Kohsuke Kawaguchi 4a95cc6f92 Fixed NPE. 2013-05-31 09:59:44 -07:00
Jesse Glick be5cd4fd16 [FIXED JENKINS-16023] Use permalinks for as many Job.getLast*Build methods as possible. 2013-05-30 18:10:55 -04:00
Jesse Glick 24334dc177 Do not fail startup in case ListView.includeRegex was syntactically malformed. 2013-05-30 16:40:44 -04:00
Jesse Glick 972d8bad22 [FIXED JENKINS-15652] “Solving” errors by just return null from ALLRM.search and reducing to one-line warnings.
@kohsuke confirms that the intent of throwing AIOOBE was to track down definite code errors;
but in at least some known occurrences of this bug, the problem is invalid data:
build records on disk with <number>s that are duplicated and/or out of order.
Since that violates the precondition of the class, we do not pretend to successfully search for such records.
At some point it would make sense to have the code detect anomalous conditions and initiate a builds folder cleanup.
Take only the last build of a given number, and discard any earlier with higher number.
I.e. just set <number> to 0 or something and ignore such builds, or rename build.xml to build-broken.xml.
2013-05-28 19:11:28 -04:00
Jesse Glick 6a70f6937b [JENKINS-15652] More clearly distinguishing the three asserts. 2013-05-28 18:46:35 -04:00
Jesse Glick f1b513cf91 [JENKINS-16301] Need to create parent directory of fingerprint file too. 2013-05-28 17:56:43 -04:00
Jesse Glick fff90c100d [FIXED JENKINS-16301] Optimized Fingerprint.save. 2013-05-28 16:28:16 -04:00
Jesse Glick f6178f4bd9 Attempting to be more robust against problems initializing this class.
https://jenkins.ci.cloudbees.com/job/core/job/jenkins_main_trunk/896/testReport/junit/hudson.tools/ToolLocationNodePropertyTest/testFormRoundTrip/
java.lang.NoClassDefFoundError: Could not initialize class hudson.model.ComputerSet
	at jenkins.model.Jenkins.getComputer(Jenkins.java:1107)
2013-05-28 13:54:17 -04:00
Jesse Glick aa657d79e9 Merge pull request #785 from vjuranek/JENKINS-18024
[FIXED JENKINS-18024] Avoid NPE when checking if reason why in the queue has been changed
2013-05-28 10:39:43 -07:00
Jesse Glick 1db5de0efb Merge pull request #778 from jglick/Job-getIconColor-unbuilt
Use NOTBUILT rather than GREY when a job has not yet been built
+1 from @kutzi and no comment from @kohsuke, so I hope this is uncontroversial.
2013-05-28 10:33:15 -07:00
Jesse Glick 73706a45bc [JENKINS-18074] Updated comment. 2013-05-28 13:20:55 -04:00
Jesse Glick 315bde60d0 [FIXED JENKINS-18119] Work around timing issue in sortable object.
Note that when workaround is active, table will not get sorted properly.
Probably OK since tables with large contents that *need* sorting probably take longer to finish rendering.
2013-05-28 12:43:15 -04:00
Jesse Glick 8549e7b32d [FIXED JENKINS-18118] Introduced UserAvatarResolver.resolveOrNull to properly produce fallback icon URL. 2013-05-28 12:23:55 -04:00
Jesse Glick 04e2ccade6 [FIXED JENKINS-18074] Avoid clearing AbstractItem.displayName when the new parent ItemGroup is different. 2013-05-24 12:06:37 -04:00
Jesse Glick 476fe22d6e hashify was in 1.510, not 1.509. 2013-05-24 10:10:36 -04:00
Jesse Glick 328b9c8d9d toString 2013-05-23 14:40:10 -04:00
Jesse Glick 1551ad6e46 Warning about mutable design, not apparent from API signature. 2013-05-23 13:55:54 -04:00
Jesse Glick ef926d8a8f Javadoc and @since. 2013-05-23 13:40:48 -04:00
Jesse Glick 186c425d55 @since 2013-05-23 12:56:36 -04:00
Jesse Glick 53cbf595ed [JENKINS-7280] Touch-ups. 2013-05-23 11:05:40 -04:00
gcummings b1415bda59 JENKINS-7280 - Allow filtering of the Run Paramters List - All,
Completed, Successful & Stable using Enum
2013-05-23 11:08:17 +01:00
Vincent Latombe 16a3ddfe05 Merge branch 'master' into recurse-folders-maven-jobs-compat 2013-05-23 10:53:29 +02:00
Jesse Glick 4af5c22134 [FIXED JENKINS-17681] Use builds\last{Stable,Successful}Build on Windows for permalinks. 2013-05-22 17:27:52 -04:00
Jesse Glick 41edc5867b [JENKINS-16301] Verifying current load/save implementation can round-trip fingerprints. 2013-05-22 17:20:43 -04:00
Jesse Glick 63ecb8269a Use message formats when logging. 2013-05-22 10:30:18 -04:00
Jesse Glick cd3efb21db Avoid gratuitous logging at INFO. 2013-05-22 10:28:00 -04:00
Ari Hyttinen 4b8329a1c4 Fixed reporting correct pass count by TestResult.toPrettyString() method. 2013-05-22 12:39:31 +03:00
Jesse Glick 54fda4faa1 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-05-21 21:40:31 -04:00
Jesse Glick 8d2e452336 [JENKINS-16301] Verifying current serial format as a baseline. 2013-05-21 21:39:44 -04:00
Jesse Glick 9d72311ba0 [JENKINS-16301] Use a buffered input stream to get somewhat better performance. 2013-05-21 17:42:50 -04:00
Jesse Glick 51fbd2d867 [JENKINS-16301] Replace impl of getDigestOf with standard (Commons Codec) DigestUtils.md5Hex, for simplicity. 2013-05-21 17:41:39 -04:00
Jesse Glick 6ea4532da3 Merge pull request #774 from dnadolny/master
[JENKINS-17478] Various improvements from code reviews
2013-05-21 11:26:35 -07:00
Jesse Glick b5d96e27dd [JENKINS-17030] Noting, fixing/adding @since, adding @Bug. 2013-05-21 14:07:10 -04:00
Jesse Glick e31b750c58 Merge pull request #767 from olivergondza/wbr_layout
[FIXED JENKINS-17030] Enable word breaking for job names.
2013-05-21 11:04:21 -07:00
Vojtech Juranek b8b9b71be1 [FIXED JENKINS-18024] Avoind NPE when checking if reason why in the queue has beed changed 2013-05-21 13:20:35 +02:00
Jesse Glick df53cc7d72 Lack of HTML escape made Javadoc misleading. 2013-05-20 13:27:19 -04:00
Jesse Glick ab2774362f [JENKINS-15652] Include directory in assertion messages so it is possible to tell which project is broken. 2013-05-20 13:04:27 -04:00