Commit Graph
13287 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi a72e64d2c0 [maven-release-plugin] prepare for next development iteration 2014-11-30 12:36:46 -08:00
Kohsuke Kawaguchi 42e620e609 [maven-release-plugin] prepare release jenkins-1.592 2014-11-30 12:36:46 -08:00
Fernando Boaglio dfe98e4785 pt_BR translation fix 2014-11-25 23:57:31 -02:00
Fernando Boaglio 5fdd3e6754 pt_BR translation fix - thanks to @kinow 2014-11-25 23:45:25 -02:00
Jesse Glick 534328b264 [FIXED JENKINS-25759] Avoid consuming too much memory while running validateAntFileMask.
Not fully solved, since the scannedDirs field can still grow to be large, but at least clearing files/dirsNotIncluded.
Also imposing a 5s timeout on the scan regardless of file count, and defining a user-customizable bound.
2014-11-24 10:37:58 -05:00
Daniel Beck b21827b34a [FIXED JENKINS-25642] Fix link to user list. 2014-11-23 00:06:42 +01:00
Jesse Glick 08542cad75 Javadoc notes warning that the action should be hidden if impermissible.
[JENKINS-25691] Might have prevented the need for: https://github.com/jenkinsci/maven-plugin/pull/33
2014-11-21 11:48:21 -05:00
Kohsuke Kawaguchi d237acc447 Added a hook to perform additional diagnostic activities before killing the channel.
ssh-slaves plugin can leverage this to try to obtain the state of the slave JVM via SSH.

Reference: ZD-23093
2014-11-20 20:12:22 +01:00
Kohsuke Kawaguchi 960b4053a1 Improving diagnostics for NoClassDefFoundError: could not initialize jenkins.model.Jenkins
Reference: http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8051847
Reference: ZD-23093
2014-11-20 19:03:09 +01:00
Kohsuke Kawaguchi 99b5fc8f38 Report the name of the channel for diagnosis.
Reference: ZD-23093
2014-11-20 18:38:48 +01:00
Fernando Boaglio 2cf428f848 pt_BR translation 2014-11-20 01:55:11 -02:00
Jesse Glick 21ee00a971 Run.getDurationString should compare against startTime, not timestamp. 2014-11-18 14:59:57 -05:00
Jesse Glick 2a144eb86f Moving message key to external-monitor-job-plugin. 2014-11-18 11:34:49 -05:00
Jesse Glick b76e7bf998 [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results.
Caused a failure in hudson.plugins.promoted_builds.conditions.ManualConditionTest.testManualPromotionProcessViaWebClient when run against 1.580.1.
2014-11-17 17:48:48 -05:00
Stephen Connolly 4e56128cd8 Allow Projects to take the Queue.Item's actions into consideration when determining their default authentication 2014-11-17 14:18:06 +00:00
Stephen Connolly b27c11acc7 Actually don't need the lock here as c.kill() now does the right thing 2014-11-17 13:51:41 +00:00
Stephen Connolly ddff2faa90 Damn you Java 7 for not catching 2014-11-17 12:49:30 +00:00
Stephen Connolly 65b71c20b1 Allow programmatic QueueItemAuthenticators that are not user configurable 2014-11-17 11:44:56 +00:00
Stephen Connolly 7335916f18 Provide a future path to refactoring the Queue locking strategy
- Also tidy up some holes in locking strategy that can cause builds to be scheduled on
  executors that are about to be interrupted or nodes in the process of being removed
2014-11-17 11:07:59 +00:00
Kohsuke Kawaguchi 7f990004ec the trunk is toward 1.592-SNAPSHOT 2014-11-16 19:34:12 -08:00
intelradoux 07a19fcc3c Update ChoiceParameterDefinition
The "it.value" don't exist, so we need to set the defaultParameterValue. 

It help me display correctly parameter for my multilauncher plugin. 
Note that other ParameterDefinition use the default value to display parameter, so IMO it is safe to do this.
2014-11-14 09:49:10 +01:00
Jesse Glick fb8a8b4041 Merge pull request #1462 from cyrille-leclerc/add-verbose-logs
Better debug messages in JSONSignatureValidator
2014-11-13 13:58:30 -05:00
Jesse Glick 9a63158175 AtomicFileWriter.commit should use Util.deleteFile so as to get a more meaningful error message in case the deletion fails.
The following is not helpful in terms of diagnosing the root problem:
java.io.IOException: Unable to delete /…/jobs/demo/builds/…/workflow/3.xml
	at hudson.util.AtomicFileWriter.commit(AtomicFileWriter.java:112)
	at hudson.XmlFile.write(XmlFile.java:179)
	at org.jenkinsci.plugins.workflow.support.storage.SimpleXStreamFlowNodeStorage.saveActions(SimpleXStreamFlowNodeStorage.java:106)
	at …
2014-11-13 10:31:12 -05:00
Cyrille Le Clerc 229ecdc7c8 Better debug messages in JSONSignatureValidator 2014-11-12 00:55:16 +00:00
Kohsuke Kawaguchi 68b383e0b2 Adding another cause 2014-11-11 11:52:26 -08:00
Kohsuke Kawaguchi 2e87c36ca0 Making this class serializable
The use case that led me here was to use this from workflow which relies primarily on Java serialization
2014-11-11 11:52:26 -08:00
Nicolas De Loof e77f79e82b log error creating slave log directory 2014-11-11 10:58:10 +01:00
Jesse Glick 9cca9e05be Expanding Javadoc from #1454 as suggested by @oleg-nenashev. 2014-11-10 13:30:17 -05:00
Jesse Glick 50124db9d5 Merge branch 'Computer.currentComputer-JENKINS-2786' 2014-11-10 13:28:53 -05:00
Kohsuke Kawaguchi d948344c1e Merge remote-tracking branch 'origin/master' 2014-11-10 06:13:05 -08:00
Kohsuke Kawaguchi 9edf0e3f79 the trunk is toward 1.591-SNAPSHOT 2014-11-10 06:12:33 -08:00
Oleg Nenashev fef47e124f Merge pull request #1408 from howlger/master
[FIXED JENKINS-22514] In ZIP archives file separator must be '/'
2014-11-10 12:26:13 +03:00
Oliver Gondža e96f08d61a Merge pull request #1458 from olivergondza/aggregate-validations
Aggregate multiple FormValidations into one
2014-11-08 10:36:08 +01:00
Jesse Glick 78fde58c30 Merge branch 'master' of git://github.com/jenkinsci/jenkins 2014-11-07 14:13:09 -05:00
Oliver Gondža e451789ac7 Merge pull request #1456 from olivergondza/extract-label-validation
Expose AbstractProject.AbstractProjectDescriptor#validateLabelExpression for plugins
2014-11-07 19:42:03 +01:00
Jesse Glick ae053472a0 Merging #1268. 2014-11-07 13:08:53 -05:00
Jesse Glick bfa557b16a Merge branch 'JENKINS-23339' of github.com:synopsys-arc-oss/jenkins 2014-11-07 13:08:03 -05:00
Kohsuke Kawaguchi ada8432fc5 [JENKINS-25144] Merge pull request #1427 2014-11-07 09:43:25 -08:00
Kohsuke Kawaguchi 9e81b8e4fe [FIXED JENKINS-25144] Revisiting the attempted fix in the previous commit.
IIUC, the issue here is that the request in question contains both a
valid session cookie AND basic authentication header, and that path
results in a failure because BasicHeaderProcessor expects one of
BasicHeaderAuthenticators to validate the basic authentication header
(without knowing that there's already a valid Authentication object that
came from the HTTP session, yet no BasicHeaderAuthenticator actually
processes this because BasicHeaderRealPasswordAuthenticator backs away
from doing that.

I think the corect fix is for BasicHeaderRealPasswordAuthenticator to
get rid of authenticationIsRequired check. This check instead belongs to
BasicHeaderProcessor, where it should be used to check if any
BasicHeaderAuthenticator should be consulted or not.

The problem with having this logic in
BasicHeaderRealPasswordAuthenticator is that this is just an
implementation of an extension point, and thus it needs to be removable.
As it stands right now in this fix, if this impl is removed,
JENKINS-25144 will be back again.
2014-11-07 09:42:23 -08:00
Christof Schoell 0176b6d902 [JENKINS-25144]
return authentication object instead of null if authentication is not
required - otherwise valid login fails with basic authentication
2014-11-07 09:40:26 -08:00
Oleg Nenashev e6c2e16f7a [FIXED JENKINS-23339] - Introduce the validated Jenkins::getActiveInstance() method
jenkins.model.Jenkins::getInstance() method is marked as @CheckForNull, but the most of Jenkins code does not actually check the return value. It leads to tons of static analysis errors, hence it is hard to analyze the code.

The change also adds annotations to old methods like Hudson::getInstance()

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-11-07 20:07:52 +03:00
Oliver Gondža 34850200b2 Introduce FormValidation#aggregate 2014-11-07 09:20:06 +01:00
Jesse Glick 24c5e5e440 Javadoc note pertaining to #1454. 2014-11-06 14:29:07 -05:00
Oliver Gondža e985ee69ff Expose AbstractProject.AbstractProjectDescriptor#validateLabelExpression for plugins 2014-11-06 13:29:08 +01:00
Oliver Gondža 12ff0b249a Junit 4 2014-11-06 12:30:33 +01:00
Jesse Glick 0b0b868805 [JENKINS-2786] Makes no sense for Computer.currentComputer to return MasterComputer when not on an executor thread. 2014-11-05 17:19:45 -05:00
Holger Voormann c56362aba3 [FIXED JENKINS-22514] In ZIP archives file separator must be '/' 2014-11-05 08:41:56 +01:00
Kohsuke Kawaguchi 96f97a4579 Integrated the new trilead library that has some minor diagnosability improvements. 2014-11-04 19:46:49 -08:00
Kohsuke Kawaguchi e7d75dc538 Make stdout swapping more reliable.
This matches fb65a2c3c8584a9ac4daa49ecbce7a540dc7f5a5 in remoting.
2014-11-04 19:46:49 -08:00
Jesse Glick 22d433deae So far unsuccessful attempt to make Jenkins startup more robust against bugs like JENKINS-25440.
Even though SezpozModule.configure catches and ignores the faulty component, Guice still dies:
… hudson.ExtensionFinder$GuiceFinder <init>
SEVERE: Failed to create Guice container from all the plugins
com.google.inject.internal.guava.collect.$ComputationException: java.lang.NoClassDefFoundError: org/eclipse/jgit/storage/file/FileRepository
	at …
	at com.google.inject.Guice.createInjector(Guice.java:73)
	at hudson.ExtensionFinder$GuiceFinder.<init>(ExtensionFinder.java:279)
2014-11-04 17:45:52 -05:00