* [JENKINS-50447] New design and slim down of login page
The change will provide a new designed login page that is using no external deps to prevent any possible malvious javascript.
We still allow the user to use the legacy login page, which has not changed the behaviour.
[JENKINS-50447] Implement error case and use final svg jenkins logo
[JENKINS-50447] remove mock up logo
[JENKINS-50447] Fix feet back from jlong
[JENKINS-50447_squash] Use theme css which only contains values to be overriden. Drop ie js since with the theme css it is not needed anymore
* [JENKINS-50447_squash] Fix expression to evaluate when to show an error and when to simply redirect
* eslint - formating changes and fix offences
* [JENKINS-50447_squash] Use system property to controll whether or not to use the legacy login
* [JENKINS-50447_squash] prevent that the jsessionId appears in the url which should fix most tests
* [JENKINS-50447_squash] Fix cli test by adding pageDecorators magic from layout.jelly
* [JENKINS-50447_squash] remove pageDecorators because they assume existence of js that we do not have
* [JENKINS-50447] New design and slim down of login page
The change will provide a new designed login page that is using no external deps to prevent any possible malvious javascript.
We still allow the user to use the legacy login page, which has not changed the behaviour.
[JENKINS-50447] Implement error case and use final svg jenkins logo
[JENKINS-50447] remove mock up logo
[JENKINS-50447] Fix feet back from jlong
[JENKINS-50447_squash] Use theme css which only contains values to be overriden. Drop ie js since with the theme css it is not needed anymore
[JENKINS-50447_squash] Fix expression to evaluate when to show an error and when to simply redirect
eslint - formating changes and fix offences
[JENKINS-50447_squash] Use system property to controll whether or not to use the legacy login
[JENKINS-50447_squash] prevent that the jsessionId appears in the url which should fix most tests
[JENKINS-50447_squash] Fix cli test by adding pageDecorators magic from layout.jelly
[JENKINS-50447_squash] remove pageDecorators because they assume existence of js that we do not have
[JENKINS-50447_squash] make login page extensible with pagedecorators
[JENKINS-50447_squash] drop legacy support
* Make theme customisable by using a magic package for css and header. Limiting the implemetation of those to one.
* [JENKINS-50447_squash] Creating a specific decorator for login which only returns one instance
* [JENKINS-50447_squash] using rounded corner
* JENKINS-50447 remove legacy code
* [JENKINS-50447_squash] Fix comments from @amuniz about javadoc and uniqueness of css for login
* [JENKINS-50447_squash] Fix click on label span to toggle the select of the checkbox
* [JENKINS-50447_squash] fix comments from @daniel-beck
* [JENKINS-50447_squash] Fix license headers
* [JENKINS-50447_squash] Implement loading/restarting and signup with same design
* [JENKINS-50447_squash] Implement the loading/restarting view and signup with same design as the login page
* [JENKINS-50447_squash] Remove limitation that only one validation error can be shown at a time
* [JENKINS-50447_squash] implement password strength checker
* [JENKINS-50447_squash] Fix different comments from @daniel-beck regarding titles. Further enhanced spacing of label and input
* [JENKINS-50447_squash] Fix restart screen css. Fix comments regarding signup page.
* [JENKINS-50447_squash] fix tabindex flow
* harmonize design
- of checkboxes using jdl styles.
- distance of headers
* [JENKINS-50447] Fix comments from @daniel-beck
- fix some accessibility issues
-- html has now a lang tag
-- define main region
- fix missplaced }
- fix when server down for real that we still show the loading page
* [JENKINS-50447_squash] should never ended up here
* Add getSystemProperty(key) to fix hudson.consoleTailKB system property
* Add Javadoc, @Restricted and delegate to SystemProperties
These changes were requested by @daniel-beck.
* PR was not merged in time for 2.96
* Changes as requested by @oleg-nenashev
* [JENKINS-27026] Notify the SecurityListener in case of Token based authentication success
- due the current version of the method, the UserDetails required for the event was not accessible. In order to stay with the same API in SecurityListener, two "protected" methods were created to split the job and let the UserDetails accessible
* - add test to ensure the SecurityListener is called for REST Token but also for regular basic auth
* - remove the comment about the split, will be put in GitHub comment instead
* - add check for anonymous call instead of just putting a comment
- remove the constructor in the dummy
- add link to PR from Daniel to simplify a call
* - separate the before/after to save one clear and be more explicit
- put more meaning in the assertLastEventIs method by explicitly say we will remove the last event
* - add comment about why we do not fire the "failedToAuthenticated" in the case of an invalid token (tips: it's because it could be a valid password)
* - also add the authenticated trigger on legacy filter as pointed by Ivan
* - add support of event on CLI remoting authentication
- adjust tests by moving the helper class used to spy on events
* - as mentioned Yvan, the code had some problems with null checking, so the approach is changed in order to encapsulate all that internal mechanism
* - add javadoc
- open the getUserDetailsForImpersonation from the User (will let the SSHD module to retrieve UserDetails from that)
* - remove single quote in log messages
* - basic corrections requested by Jesse
* - just another typo
* - adjust the javadoc for SecurityListener events
* - add the link to Jenkins#Anonymous
* - add link (not using see)
* - update comment on the isAnonymous as we (me + Oleg) do not find a best place at the moment
* - put the new method isAnonymous in ACL instead of Functions
* - little typo
- add requirement about the SecurityContext authentication
* Add default implementations to deprecated methods of BuilableItem and Item.
Currently the interface requires the API user to implement already deprecated methods.
It does not make much sense, and the API could be simplified.
* Address comments from @jglick
* Add support for exporting jobs in folders recursively
* Convert cc.xml into a Groovy view
* Revert "Convert cc.xml into a Groovy view"
This reverts commit 990ec3ebfb.
* Move logic in jelly view to static method
* Adding some interface default method implementations rather than catching AbstractMethodError or providing partial implementation classes.
* Show Javadoc warnings and errors, but not ‘Generating …/core/target/site/apidocs/jenkins/model/lazy/class-use/AbstractLazyLoadRunMap.html...’ and the like.
* Javadoc fixes.
* Review comments from @oleg-nenashev.
* Test fixes.
* Remove the unused import
* [FIXED JENKINS-36476] Do not even send the default password in encrypted form; leave the text field blank, and apply the default upon submission.
* [JENKINS-36476] Use a special token, not the empty string, as the marker for the default value.
As far as I can figure, the /TcpSlaveAgentListener/ endpoint headers
tell the slaves what the JNLP port is. When I'm running jenkins behind a
proxy (marathon using the mesos plugin, which bridged networking), even
though I was setting the advertised port per a thread[1], it was not
accurately being returned in the header. This patch fixes that.
[1] https://groups.google.com/d/topic/jenkins-mesos/qUrXpDY07TQ/discussion
- Code that is running from a plugin and on the master's JVM is guaranteed to never get null from this method (any cases where you do get null are bugs in core)
- Code that is running from a plugin and on a remote JVM should never be allowed to load the Jenkins class in their classloader, so should never use Jenkins.getInstance()... we are annotating the method with @Nullable so that such code can have some evolution time
- Code that is running in core and on one of two special paths should use the Jenkins.getInstanceOrNull() method so that the UI can be presented to users before the singleton has been instantiated / after the singleton has been destroyed
- The remaining 95% of uses in core (and 100% of uses in plugins) can safely assume that the instance is never null
This reverts commit bb7c8fcedb.
Closes#2090, I'll redo this as a PR... though if that PR is subject to multiple rounds of review before being merged then I will take that of evidence of the exact problem that committing directly was supposed to resolve... namely exponentially multiplying the effort required to make actual improvements to the code base.
- It is never too late to do the right thing.
- The vast majority of usages of `Jenkins.getInstance()` in core currently assume that its return value is non-null
- This commit changes those that are written to correctly check for non-null values will call `Jenkins.getInstanceOrNull()`
- We deprecate the `Jenkins.getActiveInstance()` madness
- I checked with @kohsuke who said not to bother with a PR and just commit this strongly opinionated change direct to master as a PR will just degrade into a bikeshedding.
Accomplished by centralizing calls to System.getProperty(String) and related into new file SystemProperties.java.
There, we first check for existence of system property; if not, we look for property in context.xml
This is done for "application" properties (like hudson.DNSMultiCast.disabled) but not for java properties (like user.name)
Jesse Glick