Commit Graph
41 Commits
Author SHA1 Message Date
Tim Jacomb ab5d044dcc Fix tests on newer java versions (#5182) 2021-01-18 16:04:12 +00:00
Stefan Spieker e75345a85e replaced deprecated IOUtils.LINE_SEPARATOR with System.lineSeparator() 2020-12-31 15:40:38 +01:00
Basil Crow 39c22138d7 Remove redundant type arguments 2020-12-11 21:34:22 -08:00
Basil Crow 578a5e8377 Use Collections#singletonList where possible 2020-12-11 21:34:22 -08:00
Raihaan Shouhellandres0nance e83e6a11dc JDK 11.0.9 / 8.0.272+ compatible FunctionsTest#printThrowable() (#5033)
* JDK 11.0.9 / 8.0.272+ FunctionsTest#printThrowable()

* Ensure proper older java 11 backwards compatibility

Co-authored-by: res0nance <res0nance@users.noreply.github.com>
2020-11-01 10:47:12 +08:00
Jesse Glick a26adf1d57 Commenting out part of FunctionsTest.printThrowable which fails in JDK 11.0.9+ 2020-10-25 22:57:27 +00:00
Basil Crow 1b62f74585 Remove star imports of org.junit.Assert 2020-05-09 15:39:40 -07:00
673a18c637 [JENKINS 60920] header breadcrumbs CSS update (#4463)
* New styles for breadcrumbs and warnings monitor

* Adds the svgxuse polyfill for svg sprites on IE 11

* Created new styles for the page header

- Used the material icons svg sprites to deliver the icons
- Icons are rendered using a <svg> tag

* Create new base styles file and undo changes to the layout-common and style css files

* Fixes and refactor for the new UI CSS code

* Make the new header color and logo section opt-in

- The new UI can be toggled with the -Dui.enableNewUi=true flag

* Rename and refactor the page-header css

- Rename the css class namespace from .main-header to .page-header
- Page header CSS moved into a modules folder and now included on the new-base-styles.css. This is done to avoid loading a separate file everytime.
- Extracted color variables to their own file

* Updated localization for header and admin monitor

- The pageHeader template receives localization strings as props
- Missing translation for the admin monitor on the it, bg and pl locales

* Update core/src/main/resources/lib/layout/layout.jelly

Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>

* Most measurements migrated to REMs

* Code cleanup and apply new-ui toggle to the html.jelly file

* Breadcrumb fixes

- Reverts breadcrumb link styling to use nested selectors instead of the .breadcrumbs__link class. The reason is that several plugins would break.
- Shifted margins so that breadcrumbs can be fullwidth in the absence of the auto refresh link

* Implemented some fixes from the feedback received

- Removed box shadow webkit prefix
- Fixed formatting on the breadcrumbs.css and layout-commons.less files
- Renamed the new UI toggle class from _new-ui_ to _ui-refresh_
- Renamed references to the _new ui_ to _v2_

* Created jelly helper to use svg icons

* Fix: restore proper icon for the user on the header

* Fixes for Edge, IE 11 and IE 10

* Improvements on the header and breadcrumbs

- Logo v2 changed and optimized using the svgo frontend https://jakearchibald.github.io/svgomg/
- Refactored the ammonitor insertion code
- Breadcrumbs are no longer capitalized
- Classic logo link no longer stretches past the images
- Fixed classic logo link on IE11
- Updated color of the footer
- Menu items background is also changed when hovering over the menu selector
- Removed copyright notice on top of some files

* Bumped JTH version with the SVG download fix

* Update test/pom.xml

Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>

* Added a function to check boolean system properties from jelly

* Fix header links and add svg styles for legacy layout

*  Some bug fixing for the new header

- The ui-refresh changes were not properly being enabled with the boolean system property. Added explicit true check on the jelly templates.
- Added an explicit width for the ui-refresh logo because it would mess with the layout

* Update core/src/main/java/hudson/Functions.java

Co-Authored-By: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>

* Do not check the system property on every page render

Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
Co-authored-by: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-02-20 16:57:47 +00:00
Stefan Spieker 02fa8003c0 simplified assertions and removed unthrown exceptions 2019-10-13 20:42:29 +02:00
Gustavo de Souza Bezerra 0e62b68012 [JENKINS-57678] - Change getInstance() (deprecated) to get() (#4042)
* Change getInstance() (deprecated) to get()

* Reverting modifications according review

* Changing for use the variable
2019-06-27 17:24:45 +02:00
Josh Soref 1d0d8069d0 Use a proper example domain (#4074)
See RFC6761
2019-06-20 14:10:45 +02:00
Oleg Nenashev d714a622ea [JENKINS-53693] - Ignore java.xml components in core tests.
It is require to make the tests passing on Java 11, but apparently it also speeds up tests on Java 8.
2018-09-27 11:17:21 +02:00
Jesse Glick d13b1361e1 Adding some interface default method implementations (#2879)
* Adding some interface default method implementations rather than catching AbstractMethodError or providing partial implementation classes.

* Show Javadoc warnings and errors, but not ‘Generating …/core/target/site/apidocs/jenkins/model/lazy/class-use/AbstractLazyLoadRunMap.html...’ and the like.

* Javadoc fixes.

* Review comments from @oleg-nenashev.

* Test fixes.

* Remove the unused import
2017-05-20 12:32:52 +02:00
Josh Soref 496703d0fe Spelling fixes in changelogs, Javadoc, logs and UI (#2718)
* spelling: abstract

* spelling: about

* spelling: absolute

* spelling: across

* spelling: activity

* spelling: actually

* spelling: addition

* spelling: allocating

* spelling: ambiguous

* spelling: analyzes

* spelling: analysis

* spelling: another

* spelling: appear

* spelling: arbitrary

* spelling: artifact

* spelling: assignment

* spelling: associated

* spelling: augment

* spelling: authentication

* spelling: automatically

* spelling: available

* spelling: availability

* spelling: because

* spelling: background

* spelling: beginning

* spelling: boolean

* spelling: browsers

* spelling: building

* spelling: calculation

* spelling: channel

* spelling: column

* spelling: concatenation

* spelling: connect

* spelling: contribute

* spelling: convert

* spelling: copied

* spelling: couldn't

* spelling: scrambled

* spelling: creates-a

* spelling: curr-entry

* spelling: customize

* spelling: diagnostic

* spelling: contain

* spelling: default

* spelling: delimiter

* spelling: descriptor

* spelling: disambiguates

* spelling: different

* spelling: diligently

* spelling: disabled

* spelling: discovered

* spelling: display

* spelling: doesn't

* spelling: dollar

* spelling: downstream

* spelling: dynamically

* spelling: preemptively

* spelling: encrypt

* spelling: erroneous

* spelling: examine

* spelling: existence

* spelling: value

* spelling: february

* spelling: handling

* spelling: hostname

* spelling: convenient

* spelling: identify

* spelling: implementation

* spelling: incorrect

* spelling: individual

* spelling: initialization

* spelling: initialized

* spelling: inputstream

* spelling: instantiated

* spelling: instantiation

* spelling: intended

* spelling: interpreted

* spelling: interrupted

* spelling: invocations

* spelling: kern

* spelling: localization

* spelling: logger

* spelling: malfunctioning

* spelling: methods

* spelling: monitor

* spelling: mutator

* spelling: multiple

* spelling: object

* spelling: configured

* spelling: optionally

* spelling: option

* spelling: overridden

* spelling: parameterized

* spelling: parent

* spelling: permissions

* spelling: plugin

* spelling: potentially

* spelling: preferable

* spelling: problems like

* spelling: programmatically

* spelling: property

* spelling: reallocate

* spelling: recommended

* spelling: redirected

* spelling: registered

* spelling: reliable

* spelling: remember

* spelling: recurrence

* spelling: repeatable

* spelling: repeated

* spelling: resource

* spelling: retrieve

* spelling: returned

* spelling: revision

* spelling: sandwich

* spelling: separator

* spelling: serialization

* spelling: settings

* spelling: shadow

* spelling: should

* spelling: someone

* spelling: source

* spelling: specified

* spelling: style

* spelling: subversion

* spelling: sufficient

* spelling: supplementary

* spelling: suppressing

* spelling: synchronization

* spelling: synchronized

* spelling: this

* spelling: transitioning

* spelling: termination

* spelling: trying

* spelling: truncatable

* spelling: unknown

* spelling: undeployed

* spelling: unnecessary

* spelling: unparseable

* spelling: update

* spelling: upper

* spelling: verify

* spelling: visible

* spelling: warning

* spelling: we're

* spelling: whitespace

* spelling: wide

* spelling: with

* spelling: workspace

* spelling: yielding

* spelling: to

* spelling: by

* spelling: the

* spelling: hours
2017-02-12 13:38:30 +03:00
Jesse Glick 7f4ce02e42 Handle circular references. 2016-12-12 16:14:48 -05:00
Jesse Glick 187731fd88 Check for printStackTrace overrides. 2016-12-12 16:06:57 -05:00
Jesse Glick da54171682 Handle suppressed exceptions. 2016-12-12 16:00:30 -05:00
Jesse Glick 106bd3e018 More test coverage. 2016-12-12 15:35:06 -05:00
Jesse Glick b55ef51ab6 More robust & flexible test framework for printThrowable. 2016-12-12 15:05:03 -05:00
Jesse Glick 6bca813768 Starting to write tests for printThrowable. 2015-05-29 08:42:30 -04:00
René Scheibe bd1d6251e0 replace all deprecated @Bug annotations with @Issue 2015-01-07 17:12:21 +01:00
Daniel Beck daacb02057 [JENKINS-16184] Also escape greater-than character 2014-10-09 00:38:22 +02:00
Jesse Glick 3f2958795c ${h.breakableString(…)} might be called with a null argument if something is broken.
For robustness, pass on the null to Jelly rather than failing page rendering.
2014-04-30 18:19:17 -04:00
Daniel Beck 35b0094137 [FIXED JENKINS-22670] Less aggressive word breaking 2014-04-17 21:49:15 +02:00
Jesse Glick bcc8614856 [FIXED JENKINS-18364] Functions.getRelativeLinkTo is called many times during rendering, so skip checking View.getItems which is expensive. 2014-04-01 10:53:25 -04:00
Oliver Gondža 3f1f122ff4 [FIXED JENKINS-20928] l:breakable mishandles HTML metacharacters 2013-12-12 15:16:13 +01:00
Jesse Glick a900b488b5 [FIXED JENKINS-20800] HTML metacharacters not escaped in log messages. 2013-11-27 18:32:22 -08:00
Jesse Glick b8ace7789a Ensuring that getRelativeNameFrom actually inserts ../ sequences where it should.
The implementation of the method is rather hard to follow so this certainly needs to be tested!
2013-10-21 15:34:58 -04:00
Jesse Glick b1c82f1e30 stephenc asks to use TODO rather than XXX 2013-06-10 11:53:13 -04:00
Jesse Glick a5ac54eac8 [JENKINS-17713] Preparing unit and functional test coverage. 2013-05-29 12:50:45 -04:00
Jesse Glick b5d96e27dd [JENKINS-17030] Noting, fixing/adding @since, adding @Bug. 2013-05-21 14:07:10 -04:00
Oliver Gondža 2c240bdc87 [FIXED JENKINS-17030] Enable word breaking for job names 2013-05-01 18:32:13 +02:00
ssogabe 55a68acca9 [FIXED JENKINS-17715] Display Name is not shown 2013-04-30 20:49:58 +09:00
Vincent Latombe f6cc507217 Functions#getRelativeLinkTo now normalize the output url.
Added some unit tests
2013-04-10 11:27:10 +02:00
Fred G 4bf431cfaf Fixed wrong camel casing and simplified dealing with locale 2013-02-07 23:20:23 +01:00
Fred G 6437fe2e78 Unit test for JENKINS-16630 2013-02-07 02:32:49 +01:00
Jesse Glick f9da4a867e Found a log file full of IAEs from ModelObjectWithContextMenu.MenuItem due to an (unknown) action with an illegal absolute URI. 2013-02-04 18:11:12 -05:00
OHTAKE Tomohiro dfffcf0fb9 Test for absolute paths and relative paths 2011-10-24 23:30:50 +09:00
OHTAKE Tomohiro e24cd27f16 Test for absolute URIs with authorities 2011-10-24 23:27:47 +09:00
OHTAKE Tomohiro eca11dfcfc Use mockito 2011-10-24 23:26:37 +09:00
OHTAKE Tomohiro 47f70c0f59 [FIXED JENKINS-7725] mailto: links should be absolute URIs 2011-10-21 08:47:20 +09:00