Commit Graph
12604 Commits
Author SHA1 Message Date
Matt Moore b00aeddf4b Null check the 'properties' element of the json message before attempting to 'rebuild' the 'DescribableList' 2014-06-14 16:36:59 -07:00
Jesse Glick 6dd071eaa8 [FIXED JENKINS-23417] Noting merge of #1277. 2014-06-12 17:40:49 -04:00
Surya Gaddipati 65b7d8a71c Remove NoExternalUse Restrictions on SecurityListener methods.
Plugins like github-oauth-plugin implementing SecurityRealm need to call
these methods in security lifecycle events.
2014-06-12 15:56:50 -05:00
Jesse Glick 74680ca221 Merge branch 'JENKINS-21631' of github.com:synopsys-arc-oss/jenkins 2014-06-12 10:42:03 -04:00
Oleg Nenashev 5df3f74b4e [JENKINS-21631] - Don't fail with NPE if the PeepholePermalink cache contains the non-numeric value.
Actually, the change just prevents symptoms. There should be an error somewhere else.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-06-12 11:13:08 +04:00
Kohsuke Kawaguchi fad3f7db48 [FIXED JENKINS-23410]
Integrated the fix made in winp 1.20.
2014-06-11 22:30:35 -07:00
Jesse Glick 78dcd063da MockFolderTest.moving pointed out a refinement to 1197e0c: list folders, if included, before their contents. 2014-06-11 16:47:01 -04:00
Jesse Glick 5396f51546 1197e0c required mocking Item.getName(). 2014-06-11 16:46:19 -04:00
Jesse Glick 1197e0ceaf What I hope is a more efficient Items.getAllItems, using a simpler sorting method.
Cf.: https://github.com/jenkinsci/metrics-plugin/commit/b7a2f58c977c8d1053d702e36dcc36bb1348e1aa
2014-06-11 12:59:36 -04:00
Jesse Glick 76c7cdea5a Improved robustness of RunParameterValue so it does not break the REST API when there is invalid data.
Observed in 1.554.1:
java.lang.ArrayIndexOutOfBoundsException: 1
        at hudson.model.RunParameterValue.getNumber(RunParameterValue.java:63)
2014-06-11 12:59:35 -04:00
Harald Albers 622226ae59 Merge pull request #1271 from bkmeneguello/portuguese-translation
Fix translation error
2014-06-11 10:17:57 +02:00
Jesse Glick a61cfe2c91 [JENKINS-23365] Follow-up API fixes: introduce SCM.getKey(), and add an SCMRevisionState baseline argument to checkout.
Necessary in order to produce correct changelogs by SCM plugins which actually use SCMRevisionState correctly (unlike git-plugin!).
(cherry picked from commit df9dc4c850)
2014-06-10 19:33:17 -04:00
Bruno Kühnen Meneguello f193c7b6ab Fix translation error 2014-06-10 18:25:41 -03:00
Jesse Glick 9f16b223b3 [JENKINS-23365] Noting some nullness conditions; calcRevisionsFromBuild in particular is tricky. 2014-06-10 13:49:08 -04:00
Jesse Glick adfa9a30c5 [FIXED JENKINS-20327] When saving a list view, submit POST data with size proportional to the # of jobs selected for inclusion, not the number of options.
This can be done easily by setting json="true"; otherwise the default is to pass =false for each unselected job.
Ironically, even with this fix we are sending 2× what is needed,
since currently ListView.submit does not even check the json parameter for job names:
it only pays attention to top-level request parameters that the browser defines for selected checkboxes.
Ideally we could ask buildFormTree to ignore a given form element entirely, so as to avoid the wasted data.
2014-06-10 11:15:08 -04:00
Jesse Glick 2b93c0cb6a Reusable API documentation: <st:include page="/hudson/model/ModifiableItemGroup/_api.jelly"/> 2014-06-10 10:54:25 -04:00
Jesse Glick 3170a1bc15 [JENKINS-19310] Unreproducible failure of DirectlyModifiableViewTest.failWebMethodForIllegalRequest, probably from a StackOverflowError.
at …
	at hudson.model.View.toString(View.java:514)
	at java.text.MessageFormat.subformat(MessageFormat.java:1246)
	at java.text.MessageFormat.format(MessageFormat.java:836)
	at java.text.Format.format(Format.java:140)
	at java.text.MessageFormat.format(MessageFormat.java:812)
	at java.util.logging.Formatter.formatMessage(Formatter.java:130)
	at java.util.logging.SimpleFormatter.format(SimpleFormatter.java:63)
	at java.util.logging.StreamHandler.publish(StreamHandler.java:179)
	at java.util.logging.ConsoleHandler.publish(ConsoleHandler.java:88)
	at java.util.logging.Logger.log(Logger.java:481)
	at java.util.logging.Logger.doLog(Logger.java:503)
	at java.util.logging.Logger.log(Logger.java:567)
	at hudson.model.AbstractItem.getUrl(AbstractItem.java:423)
	at hudson.model.View.getViewUrl(View.java:510)
	at hudson.model.View.toString(View.java:514)
	at …
2014-06-09 21:29:56 -04:00
CloudBees DEV@Cloud 15db1b9d23 Merge REMERGE_HEAD into HEAD 2014-06-09 22:12:44 +00:00
Kohsuke Kawaguchi cc776cb720 the trunk is toward 1.569-SNAPSHOT 2014-06-09 14:40:02 -07:00
Jesse Glick ea95434938 [FIXED JENKINS-19310] Provide correct links for build history inside a folder.
The basic fix is to use ${rootURL} plus full model object URLs rather than relying on ${jobBaseUrl}.
This is made trickier by the fact that the model object URLs are computed inside ProgressiveRendering.compute,
and therefore will not be correct when nondefault views are in the crumb trail unless the original request information is present.
So modifying ProgressiveRendering to preserve a copy of the original request for use during computation.
(This could probably be used to simplify parts of AsynchPeople as well.)
Also improving AbstractItem.getUrl to properly construct a URL including views even when the current page is not inside the item;
it should suffice for some ancestor of the current item (or a view thereof) to be in the ancestor list of this page.
2014-06-09 17:28:10 -04:00
Jesse Glick 00ab6012b8 [JENKINS-19310] Reproduced problem in test. 2014-06-09 13:58:48 -04:00
Jesse Glick 34f885b73f [FIXED JENKINS-23375] Incorrect redirect after deleting a folder. 2014-06-09 12:47:18 -04:00
Jesse Glick 7423d30e9e [FIXED JENKINS-23365] Noting merge of #1257. 2014-06-08 23:48:47 -04:00
Jesse Glick 38e81a69cf Merge branch 'SCM-Job' 2014-06-08 23:33:46 -04:00
Jesse Glick 75c889f265 Unused import. 2014-06-08 22:05:53 -04:00
Jesse Glick 710f168d4f @WithBridgeMethods and @AdaptField did not work to maintain binary compatibility.
Existing code referring to a member of type AbstractBuild often called methods not present in Run.
Changed to retain the existing fields and getters but deprecating them and introducing replacements.
2014-06-08 21:58:13 -04:00
Jesse Glick 3ddef512b2 Fix of JENKINS-8408 broke some tests of workspace-based polling; disable the fix when inside a test, for better predictability.
(Ideally Jenkins would actually detect whether there was a *plan* to connect a slave of a given name.)
2014-06-08 20:53:48 -04:00
Jesse Glick 5e89373187 NPE in some unit tests. 2014-06-08 20:28:43 -04:00
Jesse Glick 51f98d83f7 Some forgotten binary compatibility fixes. 2014-06-08 20:18:16 -04:00
Kohsuke Kawaguchi c95777e476 [FIXED JENKINS-23228]
Documented this feature and integrated a newer version of Stapler.

I took the opportunity to reorder the content in the section, so that
the tree parameter becomes the main subject.

At this point, the depth parameter should be only used in a limited
circumstance, so it should be treated as such.
2014-06-08 10:16:15 -07:00
Kohsuke Kawaguchi 2b079a596d Adding another way to extract the value, this time into a "natural" Java object.
I came into this use case while working on the workflow, but I think it's useful in other context as well,
such as Scriptler plugin needing to define some parameters.
2014-06-06 14:57:15 -07:00
Kohsuke Kawaguchi 6575f57adf Jenkins! 2014-06-06 14:57:15 -07:00
Kohsuke Kawaguchi e8ecf3ad70 doc improvement 2014-06-06 14:57:15 -07:00
Jesse Glick 82d2eb5ff0 @CheckForNull 2014-06-06 16:05:37 -04:00
Harald Albers f6a6ee9b9c removed debug output from from 2014-06-06 13:20:48 +02:00
Jesse Glick 65e8721121 Added SCM.guessBrowser. 2014-06-05 23:12:53 -04:00
Jesse Glick f67c9f1c13 Updating comment. 2014-06-05 22:35:54 -04:00
Jesse Glick 2a08aa1a4c Ability for project-changes.jelly to handle multiple ChangeLogSet’s per build. 2014-06-05 22:22:49 -04:00
Jesse Glick e526809bda Make sure the RepositoryBrowser is associated with a ChangeLogSet so we do not need to go back through the build and SCM to find it. 2014-06-05 21:33:02 -04:00
Jesse Glick 5a43591838 Skip NullSCM since we are returning a collection anyway. 2014-06-05 16:08:01 -04:00
Jesse Glick d843675d0b Better display name when there is no defined SCM. 2014-06-05 16:06:26 -04:00
Jesse Glick 4e24f702af Merge branch 'master' into SCM-Job 2014-06-05 14:57:06 -04:00
Jesse Glick fa832c58b0 Merge pull request #1266 from synopsys-arc-oss/refactoring_security_classes
Added annotations to kernel security classes.
2014-06-04 12:32:58 -04:00
Oleg Nenashev 870ef367b7 Added annotations to kernel security classes.
Most of methods define @Nonnull inputs and outputs (the legacy behavior is mostly non-documented), but there're several exceptions

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-06-04 18:31:39 +04:00
Jesse Glick e6b063ddd4 Merge pull request #1259 from daniel-beck/JENKINS-16827
[FIX JENKINS-16827] Don't try to guess the build number
2014-06-03 22:10:18 -04:00
Jesse Glick a9c943798e Merge pull request #1213 from synopsys-arc-oss/node_classes_improvements
[READY] Additional null checks for node access methods.
2014-06-03 16:50:48 -04:00
Oleg Nenashev e5cacd1780 Fixed node handling methods in order to comply with https://github.com/jenkinsci/jenkins/commit/3f8fc4e2ec5b1b421e1551a2a2fc2a284be330d1
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-06-03 23:37:05 +04:00
Jesse Glick 5d32d495d5 getTransientActions should defend against null members even when assertions are disabled.
Cf.: https://github.com/jenkinsci/remote-terminal-access-plugin/commit/db24e2126b649689652ac8ddb100f3ef6680a422
2014-06-03 15:23:13 -04:00
Jesse Glick ebccc6a34a Merge pull request #1223 from synopsys-arc-oss/hudson_util_annotations
Annotate hudson.Util methods by @CheckForNull and @Nonnull
2014-06-03 14:51:35 -04:00
Jesse Glick af4b7e8e68 Merge pull request #1246 from daniel-beck/Peephole-RunListener-Logging
Add logging to PeepholePermalink's RunListener
2014-06-03 14:39:27 -04:00