OpenSource/jenkins
1
0 Fork 0
mirror of https://github.com/jenkinsci/jenkins.git synced 2026-11-03 23:25:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
15,942 Commits 77 Branches 1,940 Tags
b1c82f1e30fa5f6483415f2c7ad1b95aed1eb072
Commit Graph
164 Commits
Author SHA1 Message Date
Jesse Glick b1c82f1e30 stephenc asks to use TODO rather than XXX 2013-06-10 11:53:13 -04:00
Jesse Glick 2a1d1631bd [FIXED JENKINS-14351] jna-posix → jnr-posix upgrade (opt in). 2013-05-31 14:36:15 -04:00
Jesse Glick 51fbd2d867 [JENKINS-16301] Replace impl of getDigestOf with standard (Commons Codec) DigestUtils.md5Hex, for simplicity. 2013-05-21 17:41:39 -04:00
Jesse Glick 3c2b50ecfe [FIXED JENKINS-17681] Do not try to call resolveSymlink on a nonexistent link as you will just get an IOException, breaking peephole permalinks in some Windows environments. 2013-05-01 20:13:18 -04:00
Kohsuke Kawaguchi 368d8c7394 Don't let the error icon get clipped when the text is short. 
On Chrome (and possibly others), an inline element like span doesn't enlarge
its size to cover its content, so the 1px place holder wasn't taking effect.

To ensure the minimum height of 16px, make it an inline-block element. I'm
not entirely sure how an inline-block element with no fixed width would behave,
but with a bit of casual testing, the text inside seems to wrap OK.
 2013-04-19 10:11:28 -07:00
Kohsuke Kawaguchi b27bc585a8 merged back the RC branch 2013-04-06 18:58:00 -07:00
Kohsuke Kawaguchi dc94b7d063 [FIXED JENKINS-8686] 
As I mentioned in the comment, I doubt if this makes any behaviour change, but this seems like a sensible defensive measure that wouldn't hurt.
 2013-04-02 09:58:50 -07:00
Kohsuke Kawaguchi a016f3da07 [FIXED JENKINS-17343] 
Don't break Windows XP, fall back gracefully to no-op.
 2013-04-02 09:27:09 -07:00
Jesse Glick 21912fe3dd @code in Javadoc. 2013-03-28 14:53:54 -04:00
Jesse Glick 78b263421f [FIXED JENKINS-17271] Util.deleteFile should give a concrete reason for failure. 2013-03-19 11:05:21 -04:00
Jesse Glick 606a9e1de9 File.setWritable should be the first, and if possible only, thing we try for makeWritable. 2013-03-19 10:13:19 -04:00
Jesse Glick a32f2dd39d Removing obsolete comment. 2013-03-14 10:27:56 -04:00
Kohsuke Kawaguchi 28bf5d8002 [FIXED JENKINS-15587] 
The actual fix was in the pull request #675.
 2013-03-12 22:13:26 -07:00
Kohsuke Kawaguchi 2f781863f5 Massaging the fix. 
- ID_FORMATTER is time zone sensitive, so comparing against # of
  milliseconds since the epoch won't be portable.

- resolveSymlink can return a relative path.
 2013-03-12 22:11:26 -07:00
Kohsuke Kawaguchi 88feabb429 [FIXED JENKINS-16089] 
Remember the permalink target as symlink (or simple text file) so that
looking that up doesn't cause the walk of the build history.
I think this is more in line with our general preference of making
$JENKINS_HOME useful (than trying to persist cache into a blackbox.)

Having a general purpose in-memory cache could be useful, so I'll see if
I can add that, too, in a way that allows someone to plug different
backend.
 2013-03-12 14:21:38 -07:00
Kohsuke Kawaguchi d97b0834c8 Windows symbolic support for Java5/6 2013-03-12 14:19:49 -07:00
Jesse Glick 915d825327 Further clarification of targetPath. It is not necessarily relative to baseDir! 2013-03-08 19:59:46 -05:00
Jesse Glick 400fa878e6 Verifying that symlink target may be absolute. 2013-03-08 18:55:49 -05:00
Jesse Glick ad4c39f5e2 Clarifying that symlinkPath may not be absolute. 2013-03-08 18:38:56 -05:00
Kohsuke Kawaguchi 00bfa35651 Added a convenience method. 
This change is originally from pull request #682.
 2013-02-28 17:33:36 -08:00
Jesse Glick 010866ba90 [FIXED JENKINS-15466] More robust handling of Windows JNA errors. 
b5ed319 already caught linkage errors but then unconditionally returned false from Util.isSymlink, which is wrong;
we want to fall back to the generic File.canonicalPath comparisons in this case.
 2013-02-27 11:11:34 -05:00
Vojtech Juranek 9993468ce4 Merge branch 'revert-ampersand-encoding' of https://github.com/lvotypko/jenkins into pull683 
Conflicts:
	core/src/test/java/hudson/UtilTest.java
 2013-02-27 15:33:31 +01:00
lvotypko df00baea5a Revert changes in method encode too. 2013-02-11 11:35:15 +01:00
lvotypko f2de2aca92 Revert javadoc too. 2013-01-30 13:16:41 +01:00
lvotypko 3d568123f3 Revert changes which broke backwad compatibility based on discussion in jenkins-dev list 2013-01-29 15:51:16 +01:00
Kohsuke Kawaguchi d32f9e5113 merged back the RC branch 2012-11-18 17:59:10 -08:00
Kohsuke Kawaguchi 68e84726ab [FIXED SECURITY-45] 2012-11-17 12:02:49 -08:00
Jesse Glick 0552f5ad75 [JENKINS-13202] 646154f refinement: resolveSymlink is documented to return null, not throw an exception, when called on a regular file. 2012-11-16 13:41:22 -05:00
Jesse Glick ced5c44323 [FIXED JENKINS-15316] Harmless but noisy exception running builds on some Windows systems in non-English locale. 
Falling back to just checking for ‘FileSystemException’ since detail message about missing required privilege may be translated.
 2012-10-15 14:52:04 -04:00
Jesse Glick 66cf64d88d More graceful handling of Windows accounts with symlinks disabled. 2012-09-10 17:20:17 -04:00
Jesse Glick b6f924d111 Splitting some Java 7 code into its own methods for clarity. 
(Not doing so for resolveSymlink since it would require an awkward four-way return value:
String, null (not a symlink), IOException, <something else> for Java 5/6.)
 2012-09-10 12:07:43 -04:00
Jesse Glick 1fb7541975 @IgnoreJRERequirement not necessary when using reflection to access APIs. 2012-09-06 18:28:32 -04:00
Jesse Glick ed748d4b81 Try to use NIO.2 (Java 7) methods to work with symlinks, falling back to JNA (or worse) only on Java 5–6. 2012-09-06 14:31:27 -04:00
Andrew Stucki a9a019918b Fix Windows symlink detection 2012-07-24 13:09:01 -05:00
Olivier Lamy 5379a8100c Merge pull request #496 from lvotypko/url-without-ampersand 
Fix UtilTest and replace ampersand in method encode too
Thanks !
 2012-06-14 05:56:56 -07:00
lvotypko c667523d44 Fix UtilTest and replace ampersand in method encode too 2012-06-13 13:17:19 +02:00
OHTAKE Tomohiro 1a42a2f071 Update doc for #494 2012-06-13 17:44:52 +09:00
OHTAKE Tomohiro ea9ff25f98 Make it easier to see which characters will be encoded 2012-06-13 17:43:06 +09:00
lvotypko fed2d0ff47 Do not use & in url 2012-06-13 09:20:46 +02:00
Kohsuke Kawaguchi d184d53b24 [JENKINS-9118] 
Tar/untar now correctly supports symlinks.
 2012-03-09 18:26:22 -08:00
Kohsuke Kawaguchi 48daab0f0b already using readlink 2012-03-09 18:04:30 -08:00
James Page 09d06a91df Use up-to-date animal-sniffer-annnotations 2012-01-06 13:59:12 +00:00
Kohsuke Kawaguchi 77a9746071 various trivial nit-picking 2012-01-03 16:11:21 -08:00
Kohsuke Kawaguchi 21244cac7e [FIXED JENKINS-12119] rolling back a portion of 46998ba0446834de0c725c32b328ace7ce844f6a as this is binary incompatible change 2012-01-03 12:15:38 -08:00
Vitalii Tymchyshyn 867b67ad70 [JENKINS-12119] Fix for symlinks not created when native libs don't work 2012-01-03 12:15:33 -08:00
Jerome Lacoste 386ec0d15e Ensure that the Readers are closed properly 2011-07-23 07:11:06 -07:00
Christoph Kutzinski ff3d287035 don't create a new buffer for each loop iteration 2011-07-16 13:55:23 +01:00
Christoph Kutzinski 3c09a0c43a [FIXED JENKINS-10346] thread-safety problem when computing fingerprints 2011-07-16 13:55:23 +01:00
Kohsuke Kawaguchi 2c4516dcf2 [FIXED JENKINS-10113] try to work extra hard before giving up the file deletion. 2011-06-28 22:18:36 -07:00
Nigel Magnay 5679d019ec Move hudson.model.Jenkins to be jenkins.model.Jenkins - part II 
Just import changes, from hudson.model.Jenkins -> jenkins.model.Jenkins,
and Javadoc comments.

Signed-off-by: Nigel Magnay <nigel.magnay@gmail.com>
 2011-05-29 11:06:28 +01:00