Note that the above description is incorrect as to what the merge was about.
It is the message that I intended to make. It appears that I accidentaly merged multiple fixes waiting to be reviewed on my private fork.
This reverts commit dce0d2aff0, reversing
changes made to 63f67f30bd.
The problem is that the sending side has no way of knowing when the
receiving side has hung up. So when the receiving side hangs up we should
be able to read till the stream runs out, then close. Not the optimal
solution, but one that should work for now.
http://issues.jenkins-ci.org/browse/JENKINS-8592
First pass at making sure we don't stop copying when the reader reads 0 characters.
I will now also review the callers for our internal code, and check if we can use IOUtils methods instead.
https://www.dev.java.net/svn/hudson/branches/rc
........
r35444 | kohsuke | 2010-10-01 13:44:56 -0700 (Fri, 01 Oct 2010) | 1 line
[FIXED HUDSON-7546] Fixed a possible AbstractMethodError in 1.379
........
r35445 | kohsuke | 2010-10-01 14:04:58 -0700 (Fri, 01 Oct 2010) | 1 line
[FIXED HUDSON-4229] Supported failsafe reports for the Maven2 job type.
........
r35457 | kohsuke | 2010-10-02 10:04:35 -0700 (Sat, 02 Oct 2010) | 1 line
added additional code to assist trouble-shooting.
........
r35458 | kohsuke | 2010-10-02 10:09:44 -0700 (Sat, 02 Oct 2010) | 1 line
performance optimization wrt the usage of buffer
........
r35460 | kohsuke | 2010-10-02 10:19:25 -0700 (Sat, 02 Oct 2010) | 1 line
[FIXED HUDSON-5977 HUDSON-7572] the incorrect use of WeakHashMap resulted in two instances of PipeWindows for the same OID.
........
r35461 | kohsuke | 2010-10-02 10:30:21 -0700 (Sat, 02 Oct 2010) | 1 line
debug code accidentally crept in.
........
r35463 | kohsuke | 2010-10-02 11:21:55 -0700 (Sat, 02 Oct 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_379
........
r35465 | kohsuke | 2010-10-02 11:22:14 -0700 (Sat, 02 Oct 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
r35469 | kohsuke | 2010-10-02 12:26:53 -0700 (Sat, 02 Oct 2010) | 1 line
updated changelog as a part of the release
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@35530 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r21385 | kohsuke | 2009-09-02 15:41:39 -0700 (Wed, 02 Sep 2009) | 1 line
Fixed a random test failure, which was caused by PingThread detecting communication problem while it's being orderly shut down.
........
r21386 | kohsuke | 2009-09-02 15:41:57 -0700 (Wed, 02 Sep 2009) | 1 line
indentation fix.
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21387 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r21368 | kohsuke | 2009-09-02 13:14:25 -0700 (Wed, 02 Sep 2009) | 33 lines
wait until the channel terminates normally to avoid random test failures like this:
junit.framework.AssertionFailedError: exit code should have been 0 expected:<0> but was:<255>
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:285)
at junit.framework.Assert.assertEquals(Assert.java:64)
at junit.framework.Assert.assertEquals(Assert.java:201)
at hudson.remoting.ChannelRunner$Fork.stop(ChannelRunner.java:141)
at hudson.remoting.RmiTestBase.tearDown(RmiTestBase.java:53)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21371 71c3de6d-444a-0410-be80-ed276b4c234a
I moved the capability exchange to the preamble negotiation to avoid this problem.
----
java.lang.NullPointerException
at hudson.remoting.UserRequest._serialize(UserRequest.java:136)
at hudson.remoting.UserRequest.perform(UserRequest.java:118)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:236)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21132 71c3de6d-444a-0410-be80-ed276b4c234a
Kohsuke Kawaguchi