Based on comments from Jesse, revising the fix.
I'm now putting permlinks inside the builds/ directory to avoid the computing hassle involved in the split $JENKINS_HOME.
What we historically had in $JENKINS_HOME/jobs/JOB/lastSuccessfulBuild is also now subsumed by this feature. I initially attempted to create these permalinks in the buidl root directory, but turns out those symlinks aren't the same name as the ID of permalinks, so it doesn't mesh well.
And finally, a test!
Mar 4, 2013 10:55:46 PM hudson.UDPBroadcastThread run
WARNING: UDP handling problem
java.io.IOException: Operation not permitted
at java.net.PlainDatagramSocketImpl.send(Native Method)
at java.net.DatagramSocket.send(DatagramSocket.java:625)
at hudson.UDPBroadcastThread.run(UDPBroadcastThread.java:98)
→
java.net.SocketTimeoutException: Receive timed out
at java.net.PlainDatagramSocketImpl.receive0(Native Method)
at java.net.PlainDatagramSocketImpl.receive(PlainDatagramSocketImpl.java:145)
at java.net.DatagramSocket.receive(DatagramSocket.java:725)
at hudson.UDPBroadcastThreadTest.receiveAndVerify(UDPBroadcastThreadTest.java:70)
at hudson.UDPBroadcastThreadTest.testMulticast(UDPBroadcastThreadTest.java:51)
* core/src/main/resources/lib/form/combobox/combobox.js
Increase index to 100, so that parent form elements can be initialized before
parameters in fillDependsOn are extracted.
* test/src/test/java/lib/form/ComboBoxTest.java
* test/src/test/resources/lib/form/ComboBoxTest/CompoundField/config.jelly
* test/src/test/resources/lib/form/ComboBoxTest/CompoundFieldComboBoxBuilder/config.jelly
New test to confirm null is not passed for relative dependent arguments
- Environment variables are by convention upper case, so I'm switching to upper case. This was what the original ticket requested anyway.
- Since the ".jobName" was never documented to begin with, let's not promote that and stick to "_JOBNAME" as the official version.
- My second patch, with whitelisted XPath values and forbidden JSONP.
- Disabling JSONP altogether for REST API (unless explicitly allowed).
- Forbid primitive XPath result sets by default.
- Refuse to serve _crumb=123456 as this could (very hypothetically) be exploited.
(cherry picked from commit f4af9b1ab4)
Conflicts:
core/src/main/java/hudson/model/Api.java
Removing old static field, which was not friendly to tests, especially multithreaded runners.
Cleaned up existing tests to use updateDirectly rather than POSTing raw JSON.