* [JENKINS-34833] - Installation Wizard: Allow altering the list of succested plugins from update sites
In our company we provide a custom package of Jenkins, which provides a customized set of plugins (open-source and closed-source ones). These plugins come from the custom update site.
We would like to provide custom suggestions to users of our Jenkins packages when they install Jenkins. For such purpose we would like to make the plugin suggestions list overridable by UpdateSite extensions in Jenkins.
* [JENKINS-34833] - Fix the JS Unit test (code from @kzantow)
* [JENKINS-34833] - Unit tests for SetupWizard
* [JENKINS-34833] - Address comment regarding the error propagation for the unknown version
* [JENKINS-34833] - SetupWizard::getPlatformPluginList() is not a part of the public API
* [JENKINS-34833] - Address comments from @orrc
* fix read of 'SystemProperties' values before init of the context
* fix constructor and test
* revert help-spec_fr.html
* revert help-spec_fr.html
* revert help-spec_fr.html
* [JENKINS-34628] Remove dependencies with external static resources
* [JENKINS-34628] License files were added
* [JENKINS-34628] Added references in the About page
* [JENKINS-34733] - Allow overriding Jenkins UpdateCenter by a custom implementation
* [JENKINS-34733] - Reduce the logging level for the custom update center selection
* [JENKINS-34733 and JENKINS-34674] - Use SystemProperties in the UpdateCenter
* [JENKINS-28071] generalise BuildCommand target from AbstractProject to Job
This allows e.g. WorkflowJob to build, fixing symptom [JENKINS-29826]
* fixup! [JENKINS-28071] generalise BuildCommand target from AbstractProject to Job
* fixup! [JENKINS-28071] generalise BuildCommand target from AbstractProject to Job
* [JENKINS-34745] - Prevent CheckUpdates PeriodicWork death in the case of the missing update site signature
* [JENKINS-34745] - Fix typo in the validator
* [JENKINS-34745] - Fix the formatting of the validation message (cc @lanwen)
As detailed by @stephenc:
> So there is `getInstanceOrNull()` which is for use in Jenkins core or
> in code that plugins add that may escape the Jenkins singleton
> lifecycle.
>
> In regular plugins `getInstance()` will never return null as the
> lifecycle does not instantiate them until after there is a Jenkins
> singleton and the plugins will be stopped before there is no
> singleton.
>
> The `getActiveInstance()` is therefore equivalent to `getInstance()`
> and should never have been born.
>
> The only way a plugin can get a `null` from `Jenkins.getInstance()` is
> if you install an `atExit()` handler, use a `PhantomReference` type
> thing, or directly manipulate the servlet container in some way or
> other. A correctly written plugin should unwind any of those things
> when it is stopped or a method bound to the termination lifecycle. If
> there are some cases (for which I cannot anticipate a good coder being
> able to write a correct termination lifecycle method to fix) where the
> code cannot be unhooked... then in those cases the plugin should use
> `getInstanceOrNull()` and know how to respond to the `null` that could
> not be avoided.