Commit Graph
13194 Commits
Author SHA1 Message Date
Stefan Spieker c7564f8596 removed unused imports 2020-04-19 20:53:35 +02:00
Tim Jacomb 29a91111a9 Merge pull request #4533 from timja/system-read-admin-monitors
JENKINS-61208 System read - admin monitor pattern
2020-04-19 10:34:54 +01:00
Tim Jacomb 06fc7b12ec Merge pull request #4519 from timja/system-read-tool-configuration
JEP-224 System read - Global tool configuration
2020-04-19 10:34:22 +01:00
Tim Jacomb e4c034f128 Merge pull request #4588 from daniel-beck/popularity
Sort available plugins by popularity
2020-04-19 10:33:25 +01:00
Daniel Beck 0d948792fd Merge pull request #4654 from daniel-beck/fix-isDevelopment-comment
Fix comment about when this is set
2020-04-19 01:44:12 +02:00
Tim Jacomb 2a5cb24ec0 Merge pull request #4657 from daniel-beck/redirect-groovy-view-to-login
[JENKINS-61905] Forward Groovy view permission errors to login
2020-04-18 21:12:45 +01:00
Daniel Beck 5695e3a182 More Javadoc to help implementers, simplify code a bit 2020-04-17 22:30:16 +02:00
Daniel Beck a6ebf3b4bf Merge branch 'master' into popularity 2020-04-16 16:41:36 +02:00
Daniel Beck 44abe70831 Skip the loop 2020-04-16 13:22:07 +02:00
Rishabh BudhouliyaandMark Waite be1e2bea7e [JENKINS-61711] Fix validateExecutable to allow Git plugin global config correctly report git executable in PATH (#4653)
* Fix git not in path for Git plugin global config
Git Client Plugin global configuration allows addition of git implementations using GitTool
The field Path was not able to identify git executable. The fix involves changing prefix with
File.seperator instead of File.pathSeperator. This allows Jenkins to find the git exec at the
already existing path.

* Tests added to validate JENKINS-61711 fix

* Improve hamcrest comparison in FormValidationTest

Co-Authored-By: Mark Waite <mark.earl.waite@gmail.com>

* Import matchers for `not`

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2020-04-16 09:35:41 +02:00
Daniel Beck 2bf9fc2130 [JENKINS-61905] Forward Groovy view permission errors to login 2020-04-15 01:59:46 +02:00
Daniel Beck ba2d460ad4 Fix comment about when this is set 2020-04-14 22:54:08 +02:00
Raihaan Shouhell d7b0a9d699 Merge pull request #4638 from jglick/Slave.labels
Removing apparently unused Slave.labels
2020-04-14 09:03:02 +08:00
Oleg Nenashev 7e40e1e396 Merge pull request #4609 from StefanSpieker/spotbugs_cookie
Set httpOnly and secure on cookies to fix spotbugs issue
2020-04-12 14:07:19 +02:00
Tim Jacomb 9bb02ecfa3 Merge pull request #4586 from daniel-beck/manage-context-menu-titles
Add section titles to Manage Jenkins context menu
2020-04-12 10:12:44 +01:00
Oleg Nenashev 60cb47fcf8 Merge pull request #4557 from timja/timezone-property
Make TimeZoneProperty compatible with JCasc
2020-04-11 13:21:01 +02:00
Oleg Nenashev c0bacad9b2 Merge pull request #4621 from jglick/SLAVE_LOG_HANDLER-parameters
An agent log record with numeric params could be unformattable on the master
2020-04-11 13:11:10 +02:00
Oleg Nenashev 13966d2c0d Merge pull request #4636 from jvz/commons-codec-cleanup
Commons codec cleanup
2020-04-11 13:09:08 +02:00
Oleg Nenashev e4619ebbbc Merge pull request #4617 from jglick/ExtensionFinder-logging
Reduce log level on notice about optional extensions
2020-04-11 13:08:41 +02:00
Oleg Nenashev 55aa46e66d Merge pull request #4632 from jglick/LogTaskListener-annotations
Fixing console annotation masking in LogTaskListener
2020-04-11 13:08:11 +02:00
Tim JacombandDaniel Beck 9b4a62c716 JENKINS-61203 System read - Plugin Manager (#4518)
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-04-09 22:36:46 +01:00
Jesse Glick f7e2d65062 Removing apparently unused Slave.labels 2020-04-09 11:30:49 -04:00
Matt Sicker baa1dc5b9a Use standard Java Base64 class
Signed-off-by: Matt Sicker <boards@gmail.com>
2020-04-08 15:25:16 -05:00
Oleg Nenashev f3599aa53b Merge pull request #4614 from daniel-beck/FileParameterValue-DBS
Use DirectoryBrowserSupport to serve FileParameterValue
2020-04-08 12:40:33 +02:00
Daniel BeckandDaniel Beck e7efc567d2 Hide message re disabling implied dependencies when no dependents exist (#4597)
* Hide message re disabling implied dependencies when no dependents exist

* Rename CSS class to be clear about when it's added

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-04-07 09:40:15 +02:00
Jesse Glick bf858b7e55 Fixing console annotation masking in LogTaskListener 2020-04-06 17:44:47 -04:00
Tim Jacomb f0e3a7df1d Fix compilation error after merge 2020-04-05 15:13:37 +01:00
Tim Jacomb 7f8cea0f92 Merge branch 'master' into kill-jsr-305 2020-04-04 10:30:21 +01:00
Sumit Sarin 0ca5ff7b40 [JENKINS-61479] Fix java.lang.ClassCastException in Fingerprint… (#4577)
* [JENKINS-61479] Fix a bug in FingerprintCleanupThread and add tests.

* Upgraded Hamcrest to Version 2.2. Incorporated Hamcrest assertion for FingerprintCleanupThread tests.

* Blank line removed

* Changed timestamp_millis->Date; Removed unused imports

* Added hamcrest version as a property

* Changed to assert log output
2020-04-04 10:27:28 +01:00
Daniel Beck 99f8b3f866 [JENKINS-61467] Do not show disabled, implied permissions in er… (#4575)
* [JENKINS-61467] Do not show disabled, implied permissions in erors

* Maintain order of permissions, fix test assertion
2020-04-04 10:26:59 +01:00
Tim Jacomb 171f876b83 Merge pull request #4616 from jglick/CauseOfBlockage-label
Hyperlinks in label-related CauseOfBlockage.print
2020-04-04 10:26:25 +01:00
Tim Jacomb cde033ee77 Merge pull request #4606 from oleg-nenashev/JENKINS-61694
[JENKINS-61694] - Update Groovy Init hooks to run after all job configurations are adapted
2020-04-04 10:25:47 +01:00
Markus Winter 10a224278b [JENKINS-5597] add option to follow symlinks during artifact archiving (#3947)
* [JENKINS-5597] don't follow symlinks

add an option that allows to configure the DirectoryScanner used by
ArtifactArchiver to not follow symbolic links. Option is enabled by
default for backwards compatibility.

* missing readresolve

need to resolve in case it is not defined

* add linebreaks at end of file

* add test for not follow symlinks

* fix indentation

* add tests

update ant to 1.10.7 which supports symlinks on windows and is able to
properly ignore them

* change default in jelly to false

* fix test execution

* indentation and help text
2020-04-03 16:03:29 -06:00
Jesse Glick 3262d8b7cf An agent log record with numeric params could be unformattable on the master 2020-04-03 16:11:59 -04:00
James Nord 538b9cc785 Another JSR-305 annotation crept into master 2020-04-02 20:31:53 +01:00
James Nord 6552e6dc21 Merge remote-tracking branch 'origin/master' into kill-jsr-305 2020-04-02 20:26:14 +01:00
Daniel Beck 7fab08d516 Merge branch 'master' into manage-context-menu-titles 2020-04-02 15:45:52 +02:00
Jesse Glick a3a4a2e92d Reduce log level on notice about optional extensions 2020-04-01 16:15:41 -04:00
8c1e567e7d [JENKINS-61453] Jenkins.MANAGE user to access "Prepare for Shut… (#4572)
* [JENKINS-61453] Using MANAGE instead of ADMINISTER

* Remove TODO comment

Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>

* [JENKINS-61453] build queue cancel button is also MANAGE

Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-04-01 20:15:18 +01:00
Tim Jacomb 1a0f231b06 JENKINS-56937 JCasC support for admin monitors (#4552) 2020-04-01 20:13:46 +01:00
Jesse Glick e5584cfca4 Hyperlinks in label-related CauseOfBlockage.print 2020-03-31 13:53:05 -04:00
Daniel Beck bc8ea6cdb6 Use DirectoryBrowserSupport to serve FileParameterValue
This will allow the use of Resource Root URLs for those files.

Additionally, minor UI improvements:
- Explicitly indicate when no file was uploaded
- Do not show original file name on the UI, nobody cares
2020-03-31 11:30:29 +02:00
James Nord bdcb2fb222 Merge remote-tracking branch 'origin/master' into kill-jsr-305 2020-03-30 12:40:44 +01:00
Tim Jacomb a976bfee1c Merge pull request #4608 from daniel-beck/allow-null-secret
Support null Secrets when converting form submissions
2020-03-29 09:49:57 +01:00
Jesse Glick e76f6a293a Let ConfidentialKey & Secret do something from unit tests (#4603)
* Delete ConfidentialStoreRule

* Also delete MockSecretRule so Secret.fromString works

* Secret.SECRET still referenced by SecretHelper in jenkins-test-harness, used by RekeySecretAdminMonitorTest, also copied in publish-over-*-plugin

* RSAConfidentialKey ought to use the same SecureRandom as the ConfidentialStore; this also lets the mock use a fixed seed

* For now ConfidentialStore.secureRandom can be abstract

* Some core unit tests can be rather verbose; set maven.test.redirectTestOutputToFile

* Looks like we need a ConfidentialStoreRule after all

* Restored another couple of usages
2020-03-28 19:13:00 +00:00
Tim Jacomb f72bccd6d3 Merge pull request #4075 from jsoref/antclassloader-storeandconvert
IntelliJ/Java: Duplicate code -- Refactored as AntClassLoader.storeAndConvert(...Convert<T>)
2020-03-28 19:12:29 +00:00
Stefan Spieker fa92438e88 only set secure if request is secure 2020-03-28 11:22:11 +01:00
Stefan Spieker 8b5244e87b set httpOnly and secure on cookies to fix spotbugs issue 2020-03-28 11:13:32 +01:00
Tim Jacomb 6572cfe4b4 Merge pull request #3941 from jsoref/JENKINS-56643
[JENKINS-56643] Util.createSymlink: prefer Files.move(..., ATOMIC_MOVE)
2020-03-28 09:08:04 +00:00
Tim Jacomb 7b4eab92d1 Merge pull request #4507 from res0nance/static-inner
Static nested classes
2020-03-28 09:04:59 +00:00