* [JENKINS-65829] Fix WorkspaceCleanupThread to consider suffixed workspaces even if original is inexistent
* [JENKINS-65829] Make sur controller system properties is used across all nodes
* [JENKINS-65829] Adapt test for tmp + rename test for libs
* [JENKINS-72947] Support symbols in TopLevelItemDescriptor#getIconClassName()
When adding a new Item via `newJob` the corresponding Decriptor can now
make use of symbols
* update icon
* add test
[JENKINS-58302] call refresh on the Extension providers again
In the case the ExtensionFinder is itself extensible we refresh it again
to catch extensions that would be discovered by a newly installed
extension.
This seems a little overzerlous, as there is only the variant plugin
that I know of, however calling `Jenkins.get().refreshExtensions() from
any point in the `variant` plugin would seem to be a little bit
dangerous as it would call back into a place where the reactor is
already calling back from.
* [JENKINS-18884] Remove 'People' view
* Add placeholder pages when someone tries to access removed URLs
* Remove obsolete UserInfo class, inapplicable tests
* Restore test with a different core-contributed object
It's not entirely clear what this test signifies, given the
existence of `testTopLevelItemIsLegal`, but whatever.
* Remove probably unnecessary code
---------
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
* Remove usages of StringUtils#containsIgnoreCase
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#removeStart StringUtils#removeEnd
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#defaultString
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#defaultIfBlank
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#isAlphanumeric
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils.EMPTY
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#split
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#startsWithIgnoreCase
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#countMatches
Signed-off-by: Bob Du <i@bobdu.cc>
* Remove usages of StringUtils#endsWithAny
Signed-off-by: Bob Du <i@bobdu.cc>
* fix spotbugs warning
Signed-off-by: Bob Du <i@bobdu.cc>
* Use Objects.toString
Signed-off-by: Bob Du <i@bobdu.cc>
* revert unrelated change
Signed-off-by: Bob Du <i@bobdu.cc>
---------
Signed-off-by: Bob Du <i@bobdu.cc>
* [JENKINS-69191] icon for agent not accepting tasks
This change adds another icon for the case when an agent is not
accepting tasks, e.g. because the retention strategy avoids this.
The makes it easier to decide whether an agent is in a non healthy
state.
A legend button is added below the computer overview table that shows an
explanation for the icons.
* fix style
* [JENKINS-72796] stable context classloader for Computer.threadPoolForRemoting
Whilst the threadpool used reset the context classloader at the end of
any task, it did not ensure that the initial c;lassloader used was
anything sepcific, rather it would use whatever the calling threads
contextClassLoader was.
This is now fixed as we use the Jenkins WebApp classloader (same as
the Timer) which is used by (A)PeriodicTasks.
Whilst we should really not have a context classloader (aka null) and
this should be set where needed by code, almost everywhere in Jenkins
the context classloader is already the webapp classloader, and so
setting this to be different depending on how things where called would
seemingly be a little scary. Arguably this and other context
classloaders should be all set to null and any code that wants different
should be changed, but this is a larger piece of work that would have
potential impact on an unknown number of plugins in the ecosystem, so
this fix uses what was set > 90% of the time.
* Update core/src/test/java/hudson/model/ComputerTest.java
---------
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
* allow specification of achrive's file name encoding in Archiver#create()
For JENKINS-72540 only needed for tar, but changed zip for consistency as well.
* revise copyRecursiveTo to use same file name encoding locally and remote
such that local and remote understand each other
Otherwise, if remote is z/OS with native EBCDIC encoding the file names
will be in EBCDIC and fails reading
* [JENKINS-60866] Apply Stapler update for CSP-compliant st:bind
* [JENKINS-60866] Make renderOnDemand CSP-compliant
* Thanks Spotless
* Make Stapler incrementals work
* Update Stapler to new incremental
* Fixup bad merge
* Update Stapler, add test demonstrating st:bind working
* Address review feedback
* Add test for null bind, update Stapler
* Checkstyle
* More tests
* Use released Stapler
---------
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
Co-authored-by: Basil Crow <me@basilcrow.com>
* [JENKINS-71326] - Support colored badges in breadcrumb dropdown
* [JENKINS-71326] - Support colored badges in breadcrumb dropdown - Creating a badge jelly view.
* [JENKINS-71326] - Support colored badges in breadcrumb dropdown - Adding class attribute to the badge jelly.
* Apply suggestions from code review
Co-authored-by: Alexander Brandes <brandes.alexander@web.de>
* [JENKINS-71326] - Support colored badges in breadcrumb dropdown - Lint and license Fix
---------
Co-authored-by: Alexander Brandes <brandes.alexander@web.de>
