Oliver Gondža
9328c42985
Correctly restrict read permission in CLIActionTest.serveCliActionToAnonymousUser()
2013-11-12 12:55:03 +01:00
Kohsuke Kawaguchi
e33cac27d2
the trunk is toward 1.541-SNAPSHOT
2013-11-12 00:40:01 -08:00
Jesse Glick
bdbac28472
[FIXED JENKINS-20415] Lack of type safety in JENKINS-20143 fix sometimes caused CCEs.
2013-11-11 11:54:58 -05:00
Oliver Gondža
ebeda2add8
Remove unused import
2013-11-11 14:57:26 +01:00
Oliver Gondža
184690c8f3
Merge branch 'master' of github.com:jenkinsci/jenkins
2013-11-11 14:22:00 +01:00
Oliver Gondža
d513253d28
Tidy up after #1005
2013-11-11 13:52:18 +01:00
Stephen Connolly
f68638a8fa
Fix compiler error
2013-11-11 12:40:49 +00:00
Oliver Gondža
a494868c47
Merge pull request #1005 from christ66/master
...
[FIXED JENKINS-8815] Fixed issue where CLI required giving Overall read ...
Conflicts:
core/src/main/java/hudson/cli/CLIAction.java
2013-11-11 12:05:38 +01:00
mrebasti
a8f6d6bc68
* Adding a warning message when HudsonTestCase and JenkinsRule reach the configured timeout. This message will be very useful to diagnose test failures caused by timeouts.
...
* Adding a mechanism to allow users running tests in slow systems can change the default timeout. Now they can change this value using the environment variable "jenkins.test.timeout" expresed in seconds. Example: mvn test -Djenkins.test.timeout=300
2013-11-10 16:42:04 -03:00
Kohsuke Kawaguchi
1b6ba71f9c
[JENKINS-20128] reproduced the problem
2013-11-09 14:56:47 -08:00
christ66
a2ff61010e
[FIXED JENKINS-8815] Fixed issue where CLI required giving Overall read permission to anonymous.
...
Added test unit.
2013-11-08 17:10:26 -08:00
Kohsuke Kawaguchi
61cf2df066
[JENKINS-10615]
...
Reproduced the problem. Workspace is getting released prematurely, before publishers run. This has all sorts of serious problems.
2013-11-08 11:50:35 -08:00
Stephen Connolly
dec369e68e
Merge pull request #994 from daniel-beck/dont-remember-me
...
[JENKINS-15757] Ignore 'remember me' if disabled in configuration
2013-11-06 02:21:20 -08:00
Daniel Beck
9ed2ed5fd9
[JENKINS-15757] Add tests
...
A new test for the existing 'Remember me' functionality that verifies that
the cookie is set, and a new test showing that, even if requested by the
user, no cookie will be set, if 'Remember me' is disabled in the security
configuration.
2013-11-06 10:17:05 +01:00
Kohsuke Kawaguchi
1be677da36
the trunk is toward 1.540-SNAPSHOT
2013-11-03 22:39:53 -08:00
Jesse Glick
8661222f2d
Synchronizing XPath-related assertions with implementations in HudsonTestCase, using HtmlUnit’s XPath engine rather than Hamcrest’s which does not seem to work in this context at least.
2013-10-31 16:09:47 -04:00
Jesse Glick
ac5767e3bc
Deprecating hudson field; use jenkins instead.
2013-10-31 13:39:50 -04:00
Jesse Glick
5e3387c6ae
Noting that this class is not really necessary now that cloudbees-folder is open source.
2013-10-28 14:56:33 -04:00
Kohsuke Kawaguchi
eb1de2c175
the trunk is toward 1.539-SNAPSHOT
2013-10-28 07:33:14 -07:00
Kohsuke Kawaguchi
b96d227f97
[FIXED JENKINS-19996] Support view manipulation via Jenkins CLI
...
Merged pull request #971 .
2013-10-26 14:50:57 -07:00
Kohsuke Kawaguchi
9ee9684681
Merge pull request #973 from olivergondza/cli-help
...
[JENKINS-20023] Make CLI interface help more accesible
2013-10-26 14:43:43 -07:00
Kohsuke Kawaguchi
42ced243af
Merge pull request #977 from olivergondza/build-name-command-npe
...
[FIXED JENKINS-20057] NPE when issuing set-build-display-name CLI command
2013-10-26 14:33:52 -07:00
Kohsuke Kawaguchi
3e4733c7a4
Merge branch 'rc'
2013-10-25 16:02:49 -07:00
Kohsuke Kawaguchi
b3225944d1
Revert "[FIXED JENKINS-18629]"
...
This reverts commit c01333c346 .
See
https://issues.jenkins-ci.org/browse/JENKINS-20262?focusedCommentId=188404&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-188404
for the discussion why this should be reverted.
Conflicts:
core/pom.xml
2013-10-25 15:59:59 -07:00
Jesse Glick
d0c45040d6
Get/UpdateJobCommand should work with the most generic possible type—AbstractItem.
2013-10-24 14:55:08 -04:00
Jesse Glick
7c606ae5c8
Merge branch 'fix-refused-build-cli-npe' of github.com:marco-miller/jenkins into marco-miller-fix-refused-build-cli-npe
2013-10-23 14:58:58 -04:00
Marco Miller
365df70b1f
Refactor string constant duplicate in BuildCommand and BuildCommandTest.
2013-10-23 14:14:14 -04:00
Marco Miller
eaeb45bdaa
Null check for if build scheduling Refused by extension => not in Queue.
...
New test in hudson/cli/BuildCommandTest.groovy, as well as companion
@TestExtension class, thanks to Jesse' suggestion. This is so that we
test this hereby fixed case of a QueueDecisionHandler Refusing a build,
leading to that null value now checked and handled accordingly.
Commit also includes sorted imports and a few minor indentation fixes,
as well as another (very) minor string change.
2013-10-23 11:05:03 -04:00
Jesse Glick
dceac8f0ac
[FIXED JENKINS-19173] Added ContextMenuVisibility marker interface for Action’s.
2013-10-23 10:44:01 -04:00
Jesse Glick
08aaf2b9b3
Trying to make AsynchPeopleTest more robust.
...
https://jenkins.ci.cloudbees.com/job/core/job/jenkins_main_trunk/1369/testReport/junit/hudson.model/AsynchPeopleTest/display/
org.junit.ComparisonFailure: expected:<[display: none;]> but was:<[]>
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at hudson.model.AsynchPeopleTest.display(AsynchPeopleTest.java:44)
was presumably a race condition.
Could reproduce by adding a Thread.sleep into AsynchPeople.compute.
This patch (with waitForBackgroundJavaScript) avoids that error;
but causes the assertNotNull at the end to fail, for reasons TBD.
2013-10-22 17:38:49 -04:00
Kohsuke Kawaguchi
f9f1483865
the trunk is toward 1.538-SNAPSHOT
2013-10-21 21:56:36 -07:00
Oliver Gondža
b2651f22b2
[JENKINS-19996] Support nested views in Jenkins CLI
2013-10-18 14:34:46 +02:00
Jesse Glick
f0328e55b7
testTriggerJob has been unstable recently, probably because of executor-ondemand branch changes.
2013-10-17 09:59:06 -04:00
Oliver Gondža
09693ce75e
[FIXED JENKINS-20057] NPE when issuing set-build-display-name CLI command
2013-10-17 12:50:13 +02:00
Jesse Glick
acff33106e
[FIXED JENKINS-16936] Added SecureRequester extension point.
2013-10-16 17:03:03 -04:00
Nicolas De loof
86fe60eee7
Merge pull request #970 from vjuranek/JENKINS-19926
...
[FIXED JENKINS-19926] Add only new env. variables
2013-10-16 01:59:32 -07:00
Kohsuke Kawaguchi
71afe8f0a9
the trunk is toward 1.537-SNAPSHOT
2013-10-15 08:07:00 -07:00
Oliver Gondža
29d441331e
[FIXED JENKINS-19996] Support view manipulation via Jenkins CLI
2013-10-14 16:07:06 +02:00
Oliver Gondža
5f712b3c5f
[JENKINS-20023] Generate usage for CLI commands registered via CLIMethod annotation
2013-10-14 15:41:59 +02:00
Kohsuke Kawaguchi
957dbdf675
Fixed a test failure.
...
Turns out in the new executor on-demand code, queue maintenance happens so quickly that even when a job is submitted with delay 0,
it can still fail the test if the check happens when "new GregorianCalendar()" returns the same value as "top.timestamp".
I'm relaxing that check
2013-10-11 12:34:53 -07:00
Vojtech Juranek
b95f269452
[FIXED JENKINS-19926] Add only new env. variables
...
Previous patch (3eea396489 ) broke usescases when evn. variable overwrites already existing one
like PATH = $PATH:/my/path
2013-10-10 22:23:54 +02:00
Kohsuke Kawaguchi
c01333c346
[FIXED JENKINS-18629]
...
Consult Descriptor.newInstance() even when proccessing is in the middle
of JSON tree.
(cherry picked from commit d15c15506e )
2013-10-09 15:49:04 -07:00
Jesse Glick
793b6826e5
[FIXED JENKINS-19947] Restore historical undocumented behavior of a top-level entry in a ZIP.
...
Noting that various DirScanner implementations handle this inconsistently.
2013-10-09 09:55:06 -04:00
Kohsuke Kawaguchi
8c4288ca59
Merge remote-tracking branch 'origin/master' into executor-ondemand
2013-10-07 20:38:34 -07:00
Kohsuke Kawaguchi
428aa7aaee
the trunk is toward 1.536-SNAPSHOT
2013-10-07 19:56:20 -07:00
Jesse Glick
7ca4dc47ec
[FIXED JENKINS-19920] Using selfReference to mean “none” from nextBuild/previousBuild was just asking for trouble.
...
JENKINS-16194 and an analogous but opposite bug fixed more simply by introducing a separate NONE constant.
Also numberOnDisk did not get updated properly after a build was deleted, causing double loading of build records in some cases.
2013-10-07 13:30:05 -04:00
Jesse Glick
571de9c148
JUnit 4; introduced GroovyJenkinsRule.
2013-10-07 11:43:39 -04:00
Jesse Glick
ed03fbbc9d
Revert "[FIXED JENKINS-18629]"
...
This reverts commit d15c15506e .
2013-10-07 11:18:36 -04:00
Kohsuke Kawaguchi
d15c15506e
[FIXED JENKINS-18629]
...
Consult Descriptor.newInstance() even when proccessing is in the middle
of JSON tree.
2013-10-07 08:10:42 -07:00
Jesse Glick
b9437154d8
ClassicPluginStrategy.DETACHED_LIST could confuse ClassicPluginStrategyTest by injecting dependencies on split plugins that have an index.jelly.
2013-10-04 18:19:49 -04:00