Commit Graph
289 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 57a4c02cda Merge branch 'pull-506' 2012-06-29 20:21:28 -07:00
Kohsuke Kawaguchi 30837d8903 Better encapsulation of JavaScript.
Don't expose stuff that need not be exposed.
2012-06-29 20:19:23 -07:00
Kohsuke Kawaguchi 96442cd9cd splitting JavaScript into smaller fragments for better maintainability.
One of the problems with the current way Jenkins puts JavaScripts is that most everything is in a single file. It doesn't highlight the relationship between those fragments and their corresponding tag files.

So I'm experimenting with moving out these fragments into individual JavaScript files co-located with the tag file. They then get loaded into the page via <st:adjunct>. Each script is served with unique URL such that the browser will not even have to try conditional GET when loading different pages, so this should prevent the performance problem caused by the fact that there are now lots of <script> tags in the page.

 If for some reason even this turns out to be a problem, we can always add additional build steps to concatenate them all.
2012-06-28 15:24:53 -07:00
Kohsuke Kawaguchi 02854d87bd Wrong variable name 2012-06-22 17:45:17 -07:00
Kohsuke Kawaguchi d318bbae5b Added code to assist form-element-path plugin 2012-06-22 17:41:30 -07:00
Kohsuke Kawaguchi 74bea665c6 copy & keep CSS class names 2012-06-22 17:41:30 -07:00
Kohsuke Kawaguchi 7c5efe367b deprecating 'fooButton' class in favor of 'foo-button'
This makes it consistent with other buttons like repeatable-add-button, and use of '-' prevents name collisions with form names, and make all of those UI controls addressible in the same namespace
2012-06-22 17:41:30 -07:00
Alberto Gragera 581b8256b1 Make Jenkins stop polling resources if the page is not visible (and if the browser supports Page Visibility API), restoring pollings when the page becomes visible again. This will make tabs in the background to not consume resources 2012-06-22 12:55:02 +02:00
Kohsuke Kawaguchi bc0b850510 Merge branch 'pull-434.2' 2012-06-11 15:23:28 -07:00
Kohsuke Kawaguchi 72fbaba275 Refactored existing static list into CoreEnvironmentContributor. 2012-06-11 15:21:57 -07:00
Kohsuke Kawaguchi 17317bb4ca supported more complex relative path 2012-06-05 18:16:27 -07:00
Kohsuke Kawaguchi d72a9a2bc5 fixed a bug in the neighbor field discovery.
Previously, the code was "find the nearby element of the expected @name,
then make sure it has gotten the right parent."

So if the structure is like:

  {/* outer object */
      name: "parent-name",  /* A */

      child1: {/* inner object */
        name: "child-name" /* B */
      },

      child2: {/* inner object */
        name: "child-name" /* C */
      }
  }

... and if we are looking for "../name", it finds B, and it gets
rejected, so we won't be able to find A, which is what we are supposed
to find.

With this change, we keep trying until we find the right one,
so the above case will correctly return A.
2012-06-05 18:16:27 -07:00
Vincent Latombe ec5812c82e In ListView, wrap the list of jobs inside a scrollable div.
When managing instances with lots of jobs, the size of the view
configuration screen becomes huge because there is one line per job on
the instance.
2012-06-05 15:55:37 -07:00
Kohsuke Kawaguchi fe0c718e39 Integrated the new animation GIF images that have more transparent background.
Going beyond this requires CSS animation.
2012-05-30 17:49:56 -07:00
Kohsuke Kawaguchi f9a8630f1c call layout updater when we touch DOM 2012-05-30 16:50:03 -07:00
Kohsuke Kawaguchi 32cba8f245 One more file to be removed for LDAP 2012-05-30 10:40:02 -07:00
Kohsuke Kawaguchi 18963ee9af [FIXED JENKINS-13625]
In the end, proper fix requires having a filter that tracks
GZipOutputStream.
2012-05-23 20:11:58 -07:00
Ariel Peltz 7a84ab1d34 Fix for annoying typo in custom workspace help 2012-05-17 10:57:53 +03:00
Kohsuke Kawaguchi 7a4858d65f [FIXED JENKINS-12585] restrict where sessions are created.
If a resource with 'Set-Cookie' header is cached (either by intermediary
like HTTP proxy and reverse proxy, or by the browser), it'll cause
identity swap / session mix-up as discussed in this ticket.

I suspect this was caused by HttpSessionContextIntegrationFilter2, which
is the only code path that attempts to create a session when a request
to a static resource is made.

So I'm disabling the creation of session in
HttpSessionContextIntegrationFilter2. This in turn requires that we
have sessions already created when the authentication was successful and
people need to login (or else the login will have no effect.)

We already do so in layout.jelly, so any request that renders a Jenkins
page would have a session, but I've also added it in
AuthenticationProcessingFilter2, which ensures that a successful login
does have a session.
2012-05-03 17:56:13 -07:00
Kohsuke Kawaguchi 749f4ffadf Merge remote-tracking branch 'origin/publisher' 2012-04-25 22:56:03 -07:00
OHTAKE Tomohiro 815c42c458 [FIXED JENKINS-13578] 'sortbottom' was sorted to the top 2012-04-25 09:59:27 +09:00
Kohsuke Kawaguchi 58267c4672 added scorll-into-view capability 2012-04-19 17:52:07 +02:00
Kohsuke Kawaguchi d2d7e43eee by default, try to preserve the order 2012-04-19 17:52:07 +02:00
Kohsuke Kawaguchi 28bcaea860 unused arguments 2012-04-19 17:52:07 +02:00
Kohsuke Kawaguchi 07477567d2 this is shorter 2012-04-19 17:52:07 +02:00
Kohsuke Kawaguchi 570d974568 hopefully giving it a name made it easier to understand what it means 2012-04-19 17:52:07 +02:00
Kohsuke Kawaguchi 11f8ac0875 adding animation 2012-04-19 17:52:07 +02:00
Kohsuke Kawaguchi 085ae79e5b this needs to trigger the relayout 2012-04-19 17:52:06 +02:00
Kohsuke Kawaguchi 8f16967ad5 make sure the newly added portion is always visible 2012-04-19 17:52:06 +02:00
Kohsuke Kawaguchi aef3cf3acf converting publishers to a drop-down menu to save real estate 2012-04-19 17:52:06 +02:00
Vincent Latombe 3c5d7cc38a [Fix JENKINS-13195] New Breadcrumb bar covers search suggestions
Adjust z-index for #search-box-completion to appear over the breadcrumb
2012-03-22 19:42:21 +01:00
Seiji Sogabe bc75390479 i18n & l10n(ja) for ProjectNamingStrategy 2012-03-14 00:52:42 +09:00
OHTAKE Tomohiro 6c5a9fc9bf Re-implement findElementsBySelector using Prototype.Selector
http://jenkins.local/job/JOBNAME/configure will become
10%-faster in Chrome 14 and 20%-faster in IE 9.
2012-03-05 16:42:07 -08:00
OHTAKE Tomohiro 4535b18333 IE compatibility
$(e).next() may return undefined.
If 2nd argument of insertBefore is undefined,
IE9 complains "SCRIPT87: Invalid argument".
To insert newChild at the end, 2nd argument should be null.
http://www.w3.org/TR/2000/REC-DOM-Level-2-Core-20001113/core.html#ID-952280727
2012-03-05 16:37:13 -08:00
imod a2d9bac03d define new extension point to define ProjectNamingStrategy and add two implementations: Default and Pattern 2012-03-04 11:11:39 +01:00
Kohsuke Kawaguchi 511b42a073 Merge branch 'prototype-patched' 2012-03-01 22:16:25 -08:00
Kohsuke Kawaguchi 34e8117a64 [JENKINS-11618] Adding back the 'toJSON' instance method.
This change, in parallel to a fix in stapler bind.js, would maximize the
backward compatibility.
2012-03-01 22:10:54 -08:00
Kohsuke Kawaguchi 8d98d74b51 In preparation of merging prototype 1.7, resetting the history. 2012-03-01 19:20:42 -08:00
Kohsuke Kawaguchi 728fc8aafd Backporting 918fc6e6ca
made to work with <textarea>s, too.

git-svn-id:
https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@8172
71c3de6d-444a-0410-be80-ed276b4c234a
2012-03-01 19:17:03 -08:00
Kohsuke Kawaguchi b250055edd Cherry-picking 8fa28bf76b 2012-03-01 19:10:06 -08:00
Kohsuke Kawaguchi 3cf8d2c12e Disabling automatic JSON evaluation.
This is an adopted version of 8b1e071d22.
Since 1.7 has a flag to disable this behaviour, I think a better fix is
to disable this flag by default.
2012-03-01 19:04:06 -08:00
Kohsuke Kawaguchi 521d05d53d Cherry-picking c6acb5b8d5 2012-03-01 18:56:24 -08:00
Kohsuke Kawaguchi 794cc76676 [JENKINS-11618] backporting the fix here.
I actually applied the diff from
6904bb61e31595b70260840937114e79a646da5d in keyboard-shortcuts-plugin
2012-03-01 18:50:05 -08:00
Kohsuke Kawaguchi 8009dccfb0 Imported prestine 1.7
... from
https://ajax.googleapis.com/ajax/libs/prototype/1.7.0.0/prototype.js
2012-03-01 18:48:37 -08:00
Kohsuke Kawaguchi 9a2891057d Imported prestine 1.5.1.1
... from http://www.prototypejs.org/assets/2007/6/20/prototype.js
2012-03-01 18:47:48 -08:00
Kohsuke Kawaguchi 7bf8e8e894 Merge branch 'rc' 2012-02-29 18:51:32 -08:00
Kohsuke Kawaguchi 4268881f74 more prototype navigation 2012-02-29 18:11:48 -08:00
Kohsuke Kawaguchi 5c5b4c8245 Used prototype element navigation to deal with whitespace between elements.
Jelly/Groovy views don't do this, but erb views from Ruby often do it,
so better be robust. This is breaking J-on-J currently.
2012-02-29 16:16:27 -08:00
Kohsuke Kawaguchi b6448290b1 Create and throw away IFRAME to make back button work.
At least now the back button won't trigger the drop-down notification.
2012-02-28 20:18:12 -08:00
Kohsuke Kawaguchi 959363b94b 999 was the same as the breadcrumb and it was put behind it 2012-02-28 16:26:24 -08:00