Commit Graph
7069 Commits
Author SHA1 Message Date
Donny Nadolny d658f55c30 Add extension point to rewrite JUnit test names
This adds an extension point, TestNameTransformer, which is called to transform JUnit test case names.
This is useful for JVM languages like scala which are more flexible than java with identifier naming.
Scala, for example, allows you to write test names between back ticks, and then encodes the name using valid java identifiers.
This extension point would allow a plugin to transform those names back in to readable names when they are displayed on the test result page.
2013-05-02 14:03:03 -04:00
Jesse Glick 21bf5c45d4 Diagnosis for test failure.
https://jenkins.ci.cloudbees.com/job/core/job/jenkins_main_trunk/850/testReport/jenkins.security/RekeySecretAdminMonitorTest/testBasicWorkflow/
com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 400 Bad Request for http://localhost:60027//administrativeMonitor/jenkins.security.RekeySecretAdminMonitor/scan
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:549)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:333)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:357)
	at com.gargoylesoftware.htmlunit.html.HtmlForm.submit(HtmlForm.java:196)
	at org.jvnet.hudson.test.HudsonTestCase.submit(HudsonTestCase.java:1178)
	at jenkins.security.RekeySecretAdminMonitorTest.testBasicWorkflow(RekeySecretAdminMonitorTest.java:112)
java.lang.Exception: Invalid request submission
	at org.kohsuke.stapler.HttpResponses.error(HttpResponses.java:79)
	at jenkins.security.RekeySecretAdminMonitor.doScan(RekeySecretAdminMonitor.java:117)
2013-05-02 08:55:31 -04:00
Kohsuke Kawaguchi 31eeb753aa merged back the RC branch 2013-05-01 20:37:34 -07:00
Jesse Glick 3c2b50ecfe [FIXED JENKINS-17681] Do not try to call resolveSymlink on a nonexistent link as you will just get an IOException, breaking peephole permalinks in some Windows environments. 2013-05-01 20:13:18 -04:00
Jesse Glick 00d5e38759 [JENKINS-17681] Set up a test which passes on Unix but fails on Windows when symlinks are enabled on the platform but disabled for the current user. 2013-05-01 19:10:30 -04:00
Jesse Glick 1e51b62298 [SECURITY-63] Check RUN_SCRIPTS for /eval.(cherry picked from commit 3d03990abc) 2013-05-01 14:16:49 -07:00
Jesse Glick 04403edc58 [SECURITY-63] Require POST for running Groovy scripts.(cherry picked from commit 3bbb65df3a) 2013-05-01 14:16:40 -07:00
Jesse Glick d482fc50fb [FIXED SECURITY-67] Forbid CSS links in markup to be on the safe side.(cherry picked from commit 1e19eb3ece) 2013-05-01 14:16:37 -07:00
Jesse Glick d391bbee07 Debugging toString. 2013-04-30 17:09:28 -04:00
Jesse Glick 7f3096c558 Deferring formatting Logger messages unless and until the log formatter is run.
No need to call isLoggable if you are only calling simply getters and relying on toString later.
2013-04-30 16:53:27 -04:00
Jesse Glick fd31a5d85c [FIXED JENKINS-15309] Be robust against serialized ListView with jobNames==null. 2013-04-30 16:00:00 -04:00
ssogabe 3f0f25fc6b forgot to replace XXX with 1.515 2013-04-30 22:09:50 +09:00
ssogabe 55a68acca9 [FIXED JENKINS-17715] Display Name is not shown 2013-04-30 20:49:58 +09:00
Kohsuke Kawaguchi 6327e265f8 Added the set-build-parameter command. 2013-04-26 22:03:32 -04:00
Jesse Glick 7fa8fe4096 [FIXED JENKINS-17402] getItem may return null but may not throw IAE. 2013-04-25 11:20:07 -04:00
Jesse Glick 4057463244 [JENKINS-16845] Refinement to hotfix: if build field has already been cleared due to earlier warning, do not throw a new NPE. 2013-04-25 11:11:01 -04:00
Kohsuke Kawaguchi 6e91651a57 [JENKINS-16824] log who's interrupting executors.
This bug indicates that people are having trouble understanding who's
responsible for aborting the build. This change records that
information through the logger.
2013-04-25 07:19:02 -07:00
Kohsuke Kawaguchi 6117578a43 making notes 2013-04-24 12:02:07 -07:00
Kohsuke Kawaguchi 8e6a3f7f03 Converted the build queue and executors into Widgets. 2013-04-24 12:00:58 -07:00
Kohsuke Kawaguchi f1669601e4 [FIXED JENKINS-4543] Identify the short name of the plugin from the manifest. 2013-04-24 11:23:37 -07:00
Jesse Glick 06e459fffe [FIXED JENKINS-17728] ParentBuildAction.parent can sometimes be null. 2013-04-23 20:21:01 -04:00
Jesse Glick 0bf434845b [FIXED JENKINS-17724] /about was not showing licenses.
A recent Stapler update caused the Jelly facet to ignore *.xml.
So need to use raw j:include (as plugins were doing), not st:include (as core did).
2013-04-23 14:46:47 -04:00
Jesse Glick 19f34b54d6 -Dhudson.udp=-1 to disable UDP broadcast. 2013-04-23 12:07:31 -04:00
Kohsuke Kawaguchi 70e1977f21 Call attention to the fact that the security isn't enabled.
This is deemed important because we ship Jenkins without security setting by default.
2013-04-19 14:06:48 -07:00
Kohsuke Kawaguchi ac7e27756f Avoid using now deprecated names 2013-04-19 12:07:52 -07:00
Kohsuke Kawaguchi 368d8c7394 Don't let the error icon get clipped when the text is short.
On Chrome (and possibly others), an inline element like span doesn't enlarge
its size to cover its content, so the 1px place holder wasn't taking effect.

To ensure the minimum height of 16px, make it an inline-block element. I'm
not entirely sure how an inline-block element with no fixed width would behave,
but with a bit of casual testing, the text inside seems to wrap OK.
2013-04-19 10:11:28 -07:00
Kohsuke Kawaguchi 22d1175ac6 Show when the monitor data was obtained 2013-04-18 19:21:56 -07:00
Kohsuke Kawaguchi 58cb75fd28 Improved the robustness in the node monitoring
- Improved logging and recovery for the Record thread that dies in the middle.
- Recover from failing to monitor one node and move on to the next.
2013-04-18 18:54:15 -07:00
Kohsuke Kawaguchi 5c95be34e4 don't let a programming error kill this thread 2013-04-18 18:39:18 -07:00
Kohsuke Kawaguchi e131764850 formatting improvements 2013-04-18 18:09:58 -07:00
Kohsuke Kawaguchi b1f0a7be75 Adding more diagnostics logging 2013-04-18 15:36:02 -07:00
Kohsuke Kawaguchi 7578aa93ad expose the display name of the build as environment variable 2013-04-18 10:38:20 -07:00
Kohsuke Kawaguchi 070f74f667 making this extension point more discoverable 2013-04-17 16:25:47 -07:00
Kohsuke Kawaguchi 3abc50253a 46b6bee16e left this comment that's no longer meaningful. 2013-04-17 13:52:35 -07:00
Kohsuke Kawaguchi e36a075436 Improve the error message to indicate which file had failed to parse.
This allows administrator to remove this problematic file.
2013-04-17 13:51:17 -07:00
Kohsuke Kawaguchi 3f4d82a1a3 Adding a new item should cause the dependency graph recalculation.
For example, a new job might have a trigger setting to begin with,
or it might resolve a reference that was previously failing (for
example, 'up' job referring to 'down' job and the 'down' job is newly
created.)
2013-04-17 09:55:12 -07:00
Kohsuke Kawaguchi 46b6bee16e pointless double invocation 2013-04-17 09:08:52 -07:00
Kohsuke Kawaguchi 5f806d8f63 Marked various mode-link as inside.
Observations:

- When marked inside, moving the mouse to <A> and clicking the context menu becomes easier,
  because you can move the mouse toward the hot spot area and it'll activate.
  Otherwise you have to move the mouse over to <A>, then move the mouse on the side, click it,
  then click the menu, which adds cognitive stress.

- Marking model link as inside creates an empty space to the right of <A>, which looks
  odd if hyperlinks appear inline or if some other text follows it.

Given that, my guiding principle for this change is:

- any model link that is the last child of a block element gets marked as inside
- I've adjust a few text to get rid of the single-letter training text after a model link,
  like "(#3)" to "- #3"
- If another inline element follows a model link, leave it as is.
  This does create an ugly overlap.
2013-04-16 20:09:09 -07:00
Kohsuke Kawaguchi 24aa5a54be adding more ModelObjectWithChildren implementations 2013-04-16 18:59:15 -07:00
Kohsuke Kawaguchi 304ffabed2 implemented ModelObjectWithChildren in various model object implementations 2013-04-16 18:50:33 -07:00
Kohsuke Kawaguchi b2cd4120ec Breadcrumb is reworked to show descendants to provide additional navigational shortcuts.
Object that implements ModelObjectWithChildren can expose its children in the breadcrumb.
2013-04-16 17:51:15 -07:00
Kohsuke Kawaguchi 5aa4af75c2 we want to prefer *.jpi over *.hpi, but the code was other way around 2013-04-16 13:38:54 -07:00
Kohsuke Kawaguchi 38eec41601 Simplification without changing the semantics 2013-04-16 12:56:37 -07:00
Kohsuke Kawaguchi ff7f272a4b Fixing StringIndexOutOfBoundsException
I'm not really sure what this code is doing or what ID is supposed to look like. So this is just a minimum-intrusion change to avoid an exception.

java.lang.StringIndexOutOfBoundsException: String index out of range: -1
        at java.lang.String.substring(String.java:1875)
        at hudson.tasks.junit.PackageResult.findCorrespondingResult(PackageResult.java:86)
        at hudson.tasks.junit.TestResult.findCorrespondingResult(TestResult.java:295)
        at hudson.tasks.test.AbstractTestResultAction.findCorrespondingResult(AbstractTestResultAction.java:183)
        at hudson.tasks.test.TestResult.getResultInBuild(TestResult.java:162)
        at hudson.tasks.junit.History.getList(History.java:82)
        at hudson.tasks.junit.History$1.createDataSet(History.java:105)
        at hudson.tasks.junit.History$GraphImpl.createGraph(History.java:169)
        at hudson.util.Graph.render(Graph.java:87)
        at hudson.util.Graph.doPng(Graph.java:98)
2013-04-16 12:56:37 -07:00
Kohsuke Kawaguchi 7547681a24 need to prefer linked files over archives.
This regression appeared to be introduced in 32d5c23.
2013-04-16 12:03:47 -07:00
Jesse Glick f8ce8c6e5a Removed junk from cdee827d55. 2013-04-16 11:55:58 -04:00
Nicolas De loof cdee827d55 restore backward compatibility
d3096819f6 changed constructor signature. Add a backward-compatible one
2013-04-16 13:52:23 +02:00
ssogabe ac562d821a check view name with ajax 2013-04-13 09:53:51 +09:00
Seiji Sogabe 477e8979eb rawEncode should be used instead of encode 2013-04-13 04:48:07 +09:00
Jesse Glick 299af75293 Touch-ups related to PR #757. 2013-04-12 14:09:12 -04:00