Commit Graph
2894 Commits
Author SHA1 Message Date
mindless d83f81041b [FIXED HUDSON-2379] Fix artifact archiver and workspace browser to handle filenames
that need URL-encoding.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14106 71c3de6d-444a-0410-be80-ed276b4c234a
2009-01-02 19:14:05 +00:00
mindless 839c26d1c7 [FIXED HUDSON-117] If next/previousBuild link jumps to an action not present
in that build (like testReport) then redirect up to the build page.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14099 71c3de6d-444a-0410-be80-ed276b4c234a
2009-01-02 00:04:21 +00:00
kohsuke b197e721e8 doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14090 71c3de6d-444a-0410-be80-ed276b4c234a
2009-01-01 20:17:06 +00:00
kohsuke 19f2300c28 [FIXED HUDSON-262] Subversion checkout/update now supports fixed revisions. In Hudson 1.269.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14076 71c3de6d-444a-0410-be80-ed276b4c234a
2009-01-01 04:41:16 +00:00
kohsuke 6508275d66 [FIXED HUDSON-2778] Fixed and added a test case.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14073 71c3de6d-444a-0410-be80-ed276b4c234a
2009-01-01 01:12:57 +00:00
kohsuke 4bf68f1a98 Logger configuration wasn't working since 1.267.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14072 71c3de6d-444a-0410-be80-ed276b4c234a
2009-01-01 00:50:46 +00:00
kohsuke c5a4e8c463 Prohibit creating two views with the same name.
http://d.hatena.ne.jp/ssogabe/20090101/1230744150

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14067 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 23:58:43 +00:00
kohsuke bb97d31c69 added more prominent indentation
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14057 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 21:09:53 +00:00
kohsuke 8abb2516d6 working on nested view inline expansion
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14053 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 19:50:46 +00:00
kohsuke a06e8a05c1 - introduced adjuncts from stapler
- fixed the feature envy problem in the version computation

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14052 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 19:46:02 +00:00
mindless 92ccc8dff7 [FIXED HUDSON-2408] On a failed permission check for anonymous, it seems
rsp.getOutputStream() has already been called before reaching this class.
So use getOutputStream() instead of getWriter() to send html for login
redirect (and catch exception/use getWriter, just in case).


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14049 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 19:07:03 +00:00
mindless 445603a2d1 Fix typo in css
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14045 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 17:43:07 +00:00
mindless 6ab07d0b51 Add admin-permission check on _launchAll method.
I'd list this security fix in the changelog, but this method wasn't actually
working properly so there was no previous security hole (it called launch()
on only nodes that do NOT support launch, instead of those that DO).
Fixed method to work properly now that permission check is in place
(though I don't see this method used anywhere, but you can manually enter
 computer/_launchAll URL to invoke it).


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14044 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 17:42:35 +00:00
mindless 7baeec3636 [FIXED HUDSON-1207] Don't require admin permission to view computer/ (node list) page.
Instead just hide disk-space and swap-space columns from the table.
Admin check was already there for "refresh" button at bottom of page.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14043 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 17:39:31 +00:00
petehayes 658b35c610 HUDSON-2777 Added code to go through build wrappers and adding project actions
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14038 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 15:52:01 +00:00
kohsuke 0fe86ccbf4 refactored
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14032 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 15:15:06 +00:00
kohsuke 0e4a7acc13 refactored view creation
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14029 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 14:48:47 +00:00
kohsuke e666ecb18b started working on experimental tree view.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14025 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 14:11:59 +00:00
kohsuke a9e309caa3 refactored the doConfigSubmit method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14020 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 13:51:59 +00:00
kohsuke c8de7dda19 added the fast path.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14016 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 13:37:05 +00:00
kohsuke 4841d45c84 using field binding to simplify this a bit.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14015 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 13:36:16 +00:00
mindless d15b8133c6 [FIXED HUDSON-2633] Only show form on tagBuild page if user has tag permission.
(otherwise just show existing tag info)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13988 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-30 22:09:32 +00:00
kohsuke 26603ed4ba Hudson no longer extends from View, so that it can use a different view implementation to render the top page.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13987 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-30 21:34:23 +00:00
sogabe 8ded5e3b99 Updated Japanese localization
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13971 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-30 04:11:09 +00:00
kohsuke e75c7768b8 got rid of double owner fields
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13969 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-30 02:35:24 +00:00
kohsuke 2b4892d835 leaving the view name null is important for clean persistence
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13968 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-30 02:33:01 +00:00
kohsuke 0050fb0e7d added the view rename method.
onItemChange -> onItemRenamed for consistency

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13963 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-30 02:03:27 +00:00
kohsuke aedf665296 doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13962 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-30 01:55:20 +00:00
kohsuke 0eb370ffbd pushing up the name field.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13961 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-30 01:45:38 +00:00
kohsuke 83266d8401 pushing up the name field.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13960 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-30 01:44:02 +00:00
kohsuke 9b480fa311 pushing up the getUrl method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13959 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-30 01:40:27 +00:00
kohsuke 57e4bacbb9 [HUDSON-232] Shuffling methods around to make way for nestable views.
I changed the signature of getViews() in this change. Grep indicates that no current plugins are using this method.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13958 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-30 01:28:25 +00:00
kohsuke 469bfbf455 Made the landing page configurable.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13953 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-29 18:15:38 +00:00
kohsuke 37ea99ca6f removed a pointless parameter
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13952 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-29 18:00:20 +00:00
kohsuke 790923928f added onJobChange() so that views can reflect item changes
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13951 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-29 18:00:05 +00:00
kohsuke 2830cae0ce [FIXED HUDSON-234] View is now an ExtensionPoint.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13950 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-29 17:53:56 +00:00
kohsuke 74ffde7f52 added a convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13949 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-29 17:17:12 +00:00
kohsuke e7dcc24fe1 formatting changes
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13947 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-29 14:46:34 +00:00
kohsuke ffc5884a17 [FIXED HUDSON-2771] fixed NPE, and added a regression test, which in turn required some fixes in HtmlUnit as well.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13936 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-28 19:50:41 +00:00
huybrechts 9407832bc8 HUDSON-2682 workaround for Eclipse compilation bug
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13893 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-26 21:40:21 +00:00
sogabe 3cef8497b7 [FIXED HUDSON-2764] Show Badge in bug history only when artifacts are redployed successfully
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13871 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-25 12:01:07 +00:00
mindless d60bbd610c change / to */ so javadoc ends, and getActions method is not commented out
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13858 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-24 23:45:07 +00:00
kohsuke fb873cbaf2 [FIXED HUDSON-2715] Field validators in configure screen shouldn't require the admin permission where possible.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13838 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-24 19:31:10 +00:00
kohsuke ce015a9c85 [FIXED HUDSON-2770] resurrected the awtProblem as boolean.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13837 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-24 18:11:44 +00:00
kohsuke 8a229acc28 improved error diagnostics
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13816 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-23 07:42:20 +00:00
kohsuke ae710c8119 [FIXED HUDSON-2748]
If a view name or job name contains whitespace, the navigation bar doesn't show the current positions correctly.
    (<a href="http://hudson.dev.java.net/issues/show_bug.cgi?id=2748">issue 2748</a>)

In 1.267.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13815 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-23 05:20:42 +00:00
kohsuke bf096266b9 If AWT doesn't work, Hudson reports an error now.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13812 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-23 03:10:41 +00:00
mindless 7f16908114 [FIXED HUDSON-2745] Project-based perms granted to Anonymous were not treated like Everyone,
just Anonymous.
Added ANONYMOUS check in SidACL._hasPermissions so it will also
apply for newInheritingACL() result.  This check is moved from
GlobalMatrixAuthorizationStrategy and AuthorizationMatrixProperty.
Also added SidACL.toString(Sid), so each child class doesn't need
a copy of this code.  In this method, added check for p==EVERYONE
so that Sid can be handled, if needed for future use.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13808 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-22 22:10:33 +00:00
mindless 356fdbec0d [FIXED HUDSON-2763] Add health report in build history widget on project page.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13802 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-22 19:42:11 +00:00
kohsuke 76b6ae8c01 Merged revisions 13757-13773 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/log-manager

........
  r13757 | kohsuke | 2008-12-21 08:36:43 -0800 (Sun, 21 Dec 2008) | 1 line
  
  work so far
........
  r13758 | kohsuke | 2008-12-21 11:13:59 -0800 (Sun, 21 Dec 2008) | 1 line
  
  added persistence for LogRecorders
........
  r13759 | kohsuke | 2008-12-21 11:22:04 -0800 (Sun, 21 Dec 2008) | 1 line
  
  bug fix
........
  r13760 | kohsuke | 2008-12-21 11:26:53 -0800 (Sun, 21 Dec 2008) | 1 line
  
  improved matching
........
  r13761 | kohsuke | 2008-12-21 11:27:36 -0800 (Sun, 21 Dec 2008) | 1 line
  
  bug fix
........
  r13762 | kohsuke | 2008-12-21 11:35:13 -0800 (Sun, 21 Dec 2008) | 3 lines
  
  added removal.
  
  I should really think about how to simplify CRUD operations
........
  r13763 | kohsuke | 2008-12-21 11:36:31 -0800 (Sun, 21 Dec 2008) | 1 line
  
  bug fix. Or else it will haunt us back when we restart.
........
  r13764 | kohsuke | 2008-12-21 11:43:13 -0800 (Sun, 21 Dec 2008) | 1 line
  
  added a needed image
........
  r13765 | kohsuke | 2008-12-21 11:49:05 -0800 (Sun, 21 Dec 2008) | 1 line
  
  sort log recorders
........
  r13766 | kohsuke | 2008-12-21 11:57:31 -0800 (Sun, 21 Dec 2008) | 1 line
  
  Finishing up UI
........
  r13767 | kohsuke | 2008-12-21 12:01:43 -0800 (Sun, 21 Dec 2008) | 1 line
  
  moving "/logRss" to "/log/rss"
........
  r13768 | kohsuke | 2008-12-21 12:08:36 -0800 (Sun, 21 Dec 2008) | 3 lines
  
  Moved logging code to its own package.
........
  r13769 | kohsuke | 2008-12-21 12:18:46 -0800 (Sun, 21 Dec 2008) | 1 line
  
  added RSS support
........
  r13770 | kohsuke | 2008-12-21 12:19:32 -0800 (Sun, 21 Dec 2008) | 1 line
  
  doc improvement
........
  r13771 | kohsuke | 2008-12-21 13:15:29 -0800 (Sun, 21 Dec 2008) | 1 line
  
  switched to the combobox
........
  r13772 | kohsuke | 2008-12-21 17:33:07 -0800 (Sun, 21 Dec 2008) | 1 line
  
  added help files
........
  r13773 | kohsuke | 2008-12-21 17:39:00 -0800 (Sun, 21 Dec 2008) | 1 line
  
  doc improvement
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13776 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-22 02:17:05 +00:00