kohsuke
dc175212db
changing my mind about the operator syntax. I think || and && are better than | and &.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33708 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-11 22:34:16 +00:00
kohsuke
eb51d46d56
ConcurrentHashMap should serialize like a map.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33655 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-09 22:20:11 +00:00
mindless
d4c9e40b91
[SECURITY-5] Add several missing permission checks in CLI commands.
...
Current CLI is always available and most commands can be run by anonymous users.
Now only a short help message and the login command are available for anonymous
in a Hudson without anonymous read permission, and each individual command also
checks the appropriate permission for that command. Details:
* Vulnerable CLI commands now fixed:
build, clear-queue, copy-job, create-job, delete-builds, delete-job,
disable-job, enable-job, install-plugin, install-tool, keep-build,
mail, restart, safe-restart, set-build-result
* Broken CLI commands now fixed:
connect-node, delete-node, disconnect-node, offline-node, online-node
* Other vulnerable command (not CLI) now fixed: /gc (JVM garbage collect)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33626 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-08 05:29:34 +00:00
kohsuke
bef7bfcca1
improved error check and added help text
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33622 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-07 23:03:58 +00:00
kohsuke
5c73b4eb08
Seemingly stable label boolean expression support.
...
Driven by a test case.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33620 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-07 23:03:42 +00:00
kohsuke
12fae21cb5
started writing a grammar for the label expression
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33619 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-07 23:03:26 +00:00
kohsuke
004c75c381
First stab at boolean expression over labels.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33617 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-07 23:03:06 +00:00
kohsuke
09afdea42e
Started playing with label expressions.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33616 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-07 23:02:46 +00:00
StevenGBrown
2c1680428a
[FIXED HUDSON-7138] GlobalMatrixAuthorizationStrategy (and ProjectMatrixAuthorizationStrategy since it subclasses the Converter) now sorts the permissions before persisting them.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33594 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-05 14:28:02 +00:00
kohsuke
c9ba842419
report the entire call stack, not just the tip.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33557 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-04 06:35:41 +00:00
kohsuke
a30ee8291d
Look out for a typical error a plugin developer makes.
...
See http://hudson.361315.n4.nabble.com/Help-Hint-needed-Post-build-action-doesn-t-stay-activated-td2308833.html
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33544 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-03 14:28:09 +00:00
kohsuke
50c27e875b
if we are initialing a restart, record that in the log.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33535 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-02 18:50:07 +00:00
kohsuke
dbd323f9dd
added another convenience method.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33532 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-02 18:22:06 +00:00
kohsuke
632e33d2bf
cosmetic change.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33531 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-02 18:21:34 +00:00
mindless
80f7a7ea61
[HUDSON-7108] add ArgumentListBuilder.toWindowsCommand() which wraps command
...
in CMD.EXE /C (as Ant.perform() already did), but also does escaping of special
characters to ensure argument as passed unaltered. Use this in Ant.perform() so
build parameters with < or > characters don't cause I/O redirection, for example.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33530 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-02 17:51:23 +00:00
StevenGBrown
a23baa9b22
Corrected the BuildWrapper.decorateLauncher method Javadoc.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33485 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-01 07:31:14 +00:00
mindless
7aae4ec1bf
javadoc
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33348 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-30 00:00:00 +00:00
mindless
de0cd39fa6
[FIXED HUDSON-6966] in getIndexPage(), check that result has this plugin's artifactId
...
in it, in case plugin has dependencies but is missing its own index.jelly.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33311 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-28 21:44:30 +00:00
abayer
ae354a961a
[FIXED HUDSON-6429] Check for null results to handle aborted incremental Maven builds - thanks to kutzi for the patch
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33250 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-27 16:32:30 +00:00
kohsuke
76bffc7683
wrong signature.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33219 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-26 18:38:31 +00:00
mindless
17b4a46f3d
[FIXED HUDSON-6938] Avoid infinite loop with invalid or null primary view,
...
such as in upgrade from older Hudson.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33194 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-25 00:15:26 +00:00
kohsuke
fe60cc4ebb
[FIXED HUDSON-4044] added more logging
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33186 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-24 00:09:32 +00:00
mindless
9977ccdaa6
[FIXED HUDSON-7054] use Node.canTake(Task) in Queue._getBuildableItems so that
...
Mode.EXCLUSIVE ("only for tied jobs") setting is respected.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33185 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-23 19:01:57 +00:00
mindless
a59814e85c
[FIXED HUDSON-6804] call Hudson.cleanUp from lifecycle classes and in Hudson.doSafeExit
...
so that safeRestart and safeExit propertly cleanup before terminating the process;
in particular, so the contents of the build queue is saved so it can be restored
after restart. Also increased delay before restart from 5 to 10 seconds,
as I saw one build get interrupted at restart in my testing.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33184 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-23 18:57:24 +00:00
mindless
c83e846fd0
[FIXED HUDSON-6925] Support LogRotator deletion of old artifacts in
...
multiconfiguration(matrix) projects, based on patch from cjo9900.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33178 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-22 22:44:35 +00:00
kohsuke
c97593de6f
Merged revisions 33168 via svnmerge from
...
https://www.dev.java.net/svn/hudson/branches/rc
........
r33168 | kohsuke | 2010-07-22 10:42:12 -0700 (Thu, 22 Jul 2010) | 1 line
fixed a silly compilation problem
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33169 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-22 17:46:55 +00:00
kohsuke
8809bea8a5
report the exit code.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33148 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-22 03:01:05 +00:00
mindless
6999c607f8
[FIXED HUDSON-6880] patch from jeroen_muis to fix autoinstall of JDK with
...
windows master and linux slave. I applied same change for reverse situation.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33136 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-21 22:41:15 +00:00
mindless
7b109f7892
javadoc
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33116 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-21 15:55:48 +00:00
mindless
8b2617b6e6
[FIXED HUDSON-6394] use EnvVars to expand parameters in recipient list
...
(not just ParametersAction), don't overwrite the field in this object (!)
when parameters are expanded, and note that parameters are supported in
the help text.
Also correct the help text that mentions when email is sent.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33098 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-21 01:34:23 +00:00
mindless
7414c3ed21
[FIXED HUDSON-6348] avoid NPE in log from Functions.getCrumb when hudson
...
start fails and error page is being shown.
Also fix message on NoHomeDir error page to show dir instead of {0}
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33085 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-20 22:04:01 +00:00
mindless
37e9b61ab5
[FIXED HUDSON-7004] Make /buildWithParameters support remote cause and
...
user supplied cause text for build via authentication token, just as /build does.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33032 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-18 15:46:55 +00:00
kohsuke
89c437c877
allowing PluginStrategy to create subtypes.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32980 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-16 23:17:09 +00:00
kohsuke
f2248620af
Reduced the time it takes to provision a new node if the # of existing slaves is small.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32935 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-15 21:03:44 +00:00
mindless
81b3603c13
[FIXED HUDSON-6966] Plugins with dependencies show wrong description on
...
installed plugins page. DependencyClassLoader checks dependencies before
this plugin, so wrong index.jelly is found for plugins with dependencies.
Added implementation of findResources in DependencyClassLoader, and use
getResources to find the right index.jelly in PluginWrapper.getIndexPage().
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32876 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-14 16:32:26 +00:00
kohsuke
ad1c0a0b1b
<input type='hidden'> field shouldn't be getting the plain text password value.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32853 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-14 00:52:58 +00:00
kohsuke
54f7372279
Added a CLI command that can be used from inside a build to set the build status.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32828 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-13 01:30:45 +00:00
kohsuke
dca3317d86
Added a mechanism to register CLI option handler as an extension point.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32827 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-13 01:29:15 +00:00
kohsuke
45721b0e99
Remember the current CLICommand that's being executed.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32817 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-12 23:50:27 +00:00
mindless
24408ed660
[FIXED HUDSON-6649] doQuietDown was sychronized, so safeRestart (calling doQuietDown
...
in blocking mode since 1.361) was locking Hudson object until all jobs complete!
Now synchronize just to set isQuietingDown flag, but not while blocking.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32805 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-12 22:26:04 +00:00
kohsuke
3ffa939891
Show outline structure for Ant execution in the console output view.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32581 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-08 01:44:34 +00:00
kohsuke
52838e1313
doc improvement
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32559 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-07 18:24:31 +00:00
kohsuke
c7a5a555e5
added additional methods to expose the pending state.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32533 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 23:34:20 +00:00
kohsuke
ecfbd6a0d4
better documenting my intention in rev.32528.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32531 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 22:45:26 +00:00
kohsuke
e9463136f2
follow up to rev.31906. I think this was breaking the atomicity.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32528 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 22:17:55 +00:00
kohsuke
fe042a4998
<li class=rfe>
...
Hudson can now remotely install JDK on Windows slaves when connecting via the
"Let Hudson control this Windows slave as a Windows service" mode.
<li class=rfe>
The "Let Hudson control this Windows slave as a Windows service" mode now allows the same Windows slave
to be used by multiple Hudson masters.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32525 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 17:46:53 +00:00
kohsuke
941559c98c
[FIXED HUDSON-6034] plain text console output needs to filter out inline console annotations
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32514 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 02:12:06 +00:00
StevenGBrown
a0c958b61f
[FIXED HUDSON-6896] The correct file name is now provided when a file parameter is uploaded via the CLI.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32421 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-01 13:30:12 +00:00
mindless
257aa0d992
use "command" as name for shell/batchfile textarea in the form,
...
so the @DataBoundConstructor on these classes can work.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32397 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 17:37:12 +00:00
kohsuke
570e3e6bc0
added another convenience method.
...
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32396 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 15:45:26 +00:00