Commit Graph
4640 Commits
Author SHA1 Message Date
kohsuke dca3317d86 Added a mechanism to register CLI option handler as an extension point.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32827 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-13 01:29:15 +00:00
kohsuke 45721b0e99 Remember the current CLICommand that's being executed.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32817 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-12 23:50:27 +00:00
mindless 24408ed660 [FIXED HUDSON-6649] doQuietDown was sychronized, so safeRestart (calling doQuietDown
in blocking mode since 1.361) was locking Hudson object until all jobs complete!
Now synchronize just to set isQuietingDown flag, but not while blocking.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32805 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-12 22:26:04 +00:00
kohsuke 3ffa939891 Show outline structure for Ant execution in the console output view.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32581 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-08 01:44:34 +00:00
kohsuke 52838e1313 doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32559 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-07 18:24:31 +00:00
kohsuke c7a5a555e5 added additional methods to expose the pending state.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32533 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 23:34:20 +00:00
kohsuke ecfbd6a0d4 better documenting my intention in rev.32528.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32531 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 22:45:26 +00:00
kohsuke e9463136f2 follow up to rev.31906. I think this was breaking the atomicity.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32528 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 22:17:55 +00:00
kohsuke fe042a4998 <li class=rfe>
Hudson can now remotely install JDK on Windows slaves when connecting via the
    "Let Hudson control this Windows slave as a Windows service" mode.
  <li class=rfe>
    The "Let Hudson control this Windows slave as a Windows service" mode now allows the same Windows slave
    to be used by multiple Hudson masters.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32525 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 17:46:53 +00:00
kohsuke 941559c98c [FIXED HUDSON-6034] plain text console output needs to filter out inline console annotations
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32514 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 02:12:06 +00:00
StevenGBrown a0c958b61f [FIXED HUDSON-6896] The correct file name is now provided when a file parameter is uploaded via the CLI.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32421 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-01 13:30:12 +00:00
mindless 257aa0d992 use "command" as name for shell/batchfile textarea in the form,
so the @DataBoundConstructor on these classes can work.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32397 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 17:37:12 +00:00
kohsuke 570e3e6bc0 added another convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32396 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 15:45:26 +00:00
kohsuke 66b9d9baaf fixed a possible security issue (SECURITY-3)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32394 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 15:31:02 +00:00
StevenGBrown f756ddae48 [FIXED HUDSON-6889] FileParameterValue now creates the directory that the file parameter is copied into, since DiskFileItem does not.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32393 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 15:21:33 +00:00
mindless bbf53fc98b add system property to set auto refresh interval
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32336 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-28 22:31:48 +00:00
mindless 9083e5d6e6 [HUDSON-6849] revert r32272.. might as well keep URLs a little shorter
until/unless this issue is better understood.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32325 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-28 03:18:23 +00:00
mindless 6ce5b797cc [FIXED HUDSON-6832] Hide some sidepanel links that should not be shown in
user-private views.  Use it="${app}" for Manage Hudson and New Job links,
so these check the proper permission.  Replaced !it.isDefault() check
with new ViewGroup.canDelete API call.. Hudson ViewGroup uses isDefault()
for this method; MyViewsProperty checks views.size() > 1 so link is
hidden when there is only one user-private view.
Used !=false in jelly for backward compatibility (if a plugin implements
ViewGroup but does not have canDelete, null!=false will result in true).


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32319 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-27 18:31:50 +00:00
kutzi 40ffa913f8 [FIXED HUDSON-6543] use last 3 builds to calculate estimated remaining build time
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32310 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-26 13:37:56 +00:00
km f1b4cf47de [FIXED HUDSON-6849]
Go to getDescriptorByName rather than getDescriptor to get the help files. This is useful in
situations where Hudson instance is not the root of the webapp.



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32272 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 23:03:56 +00:00
kohsuke 3216dface6 [FIXED HUDSON-6819] Here is the race condition that induces this problem.
- Task X becomes buildable
- Thread E1 enters the pop() method, assigns X to an executor E2.
  Note that at this point X is not removed from the buildables list yet
- Thread E1 goes to offer.event.block and blocks, losing the lock
- Thread E3 enters the pop() method, assigns X to anogher executor E4.
  This is possible because X is still in the buildables list.
- Thread E3 goes to offer.event.block  and blocks, losing the lock.
- Thread E2 wakes up, obtains the lock and execute the rest of the
  pop() method. It decides that it's assigned X, it removes X from
  the buildables list.
- Thread E2 leaves the pop() method, loses the lock, and starts building X
- Thread E4  wakes up, obtains the lock, and executes the rest of the
  pop() method. It decides that it's assigned X. It tries to remove X
  from the buildables list. This remove operation becomes no-op,
  but we don't check that.
- Thread E4 leaves the pop(), and start building X.

Thus we end up building X twice.

To avoid this problem, I've introduced the 4th state "pending", and moves BuildableItem from buildables to pendings as soon as we assigned it to the executor. New BuildableItem cannot be created
while its another copy is either in the buildables or pendings state.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32258 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 01:40:12 +00:00
kohsuke b2df57e4f0 [FIXED HUDSON-6497] slightly revised the patch, to avoid using a boolean flag for a concurrency control. It affects the serialization format, and it's not concurrency safe.
Given the use case described in the bug, I wonder if it's better to have a different extension point (sort of like ComputerListener) that can contribute build variables to any builds going on in the system.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32257 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 00:47:03 +00:00
kohsuke 59317c93fb [HUDSON-6819] tweaking the implementation a bit so that the code never ever have multiple edges between the same src and dst.
Not that I was able to spot where the previous code did that, but this implementation is bit more straightforward.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32256 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 00:17:13 +00:00
kohsuke 46f7945813 value equality unnecessary
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32255 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-23 23:21:34 +00:00
jglick 33f7ed732f [FIXED HUDSON-6824] Statically held fields should be of type Localizable rather than String.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32240 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-22 20:10:59 +00:00
GLundh 0aaa0fa5b0 [FIXED HUDSON-6787] If a suitable truncable index cannot be found, force a trunc at maxTruncLength.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32224 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-22 09:24:08 +00:00
jglick b83a335e85 Fixed typo.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32205 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-21 16:52:34 +00:00
wyukawa b0cdf1eb2e fix link of Apache Ant FileSet URL
from http://ant.apache.org/manual/CoreTypes/fileset.html
to http://ant.apache.org/manual/Types/fileset.html

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32164 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-19 06:45:26 +00:00
mode 6f1cdeda56 Merged revisions 32154-32155,32157 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r32154 | kohsuke | 2010-06-18 20:38:45 -0700 (Fri, 18 Jun 2010) | 1 line
  
  fixed a bug in the logic of aggregating multiple dependency edges.
........
  r32155 | kohsuke | 2010-06-18 21:41:33 -0700 (Fri, 18 Jun 2010) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_363
........
  r32157 | kohsuke | 2010-06-18 21:41:47 -0700 (Fri, 18 Jun 2010) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32161 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-19 05:35:41 +00:00
jacob_robertson 1a48b12f46 ViewJobFilter - finalizing api
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32116 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-17 16:47:13 +00:00
mindless aad53296de [FIXED HUDSON-6431] set system privilege during task
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32088 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-16 17:57:03 +00:00
jglick 1d5dbd8a03 [FIXED HUDSON-5551] Keep track of which JDK we have installed, so it is possible to upgrade without changing the tool's name.
Note that this will force a redownload of the JDK in everyone's installation, even if it was already the right version; irritating but probably unavoidable.
(Could compare to `java -version` but this would require parsing code to compare download IDs with self-reported versions.)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32082 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 23:50:51 +00:00
jglick 2bd01adb61 [FIXED HUDSON-6559] Proc.joinWithTimeout convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32076 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 22:19:57 +00:00
kohsuke da612c83c5 "who am I?" page should be visible to everyone.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32073 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 21:22:50 +00:00
kohsuke e3fab71cdf eliminated the exception handling by using the Failure class.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32055 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 18:52:34 +00:00
kohsuke 12c4cc253d added a hook to customize custom node creation.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32052 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 18:00:18 +00:00
kohsuke 1b441d4579 moved the method to the right place.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32048 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 17:41:29 +00:00
kohsuke 2755df4d01 added a convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32047 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 17:36:23 +00:00
mdillon 97c46cf8df Fix close tag of <dl> that was breaking Javadocs
Flag summary.jelly view as optional in the NodeProperty Javadocs


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32015 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-14 01:47:45 +00:00
mdillon 8a9fc58a7f Mention summary.jelly view from HUDSON-6753 in the Javadocs
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32014 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-14 01:13:08 +00:00
sogabe f7faf4b8e8 Fixed exception without uploaded Plugin.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32004 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-13 12:35:50 +00:00
kohsuke e5768ba850 Don't mask the cause of the checkout related exception.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31978 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-12 03:11:42 +00:00
kohsuke 0f12b8401a Cache downloaded JDKs.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31944 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-11 03:04:45 +00:00
mindless 0d53810761 [FIXED HUDSON-5981] allow plugins to add self-referencing project dependencies
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31935 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-10 23:34:41 +00:00
mindless 2bb5df0105 [FIXED HUDSON-5708] collect multiple dependencies between same 2 projects into
a DependencyGroup container; container checks each collected dependency and
returns when the first one returns true for shouldTriggerBuild.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31934 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-10 23:27:37 +00:00
kohsuke 74b6916f22 doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31921 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-10 18:24:33 +00:00
jacob_robertson d83325725e [FIXED HUDSON-6739] ViewJobFilter - provide extension point to allow for more ways to filter jobs for a view
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31916 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-10 11:44:07 +00:00
jacob_robertson 625c657a47 [FIXED HUDSON-6739] ViewJobFilter - provide extension point to allow for more ways to filter jobs for a view
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31915 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-10 11:43:28 +00:00
kohsuke 7bc7bbec83 Merged revisions 31912-31913 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r31912 | kohsuke | 2010-06-09 22:13:50 -0700 (Wed, 09 Jun 2010) | 1 line
  
  fixed a test failure
........
  r31913 | kohsuke | 2010-06-09 22:41:02 -0700 (Wed, 09 Jun 2010) | 1 line
  
  fill in CLICommand basics
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31914 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-10 06:01:17 +00:00
kohsuke 902803df33 [FIXED HUDSON-5752] Avoid pointless and harmful redirection when downloading slave.jar.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31911 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-10 04:22:10 +00:00