Commit Graph
582 Commits
Author SHA1 Message Date
Jesse Glick 0a9b638280 Added a tool to reverse the build directory migration if required. 2014-12-15 14:26:36 -05:00
Jesse Glick 0cd13e9670 Compilability fix. 2014-12-12 14:59:03 -05:00
Jesse Glick 7c988de3cd Merge branch 'master' into build-number-is-id-JENKINS-24380 2014-12-12 13:27:31 -05:00
Stephen Connolly 8e5a92d8e6 remove trailing whitespace and tabs 2014-12-03 17:02:18 +00:00
Jesse Glick 534328b264 [FIXED JENKINS-25759] Avoid consuming too much memory while running validateAntFileMask.
Not fully solved, since the scannedDirs field can still grow to be large, but at least clearing files/dirsNotIncluded.
Also imposing a 5s timeout on the scan regardless of file count, and defining a user-customizable bound.
2014-11-24 10:37:58 -05:00
Jesse Glick b76e7bf998 [FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results.
Caused a failure in hudson.plugins.promoted_builds.conditions.ManualConditionTest.testManualPromotionProcessViaWebClient when run against 1.580.1.
2014-11-17 17:48:48 -05:00
Oliver Gondža 34850200b2 Introduce FormValidation#aggregate 2014-11-07 09:20:06 +01:00
Oliver Gondža 12ff0b249a Junit 4 2014-11-06 12:30:33 +01:00
Jesse Glick f0658e233d Merge branch 'security-rc' into SECURITY-144-rc
Conflicts:
	core/src/main/java/hudson/FilePath.java
2014-10-26 13:55:39 -07:00
Oleg Nenashev e80fa118aa Merge pull request #1411 from synopsys-arc-oss/JENKINS-19017
[FIXED JENKINS-19017] - FileParameter - Handle non-null file parameters as different values
2014-10-19 23:28:14 +04:00
Oleg Nenashev cc06ae78e3 [JENKINS-19017] - Unit tests
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-10-18 22:03:28 +04:00
Jesse Glick ccbe96227f Merge branch 'security-rc' into SECURITY-144-rc
Conflicts:
	core/src/main/java/hudson/FilePath.java
	pom.xml
2014-10-16 13:18:08 -04:00
Daniel Beck daacb02057 [JENKINS-16184] Also escape greater-than character 2014-10-09 00:38:22 +02:00
Jesse Glick 89cbfc4639 Merge branch 'SECURITY-144' into SECURITY-144-rc
Conflicts:
	core/src/main/java/hudson/EnvVars.java
	core/src/main/java/hudson/FilePath.java
	core/src/main/java/hudson/cli/ClientAuthenticationCache.java
	core/src/main/java/hudson/markup/MyspacePolicy.java
	core/src/main/java/hudson/model/Computer.java
	core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java
	core/src/main/java/hudson/node_monitors/ResponseTimeMonitor.java
	core/src/main/java/hudson/node_monitors/TemporarySpaceMonitor.java
	core/src/main/java/hudson/security/AbstractPasswordBasedSecurityRealm.java
	core/src/main/java/hudson/slaves/Channels.java
	core/src/main/java/hudson/slaves/SlaveComputer.java
	core/src/main/java/hudson/tasks/Fingerprinter.java
	core/src/main/java/hudson/tasks/Shell.java
	core/src/main/java/hudson/tasks/junit/JUnitParser.java
	core/src/main/java/hudson/tasks/test/DefaultTestResultParserImpl.java
	core/src/main/java/hudson/util/ProcessTree.java
	core/src/main/java/hudson/util/RemotingDiagnostics.java
	core/src/main/java/jenkins/model/Jenkins.java
	core/src/test/java/hudson/LauncherTest.java
	pom.xml
	test/src/test/java/hudson/tasks/junit/CaseResultTest.java
2014-09-26 15:56:48 -04:00
Kohsuke Kawaguchi ffb5b65093 Switched from annotation based scheme to a function based scheme. 2014-09-23 19:12:43 -07:00
Kohsuke Kawaguchi c0260056e5 in pre-cursor for the next change, make all remoting call go through FileCallable 2014-09-23 14:53:31 -07:00
Kohsuke Kawaguchi 6a2b879262 Revisiting 9b7b1364c0 a bit.
Since ConsistentHash is written as a mutable class, I think a better way to fit the existing design is to provide a bulk add operation.
It already has several methods to that end, so I just added one more that's needed for our purpose.
2014-09-05 10:45:42 -07:00
Jesse Glick cb6e568815 [FIXED JENKINS-23522] Defend against stack overflows when a listener (unnecessarily) called super from a deprecated method.
Fixes #1295 a little differently.
2014-08-29 18:16:19 -04:00
Jesse Glick 843d238723 Added RunIdMigrator. 2014-08-27 15:04:45 -04:00
Jesse Glick 1ede3e9833 Defend against out-of-order builds even if nextBuildNumber is wrong. 2014-08-27 11:00:39 -04:00
Jesse Glick 6d2e3ae5cb Initial sketch of replacement of Run.id by number.
Does not yet deal with migrating historical records.
2014-08-21 18:18:25 -04:00
Jesse Glick df4ba0d82c Trying to make testRemoteKill less prone to random failure (presumably on a heavily loaded machine). 2014-08-21 10:25:58 -04:00
Jesse Glick 16197ea502 [FIXED JENKINS-23263] JUnit reporter moved to a plugin. 2014-08-11 13:45:23 -04:00
Jesse Glick 1239ed3bd9 Merge commit '16f2c7af0122a4f3cfd709bd44d9b5402a6ec8bf' into security
Updating branch base to 1.532.
2014-07-30 17:39:01 -07:00
tfennelly 42190ed977 <l:icon> tag 2014-07-30 15:52:15 +01:00
Daniel Beck 5751560fc1 Merge pull request #1251 from daniel-beck/JENKINS-14583
[FIX JENKINS-14538] Improve builds dir input validation
2014-07-26 13:32:27 +02:00
Jesse Glick b25e8e54dc Introduced Run.StatusSummarizer extension point so that Run need not refer directly to AbstractTestResultAction. 2014-07-22 17:47:35 -04:00
Jesse Glick 37c5bc2fd8 Deprecating getTestResultAction as an unwanted link from the model package to hudson.tasks.test package. 2014-07-22 10:22:17 -04:00
Jesse Glick 2f58ceb1a6 [JENKINS-18065] Uncommenting original test.
The actual implementation does not behave as nicely as one would hope, for a few reasons:
1. isEmpty actually tries to load the newestBuild, rather than simply checking whether there is some idOnDisk.
   Arguably this is necessary, since there could be an unloadable build record, in which case it would be technically correct for the map to be considered empty.
2. Loading AbstractLazyLoadRunMap.newestBuild calls search(MAX_VALUE, DESC), which behaves oddly, by doing a binary search, and thus perhaps loading lg(|map|) entries.
   You would think that it would suffice to check for the last member of idOnDisk in index.byId.
3. The iterator eagerly loads the next value before hasNext has even been called.
   Looks bad in a test, though it probably has little practical impact since most callers would be calling hasNext soon afterward anyway.
   Might cause one extra build record to be loaded unnecessarily from a limited RunList.
2014-07-11 17:17:45 -04:00
Kohsuke Kawaguchi 54c084613f [FIXED JENKINS-18065] made ALLRM.entrySet() smarter 2014-07-11 12:03:11 -07:00
Daniel Beck 50cbded7f8 [JENKINS-14583] Fix tests 2014-06-30 03:16:48 +02:00
Jesse Glick cffe9df017 [FIXED JENKINS-23294] Deal with X-Forwarded-Port.
If this is set, use it instead of ServletRequest.getServerPort() for purposes of getRootUrlFromRequest().
Also treat the default port as scheme-specific in that method (which presumes that we in fact got the reported port right).
And enhance the reverse proxy setup monitor to validate that the Referer header (/manage)
actually matches what we have computed from getRootUrlFromRequest;
if it does not, something is messed up, though it may require some digging to find what.
(Would be better to let the monitor specify the exact problem it determined,
though this is not always actually possible;
for example if you are missing AllowEncodedSlashes NoDecode in Apache,
you just get a 404 from Apache without even getting to Jenkins.)
2014-06-19 14:05:28 +01:00
Jesse Glick 5396f51546 1197e0c required mocking Item.getName(). 2014-06-11 16:46:19 -04:00
Jesse Glick 76c7cdea5a Improved robustness of RunParameterValue so it does not break the REST API when there is invalid data.
Observed in 1.554.1:
java.lang.ArrayIndexOutOfBoundsException: 1
        at hudson.model.RunParameterValue.getNumber(RunParameterValue.java:63)
2014-06-11 12:59:35 -04:00
Oliver Gondža 9402bd82cd Merge pull request #1229 from synopsys-arc-oss/CLI_null_ParameteValue
[READY][FIXED JENKINS-15094] - Handle null parameter values to avoid massive executor deaths
2014-06-01 17:24:44 +02:00
Oleg Nenashev cd23fac995 [JENKINS-15094] - Unit tests for the issue
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-05-31 23:38:02 +04:00
Jesse Glick 2ff7a905ac [FIXED JENKINS-22822] PeepholePermalink should maintain an in-memory cache of symlinks to avoid disk I/O. 2014-05-27 22:10:57 -04:00
Daniel Beck a72c9f7766 [FIX JENKINS-14538] Improve builds dir input validation 2014-05-24 14:58:27 +02:00
Jesse Glick cb0743412b Merge branch 'JENKINS-22839-Improvements' of github.com:daniel-beck/jenkins 2014-05-02 11:14:34 -04:00
Daniel Beck 11fd480fec [JENKINS-22839] Style changes after feedback 2014-05-02 17:09:15 +02:00
Jesse Glick 98ccd9d620 Merge branch 'JENKINS-22839' of github.com:daniel-beck/jenkins 2014-05-02 10:59:46 -04:00
Daniel Beck 92cd35f0e3 [FIXED JENKINS-22839] Allow clearing log recorders. 2014-05-02 01:32:29 +02:00
Jesse Glick 3f2958795c ${h.breakableString(…)} might be called with a null argument if something is broken.
For robustness, pass on the null to Jelly rather than failing page rendering.
2014-04-30 18:19:17 -04:00
Kohsuke Kawaguchi d5c368dd8e Merge branch 'pull-714' 2014-04-19 18:31:09 -07:00
Kohsuke Kawaguchi 52b2571126 Merge pull request #737
Conflicts:
	core/src/main/java/hudson/model/UpdateCenter.java
2014-04-19 16:42:31 -07:00
Jesse Glick b6b7bfd27c [FIXED JENKINS-22681] Fix of JENKINS-19418 should have used getById, not load, to avoid reloading the last build gratuitously. 2014-04-18 18:36:55 -04:00
Oliver Gondža a7eb8b7eb3 Merge pull request #1195 from daniel-beck/JENKINS-22670
[FIXED JENKINS-22670] Less aggressive word breaking
2014-04-18 19:20:55 +02:00
Daniel Beck 35b0094137 [FIXED JENKINS-22670] Less aggressive word breaking 2014-04-17 21:49:15 +02:00
Jesse Glick 04aace98d1 Extracting some miscellaneous usages from core/src. 2014-04-14 19:47:20 -04:00
Jesse Glick 4aad749cbe Removing hudson.matrix classes and associated resources as a first pass. 2014-04-14 19:03:29 -04:00