Commit Graph
395 Commits
Author SHA1 Message Date
Ramon Leon e3b17eff92 [JENKINS-63563] Avoid anonymous class warning for hudson.FilePath$2 (#4921) 2020-09-03 17:23:35 +02:00
Daniel BeckandDaniel Beck c632f42f07 Update at-since Javadoc (#4877)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-08-01 08:33:48 +01:00
Tim Jacomb e9dc2694db JENKINS-41805 Cleanup workspace suffixes (#4824) 2020-07-06 19:37:30 +01:00
James Nord bdcb2fb222 Merge remote-tracking branch 'origin/master' into kill-jsr-305 2020-03-30 12:40:44 +01:00
Tim Jacomb 7b4eab92d1 Merge pull request #4507 from res0nance/static-inner
Static nested classes
2020-03-28 09:04:59 +00:00
James Nord 1f946961b9 s/javax.annotation.CheckForNull/edu.umd.cs.findbugs.annotations.CheckForNull/g 2020-03-26 16:12:35 +00:00
James Nord 819f80b12f s/javax.annotation.Nonnull/edu.umd.cs.findbugs.annotations.NonNull/g 2020-03-26 11:14:41 +00:00
James Nord a7fcc8e447 s/javax.annotation.Nullable/edu.umd.cs.findbugs.annotations.Nullable/g 2020-03-26 11:11:22 +00:00
Jesse Glick 06712954c2 [JENKINS-61197] Skip $WORKSPACE_TMP for root directories (#4527)
* [JENKINS-61197] Skip $WORKSPACE_TMP for root directories

* Documenting amended behavior

* Javadoc
2020-02-29 13:31:23 +01:00
Raihaan Shouhell f8f5b25a68 Static nested classes 2020-02-19 15:43:26 +08:00
55b2bc7f3f [JEP-223] Overall/Manage permission
Co-Authored-By: Esther Alvarez Feijoo <ealvarez@cloudbees.com>
Co-Authored-By: aHenryJard <ajard@cloudbees.com>
Co-Authored-By: michael cirioli <mikecirioli@gmail.com>
2020-02-14 19:37:32 +01:00
Oleg Nenashev a0da4a8fd0 Merge pull request #4459 from thomasgl-orange/buffered-streams-in-TarCompression-NONE
[JENKINS-60907] add Buffered{In,Out}putStream to FilePath.TarCompression.NONE
2020-02-06 04:44:02 -05:00
Thomas de Grenier de Latour 4be9f741c1 Buffered{In,Out}putStream in FilePath.TarCompression.NONE 2020-01-29 17:38:49 +01:00
Stefan Spieker 40206e023c removed some redundant constructs and replaced stringbuilder operations with too few arguments with string concatenation 2019-11-24 16:15:20 +01:00
Oleg Nenashev 41a13dffc6 Merge pull request #4308 from basil/javadoc
Javadoc cleanup
2019-11-01 01:30:33 +03:00
Basil Crow 861855953b Replace <code>…</code> with {@code …} 2019-10-19 14:02:59 -07:00
Daniel Beck fdb6faed00 Update at-since in Javadoc, make script work on Mac OS X 2019-10-16 12:22:03 +02:00
Oleg Nenashev c1dacc10e2 Merge pull request #4205 from slonopotamus/disable-artifact-manager-gzip
[JENKINS-26008] Add an option to disable gzip compression for StandardArtifactManager
2019-09-21 02:56:44 +02:00
Anders Hammar 5c10c6c055 Improved handling when TaskListener is null (#4201) 2019-09-20 09:35:17 +02:00
Marat Radchenko 91b0ed3e5f [JENKINS-26008] Add an option to disable gzip compression for StandardArtifactManager
1. There are cases where saving CPU is more important than network bandwidth between Jenkins master and slaves
2. According to benchmarks[1], gzip compression is unable to saturate 1Gbps network even on high-end desktop CPUs,
so can easily become a bottleneck.

[1]: https://github.com/lz4/lz4#benchmarks
2019-09-19 13:25:36 +03:00
Raihaan Shouhell 89702627a2 Fix annotations and remove unused imports (#4190) 2019-09-07 22:57:04 +02:00
Gustavo de Souza Bezerra 0e62b68012 [JENKINS-57678] - Change getInstance() (deprecated) to get() (#4042)
* Change getInstance() (deprecated) to get()

* Reverting modifications according review

* Changing for use the variable
2019-06-27 17:24:45 +02:00
Josh SorefandDaniel Beck e851b5e024 Show empty statement by putting the semicolon on its own line - FilePath.normalize
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2019-05-14 10:58:34 -04:00
Josh Soref 36fa47add2 noinspection StatementWithEmptyBody 2019-02-20 23:15:14 -05:00
Josh Soref 5e0288b86b StringBuilder 2019-02-20 22:22:19 -05:00
Jesse Glick 7054610887 [JENKINS-57244] FilePath (de)serialization via XStream is unsupported but should not be fatal (#4011)
* [JENKINS-57244] FilePath (de)serialization via XStream is unsupported but should not be fatal.

* Factoring out a _getChannelForSerialization with a friendlier message and a redirect.
2019-05-05 16:25:01 +02:00
Jesse Glick 7c3810a82e Merge branch 'refactoring/JENKINS-47896-serializableOnlyOverRemoting' of github.com:oleg-nenashev/jenkins into SerializableOnlyOverRemoting-JENKINS-47896 2019-04-11 15:58:57 -04:00
Baptiste Mathus 58dfce4b1c Merge pull request #3425 from aviadatsnyk/patch-1
[JENKINS-56931] handle absolute paths correctly when unzipping
2019-04-08 21:51:12 +02:00
Josh Soref 264980c707 Java 7: omit explit type in favor of <> 2019-02-20 21:51:03 -05:00
Wadeck Follonier 5562b2fec6 [JENKINS-56114] Correct behavior for Windows Server 2016 with Docker (#3914)
* [JENKINS-56114] Correct behavior for Windows Server 2016 with Docker
- also adjust the symlink escape hatch

* Correct missing space + retrigger build

* Improve performance with a check on the logger level

* Run the specific code only under Windows

* Rename the method as it's used only for Windows
2019-03-08 10:19:07 +01:00
Josh Soref bd8091cf57 Drop useless local variables 2019-02-20 19:18:09 -05:00
Josh Soref b7e83565fd Java 5: contains 2019-02-20 18:18:23 -05:00
Josh Soref c3fc2b70d0 refactor throwIOwithCause 2019-02-20 17:49:51 -05:00
Josh Soref 8ee908977a Drop superfluous Suppression
getEntries returns a new object or throws
2019-02-20 17:49:26 -05:00
Wadeck Follonier 2f8b557a3b [JENKINS-55050] Reduce performance impact of SEC-904 (esp. zip) (#3861)
* [JENKINS-55050] Reduce log impact on performance
- especially in case of large / deep folder that is fully illegal
- could reduce time by a factor of around 2.

* Use SystemProperties

* [JENKINS-55050] Reduce performance impact of the security release
- SEC-904 increased the time taken to zip files from
DirectoryBrowserSupport views (workspace / artifact)
- This PR proposes a different approach for some of the highly impact scenario

* Update core/src/main/java/jenkins/util/VirtualFile.java

Co-Authored-By: Wadeck <Wadeck@users.noreply.github.com>

* Return in case of interruption instead of continuing
- The interruption status flag is not really respected otherwise

* Update core/src/main/java/jenkins/util/VirtualFile.java

Co-Authored-By: Wadeck <Wadeck@users.noreply.github.com>

* Improve ZipEntry writing
- Add logging on FileSystemException

* Minor refactoring in DirScanner

* Correct conjugation, size for arraylist and dead code removal

* Adjust the PR using the feedbacks

* Adjust the PR using the feedbacks (part 2)

* Adjust the PR using the feedbacks (part 3)
2019-02-08 06:44:29 +01:00
Oleg Nenashev 34fb3c86c7 [JENKINS-47896] - Allow FilePath with null channel to be serialized anywhere 2019-02-03 02:06:41 +01:00
Oleg Nenashev 78423ca292 [JENKINS-47896] - Add some diagnostics for the failing channel comparison in FilePath 2019-01-31 01:47:50 +01:00
Oleg Nenashev ab4cd01a8f Merge branch 'master' into refactoring/JENKINS-47896-serializableOnlyOverRemoting 2019-01-28 16:48:09 +01:00
Oleg Nenashev ca6361e259 Update FilePath.java 2019-01-25 17:15:15 +01:00
Jesse Glick dca272db6b Removing gratuitous catch of InvalidPathException. 2019-01-24 08:28:03 -05:00
Jesse Glick 479bf62c86 Javadoc 2019-01-23 16:34:51 -05:00
Jesse Glick 7090b3747a More consistent use of Util.fileToPath from FilePath methods. 2019-01-23 14:47:14 -05:00
Jesse Glick ea7cade101 Optimize FilePath.readToString. 2019-01-23 14:46:22 -05:00
Matt Sicker 84b1193378 Use explicit functional interface for path checking
Signed-off-by: Matt Sicker <boards@gmail.com>
2019-01-10 14:10:32 -06:00
Matt Sicker 59880c2fcd Add path filter support to PathRemover
This allows for simplifying FilePath to use PathRemover rather than duplicating logic.

Signed-off-by: Matt Sicker <boards@gmail.com>
2019-01-10 13:40:17 -06:00
Matt Sicker c05d00ad69 Update FilePath.delete* to use Util.delete*
This reduces duplication of file deletion strategy code and potentially fixes a regression noted in JENKINS-55448.

Signed-off-by: Matt Sicker <boards@gmail.com>
2019-01-10 11:00:54 -06:00
Wadeck Follonier 87cba3d730 Remove windows specific paths 2018-12-10 11:05:49 +01:00
Wadeck Follonier 9e8df1aebc Use different approach for relativize two paths due to Java 11 2018-12-10 10:47:19 +01:00
Daniel Beck 69eacee964 Merge branch 'security-stable-2.138' into security-stable-2.150 2018-11-21 14:25:44 +01:00
Daniel Beck 23ea44f9ae Merge branch 'security-stable-2.121' into security-stable-2.138 2018-11-21 14:22:28 +01:00