Josh Soref and Daniel Beck
e851b5e024
Show empty statement by putting the semicolon on its own line - FilePath.normalize
...
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com >
2019-05-14 10:58:34 -04:00
Josh Soref
36fa47add2
noinspection StatementWithEmptyBody
2019-02-20 23:15:14 -05:00
Josh Soref
5e0288b86b
StringBuilder
2019-02-20 22:22:19 -05:00
Jesse Glick
7054610887
[JENKINS-57244] FilePath (de)serialization via XStream is unsupported but should not be fatal ( #4011 )
...
* [JENKINS-57244] FilePath (de)serialization via XStream is unsupported but should not be fatal.
* Factoring out a _getChannelForSerialization with a friendlier message and a redirect.
2019-05-05 16:25:01 +02:00
Jesse Glick
7c3810a82e
Merge branch 'refactoring/JENKINS-47896-serializableOnlyOverRemoting' of github.com:oleg-nenashev/jenkins into SerializableOnlyOverRemoting-JENKINS-47896
2019-04-11 15:58:57 -04:00
Baptiste Mathus
58dfce4b1c
Merge pull request #3425 from aviadatsnyk/patch-1
...
[JENKINS-56931] handle absolute paths correctly when unzipping
2019-04-08 21:51:12 +02:00
Josh Soref
264980c707
Java 7: omit explit type in favor of <>
2019-02-20 21:51:03 -05:00
Wadeck Follonier
5562b2fec6
[JENKINS-56114] Correct behavior for Windows Server 2016 with Docker ( #3914 )
...
* [JENKINS-56114] Correct behavior for Windows Server 2016 with Docker
- also adjust the symlink escape hatch
* Correct missing space + retrigger build
* Improve performance with a check on the logger level
* Run the specific code only under Windows
* Rename the method as it's used only for Windows
2019-03-08 10:19:07 +01:00
Josh Soref
bd8091cf57
Drop useless local variables
2019-02-20 19:18:09 -05:00
Josh Soref
b7e83565fd
Java 5: contains
2019-02-20 18:18:23 -05:00
Josh Soref
c3fc2b70d0
refactor throwIOwithCause
2019-02-20 17:49:51 -05:00
Josh Soref
8ee908977a
Drop superfluous Suppression
...
getEntries returns a new object or throws
2019-02-20 17:49:26 -05:00
Wadeck Follonier
2f8b557a3b
[JENKINS-55050] Reduce performance impact of SEC-904 (esp. zip) ( #3861 )
...
* [JENKINS-55050] Reduce log impact on performance
- especially in case of large / deep folder that is fully illegal
- could reduce time by a factor of around 2.
* Use SystemProperties
* [JENKINS-55050] Reduce performance impact of the security release
- SEC-904 increased the time taken to zip files from
DirectoryBrowserSupport views (workspace / artifact)
- This PR proposes a different approach for some of the highly impact scenario
* Update core/src/main/java/jenkins/util/VirtualFile.java
Co-Authored-By: Wadeck <Wadeck@users.noreply.github.com >
* Return in case of interruption instead of continuing
- The interruption status flag is not really respected otherwise
* Update core/src/main/java/jenkins/util/VirtualFile.java
Co-Authored-By: Wadeck <Wadeck@users.noreply.github.com >
* Improve ZipEntry writing
- Add logging on FileSystemException
* Minor refactoring in DirScanner
* Correct conjugation, size for arraylist and dead code removal
* Adjust the PR using the feedbacks
* Adjust the PR using the feedbacks (part 2)
* Adjust the PR using the feedbacks (part 3)
2019-02-08 06:44:29 +01:00
Oleg Nenashev
34fb3c86c7
[JENKINS-47896] - Allow FilePath with null channel to be serialized anywhere
2019-02-03 02:06:41 +01:00
Oleg Nenashev
78423ca292
[JENKINS-47896] - Add some diagnostics for the failing channel comparison in FilePath
2019-01-31 01:47:50 +01:00
Oleg Nenashev
ab4cd01a8f
Merge branch 'master' into refactoring/JENKINS-47896-serializableOnlyOverRemoting
2019-01-28 16:48:09 +01:00
Oleg Nenashev
ca6361e259
Update FilePath.java
2019-01-25 17:15:15 +01:00
Jesse Glick
dca272db6b
Removing gratuitous catch of InvalidPathException.
2019-01-24 08:28:03 -05:00
Jesse Glick
479bf62c86
Javadoc
2019-01-23 16:34:51 -05:00
Jesse Glick
7090b3747a
More consistent use of Util.fileToPath from FilePath methods.
2019-01-23 14:47:14 -05:00
Jesse Glick
ea7cade101
Optimize FilePath.readToString.
2019-01-23 14:46:22 -05:00
Matt Sicker
84b1193378
Use explicit functional interface for path checking
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2019-01-10 14:10:32 -06:00
Matt Sicker
59880c2fcd
Add path filter support to PathRemover
...
This allows for simplifying FilePath to use PathRemover rather than duplicating logic.
Signed-off-by: Matt Sicker <boards@gmail.com >
2019-01-10 13:40:17 -06:00
Matt Sicker
c05d00ad69
Update FilePath.delete* to use Util.delete*
...
This reduces duplication of file deletion strategy code and potentially fixes a regression noted in JENKINS-55448.
Signed-off-by: Matt Sicker <boards@gmail.com >
2019-01-10 11:00:54 -06:00
Wadeck Follonier
87cba3d730
Remove windows specific paths
2018-12-10 11:05:49 +01:00
Wadeck Follonier
9e8df1aebc
Use different approach for relativize two paths due to Java 11
2018-12-10 10:47:19 +01:00
Daniel Beck
69eacee964
Merge branch 'security-stable-2.138' into security-stable-2.150
2018-11-21 14:25:44 +01:00
Daniel Beck
23ea44f9ae
Merge branch 'security-stable-2.121' into security-stable-2.138
2018-11-21 14:22:28 +01:00
Daniel Beck
748e2f326e
Merge branch 'security-stable-2.107' into security-stable-2.121
2018-11-21 13:52:38 +01:00
Wadeck Follonier
c19cc70568
[SECURITY-904]
2018-11-21 13:41:15 +01:00
Daniel Beck
ef5e4a0145
Merge commit 'edd303e91747380043723c1b4c7dc843b91afa51' into security-master
2018-10-08 08:16:41 +02:00
Daniel Beck
5ddb847d2a
Merge branch 'security-stable-2.138' into security-master
2018-09-27 15:26:44 +02:00
Daniel Beck
9c97530127
Merge branch 'security-stable-2.121' into security-stable-2.138
2018-09-27 15:24:46 +02:00
Daniel Beck
7553c7085e
Merge branch 'security-stable-2.107' into security-stable-2.121
2018-09-27 15:22:01 +02:00
Daniel Beck
dc1f162afb
Merge branch 'security-stable-2.89' into security-stable-2.107
2018-09-27 15:13:29 +02:00
Daniel Beck
5ed93548f8
Merge branch 'security-stable-2.73' into security-stable-2.89
2018-09-27 15:02:34 +02:00
Wadeck Follonier
c3351d2e7c
[SECURITY-1074]
2018-09-27 11:31:06 +02:00
Oleg Nenashev
8598492f19
Ignored Exceptions: use ‘ignored’ to supress IntellijIDEA warnings as suggested by @daniel-beck
2018-09-27 01:23:28 +02:00
Oleg Nenashev
a3cc7780aa
JDK11 support: refactor code to avoid underscore variable names
2018-09-21 16:47:59 -07:00
Daniel Beck
323982abd7
Merge branch 'security-stable-2.121' into security-master
2018-08-01 17:34:32 +02:00
Daniel Beck
f42fe0fc63
[JENKINS-51777] Don't let tar entries escape target dir
...
(cherry picked from commit 7438abb88f )
2018-08-01 09:51:06 +02:00
Oliver Gondža
4cb86a5c30
[FIXED JENKINS-52417] Restrict Beta API removed in weekly: FilePath.copyFromRemotely()
2018-08-01 09:33:31 +02:00
Jesse Glick
1cac1b7a41
[JENKINS-52417] Javadoc clarifications now that INFRA-1600 is cleared up.
2018-07-15 09:53:38 -04:00
Zbynek Konecny
af6dc33ff4
[JENKINS-52325] - If copy of artifact with attributes throws error, retry without attributes ( #3537 )
...
[JENKINS-52325] - If copy of artifact with attributes throws error, retry without attributes
2018-07-13 13:53:49 +03:00
Jesse Glick
3a0c2220d4
[JENKINS-52417] - Removing FilePath.copyFromRemotely ( #3480 )
...
[JENKINS-52417] - Removing FilePath.copyFromRemotely
2018-07-07 11:53:12 +02:00
Oleg Nenashev
1afd9f8c6e
Merge pull request #3482 from daniel-beck/zip-slip-tar
...
[JENKINS-51777] Don't let tar entries escape target dir
2018-06-09 18:00:47 +02:00
Daniel Beck
7438abb88f
[JENKINS-51777] Don't let tar entries escape target dir
2018-06-08 12:20:39 +02:00
Oliver Gondža
d333057442
[FIX JENKINS-51082] Avoid attaching calling stacktrace as that is done by Channel already ( #3417 )
...
(cherry picked from commit 0e5fc86f4f )
2018-06-07 08:36:27 +02:00
Oliver Gondža
0e5fc86f4f
[FIX JENKINS-51082] Avoid attaching calling stacktrace as that is done by Channel already ( #3417 )
2018-06-01 20:04:22 +02:00
Jesse Glick
63fa1785eb
Converting remaining anonymous Callable and FileCallable implementations to named classes. ( #3437 )
2018-06-01 19:40:30 +02:00