Commit Graph
13279 Commits
Author SHA1 Message Date
Tim Jacomb e9dc2694db JENKINS-41805 Cleanup workspace suffixes (#4824) 2020-07-06 19:37:30 +01:00
Jeff Thompson 55d1b9e387 [JENKINS-62889] ParameterDefinition check for validity (#4826) 2020-07-06 07:55:52 +01:00
Tim Van Holder a1b5ec1532 JENKINS-62572: Extend Downloadable API slightly (#4773) 2020-07-06 07:52:53 +01:00
Tim Van Holder a49f58057c [JENKINS-26097] Adjust label expression auto-completion and validation (#4774) 2020-06-29 07:40:51 +01:00
Oleg Nenashev 339f9b930e Merge pull request #4803 from jtnord/JENKINS-62688
[JENKINS-62688] use id in User.toString()
2020-06-24 18:56:26 +02:00
Johno Crawford c732bb3693 [JENKINS-62695] - Use daemon threads for SCMTrigger so Jenkins shuts down gracefully. (#4805) 2020-06-24 10:25:41 +01:00
Sumit Sarin a5310b10d6 [JENKINS-62345] Introduce FingerprintStorage API in core (#4731)
* [JENKINS-62345] Introduce FingerprintStorage API

* Fix FingerprintTest by adding JenkinsRule

* Add licenses

* Undo Adding JTH to core

* Move roundTrip test to JTH

* Move toByteArray method to Fingerprint class

* Decrease extension ordinal value for FileFingerprintStorage

* abstract logging and bulkchange into fingerprint class

* Move loading logs into Fingerprint

* Expose setPersistedFacets in Fingerprint class

* Annotate FingerprintStorage as Beta

* Add docstring for FingerprintStorage and FileFingerprintStorage

* Remove nonnull annotation from getPersistedFacets

* Add System property to choose FingerprintStorage engine

* Introduce initFacets method for abstraction

* Remove setPersistedFacets method

* Change scope of getPersistedFacets to default

* Single line return statement

* Add check for null

* Remove checkForNull annotation from initFacets

* change access scope from package to public for load

* Remove No external use from FingerprintStorageEngine

* fingerprintStorageEngine moved inside constructor

* Make get function static

* Remove ordinal value

* Make get method public

* make getPersistedFacets public

* Remove brackets from Extension

* Mark FileFingerprintStorage Beta

* Add fingerprint's hash to logging

* Spelling fix

* Remove toByteArray method

* Move getConfigFile and getFingerprintFile to FileFingerprintStorage

* Annotate and make final: getPersistedFacets

* getBytes -> fromHex

* Deprecate Fingerprint.save(File file)

* add version since deprecated

* Deprecate Fingerprint.load(file) method

* Move FingerprintStorage,FileFingerprintStorage -> jenkins.fingerprints package

* Deprecate Fingerprint load(@NonNull byte[] md5sum) and move to String id

* Delete private deprecated method

* CheckForNull added

* Add comments about implementing Saveable Listener

* Add TODO for Saveable Listener

* Add TODO for renaming md5 in xml

* Move serialize to FileFingerprintStorage

* Make serialize method private

* Add docstrings

* Revert serialize to static

* Introduce deletion in the API

* Make messageOfParseException private

* Remove Redundant imports

* Add test for fingerprint deletion

* Make methods private

* Move deletion test to FingerprintTest

* Improve code style

* Improve code style

* Add deletion errors in FileFingerprintStorage#delete

* Add spaces

* Remove extra empty line

* Variable renaming

* Add documentation

* Add spacing

* Remove spacing

* Beta -> NoExternalUse

* Refactoring

* Add CheckForNull annotation in save method

* Add documentation

* Refactor FingerprintMap#isReady to FingerprintStorage

* Suppress fingerprint cleanup thread when external storage is configured

* Add TODO

* Fix negation bug

* Move FingerprintCleanupThreadTest from core to test (needs JTH)

* Revert to using ordinal for extension

* Remove redundant import

* Add note on ID

* spacing changes

* Add spacing

* Add ordinal to extension

* Add curlies

* remove curlies

* j -> jenkinsRule

* Remove note on | delimeter

* Improve docstring

* null -> {@code null}

* Improve docstring

* Improve documentation

* Fix typos

* Minor changes to variable names and docstrings

* Update docstring
2020-06-22 09:42:08 +02:00
James Nord eb1c156065 [JENKINS-62688] use id in User.toString()
Change toString() to use the id rather than fullName.

This is because a full name may not be unique and as such when used in log
messages we get something that is less than helpful.

as such we should print the user's Id so we can actually identify the
user.
2020-06-15 15:00:29 +01:00
Daniel Beck ca00f7a11a [JENKINS-62622] Do not throw exception with nonpublic plugins 2020-06-15 09:44:46 +02:00
Tim Van HolderandJesse Glick 302159c0e8 JENKINS-29144: Enable proper environment access for build steps (#4766)
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
2020-06-13 13:00:37 +01:00
Daniel BeckandDaniel Beck a53ef93cca Use the 'agent' term more often (#4777)
* Use the 'agent' term more often

* More cleanup

* Another occurrence

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-06-09 18:00:37 +02:00
Daniel BeckandDaniel Beck 2776f4dc77 [JENKINS-62332] Show when a plugin version newer than offered exists (#4742)
* [JENKINS-62332] Show when a plugin version newer than offered exists

* Add more obvious label/tag to entries that cannot be installed

Also link to plugin documentation from the detail message

* Also show the list if there are any unavailable updates

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-06-07 10:51:16 +02:00
Oleg Nenashev 014d23e923 Merge pull request #4765 from daniel-beck/deprecate-useAntClassLoader
Note deprecation of ClassicPluginStrategy#useAntClassLoader
2020-06-05 23:52:04 +02:00
Daniel Beck d8080d2e96 Note deprecation of ClassicPluginStrategy#useAntClassLoader 2020-06-01 16:34:13 +02:00
Tim Jacomb 61041b4642 Merge pull request #4739 from res0nance/cli-read
Make CLILink use read permission
2020-05-31 07:28:00 +01:00
Tim Jacomb de866dffdf Merge pull request #4754 from Vlatombe/capture-slavecomputer-threadinfo
Capture stacktrace from the original thread when SlaveComputer#_connect fails
2020-05-31 07:25:32 +01:00
Raihaan Shouhell 3fd66ff220 [JENKINS-20052] Refactor ListView getItems (#4466)
* Refactor ListView getItems

Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>

* Minor Refactor

* Optimization for specific case

* Migrate statusfilter to viewjobfilter

* Use unboxed boolean so we don't have to deal with null

* UI Changes

* Add tests and use pre-auth filters

* Add test with a simple filter

* Remove old tests as the new tests should cover this

* Change annotation

* Only iterate if there are names or a regex pattern
2020-05-29 22:38:38 +08:00
Vincent LatombeandJesse Glick 97e8d17ef3 Update core/src/main/java/hudson/slaves/SlaveComputer.java
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
2020-05-28 15:27:01 +02:00
Vincent Latombe dab8a19d78 Capture stacktrace from the original thread when SlaveComputer#_connect fails 2020-05-28 15:02:36 +02:00
Antonio Muniz c8bd0f0949 [JENKINS-62264] User with MANAGE permissions can access node monitoring (#4724)
* [JENKINS-62264] User with MANAGE permissions can access node monitoring

And submit its configuration.

* [JENKINS-62264] Allow Overall/Manage to refresh nodes status
2020-05-28 09:34:07 +02:00
res0nance f68a90eacc Make CLILink use read permission 2020-05-25 23:20:01 +08:00
Tim JacombandDaniel Beck 634004a648 JENKINS-61206 System read / Extended read for agents (#4531)
* JENKINS-61206 System read / Extended read for agents

* Update core/src/main/java/hudson/Functions.java

* Set permission to false explicitly

* Add message when no configured clouds

Otherwise there was a white page and it looked weird

* Hide password for Computer.EXTENDED_READ

* Add test

* Access controlled simplification

* Fix typoes  / simplify code

* Simplify task.jelly

* Allow filtering system info extensions

* Show link that should be present

* Adjust MasterComputer access

* Adjust javadoc

* Adjust MasterComputer#configure

* Change links when read only access

* Use it instead of app

* Update core/src/main/resources/hudson/model/Computer/configure.jelly

Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>

* Code simplification

* Inline jelly text customisation

* Allow system read to see cloud move blurb

* Tooltip based on permission

Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-05-24 06:58:27 +01:00
Vincent Latombe 4c16f2cd95 Make Computer#getLogDir thread-safe (#4730) 2020-05-23 13:16:05 +01:00
Emilio Escobar 9f48a332e5 [JENKINS-61458] Allow Jenkins.MANAGE user to access "Reload Configuration From Disk" (#4728)
* [JENKINS-61458] Jenkins.MANAGE requires for configuration reload

* [JENKINS-61458] Test fixed
2020-05-22 14:57:23 +08:00
Mark Waite c2bd4fa006 Merge pull request #4714 from jglick/deadlock-JENKINS-62181
[JENKINS-62181] Deadlock during log formatting
2020-05-19 16:36:47 -06:00
Tim Jacomb 86af885a41 Merge pull request #4718 from MRamonLeon/JENKINS-62231 2020-05-15 19:50:50 +01:00
Jesse Glick a01810e7d5 Keep a ThreadLocal for the SimpleFormatter 2020-05-15 11:44:15 -04:00
Jesse Glick 22f0692bec Merge branch 'master' of github.com:jenkinsci/jenkins into deadlock-JENKINS-62181 2020-05-15 11:38:45 -04:00
Oleg Nenashev 711a0c9f26 Merge pull request #4711 from oleg-nenashev/JENKINS-60118-2
[JENKINS-60118] - Ensure that UserLanguages telemetry initializer always runs after extensions are augmented
2020-05-15 17:37:47 +02:00
Ramon Leon f914170e32 [JENKINS-62231] Adjust level depending on the case 2020-05-15 08:57:43 +02:00
Tim Jacomb c091890537 Merge pull request #4684 from calvinpark/JENKINS-61956_createProject-checkGoodName 2020-05-14 18:36:36 +01:00
Tim Jacomb 0a4159068b Merge pull request #4712 from MRamonLeon/JENKINS-61920 2020-05-14 18:25:55 +01:00
Ramon Leon a69a9a24e9 [JENKINS-62231] Optimize catch code 2020-05-12 10:55:46 +02:00
Raihaan Shouhell bbcf1dbbb9 Merge pull request #4715 from jglick/Configuration
Deprecating jenkins.model.Configuration
2020-05-12 08:19:49 +08:00
Ramon Leon 5d40c424f0 [JENKINS-61920] Add more information 2020-05-11 17:33:33 +02:00
Ramon Leon 943fbcd40c [JENKINS-62231] Log a report problem with info 2020-05-11 12:43:02 +02:00
Ramon Leon f621e5b68b [JENKINS-62231] Avoid OldDataMonitor avoids Jenkins load a plugin 2020-05-10 17:06:57 +02:00
Tim Jacomb b907828653 Merge pull request #4708 from daniel-beck/fix-and-restrict-Protector 2020-05-10 11:11:24 +01:00
Daniel BeckandDaniel Beck 8a9a1b2f7b [JENKINS-61808] Always transmit f:password values as Secret (#4630)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-05-10 11:17:51 +02:00
Jesse Glick 4066817e6f Deprecating jenkins.model.Configuration 2020-05-08 12:24:03 -04:00
Jesse Glick 44048365d7 [JENKINS-62181] Deadlock during log formatting 2020-05-07 11:00:33 -04:00
Ramon Leon 11cea45a62 [JENKINS-61920] Keep imports as it was 2020-05-07 09:51:46 +02:00
Ramon Leon 28480185f0 [JENKINS-61920] Minor changes, improve docs 2020-05-07 09:49:48 +02:00
Ramon Leon a4d59f03b5 [JENKINS-61920] Avoid MissingClassTelemetry populates the log 2020-05-05 18:09:13 +02:00
Oleg Nenashev ac24beb0e1 [JENKINS-60118] - Ensure that UserLanguages telemetry initializer always runs after extensions are augmented 2020-05-05 10:54:39 +02:00
Daniel Beck 0bfd14d9be Remove reference to Protector from Scrambler, entirely unrelated 2020-05-04 13:44:02 +02:00
Daniel Beck 7389f41373 Fix up Protector class 2020-05-04 13:00:33 +02:00
Oleg Nenashev 0b6e868119 Make the SystemProperties API available to plugins 2020-05-04 12:03:00 +02:00
Daniel Beck 78ea4b6b55 These at-since were improperly added 2020-05-04 01:34:15 +02:00
Tim Jacomb 40c672824d Merge pull request #4705 from daniel-beck/at-since-20200503
Update at-since up to May 3, 2020
2020-05-03 22:36:35 +01:00