Commit Graph
5182 Commits
Author SHA1 Message Date
kohsuke fdf7c75296 define a mode that doesn't report an error.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23431 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-03 00:58:23 +00:00
kohsuke b9c40295e8 made the fromString method reusable.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23430 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-03 00:40:27 +00:00
kohsuke e168daa5fc context path can be empty, so a better rendering is needed.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23429 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-03 00:18:56 +00:00
mindless 07333d300c 3 fixes when renaming a LogRecorder:
- checkGoodName on new name (new recorder already checks, but rename didn't)
- delete config file for old name (after Hudson restart, old name would come back)
- redirect to new name instead of old (rename was getting stapler error after save)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23405 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-01 16:42:30 +00:00
mindless 72e0942fc9 oops, fix typo in r23393
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23399 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-01 00:39:10 +00:00
mindless 0869aafbbe make My Views link text localizable
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23397 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-01 00:32:23 +00:00
mindless 4d7b8a774d update use of deprecated stapler API (missed in r23277 commit)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23396 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-01 00:22:05 +00:00
mindless 4ec75ea5f9 revert r23341 as it was already fixed in hudson.util.XStream2 in r23339
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23395 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-01 00:20:19 +00:00
mindless bc9db0fd0a [FIXED HUDSON-4720] Don't always append / to non-absolute action URLs,
as this may break some links (.../*.html for example).
See related HUDSON-1335, HUDSON-1679, r347 and r11319.
Updated hyperlinkMatchesCurrentPage to ignore trailing / in matching
to avoid regression in bold context links.
Also fixed tiny bug introduced in r13815 where "/" was changed to "."
in moving code from jelly to Functions, causing a couple links in
LogRecorder area (with href=".") to not show as bold.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23393 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-01 00:00:32 +00:00
kohsuke 931e2d38cc fixed NPE
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23353 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-30 18:15:21 +00:00
kohsuke 71820041a4 fixed an error during start up due to the Converter type inconsistency with the current version of XStream.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23341 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-30 17:04:04 +00:00
kohsuke fb2bf8e05f doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23340 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-30 16:28:49 +00:00
mindless c0e51ace46 Add support in XStream2.AssociatedConverterImpl for SingleValueConverter
(fixes bug introduced in r23277 where BuildAuthorizationToken's
ConverterImpl was changed to a SingleValueConverter).


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23339 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-30 16:24:49 +00:00
abayer 56c1d298d2 [FIXED HUDSON-4553] Along with earlier commit, added /safeExit and /safeRestart web endpoints and safe-restart CLI command
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23331 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-29 22:01:18 +00:00
abayer f01b73bc99 Fixing compilation error caused by UpdateCenter.Plugin moving to UpdateSite.Plugin
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23329 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-29 21:41:45 +00:00
abayer c202a1746f Adding safeRestart to CLI and web UI
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23328 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-29 21:32:20 +00:00
kohsuke 720be7d7a1 Merged revisions 23183,23185,23245,23256,23266,23279-23284,23286 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/multiple-update-sources

........
  r23183 | abayer | 2009-10-25 11:53:17 -0700 (Sun, 25 Oct 2009) | 1 line
  
  First chunk of work towards supporting multiple update centers - infrastructure in place for it, and default update center treated as only one of multiple - have to use slightly modified update-center.json though
........
  r23185 | abayer | 2009-10-25 12:25:49 -0700 (Sun, 25 Oct 2009) | 1 line
  
  a number of tweaks - among other things, now works properly with additional update centers defined in hudson.model.UpdateCenter.xml - try using http://andrewbayer.com/images/hello-world/helloWorld-update-center.json as second update center
........
  r23245 | abayer | 2009-10-27 13:45:25 -0700 (Tue, 27 Oct 2009) | 1 line
  
  Modified to support existing default update-center.json
........
  r23256 | kohsuke | 2009-10-27 18:30:15 -0700 (Tue, 27 Oct 2009) | 7 lines
  
  - moved data binding of update-center.json to UpdateSource.
  - moved some of the UpdateSource property into JSON, to improve the user experience when adding an update source.
    the user should just type in one URL, and everything else should happen automatically.
  - it doesn't make sense for UpdateSource to rely on UpdateCenterConfiguration, since behaviors cannot be
    modified per UpdateSource basis. Instead, leaving it in UpdateCenter allows us to maintain backward compatible
    behaviors with the existing custom UpdateCenterConfiguration implementation.
........
  r23266 | kohsuke | 2009-10-27 19:29:24 -0700 (Tue, 27 Oct 2009) | 1 line
  
  serve id inside JSON.
........
  r23279 | kohsuke | 2009-10-28 10:44:00 -0700 (Wed, 28 Oct 2009) | 1 line
  
  Do not special-case "default" ID. Receive hudson.war updates from wherever that provides one.
........
  r23280 | kohsuke | 2009-10-28 10:50:57 -0700 (Wed, 28 Oct 2009) | 1 line
  
  formatting change.
........
  r23281 | kohsuke | 2009-10-28 11:30:40 -0700 (Wed, 28 Oct 2009) | 1 line
  
  typo
........
  r23282 | kohsuke | 2009-10-28 11:45:06 -0700 (Wed, 28 Oct 2009) | 2 lines
  
  - added the UI to remove sites.
  - persistence of UpdateSource happens more automatically now.
........
  r23283 | kohsuke | 2009-10-28 11:50:04 -0700 (Wed, 28 Oct 2009) | 1 line
  
  UpdateSource -> UpdateSite to align terminology with Eclipse.
........
  r23284 | kohsuke | 2009-10-28 11:55:03 -0700 (Wed, 28 Oct 2009) | 5 lines
  
  Actually, for now, just having a programmatic modification to UpdateSite would satisfy the primary use case.
  
  And I'd like to upgrade YUI to a more recent version so that we can use its DataTable for UI. Plus the single update center model encourages the community to bring the code into the Hudson project, which is something we'd like to keep.
  
  So all in all, I'm postponing the UI work.
........
  r23286 | kohsuke | 2009-10-28 13:07:19 -0700 (Wed, 28 Oct 2009) | 1 line
  
  Renaming and bug fixes.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23326 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-29 21:27:46 +00:00
kohsuke 1627280a5a do deep copy.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23321 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-29 20:39:25 +00:00
kohsuke 564db95d2b pointless complexity. if there's no permissions to define, just don't have an instance.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23309 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-29 00:37:43 +00:00
kohsuke 3cd35cf8e4 bringing the pseudo immutability back.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23308 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-29 00:24:42 +00:00
kohsuke fdba356ffd pointless boxing
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23307 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-29 00:23:25 +00:00
kohsuke ed096ea21d Added the "install-plugin" command to install plugins from CLI.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23292 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-28 21:20:08 +00:00
kohsuke 0449001bd4 added a convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23290 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-28 21:03:36 +00:00
mindless 2530da6893 Update uses of deprecated APIs.
Hudson APIs: tasks.Shell, model.Hudson, model.*LoadStatistics,
             slaves.ConnecationActivityMonitor, PluginManager
XStream APIs: util.CopyOnWriteList, util.Robust*Converter, model.Result,
              model.BuildAuthorizationToken, model.Fingerprint
Stapler APIs: diagnosis.HudsonHomeDiskUsageMonitor, os.solaris.ZFSInstaller
args4j APIs: model.Job, cli.GroovyCommand, cli.handlers.*


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23277 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-28 17:10:52 +00:00
stigkj 58b535c33a * Fixed error when using stdin as "-" is parsed by args4j which does not understand it;
replaced it with "="
* Hardcoded name of script as "=" or something like "not-a-good-script-name.groovy" failed

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23228 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-27 00:10:56 +00:00
kohsuke 46f795986a why do we catch an exception here?
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23213 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-26 19:06:37 +00:00
kohsuke 76eadc1a14 catch any exception whatsoever, as we've heard in IRC from someone who seems to be getting an exception outside the try block.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23212 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-26 18:58:59 +00:00
kohsuke 2c12164d86 Improved the UI of taking a node offline. A textbox without a descriptive label doesn't give users any clue as to what you are supposed to type there.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23211 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-26 17:37:43 +00:00
kohsuke baee163bbd SCM information is now exposed via the remote API.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23209 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-26 17:32:10 +00:00
mindless 6126c5911d [FIXED HUDSON-3607] Omit unconfigurable project types (like MatrixConfiguration)
from upstreamProject processing (suggested by jking_ok)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23207 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-26 16:20:25 +00:00
kohsuke df4cb2a496 trust our own root CAs so that the community doesn't have to rely on normal CAs that are quite expensive.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23182 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-25 18:43:50 +00:00
kohsuke 4ecfdc7a6c integrated signature validation code, but off by default until we verify that it's working.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23181 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-25 16:42:00 +00:00
kohsuke fe086df945 Automated tool downloads are made more robust by using HTTP download retries.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23122 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-24 00:15:29 +00:00
kohsuke 199db7ab59 [FIXED HUDSON-4618] Applied the patch toward 1.331.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23111 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-23 20:23:08 +00:00
kohsuke 73130a3853 [FIXED HUDSON-1816] in 1.331. Applied a patch from ybubnov, and made him a committer.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23071 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-22 23:03:44 +00:00
kohsuke 2bc598ecdd Merged revisions 23066 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23066 | kohsuke | 2009-10-22 15:03:52 -0700 (Thu, 22 Oct 2009) | 1 line
  
  fixed a compilation problem.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23067 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-22 22:06:08 +00:00
dty 75b43ed5f8 Fix terminology, get rid of redundant String creation.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23007 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 22:47:18 +00:00
dty bd27be08fc Older versions of bash improperly decide that a script is a binary file if there
is non-ASCII on the first line of the file, preventing the step from executing
properly. This was discovered by the DirectoryBrowserSupport unit test failing.
This can be worked around by inserting a leading carriage return so that bash
won't find the non-ASCII on the first line.

   - Modify the Shell task to insert a carriage return for shell scripts that
     don't start with #! or already contain a leading carriage return.

     main/core/src/main/java/hudson/tasks/Shell.java

   - This test failed after the change because the inserted carriage return
     is returned from getContent(). Trim the result before comparing it to
     the expected data.

     main/test/src/test/java/hudson/model/FreeStyleProjectTest.java


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23006 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 22:01:32 +00:00
abayer 34387b2fef Added meetsMavenReqVersion method to Maven.MavenInstallation - generalization of logic from isMaven2_1 - tests modified to check whether default MavenInstallation meets required Maven version before using bundled Maven install instead
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23000 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 19:48:11 +00:00
kohsuke f2402ec6d8 fixed a compilation problem.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22996 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 18:17:47 +00:00
kohsuke 4ca37cfd46 FoldableAction isn't used by any plugin yet, so changing the signature and moving it to a new home.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22992 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 16:56:49 +00:00
kohsuke b1b384d243 removed a compiler warning.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22990 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:49:12 +00:00
kohsuke 7d159d19e2 simplified.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22989 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:43:24 +00:00
kohsuke 2e8f055592 unused field.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22988 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:39:09 +00:00
kohsuke f52873cc30 unused private method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22987 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:38:12 +00:00
kohsuke 531ce7179f simplifiedi
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22986 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:37:59 +00:00
kohsuke 773fdeeb9a avoid instanceof.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22985 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:28:58 +00:00
kohsuke 3fc44fdfdd removed pointless empty check that doesn't affect the execution.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22984 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:27:56 +00:00
kohsuke fd4039aff4 cosmetic changes
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22983 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:23:08 +00:00
kohsuke 30a45d4364 Avoid instanceof
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22982 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:18:47 +00:00