Commit Graph
5182 Commits
Author SHA1 Message Date
kohsuke 439a6b94f0 while working on a hang problem in JavaFX deployment of Hudson, I noticed that slave is eagerly loading a lot of classes that it shouldn't load, which appears to be caused by the fact that SLAVE_LOG_HANDLER is in SlaveComputer class, which triggers classloading of such classes like hudson.model.Hudson.
I'm hoping that this fixes the hang issue, but at least this makes the start up a bit faster.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19542 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-08 23:20:54 +00:00
jglick b7c25bdf45 [FIXED HUDSON-3989] Installation of JDK 1.4.x did not work due to to "j2sdk" dir name.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19476 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-07 19:44:20 +00:00
kohsuke a31176489c Using AntClassLoader with Closeable so that we can predictably release jar files opened by URLClassLoader
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19472 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-07 18:35:32 +00:00
jglick 2dd667265b File.toURL() is deprecated.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19471 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-07 18:31:24 +00:00
kohsuke f6e9363491 a small code simplification
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19451 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-07 16:56:09 +00:00
kohsuke 1bdbdbb398 added the simplest kill method
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19440 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-06 22:16:56 +00:00
kohsuke d1a4bb7bf7 [FIXED HUDSON-3981] Increased the timeout to 3secs as suggested. Added caching so that successive look-ups go faster. This fix will be in 1.315.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19436 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-06 21:46:01 +00:00
kohsuke a86fe5e9c7 reformatted import statements
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19435 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-06 21:32:11 +00:00
kohsuke af1d6538f4 generalized ProcessTreeKiller to expose more system information, so that the plugins and core can do more interesting things.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19434 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-06 21:31:29 +00:00
mindless 8aa65078c9 [HUDSON-3590] load user when create flag is false if user has a config file
(this should not be considered "creating" the user), so login works even if
User.getAll has not yet been called.  fixes regression from r19411


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19412 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-05 23:58:44 +00:00
mindless c9db91664d [FIXED HUDSON-3590] don't create new in-memory user when someone attempts
login with invalid username


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19411 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-05 20:17:39 +00:00
mindless aedca55e74 [FIXED HUDSON-3505] fix getUpUrl when parent is MatrixConfiguration.
(this makes a valid link for "Back to Project" in this case, though sidepanel
navigation between MatrixProject/Configuration/Build/Run could still be improved)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19409 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-05 19:28:14 +00:00
kohsuke 8487501176 Hudson failed to notice a build result status change if aborted builds
were in the middle.
    (<a href="http://www.nabble.com/Losing-build-state-after-aborts--td24335949.html">report</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19401 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-04 18:53:31 +00:00
kohsuke d6677bcb1c added an option to close OutputStream at the end
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19392 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-04 01:49:18 +00:00
mindless 12689f0c30 [FIXED HUDSON-3674] Don't allow rename of view to same name as another view
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19389 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-03 22:04:18 +00:00
kohsuke ca0b6e830d I discovered that when Apache sits in front of Hudson as a reverse proxy, it blocks the traffic in such a way that breaks tunneling of the remoting.
The issue is that the CLI initiates the upload side of the connection and sends some small chunk, yet Apache never forwads that to Hudson, presumably because it's trying to buffer more contents from CLI, which never arrives.

A similar problem seems to exist for the download side, although various reports (like http://mail-archives.apache.org/mod_mbox/httpd-users/200509.mbox/%3C20050927152742.GA8726@redhat.com%3E) suggests that this is fixed in a relatively recent version of Apache.

Other pages, like http://httpd.apache.org/docs/2.2/mod/mod_proxy.html , seems to suggest that Apache can be configured not to do this buffering, but my attempt to configure them failed, both on Ubuntu and OpenSolaris. It could be my mistake, but the lesson for me is that even if Apache can be configured not to interfere, it's still rather error prone.

On top of that, it's not hard to imagine that other forward/reverse proxy have similar problems --- IIRC, Dean Yu reported a similar problem.

So I decided to let CLI talk to Hudson via a conventional TCP/IP connection, if possible. An extra bonus is that this is more resource efficient on the server side (which was tying 2 request handling for pushing and pulling before this change.)

The downside of this change is that if the client is behind the proxy, or if the server is behind a reverse proxy, this needs an extra set up. I thought this is a lesser evil, as Hudson tends to run inside a corporate network, and this issue is already better understood since JNLP slaves have the same issue.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19378 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-03 00:12:46 +00:00
kaxelson 4448beb285 [FIXED HUDSON-3966] added option to clean workspace before each build as part of advanced project configuration
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19373 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-02 22:37:17 +00:00
kohsuke 46d1e006ae fixed the archiving code by de-composing it to a smaller orthogonal pieces
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19364 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-02 18:20:13 +00:00
kohsuke dd808e1f1e Merged revisions 19167-19168,19178,19183-19187,19190,19193-19194,19207,19209,19223,19236,19248,19254,19257,19338 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/rc

........
  r19167 | kohsuke | 2009-06-23 16:08:06 -0700 (Tue, 23 Jun 2009) | 1 line
  
  merged back the changes in the RC branch
........
  r19168 | kohsuke | 2009-06-23 16:12:46 -0700 (Tue, 23 Jun 2009) | 1 line
  
  fixed the bug
........
  r19178 | swiest | 2009-06-24 02:43:21 -0700 (Wed, 24 Jun 2009) | 1 line
  
  Updated German localization of core module.
........
  r19183 | kohsuke | 2009-06-24 08:57:07 -0700 (Wed, 24 Jun 2009) | 1 line
  
  forgot to update this
........
  r19184 | kohsuke | 2009-06-24 09:06:59 -0700 (Wed, 24 Jun 2009) | 1 line
  
  fixed and improved the retry logic
........
  r19185 | kohsuke | 2009-06-24 09:07:49 -0700 (Wed, 24 Jun 2009) | 1 line
  
  I think this is better
........
  r19186 | kohsuke | 2009-06-24 09:08:02 -0700 (Wed, 24 Jun 2009) | 1 line
  
  fixed import statements
........
  r19187 | kohsuke | 2009-06-24 09:57:52 -0700 (Wed, 24 Jun 2009) | 3 lines
  
  WebDAV deployment from Maven was failing with VerifyError.
  
  A test case requires a webdav server, I tried Milton but couldn't make it work without the source code.
........
  r19190 | swiest | 2009-06-24 12:07:50 -0700 (Wed, 24 Jun 2009) | 1 line
  
  Deprecated Util.combine(long,String) method and rewrote its callers to use localizable resources.
........
  r19193 | sogabe | 2009-06-24 14:53:02 -0700 (Wed, 24 Jun 2009) | 2 lines
  
  Updated Japanese localization.
........
  r19194 | kohsuke | 2009-06-24 15:20:15 -0700 (Wed, 24 Jun 2009) | 1 line
  
  added default value support
........
  r19207 | kohsuke | 2009-06-24 19:50:48 -0700 (Wed, 24 Jun 2009) | 1 line
  
  recording HUDSON-2909 for 1.313
........
  r19209 | kohsuke | 2009-06-24 19:52:21 -0700 (Wed, 24 Jun 2009) | 1 line
  
  creating a new RC branch
........
  r19223 | kohsuke | 2009-06-25 10:43:06 -0700 (Thu, 25 Jun 2009) | 7 lines
  
  Replaced the icon with the one that came from the same icon set, plus hyperlinking the icon
  to Hudson Wiki so that we can be more informative.
  
  Tooltip on the icon doesn't work very well because the TD itself sets a tooltip, and
  we end up seeing the overlapped 2 tooltips (at least on my Firefox 3.0 on Ubuntu)
........
  r19236 | kohsuke | 2009-06-25 18:06:50 -0700 (Thu, 25 Jun 2009) | 1 line
  
  applied a patch from Jeremy (or id:endolf). See http://www.nabble.com/Build-publisher-patch-svn-access-td24164282.html
........
  r19248 | kohsuke | 2009-06-26 14:42:40 -0700 (Fri, 26 Jun 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_313
........
  r19254 | kohsuke | 2009-06-26 17:28:12 -0700 (Fri, 26 Jun 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r19257 | kohsuke | 2009-06-26 18:20:24 -0700 (Fri, 26 Jun 2009) | 1 line
  
  updated changelog as a part of the release
........
  r19338 | kohsuke | 2009-06-30 18:48:25 -0700 (Tue, 30 Jun 2009) | 1 line
  
  added maven-versions-plugin to pick up ones that got out of sync
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19354 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-02 04:17:46 +00:00
kohsuke e950c0e93c added a pointer back to Wiki
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19351 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-01 23:25:31 +00:00
kohsuke 597f52569e Allow SecurityRealm to change where the user is taken to after logout. See http://www.nabble.com/Modify-behavior-of-log-out-link-td24273856.html
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19341 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-01 14:02:24 +00:00
kohsuke 01fc0c46ac Fixed a regression in the <tt>groovy</tt> CLI command
<a href="http://d.hatena.ne.jp/tanamon/20090630/1246372887">report</a>

CLICommand may get serialized and sent to somewhere else, so don't have its initializers do anything harmful

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19339 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-01 02:13:34 +00:00
kohsuke 32458598da Made Hudson more robust in parsing <tt>CVS/Entries</tt>
<a href="http://www.nabble.com/Exception-while-checking-out-from-CVS-td24256117.html">report</a>


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19334 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-30 23:48:34 +00:00
kohsuke 439194e39e rev.19332 went with a partial change.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19333 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-30 23:45:12 +00:00
kohsuke b7a52ff7ba rolling back my earlier change that seems to be breaking tests. will revisit this change later
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19332 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-30 23:44:08 +00:00
jglick aad955d515 [FIXED HUDSON-3964] Can escape characters in username to make an ID, but retain the original form for display & email purposes.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19322 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-30 16:31:44 +00:00
kohsuke 1e9cc3b4e3 Fixed a possible "Cannot create a file when that file already exists" error in managed Windows slave launcher.
<a href="http://www.nabble.com/%22Cannot-create-a-file-when-that-file-already-exists%22---huh--td23949362.html#a23950643">report</a>

SmbFile.mkdirs() behave differently to File.mkdirs(), and it fails if the directory already exists.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19321 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-30 15:54:59 +00:00
kohsuke 8ad45a5f10 introduced a visitor pattern to avoid code duplication
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19320 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-30 14:54:26 +00:00
jglick 23adbc51dc [FIXED HUDSON-3914] JDK 1.4.2 installations were broken because there is no option to select a language.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19225 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-25 22:20:09 +00:00
kohsuke 175eb35627 [FIXED HUDSON-3924] Exposing additional items in the XML API.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19224 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-25 18:36:00 +00:00
swiest 8baca8d5b6 Deprecated Util.combine(long,String) method and rewrote its callers to use localizable resources.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19190 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-24 19:07:50 +00:00
kohsuke 27d0fed834 fixed import statements
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19186 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-24 16:08:02 +00:00
kohsuke 4a00f5a7d7 I think this is better
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19185 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-24 16:07:49 +00:00
kohsuke 3778279edf fixed and improved the retry logic
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19184 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-24 16:06:59 +00:00
kohsuke 78f3ab1ba9 fixed the bug
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19168 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-23 23:12:46 +00:00
kohsuke a00e7d579d merged back the changes in the RC branch
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19167 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-23 23:08:06 +00:00
kohsuke 59d578c24e renamed to "SCM checkout retry count" to clarify what it really means
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19165 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-23 22:46:53 +00:00
dty 1d3896679a [FIX BUG 3854] Add support for the X-Forwarded-For HTTP header, which proxies
commonly filled in to pass along the IP address of the client. If this header
exists, use the first IP address as the client IP instead of calling
getRemoteAddr.

Added test cases to test various situations.



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19132 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-22 23:52:38 +00:00
kohsuke bf97df3690 Added delete-job, enable-job, and disable-job command.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19119 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-22 20:16:16 +00:00
kohsuke 5107d8d784 added license header
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19113 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-22 18:38:20 +00:00
kohsuke 1648ecc959 Forgot to put @Extension
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19112 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-22 18:33:27 +00:00
kohsuke 42b93fe0d9 Exposes more methods to enable decoration of Launcher
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19109 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-22 17:30:05 +00:00
kohsuke ee2ef56a0f added one more convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19095 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-20 03:13:29 +00:00
kohsuke 027a7e3e1b Fixed a bug in the non-ASCII character handling in remote bulk file copy.
(<a href="http://www.nabble.com/WG%3A-Error-when-saving-Artifacts-td24106649.html">report</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19075 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-19 23:19:33 +00:00
kohsuke fcc7514394 Fixed a bug in the non-ASCII character handling in remote bulk file copy.
(<a href="http://www.nabble.com/WG%3A-Error-when-saving-Artifacts-td24106649.html">report</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19074 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-19 23:18:19 +00:00
kohsuke 47319ae718 imported from Ant 1.7.0 to patch encoding related issues.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19073 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-19 23:07:06 +00:00
kohsuke 1447affed5 fixed a compilation error
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19072 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-19 20:54:39 +00:00
kohsuke 9e07241fd2 Starting Hudson 1.312, this method is also invoked for the master, not just for slaves.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19069 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-19 20:08:36 +00:00
shinodkm 4c2a73f61a Added retry option for check out . ie, If checkout fail, it will retry the specified number of times.
BUG FIX : 3855

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19062 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-19 08:38:30 +00:00
shinodkm 636c5cd843 Added retry option for check out . ie, If checkout failes, it will retry the specified number of times.
BUG FIX : 3855

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19061 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-19 08:36:46 +00:00