Commit Graph
11799 Commits
Author SHA1 Message Date
mindless 71854d1b69 [FIXED HUDSON-6371] Fix getArtifactsUpTo so it doesn't count collapsed-directories
as artifacts, resulting in too few artifacts returned (since 1.348).
Also fix limit check so it returns "n" items, not n+1.  Added test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30451 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-28 16:13:37 +00:00
mindless 5ad11a0dbc [FIXED HUDSON-6332] for 1.357
Add setOverwrite(true) for local->local copy in FilePath.copyRecursiveTo().
This makes it consistent with master/slave copy (either direction),
and also avoids returning 0 if all files already have current/newer timestamp
which some code (javadoc publishing, copyartifact plugin) would interpret as
copy failure or no matching files found.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30450 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 23:53:41 +00:00
kohsuke 5c339d5040 @nameRef is a mechanism to designate a different parent, so it needs to be in the different branch of if/then/else from e=e.parentNode.
I realize that this is a risky change, so I need to pay attention to the regerssions caused by this.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30449 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 23:43:23 +00:00
kohsuke b988eb8b83 @fillUrl should take the public static fromStapler method into account.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30448 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 21:33:23 +00:00
kohsuke b0f664dfcf improved construction of query string.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30447 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 21:09:40 +00:00
kohsuke 5963112082 f:combobox is preferred now.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30442 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 18:33:49 +00:00
kohsuke 38d8c36aa9 a convenience method to assist trouble-shooting.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30441 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 18:32:45 +00:00
kohsuke 77e5369157 fixed ArrayIndexOutOfBoundsException
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30421 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-26 21:15:34 +00:00
kohsuke 4cc6223c45 @items doesn't exist for <f:select>. C&P error from <f:dropDownList>.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30415 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-26 19:09:25 +00:00
kohsuke f672a29cd5 adding a UI sample for dynamic combo box.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30360 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-23 20:05:12 +00:00
mindless 24bfe8eac5 r30283 introduced an NPE when tests do createSlave(), as there is no Stapler context
to get the rootUrl.  Add null check here.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30359 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-23 18:09:42 +00:00
kohsuke ee711d4e63 added a convenient base class.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30333 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-22 21:42:41 +00:00
kohsuke 23c7b05fc7 simplified.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30332 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-22 21:31:39 +00:00
kohsuke 4af6899fbf @field is supported and @items is not mandatory.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30331 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-22 21:25:43 +00:00
kohsuke ad7b504ced user report indicates that if someone puts a null value into a system proeprty we get a hard-to-diagnose NPE. Adding code to proactively watch out for that:
[workspace] $ /usr/lib/jvm/sun-jdk-1.6/bin/java -cp /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven-agent-1.355.jar:/usr/share/maven-bin-2.1/boot/classworlds-1.1.jar hudson.maven.agent.Main /usr/share/maven-bin-2.1 /opt/glassfish/server/glassfish/domains/domain1/applications/hudson/WEB-INF/lib/remoting-1.355.jar /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven-interceptor-1.355.jar 35855 /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven2.1-interceptor-1.2.jar
<===[HUDSON REMOTING CAPACITY]===>���channel started
channel stopped
ERROR: Processing failed due to a bug in the code. Please report this to users@hudson.dev.java.net
java.lang.NullPointerException
	at java.util.Hashtable.put(Hashtable.java:394)
	at java.util.Hashtable.putAll(Hashtable.java:466)
	at hudson.maven.MavenBuilder.call(MavenBuilder.java:156)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:696)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:640)
	at hudson.remoting.UserRequest.perform(UserRequest.java:114)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:270)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)
project=hudson.maven.MavenModuleSet@19cc863[Meetspace]
project.getModules()=[hudson.maven.MavenModule@19fef64[Meetspace/com.steeplesoft:meetspace], hudson.maven.MavenModule@bc2f14[Meetspace/com.steeplesoft.meetspace:meetspace-parent], hudson.maven.MavenModule@11d8f11[Meetspace/com.steeplesoft.meetspace:plugin-engine], hudson.maven.MavenModule@b6e204[Meetspace/com.steeplesoft.meetspace:webapp], hudson.maven.MavenModule@b097da[Meetspace/com.steeplesoft.meetspace.plugins:helloworld-plugin], hudson.maven.MavenModule@1c18b6a[Meetspace/com.steeplesoft.meetspace.plugins:plugin-api], hudson.maven.MavenModule@1a80928[Meetspace/com.steeplesoft.meetspace.plugins:plugin-engine]]
project.getRootModule()=hudson.maven.MavenModule@bc2f14[Meetspace/com.steeplesoft.meetspace:meetspace-parent]
FATAL: null
java.lang.NullPointerException
	at java.util.Hashtable.put(Hashtable.java:394)
	at java.util.Hashtable.putAll(Hashtable.java:466)
	at hudson.maven.MavenBuilder.call(MavenBuilder.java:156)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:696)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:640)
	at hudson.remoting.UserRequest.perform(UserRequest.java:114)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:270)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30326 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-22 17:14:06 +00:00
mindless 491dc45cda Update to stapler 1.140 which includes two fixes:
- Catch case in loadParametersFromAsm when not all parameter names were found
  (if a param has type "long" then an index is skipped, so a null is left in
   the array) and simply return null so it can fallback to a .stapler file.
  This fixes calling of Job.doTimelineData()
- Fix /adjuncts handling in some containers that don't like a leading /
  on a path for ClassLoader.getResource() (ok for jetty, bad for SJSWS7)
  This fixes loading of javascript for Timeline display in those containers.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30305 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 23:48:09 +00:00
mindless e2666f0645 avoid math on buildNumber value when possible, in case it isn't numeric
(e.g. batch-task plugin)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30303 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 22:54:17 +00:00
mindless 7694a68258 tiny simplification
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30302 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 17:48:32 +00:00
kohsuke d21407be4f [FIXED HUDSON-6311] (actually, this change went in as rev.30287, but I'm testing if the issue update is working again)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30290 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 07:07:55 +00:00
kohsuke e57e27dafd accidentally committed
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30288 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 05:32:04 +00:00
kohsuke 7e183a983b [FIXED HUDSON-6311] reverted the problematic change and instead introduced the ideal signature in a new name.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30287 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 05:29:10 +00:00
kohsuke d05c314605 moved to the correct tag.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30284 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 05:18:53 +00:00
kohsuke b06bf8461b expose a few variables to the script.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30283 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 05:17:52 +00:00
kohsuke 207f3112af Fixed UOE in the following exception. Maybe I shouldn't have relied on servlet filters and defined my own thing inside Stapler, so that this whole thing can happen after the request/response/stapler association was made.
But now it's too late. 

java.lang.UnsupportedOperationException
	at hudson.security.AccessDeniedHandlerImpl$1.getServletName(AccessDeniedHandlerImpl.java:58)
	at javax.servlet.GenericServlet.getServletName(GenericServlet.java:368)
	at javax.servlet.GenericServlet.log(GenericServlet.java:300)
	at javax.servlet.GenericServlet.init(GenericServlet.java:257)
	at org.kohsuke.stapler.Stapler.init(Stapler.java:67)
	at hudson.security.AccessDeniedHandlerImpl.handle(AccessDeniedHandlerImpl.java:56)
	at org.acegisecurity.ui.ExceptionTranslationFilter.handleException(ExceptionTranslationFilter.java:229)
	at org.acegisecurity.ui.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:176)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.BasicAuthenticationFilter.doFilter(BasicAuthenticationFilter.java:112)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76)
	at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:164)
	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1088)
	at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360)
	at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
	at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
	at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:729)
	at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
	at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
	at org.mortbay.jetty.Server.handle(Server.java:324)
	at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
	at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:829)
	at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:513)
	at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
	at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
	at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
	at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:488)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30282 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 01:12:40 +00:00
kohsuke 7a6c9d5b1a handle cases like [foo]http://bar/[/foo] or <foo>http://bar/</foo>.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30281 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 00:16:52 +00:00
mindless a101330ebd [HUDSON-6287] add escape-by-default for layout.jelly to avoid XSS attack from
page title as described in case #1 in this issue.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30280 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 00:04:30 +00:00
kohsuke 5ae67f416b Added Secret.toString(Secret) that hides the handling against NPE.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30276 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-20 23:33:03 +00:00
mindless 82dba60b93 Don't used /computers/(index)/ in links to abort a job or for dead executors,
as the index can be incorrect on node page or in a filtered view where
not all nodes are shown.  Use /computer/(name)/.. in links instead.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30275 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-20 23:31:38 +00:00
kohsuke 58c3ceff3f Merged revisions 30161-30163,30165,30169 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r30161 | kohsuke | 2010-04-16 20:12:58 -0700 (Fri, 16 Apr 2010) | 1 line
  
  forgot to commit this file
........
  r30162 | kohsuke | 2010-04-16 20:13:56 -0700 (Fri, 16 Apr 2010) | 1 line
  
  reworking the release process
........
  r30163 | kohsuke | 2010-04-16 20:47:30 -0700 (Fri, 16 Apr 2010) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_355
........
  r30165 | kohsuke | 2010-04-16 20:47:51 -0700 (Fri, 16 Apr 2010) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r30169 | kohsuke | 2010-04-16 22:56:23 -0700 (Fri, 16 Apr 2010) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30232 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-18 18:31:09 +00:00
sogabe 799492ba6b fixed garbled response of XML API if xpath is specified. http://n4.nabble.com/Hudson-API-XML-td1723766.html#a1723766
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30178 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-17 11:11:35 +00:00
vlatombe 3b00f57627 [FIXED-HUDSON-6283] consoleFull output is not served using gzip
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30139 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-16 18:59:49 +00:00
mindless c2fd840846 [FIXED HUDSON-6252] fix bad index calculation in SubText.subText which
caused StringIndexOutOfBoundsException in UrlAnnotator.  Added test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30102 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-16 00:23:00 +00:00
kohsuke be39749c1d picked up the latest that handles whitespace in path correctly
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30100 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 23:17:57 +00:00
kohsuke 86c0b80265 bug fix.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30095 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 23:08:54 +00:00
kohsuke e1e0237f65 work around for bug 6933067.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30091 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 21:30:47 +00:00
mcrooney ba9136a89a HUDSON-6260 provide helpful information about the 'authenticated' group when adding a user/group to a matrix
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30088 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 18:50:24 +00:00
mindless 77da4bcba2 [FIXED HUDSON-6269] Add synchronized on Project.updateTransient actions to avoid
deadlock between saving project config and getting project page.. save locked
transientActions and then project itself; get locks project, then transientActions.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30087 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 18:04:47 +00:00
kohsuke 277d995bb1 [HUDSON-6259] report the error messaeg in addition to error code.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30074 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 01:34:14 +00:00
kohsuke 000a7c33b1 Extension points can be now sorted.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30071 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 00:24:55 +00:00
kohsuke 6253fb1b24 Test performance improvement by allowing multiple Hudsons to reuse classloaders.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30070 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-14 22:55:18 +00:00
drulli 9425e196d7 Use <st:nbsp/> as space since it is more readable than &#160;.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30029 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-13 15:19:28 +00:00
mindless b3eb862daa report any missing class errors to OldDataMonitor
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30025 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-13 14:52:45 +00:00
drulli 4db0c7685a Added a &nbsp; separator between a text and its comment (in braces).
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30024 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-13 14:46:31 +00:00
kohsuke 19342831c6 Merged revisions 29994,29996 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r29994 | kohsuke | 2010-04-12 15:57:26 -0700 (Mon, 12 Apr 2010) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_354
........
  r29996 | kohsuke | 2010-04-12 15:57:47 -0700 (Mon, 12 Apr 2010) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30003 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-13 02:51:55 +00:00
mindless da9acc9705 remove workaround to rerun testSymlink with shorter link for S10,
and instead add (char) cast so original test uses right length for name.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29990 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-12 19:45:13 +00:00
mindless 0cd23f0ea6 Make f:dropdownList work in repeatable content, such as a build step.
Removed uses of element ids and moved initialization into hudson-behavior rules.
Added unit test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29987 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-12 18:05:02 +00:00
kohsuke a559b1635a Fixed http://n4.nabble.com/Password-masking-when-running-commands-on-a-slave-tp1753033p1753033.html
Mask wasn't sent properly to slaves.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29920 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-10 01:17:04 +00:00
mindless db7f908fb2 update wiki url
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29919 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-10 00:56:10 +00:00
kohsuke 06d4cf11a1 integrated custom annotation checker
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29918 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-09 23:16:15 +00:00
dty e48188122d Hook to allow Build subclasses to provide their own Runner implementations.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29913 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-09 22:40:11 +00:00