Harald Albers
50ddd4c60a
added translation for SecurityIsOffMonitor (de)
2013-07-09 19:51:17 +02:00
Oliver Gondža
b8a580c9b3
Add unittests for Util.loadProperties
2013-07-09 16:59:31 +02:00
Jesse Glick
dbdf1d5347
Delete “No” button when renaming; does not work reliably anyway.
...
Going back in browser history can reset configuration form to the *previous* state,
not what was just saved! (In the case of lazily inserted form elements.)
Thus clicking Save from that page would actually revert your recent changes.
For now, just omitting the button; could make it go back to index or configuration pages,
but there are already links for this.
2013-07-09 09:45:13 -04:00
Stephen Connolly
5981ac4ed7
[FIXED JENKINS-18660] Added dedicated denormalized counter function
2013-07-08 15:21:03 +01:00
Nicolas De Loof
a6926e1c51
[FIXED JENKINS-18654] exlude disabled plugins from transitive dependency list
2013-07-08 11:45:26 +02:00
Oliver Gondža
b74185f133
Merge branch 'master' into node-cli
2013-07-07 01:40:19 +02:00
Oliver Gondža
6af228ebc4
Merge branch 'master' into jenkins18393
2013-07-06 23:53:18 +02:00
Kohsuke Kawaguchi
a832b3f9b8
the trunk is toward 1.524-SNAPSHOT
2013-07-06 10:17:44 -07:00
Kohsuke Kawaguchi
7e4996eb1e
merged back the RC branch
...
Conflicts:
core/src/main/java/hudson/model/AbstractProject.java
2013-07-06 09:29:33 -07:00
Kohsuke Kawaguchi
3a265f5c2f
[maven-release-plugin] prepare for next development iteration
2013-07-06 07:57:40 -07:00
Kohsuke Kawaguchi
d38ca25813
[maven-release-plugin] prepare release jenkins-1.522
2013-07-06 07:57:39 -07:00
Christoph Kutzinski
04d85eb476
Loading the last 3 successful builds may be very expensive in certain rare, but possible situations (all newer builds failed, only some very old builds were successful).
...
Go only up to 6 build into the past for calculating the estimated duration.
Also take failed builds into account, if we don't find any successful ones.
2013-07-06 15:19:27 +02:00
Christoph Kutzinski
95ac644029
fixed some warnings
2013-07-06 11:54:25 +02:00
Christoph Kutzinski
7154363803
This helps a lot when mocking AbstractProject in unit tests, because so I don't have to suppress the constructor with PowerMockito
2013-07-06 11:26:14 +02:00
Kohsuke Kawaguchi
059e6081d0
[FIXED JENKINS-18585]
...
The earlier fix by @ssogabe broke the test. This fix corrects the
problem properly.
The reason this error happens with some plugins is that if there's an
input field whose name is "on", then even after prototype.js extends
an element object, "form.on" will refer to the input element, not the
prototype.js function to add an event handler.
2013-07-04 11:11:50 -07:00
Nicolas De Loof
aa7eb7c137
check name conflicts in local ItemGroup
2013-07-04 11:55:03 +02:00
Kohsuke Kawaguchi
c928291541
more bug fix
2013-07-03 21:50:19 -07:00
Kohsuke Kawaguchi
6dea054125
bug fix
...
(cherry picked from commit d8f74cf866 )
2013-07-03 21:38:57 -07:00
Kohsuke Kawaguchi
d8f74cf866
bug fix
2013-07-03 12:00:51 -07:00
Vojtech Juranek
4f2626aaac
Add convenient method for checking if object is MatrixProject
...
This is useful for jelly pages where instanceof operator doesn't work.
2013-07-03 16:11:15 +02:00
Glöckle Bastian
40f3b095aa
[FIXES JENKINS-15976] After de-serializing changed job settings after "Save", the maven settings done by config-file-provider-plugin were overwritten blindly (presumably with fallback values). These fallback values should be set correctly in the constructor of the "Maven" class and do not need to be set explicitly after deserialization.
2013-07-03 14:56:14 +02:00
Stephen Connolly
55bf883290
If every node is restricted to tied jobs only, Matrix build jobs can never start.
2013-07-03 10:20:19 +01:00
Stephen Connolly
503c3bd2e6
[FIXES JENKINS-2494] Restore correct behaviour
...
- Fixes a regression in core where the display name clear on copy was triggering a save
- More than one way to do this, could also have used the marker interface approach
This route seems slightly less fragile, though people could still add ItemListeners
with order == -Double.MAX_VALUE which would then introduce intdeterminism.
A marker interface would remove that indeterminism as the onCopyComplete method would
be only called on the Job as the last method... but it could be hard to
ensure that all ItemGroupMixin's respect the calling of onCopyComplete contract
hence this approach seems better to me for that reason
2013-07-03 10:02:24 +01:00
Stephen Connolly
817237d732
Update stale javadoc
...
- The caller is no longer responsible as the listener is actually invoked from the method
2013-07-03 09:57:37 +01:00
Kohsuke Kawaguchi
c15dc50acd
the trunk is toward 1.523-SNAPSHOT
2013-07-02 23:48:06 -07:00
Kohsuke Kawaguchi
7facc7733c
[FIXED JENKINS-18589]
...
Use DescribableList to handle the copy-on-write semantics correctly. The vector class just doesn't cut it, and we've been setting a new value to this field, which will violates all sorts of the concurrent programming practice.
This change has the nice side effect of removing {{class="vector"}} from the persisted XML. A test is added to make sure we can still read back such an XML.
2013-07-02 15:44:55 -07:00
Kohsuke Kawaguchi
f014d7ac9c
Pushing the dependency computation down to another thread.
2013-07-02 15:44:55 -07:00
Kohsuke Kawaguchi
5a547c91fb
Fixed an overzealous form validation
2013-07-02 15:44:55 -07:00
Seiji Sogabe
6ceafac2cd
added l10n(ja)
2013-07-02 11:32:25 +09:00
Kohsuke Kawaguchi
82404407f2
removed Java 1.6 dependency
2013-07-01 18:27:25 -07:00
Kohsuke Kawaguchi
f7671e621e
not sure which code is triggering animal sniffer violation
2013-07-01 18:19:05 -07:00
Kohsuke Kawaguchi
43ecda6d2d
Forgot to close the file
2013-07-01 18:01:01 -07:00
Kohsuke Kawaguchi
14d980c437
[FIXED JENKINS-15382]
...
Revisiting the fix. Avoid parsing the entire text by only looking at the tail portion.
2013-07-01 17:58:10 -07:00
Kohsuke Kawaguchi
047233eb48
Don't do memory mapped file unless it's helpful.
...
This will hopefully reduce the file locking problems on Windows.
2013-07-01 17:58:10 -07:00
Kohsuke Kawaguchi
59f0f32ff6
no longer only about UTF-8
2013-07-01 17:58:10 -07:00
ssogabe
0256f0a74e
fixed a javascript error in job configuration page.
...
see
https://github.com/jenkinsci/jenkins/commit/2ffece9d737f4a77ed4059c777948299daf22771#commitcomment-3526425
2013-06-30 22:01:34 +09:00
Olivier Lamy
13ae5c7936
[JENKINS-15846] Deadlock during Maven builds Parsing POM step
...
Do not use anymore shaded version of wagon-http as it we can control commons-logging version
2013-06-29 23:17:50 +10:00
Kohsuke Kawaguchi
4f828a32f7
expand the detail reporting
2013-06-28 18:26:34 -07:00
Kohsuke Kawaguchi
b834346912
this makes no sense.
...
- if the user is anonymous, he'd go to HudsonAUthenticationEntryPoint, not here.
- even if there is some code path that comes here, there's no guarnatee that SecurityRealm in charge wants a login form.
2013-06-28 18:21:55 -07:00
Kohsuke Kawaguchi
d6ac6aabaf
report the details of the access control rejection to assist trouble-shooting
2013-06-28 18:10:18 -07:00
Kohsuke Kawaguchi
63afbdee4a
chain the root cause.
...
This allows HudsonAuthenticationEntryPoint to access which permission was needed
2013-06-28 18:09:43 -07:00
Kohsuke Kawaguchi
951b9a0823
copied verbatim from org.acegisecurity.ui.ExceptionTranslationFilter
...
... before making any modification.
The original version is acegi-security 1.0.7
2013-06-28 18:01:49 -07:00
Kohsuke Kawaguchi
735713801b
[FIXED JENKINS-18438]
...
Node monitoring should run in parallel to reduce the total round-trip
time in large instances.
2013-06-26 16:29:43 -07:00
Harald Albers
208cf9cddc
fixed typo
2013-06-26 16:42:37 +02:00
Oliver Gondža
0c65654699
Merge branch 'master' into jenkins18393
2013-06-26 14:20:25 +02:00
lvotypko
14b3d918f0
User friendly response if deletion of a build fails
2013-06-26 13:36:58 +02:00
Kohsuke Kawaguchi
db9fe324b7
the trunk is toward 1.522-SNAPSHOT
2013-06-26 00:04:25 -07:00
Kohsuke Kawaguchi
1fcfb9e440
[maven-release-plugin] prepare release jenkins-1.520
2013-06-25 22:54:41 -07:00
Kohsuke Kawaguchi
0b8917b344
fixed test regressions
2013-06-25 17:04:26 -07:00
Christoph Kutzinski
8caa1a04f2
Minimal refactoring for a8c3a031c0
...
IMO this needs further refactoring - respect separation of concerns:
it's not AbstractProject's call to trigger a node offline
2013-06-25 21:49:33 +02:00