Commit Graph
11799 Commits
Author SHA1 Message Date
Jesse Glick 3e7218ce44 Orphaned messages file. 2013-03-27 12:38:40 -04:00
Jesse Glick ebecde8cb9 Restored some orphaned translations. 2013-03-27 11:51:44 -04:00
Andrew Mann 00b28d40e2 Merge branch 'master' into JENKINS-16942 2013-03-26 00:51:49 -05:00
Andrew Mann 398fa74da0 Replace \r\n with system property line.separator
Implementing change as suggested by vjuranek
2013-03-25 21:08:54 -05:00
Kohsuke Kawaguchi 57900a2355 Trunk is toward 1.510 2013-03-25 14:10:03 -07:00
Kohsuke Kawaguchi a114c693bc [FIXED JENKINS-7291] Permit flyweight tasks to run on master even when it has zero configured executors.
Always adding Computer for master as a fallback

The original proposed fix for JENKINS-7291 creates a Computer object
transitively. This seems unwise as it violates the design of Computer
as stated in the javadoc, and for example we can end up creating two
Computers for the master.

I think a better fix is to create a Computer for the master all the
time, even if there's no executors configured. The discrimination in
Queue.makeBuildable would ensure that such phantom Computer is only used
as a last resort (statistically speaking).

I've also tweaked executors.jelly a bit. I simplified it somewhat
based on the idea that "if there's only one computer to show, the
context is likely making it obvious".

(I must be missing the intricacy in the current code.)

Originally developed in a branch at
2c5b57fcc1 then squashed for clarity.
2013-03-25 11:22:20 -07:00
Jesse Glick 7f92a9bd1a [JENKINS-17311] Improved hashify to detect manual skip idiom. 2013-03-25 13:34:49 -04:00
Kohsuke Kawaguchi b41278d1ab Merge branch 'pull-743' 2013-03-25 09:53:35 -07:00
Kohsuke Kawaguchi 8f6bfcdabc marking the release 2013-03-25 09:53:28 -07:00
Kohsuke Kawaguchi 17e7d7a1e6 minor touch-up and documentation
as I was playing with it to understand what those logics mean.
2013-03-25 09:51:24 -07:00
Kohsuke Kawaguchi 4335d96bd8 introduced a constant since H/1 really doesn't mean H. 2013-03-25 09:40:51 -07:00
Kohsuke Kawaguchi ed712a783c merging this toward 1.509 2013-03-25 09:27:55 -07:00
Jesse Glick 3d433ab67e @since up in the air. 2013-03-25 12:01:53 -04:00
Jesse Glick 6871618022 Merge branch 'master' into ACL.impersonate 2013-03-25 11:59:36 -04:00
Pei-Tang Huang 232f67556d Aligned Traditional Chinese translation with commit
aa43283942.
2013-03-25 21:14:50 +08:00
Pei-Tang Huang 9eb2306ec0 Aligned Traditional Chinese translations with commit
d8b29df355.
2013-03-25 21:11:24 +08:00
Pei-Tang Huang 4e723c5fb1 Aligned Traditional Chinese with commit
f6a2f64bd6.
2013-03-25 21:08:20 +08:00
Pei-Tang Huang 33d6bd91d3 Aligned Traditional Chinese with commit
5537213fcf.
2013-03-25 21:03:50 +08:00
Andrew Mann 899f5aa417 Fix for JENKINS-16942
https://issues.jenkins-ci.org/browse/JENKINS-16942

PrintWriter.println() uses the OS specific line separator. When
SecretRewriter rewrites the secret file, the lines are converted to the
format of the running OS.  The test case does not account for this.
Since the test case is coded expecting line endings of \n, this fix
converts \r\n to \n before comparing.
2013-03-25 00:35:41 -05:00
Kohsuke Kawaguchi 061a4840e4 the trunk is toward 1.509-SNAPSHOT 2013-03-24 22:13:21 -07:00
Seiji Sogabe aa43283942 i18n & l10n(ja) for HudsonPrivateSecurityRealm 2013-03-24 20:37:16 +09:00
Jesse Glick a941338b8a Promote use of crontab hashes in documentation and form validation. 2013-03-22 18:23:54 -04:00
mspring 5537213fcf added to online help about concurrent builds: a paragraph about using the hudson.slaves.WorkspaceList system property for configuring the separator 2013-03-22 14:29:46 -07:00
Jesse Glick b8151b5723 Merge branch 'master' into cron-hash-JENKINS-17311 2013-03-22 17:29:11 -04:00
Kohsuke Kawaguchi 3d2acbcda0 fixing loose-ends as pointed out by Jesse 2013-03-22 21:00:52 +01:00
Jesse Glick ccf8427ae7 Merge branch 'master' into cron-hash-JENKINS-17311 2013-03-22 15:42:56 -04:00
Jesse Glick f6a2f64bd6 Test & I18N for checkSanity. 2013-03-22 15:42:23 -04:00
Jesse Glick 3e71c97639 hudson.scheduler.BaseParser.hash=true by default: @daily should not necessarily mean 12:00 AM. 2013-03-22 15:26:59 -04:00
Jesse Glick 67c0edd014 Support skips with hash syntax. 2013-03-22 15:17:01 -04:00
Seiji Sogabe d8b29df355 [FIXED JENKINS-16608] View name should not allow "..". 2013-03-23 03:40:43 +09:00
vjuranek 4a39c5ab04 Merge pull request #729 from vjuranek/fix_pull646
[FIXED JENKINS-17084] Changelog should produce output even if some chang...
2013-03-22 04:15:36 -07:00
vjuranek 8ef261ef8d Merge pull request #730 from vjuranek/label_cast_exception
[FIXED JENKINS-17128] Unquote labels before processing
2013-03-22 04:14:59 -07:00
Jesse Glick a689c472ab More pleasant way to test bitsets. 2013-03-21 18:05:51 -04:00
Jesse Glick 7f10717451 More tests of hash syntax. 2013-03-21 16:56:18 -04:00
Jesse Glick f9638163a9 fromdos 2013-03-21 16:39:32 -04:00
Jesse Glick e94152df33 Avoiding printing anything unless there is actually a failure.
Also take advantage of JUnit’s ability to show the exact spot of a mismatch between two strings.
2013-03-21 16:30:29 -04:00
Jesse Glick c454eaacf4 ohtake’s 20249e4 accidentally suppressed all but one test case. 2013-03-21 15:32:09 -04:00
Jesse Glick b0f30aba2e Merge branch 'master' of github.com:jenkinsci/jenkins 2013-03-21 14:49:59 -04:00
Jesse Glick fdc090a3ae [FIXED JENKINS-13154] AnnotationMapper bug was causing massive lock contention when saving fingerprints. 2013-03-21 14:49:09 -04:00
Kohsuke Kawaguchi 8a3e909d26 [FIXED JENKINS-7813]
Fixed the throughput problem between master/slave communication.
This fix contains two independent problems.

One was in the remoting. During a large sustained data transfer
(such as artifact archiving and large test reports), the way we
were doing flow control and ACK-ing were penalizing us badly.
I improved the flow control algorithm in remoting 1.23, and also
increased advertised window size so that the transfer can saturate
available bandwidth even when a latency is large. (And unless
the reader side is excessivesly slow, this shouldn't increase
any memory consumption.)

The other fix was in trilead-ssh2, which is our SSH client
implementation used by ssh-slaves plugin. The buffer size for flow
control was too small. I improved the way buffering is done to reduce
the memory footprint when the reader closely follows the writer, then I
increased the advertised window size. Again, this shouldn't increase
memory consumption (in fact it'll likely actually reduce them) unless
the reader end gets abandoned.

On my simulated latency-injected network, the sustained transfer rate is
now on par with scp. We win for smaller files because of the TCP slow
start penality that scp would incur, and we lose a bit as files get
larger due to additional framing overhead.

If you have manually extracted slave.jar and placed them on slaves, you
need to update them to 2.23 to see the performance benefits.
2013-03-21 18:07:46 +01:00
Jesse Glick c49d6b5b3b Use TemporaryFolder to good effect.
Prevents us from leaving behind a temp dir with cyclic symlinks, which breaks JGit’s clean function.
That in turn can cause test builds to break:
https://jenkins.ci.cloudbees.com/job/core/job/jenkins_main_trunk/783/console
Cleaning workspace
FATAL: Could not delete file …/workspace/core/jenkins_main_trunk/core/target/hudson5309354136960541268tmp/c/symlink/c/symlink/c/symlink/…/c/foo.xml
org.eclipse.jgit.api.errors.JGitInternalException: Could not delete file …/workspace/core/jenkins_main_trunk/core/target/hudson5309354136960541268tmp/c/symlink/c/symlink/c/symlink/…/c/foo.xml
	at org.eclipse.jgit.api.CleanCommand.call(CleanCommand.java:137)
	at org.jenkinsci.plugins.gitclient.JGitAPIImpl.clean(JGitAPIImpl.java:305)
	at hudson.plugins.git.GitAPI.clean(GitAPI.java:248)
	at hudson.plugins.git.GitSCM$4.invoke(GitSCM.java:1213)
	at hudson.plugins.git.GitSCM$4.invoke(GitSCM.java:1196)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2236)
	at hudson.remoting.UserRequest.perform(UserRequest.java:118)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:326)
	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
	at java.util.concurrent.FutureTask.run(FutureTask.java:166)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:722)
Caused by: java.io.IOException: Could not delete file …/workspace/core/jenkins_main_trunk/core/target/hudson5309354136960541268tmp/c/symlink/c/symlink/c/symlink/…/c/foo.xml
	at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:142)
	at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:126)
	at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:126)
	…
	at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:126)
	at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:126)
	at org.eclipse.jgit.api.CleanCommand.call(CleanCommand.java:132)
	... 14 more
2013-03-20 11:23:01 -04:00
Stephen Connolly a16c59bfb8 This code was borked as SlaveComputer is not serializable and we are passing an implicit ref to the outer class.
- I suspect that nobody has ever used this method given the lack of conversion to static inner class required to make it work
2013-03-20 11:12:35 +00:00
Jesse Glick 845bf37a44 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-03-19 18:40:01 -04:00
Jesse Glick 3370e6edf5 [FIXED JENKINS-3265] Hotfix for regression in matrix project loading from 25084f5. 2013-03-19 18:39:40 -04:00
Harald Albers 377e3136b3 updated comment 2013-03-19 19:23:47 +01:00
Pei-Tang Huang 59b4637480 Aligned Traditional Chinese translation with
f43cde68a8.
2013-03-19 23:32:05 +08:00
Jesse Glick 78b263421f [FIXED JENKINS-17271] Util.deleteFile should give a concrete reason for failure. 2013-03-19 11:05:21 -04:00
Jesse Glick 606a9e1de9 File.setWritable should be the first, and if possible only, thing we try for makeWritable. 2013-03-19 10:13:19 -04:00
Jesse Glick 4d8843c991 There is no ‘title’ format key. 2013-03-18 18:28:58 -04:00
Jesse Glick f2508b36ed [FIXED JENKINS-17263] Correctly display current Jenkins.mode. 2013-03-18 18:28:08 -04:00