b5ed319 already caught linkage errors but then unconditionally returned false from Util.isSymlink, which is wrong;
we want to fall back to the generic File.canonicalPath comparisons in this case.
There are several incompatibilities in XStream 1.4 that resulted in our
changing the core, but according to the text search on all the public
plugins, none of these changes affect the 600+ plugins we have today.
However, it is still possible that there are some parts of XStream 1.3
that plugins depend on but the core doesn't depend on --- we won't be
able to tell those problems at this point.
Not observed in actual usage, but reproducible (for me at least, though apparently not ci.jenkins-ci.org) in a test:
java.lang.AssertionError: null
at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:628)
at jenkins.model.lazy.AbstractLazyLoadRunMap.all(AbstractLazyLoadRunMap.java:581)
at jenkins.model.lazy.AbstractLazyLoadRunMap.entrySet(AbstractLazyLoadRunMap.java:243)
at java.util.AbstractMap$2$1.<init>(AbstractMap.java:378)
at java.util.AbstractMap$2.iterator(AbstractMap.java:377)
at hudson.util.RunList.iterator(RunList.java:103)
at hudson.util.RunList.size(RunList.java:114)
at hudson.maven.MavenProjectTest.testDeleteSetBuildDeletesModuleBuilds(MavenProjectTest.java:159)
(Generally there is no reason to subclass a Descriptor type which is already an @Extension rather than an explicit abstract supertype, but this is a bit more conservative change than just making it final.)
removed translations from GlobalSecurityConfiguration and jenkins/model/Jenkins
that should only exist in GlobalQuietPeriodConfiguration and config-quietPeriod
added translations based on messages from corresponding locations
removed translations from GlobalSecurityConfiguration and jenkins/model/Jenkins
that should only exist in GlobalSCMRetryCountConfiguration and config-retryCount
added translation based on messages from corresponding locations
corrected wrong property names
* core/src/main/resources/lib/form/combobox/combobox.js
Increase index to 100, so that parent form elements can be initialized before
parameters in fillDependsOn are extracted.
* test/src/test/java/lib/form/ComboBoxTest.java
* test/src/test/resources/lib/form/ComboBoxTest/CompoundField/config.jelly
* test/src/test/resources/lib/form/ComboBoxTest/CompoundFieldComboBoxBuilder/config.jelly
New test to confirm null is not passed for relative dependent arguments
Traditionally, matrix axis values are only exposed as "build variables", and it was up to individual build steps and others to treat them equally like environment variables.
However, in practice, this distinction between environment variables vs build variables didn't serve any useful purposes, and the down side (of some plugins only expanding env vars in the ${VAR} notation and not build variables) was probably bigger than whatever benefit this distinction was supposed to bring.
In this fix, we are exposing matrix axis values also as environment variables. This will make them recognizable from plugins that only expand environment variables, such as parameterized trigger plugins as indicated in the original bug report.
This was motivated by pull request #701 but fix was made differently.
The Actionable#getActions() method only needs to be synchronized when lazy loading. After that, the synchronization is superfluous and impacts performance.
Since the field is volatile, the double-check block works in JDK5+. See http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html for more in
Analyzing various thread dumps, many threads and requests stall on this method waiting for the lock. Since the lock isn't necessary in most cases anyway,
- Environment variables are by convention upper case, so I'm switching to upper case. This was what the original ticket requested anyway.
- Since the ".jobName" was never documented to begin with, let's not promote that and stick to "_JOBNAME" as the official version.
removed some translations from GlobalSecurityConfiguration and jenkins/model/Jenkins
that should only exist in MasterComputer, DumbSlave & MasterBuildConfiguration