Commit Graph
11799 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 516c4a7430 leaving notes for future TODO 2012-09-20 13:15:40 -07:00
Kohsuke Kawaguchi 5b00127eab Needs to copy the collection before it mutates them. 2012-09-20 11:31:05 -07:00
Jesse Glick f5a7869506 Null safety of Trigger.timer.
A botched startup (say by an error in InitializerFinder) can cause log to be filled with junk like:
Sep 20, 2012 1:10:50 PM hudson.ExtensionFinder$GuiceFinder instantiate
WARNING: Failed to load hudson.node_monitors.DiskSpaceMonitor
java.lang.InstantiationException: java.lang.ExceptionInInitializerError
	at net.java.sezpoz.IndexItem.instance(IndexItem.java:193)
	at hudson.ExtensionFinder$GuiceFinder.instantiate(ExtensionFinder.java:353)
	at hudson.ExtensionFinder$GuiceFinder.access$400(ExtensionFinder.java:232)
	at hudson.ExtensionFinder$GuiceFinder$SezpozModule$1.get(ExtensionFinder.java:509)
	at com.google.inject.internal.ProviderInternalFactory.provision(ProviderInternalFactory.java:84)
	at com.google.inject.internal.InternalFactoryToInitializableAdapter.provision(InternalFactoryToInitializableAdapter.java:52)
	at com.google.inject.internal.ProviderInternalFactory.circularGet(ProviderInternalFactory.java:66)
	at com.google.inject.internal.InternalFactoryToInitializableAdapter.get(InternalFactoryToInitializableAdapter.java:45)
	at com.google.inject.internal.ProviderToInternalFactoryAdapter$1.call(ProviderToInternalFactoryAdapter.java:46)
	at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1018)
	at com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:40)
	at com.google.inject.Scopes$1$1.get(Scopes.java:59)
	at hudson.ExtensionFinder$GuiceFinder$4$1.get(ExtensionFinder.java:420)
	at com.google.inject.internal.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:41)
	at com.google.inject.internal.InjectorImpl$3$1.call(InjectorImpl.java:965)
	at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1011)
	at com.google.inject.internal.InjectorImpl$3.get(InjectorImpl.java:961)
	at hudson.ExtensionFinder$GuiceFinder._find(ExtensionFinder.java:389)
	at hudson.ExtensionFinder$GuiceFinder.find(ExtensionFinder.java:380)
	at hudson.ExtensionFinder._find(ExtensionFinder.java:149)
	at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:289)
	at hudson.ExtensionList.load(ExtensionList.java:278)
	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:231)
	at hudson.ExtensionList.getComponents(ExtensionList.java:149)
	at hudson.DescriptorExtensionList.load(DescriptorExtensionList.java:182)
	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:231)
	at hudson.ExtensionList.size(ExtensionList.java:157)
	at java.util.AbstractCollection.isEmpty(AbstractCollection.java:86)
	at hudson.model.labels.LabelAtom.updateTransientActions(LabelAtom.java:107)
	at hudson.model.labels.LabelAtom.load(LabelAtom.java:189)
	at jenkins.model.Jenkins.getLabelAtom(Jenkins.java:1545)
	at jenkins.model.Jenkins.getSelfLabel(Jenkins.java:2422)
	at hudson.model.Node.getAssignedLabels(Node.java:240)
	at jenkins.model.Jenkins$17.run(Jenkins.java:2499)
	at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:146)
	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:259)
	at jenkins.model.Jenkins$7.runTask(Jenkins.java:875)
	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:187)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:94)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
	at java.lang.Thread.run(Thread.java:722)
Caused by: java.lang.ExceptionInInitializerError
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:601)
	at net.java.sezpoz.IndexItem.instance(IndexItem.java:183)
	... 41 more
Caused by: java.lang.NullPointerException
	at hudson.node_monitors.AbstractNodeMonitorDescriptor.schedule(AbstractNodeMonitorDescriptor.java:73)
	at hudson.node_monitors.AbstractNodeMonitorDescriptor.<init>(AbstractNodeMonitorDescriptor.java:58)
	at hudson.node_monitors.AbstractNodeMonitorDescriptor.<init>(AbstractNodeMonitorDescriptor.java:54)
	at hudson.node_monitors.DiskSpaceMonitorDescriptor.<init>(DiskSpaceMonitorDescriptor.java:49)
	at hudson.node_monitors.DiskSpaceMonitor$1.<init>(DiskSpaceMonitor.java:62)
	at hudson.node_monitors.DiskSpaceMonitor.<clinit>(DiskSpaceMonitor.java:62)
	... 46 more
2012-09-20 13:38:36 -04:00
Kohsuke Kawaguchi b4888f2dd1 bug fix 2012-09-20 10:12:58 -07:00
Kohsuke Kawaguchi e357135e9f Rewrote RunList to derive from List, not ArrayList.
This is a signature breaking change, but it's critical in avoiding
unnecessary record load operations.
To my limited repository search, I couldn't find any use in a plugin
where RunList is casted to ArrayList, so hopefully this would be safe
enough.
2012-09-19 16:52:34 -07:00
Kohsuke Kawaguchi 0500ec9c27 overridden a number of Job methods in AbstractProject to avoid the slow path (of loading everything) 2012-09-19 15:29:08 -07:00
Kohsuke Kawaguchi b35678d5c1 fixed a regression in a test. 2012-09-19 14:31:13 -07:00
Jesse Glick a885cc2179 [FIXED JENKINS-7214] FilePath.validateAntFileMask too slow for /configure. 2012-09-19 16:43:20 -04:00
Jesse Glick 347bca5e5a testValidateAntFileMask 2012-09-19 16:03:26 -04:00
Jesse Glick 30de1dd47c Merge branch 'master' into slow-people-15206
Conflicts:
	changelog.html
2012-09-18 20:53:04 -04:00
Jesse Glick cf621d8caf Merge branch 'master' of github.com:jenkinsci/jenkins 2012-09-18 20:52:07 -04:00
Jesse Glick f9583b89c4 [FIXED JENKINS-15226] Log recorders do not work reliably. 2012-09-18 20:51:23 -04:00
Jesse Glick 968bc6019b Should not log full payload. 2012-09-18 20:40:57 -04:00
Jesse Glick 5c5bfeb099 @since 2012-09-18 20:10:25 -04:00
Jesse Glick 01a93320ef No need to really wait the first time. 2012-09-18 20:07:19 -04:00
Jesse Glick 6e87498608 Forgotten link. 2012-09-18 20:03:04 -04:00
Jesse Glick 3a603cf578 e.setAttribute('a', v) is apparently different from e.a=v. 2012-09-18 19:32:09 -04:00
Jesse Glick e630819f5f Using ts_refresh to resort properly. 2012-09-18 19:06:47 -04:00
Jesse Glick c6f17d097e ts_refresh 2012-09-18 19:06:23 -04:00
Jesse Glick 4543ad3f84 Do initial refresh asynch; seems to work better with some kinds of HTML. 2012-09-18 19:05:51 -04:00
Jesse Glick eb1a1ffa94 AsynchPeople 2012-09-18 18:27:16 -04:00
Jesse Glick 66191909c9 .className, not .class. 2012-09-18 17:50:52 -04:00
Jesse Glick 4f7b5f3b25 ProgressiveRendering 2012-09-18 16:58:15 -04:00
Kohsuke Kawaguchi 93321854f2 off by one bug.
toKey-1 won't work as intended when toKey is Integer.MIN_VALUE.
2012-09-18 09:39:48 -07:00
Kohsuke Kawaguchi 25ed3c5818 RunMap should be in the descending order 2012-09-17 18:37:01 -07:00
Kohsuke Kawaguchi bbe74db920 when new objects are added programmatically, disk index needs to be updated or else search() will not find them 2012-09-17 17:40:53 -07:00
Kohsuke Kawaguchi 64ab2ca200 Added efficient contains() method 2012-09-17 17:40:32 -07:00
Kohsuke Kawaguchi b0541e4bbe Having two neighbors pointing to each other is important to make RunMap.removeValue work.
Why, you may ask?

Think of neighbors A, B. If A points to B but B doesn't point to A, when B is removed A will still end up pointing B as the next build.
2012-09-17 17:04:11 -07:00
Kohsuke Kawaguchi 7f72bf1a22 otherwise the assert in initBaseDir will fail right away 2012-09-17 17:03:18 -07:00
Kohsuke Kawaguchi 456f14ce52 remove(R) collides with remove(Object) at AbstractLazyLoadRunMap. So renaming a method.
RunMap.remove(R) needs to be still called remove(R) to remain compatible
2012-09-17 16:48:20 -07:00
Kohsuke Kawaguchi 7741f96ba3 fix up next/previous build links 2012-09-17 16:45:26 -07:00
Kohsuke Kawaguchi eec63febb9 for now don't let plugins consume this 2012-09-17 16:36:25 -07:00
Kohsuke Kawaguchi 6b5a2f6a8f initialize with empty index to allow operation without ever calling initBaseDir() 2012-09-17 16:35:52 -07:00
Kohsuke Kawaguchi b2fecdf860 merged up with AbstractLazyLoadRunMap 2012-09-17 16:18:24 -07:00
Kohsuke Kawaguchi 9e86629c76 Use 'this' as a lock to remain compatible with RunMap 2012-09-17 16:18:08 -07:00
Kohsuke Kawaguchi fb3fea037f adding remove() because RunMap needs it 2012-09-17 16:03:13 -07:00
Kohsuke Kawaguchi 8fc8915f6f added mutation methods 2012-09-17 15:33:23 -07:00
Kohsuke Kawaguchi ab4b0e1e20 byId needs to be copied, too 2012-09-17 15:08:32 -07:00
Kohsuke Kawaguchi 2e91bcb99a these methods actually return unmodifiable stuff. 2012-09-17 14:55:02 -07:00
Kohsuke Kawaguchi bc1fdc170e minor adjustments
- doc improvements
- SortedStringList actually isn't String specific
2012-09-17 14:53:10 -07:00
Kohsuke Kawaguchi 580a463ab8 Renaming packages 2012-09-17 14:28:30 -07:00
Kohsuke Kawaguchi f952411b86 Merge branch 'master' into lazy-load 2012-09-17 14:18:27 -07:00
Kohsuke Kawaguchi 00b0ebcdf8 moving into positions to be merged into the mainline 2012-09-17 14:18:23 -07:00
Baptiste Mathus 0d69b0b15b Updating file to use keys from Messages.properties.
I also tried to update french translation so that
it's closer to the english version meaning.
2012-09-17 22:49:04 +02:00
Baptiste Mathus 9b4d0b0864 Fixing a typo well-hidden in unicode-escaped characters. 2012-09-17 22:48:04 +02:00
Jesse Glick 991072bf72 Constraining type of People.parent at least a little bit, to ModelObject.
(Its index.jelly does assume getDisplayName is available.)
2012-09-17 15:58:27 -04:00
Kohsuke Kawaguchi 1906f601ed the trunk is toward 1.484-SNAPSHOT 2012-09-16 20:49:46 -07:00
Olivier Lamy 583fb5115e Merge pull request #565 from aerickson/fix_npe_due_to_change_node_offline_note_feature
fixing NPE introduced by change offline note feature
Thanks
2012-09-14 15:01:29 -07:00
Kohsuke Kawaguchi e1b7ac281b Merge branch 'pull-566' 2012-09-14 14:57:29 -07:00
Andrew J. Erickson 37e14044d9 small tweaks
no need to call toString() on the string
add comments
2012-09-14 14:57:02 -07:00