Commit Graph
11799 Commits
Author SHA1 Message Date
Ryan Campbell eef3e4e7ad Put Computer.CREATE in the COMPUTER permission group 2012-06-15 12:58:46 -05:00
Kohsuke Kawaguchi 4e7a43c586 [FIXED JENKINS-14113]
The proposed fix https://github.com/buckett/jenkins/commit/eec16f1b6156aea76bd0cc6e0262538713ebffb6 has a problem in that it'd allow anything that has the given URL name as a prefix.
2012-06-14 17:01:10 -07:00
Kohsuke Kawaguchi 9272e67d79 Expose /computer/(master)/configure for master's node properties. 2012-06-14 16:46:16 -07:00
Kohsuke Kawaguchi e6cc6b1c22 doc improvement 2012-06-14 16:45:22 -07:00
Vojtech Juranek 851cb17cda Evn variable wasn't actually populated by computer variables 2012-06-14 21:26:13 +02:00
Olivier Lamy 5379a8100c Merge pull request #496 from lvotypko/url-without-ampersand
Fix UtilTest and replace ampersand in method encode too
Thanks !
2012-06-14 05:56:56 -07:00
Kohsuke Kawaguchi 03a63ea8b2 the trunk is toward 1.472-SNAPSHOT 2012-06-13 10:47:17 -07:00
lvotypko c667523d44 Fix UtilTest and replace ampersand in method encode too 2012-06-13 13:17:19 +02:00
OHTAKE Tomohiro 1a42a2f071 Update doc for #494 2012-06-13 17:44:52 +09:00
OHTAKE Tomohiro ea9ff25f98 Make it easier to see which characters will be encoded 2012-06-13 17:43:06 +09:00
Olivier Lamy bdaf5eadc2 Merge pull request #494 from lvotypko/url-without-ampersand
Do not use & in url
Thanks
2012-06-13 00:31:30 -07:00
lvotypko fed2d0ff47 Do not use & in url 2012-06-13 09:20:46 +02:00
Kohsuke Kawaguchi 368bd249b7 merged back the RC branch
Conflicts:
	changelog.html
	cli/pom.xml
	core/pom.xml
	maven-plugin/pom.xml
	pom.xml
	test/pom.xml
	ui-samples-plugin/pom.xml
	war/pom.xml
2012-06-11 23:32:36 -07:00
Kohsuke Kawaguchi 44de58394a [maven-release-plugin] prepare for next development iteration 2012-06-11 21:48:25 -07:00
Kohsuke Kawaguchi 6fcc4bac9b [maven-release-plugin] prepare release jenkins-1.469 2012-06-11 21:48:24 -07:00
Kohsuke Kawaguchi 3445fe1943 Not exactly sure if these are truly needed, but J-on-J otherwise fails with compilation error.
It's apparently failing to properly deduce the JobT type. Making it explicit to avoid stretching the compiler
2012-06-11 17:55:51 -07:00
Kohsuke Kawaguchi 40c10ff6eb Fixed a regression in 1.468 that broke LDAP
Stack trace:

org.jvnet.hudson.reactor.ReactorException: java.lang.IllegalAccessError: tried to access method hudson.security.SecurityRealm.findBean(Ljava/lang/Class;Lorg/springframework/context/ApplicationContext;)Ljava/lang/Object; from class hudson.security.LDAPSecurityRealm$LDAPUserDetailsService
  at org.jvnet.hudson.reactor.Reactor.execute(Reactor.java:246)
  at jenkins.InitReactorRunner.run(InitReactorRunner.java:43)
  at jenkins.model.Jenkins.executeReactor(Jenkins.java:885)
  at jenkins.model.Jenkins.<init>(Jenkins.java:790)
  at hudson.model.Hudson.<init>(Hudson.java:81)
  at hudson.model.Hudson.<init>(Hudson.java:77)
  at hudson.WebAppMain$2.run(WebAppMain.java:217)
Caused by: java.lang.IllegalAccessError: tried to access method hudson.security.SecurityRealm.findBean(Ljava/lang/Class;Lorg/springframework/context/ApplicationContext;)Ljava/lang/Object; from class hudson.security.LDAPSecurityRealm$LDAPUserDetailsService
  at hudson.security.LDAPSecurityRealm$LDAPUserDetailsService.<init>(LDAPSecurityRealm.java:419)
  at hudson.security.LDAPSecurityRealm.createSecurityComponents(LDAPSecurityRealm.java:369)
  at hudson.security.SecurityRealm.getSecurityComponents(SecurityRealm.java:398)
  at hudson.security.HudsonFilter.reset(HudsonFilter.java:134)
  at jenkins.model.Jenkins.setSecurityRealm(Jenkins.java:1960)
  at jenkins.model.Jenkins$17.run(Jenkins.java:2524)
  at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:146)
  at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:259)
  at jenkins.model.Jenkins$7.runTask(Jenkins.java:874)
  at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:187)
  at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:94)
  at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
  at java.lang.Thread.run(Thread.java:680)
2012-06-11 17:31:07 -07:00
Kohsuke Kawaguchi 2b9b49101c allow SCM classes to have buildEnv.groovy since SCM can contirbute environment variables 2012-06-11 15:36:17 -07:00
Kohsuke Kawaguchi bc0b850510 Merge branch 'pull-434.2' 2012-06-11 15:23:28 -07:00
Kohsuke Kawaguchi 72fbaba275 Refactored existing static list into CoreEnvironmentContributor. 2012-06-11 15:21:57 -07:00
Kohsuke Kawaguchi 08d870baeb this should be done in the reverse order. 2012-06-11 14:24:09 -07:00
Kohsuke Kawaguchi 36b84a5d7f moving the logic from core to an extension point implementation 2012-06-11 14:23:04 -07:00
Kohsuke Kawaguchi 559656679c added a convenience method 2012-06-11 14:21:49 -07:00
Kohsuke Kawaguchi 5d78f3c958 Merge branch 'pull-449' 2012-06-11 11:54:46 -07:00
Kohsuke Kawaguchi d5513b0bd5 Reworked the dynamically modifiable Axis.
I thought about this and decided that the best way to incorporate this
expansion of the abstraction is to think of it as a re-configuration of
project right before the build.

This resolves my concern with the previous change of calling expensive
rebuildConfigurations() from every getActiveConfigurations() call (and
getter shouldn't have a side-effect, right?)

Also, in this way, Axis gets a reference to MatrixBuildExecution, so it
makes it more explicit that the Axis can update values based on the
current build.
2012-06-11 11:51:11 -07:00
Emanuele Zattin 5f7d239c6f Added support for runtime modifiable Axis
Sometimes there's the need to change the value of an axis right when the build starts.
I did this adding a couple of methods to Axis and letting MatrixBuild use them.
It should all be backwards compatible.
2012-06-11 10:51:24 -07:00
Kohsuke Kawaguchi dea9588415 the trunk is toward 1.471-SNAPSHOT 2012-06-11 10:34:20 -07:00
Kohsuke Kawaguchi 78362282bf I botched 1.469 release, so skipping that and moving on to 1.470
This is a precautionary measure against those Maven proxies that might
have already cached 1.469 binaries while they were out.
2012-06-11 10:04:37 -07:00
Kohsuke Kawaguchi 436df00528 [maven-release-plugin] prepare for next development iteration 2012-06-11 09:11:48 -07:00
Kohsuke Kawaguchi 5f48c2d91f [maven-release-plugin] prepare release jenkins-1.468 2012-06-11 09:11:47 -07:00
Kohsuke Kawaguchi 4ec7ebf879 Added the -v option to report the console output of the build in progress. 2012-06-09 12:45:09 -07:00
Kohsuke Kawaguchi f037b11311 Added an option to wait for the start of a build. 2012-06-09 12:28:39 -07:00
Kohsuke Kawaguchi 9e3b4951df added ability to wait for the start of a build in a future, not just the end of it. 2012-06-09 12:16:43 -07:00
Kohsuke Kawaguchi 2776eea674 formatting changes 2012-06-09 11:49:26 -07:00
Kohsuke Kawaguchi 1d928a7b68 doc improvement 2012-06-09 11:49:05 -07:00
Kohsuke Kawaguchi 07c09bebb8 do not approximate the aggregated test result.
AggregatedTestResultAction remembers the exact build # of the child build, so honor that number, and don't let MatrixBuild.getRunFor(Configuration) picks up some earlier run.

The problem was discovered in the following situation:

 - there's a matrix project M with single configuration X
 - M #868 run normally, with 69 failures.
 - M #869 run with 258 failures, and that was reported in MatrixTestResult.add(AbstractTestResultAction), updating  the total count.
 - but for whatever reason, X #869 is lost
 - now if you look at M #869 test report, you'll see 258 as the total count, but the detail drill down would show 69, from X #868.

----
(05:25:57 PM) veebers: Hi all, I  have an odd issue with the 'test results'
(05:26:12 PM) veebers: In this result: Test Result (258 failures / +189) where could the +189 come from?
(05:26:20 PM) veebers: I can only actually see 69 failed tests :P
(05:26:48 PM) kohsuke: it means comparing to the last test result, you got 189 more failure
(05:27:37 PM) veebers: ah ok, but how can I have +189 failing tests when there are only 69 failed this time around?
(05:28:21 PM) kohsuke: I wonder if it cuts off the summary display at 70 (out of your 258 failures)?
(05:29:48 PM) veebers: Hmmm, kohsuke I don't know about that. Clicking the 'show all failed tests'  only shows 69 tests :P
(05:30:22 PM) veebers: and when I look at a prev. failing test, one that has ~200 fails
(05:30:24 PM) veebers: it shows the lot
(05:31:07 PM) kohsuke: veebers: want to do the screenshot?
(05:34:59 PM) veebers: kohsuke: sure: http://static.inky.ws/image/2143/image.jpg
(05:35:40 PM) kohsuke: this is a matrix project that just has one configuration?
(05:35:49 PM) kohsuke: Or is it a partial re-run?
(05:35:53 PM) mode (+o abayer) by ChanServ
(05:36:46 PM) veebers: first option. Only one config
(05:37:56 PM) kohsuke: I wonder if this is some kind of rendering gritch
(05:38:06 PM) kohsuke: perhaps if somehow it's showing the data of the previous run?
(05:38:24 PM) kohsuke: 69+189=258 can't be a coincidence
(05:38:53 PM) kohsuke: is this instance publicly visible?
(05:39:25 PM) veebers: err not that one, just checking if the results are published to the public one
(05:41:16 PM) veebers: hmm, that's odd. The publicly avail. one isn't showing the right details :P
(05:41:24 PM) kohsuke: URL?
(05:41:26 PM) veebers: well, perhaps there is something screwy with that setup
(05:42:14 PM) veebers: kohsuke: https://jenkins.qa.ubuntu.com/job/dx-autopilot-run/869/
(05:43:33 PM) veebers: kohsuke: although I don't think that's going to be much help as that gives me a 500 error :P
(05:43:45 PM) kohsuke: that's a bug of its own
(05:43:51 PM) kohsuke: I think I can fix that one
(05:50:29 PM) kohsuke: veebers: I think I have a hypothesis
(05:51:00 PM) kohsuke: when you do click that 69 failed tests reported under a configuration, I suspect you'll be actually taken to the different build number
(05:51:23 PM) kohsuke: likely the same configuration build of the previous one
(05:53:02 PM) veebers: kohsuke: hmm, not sure that's it.
(05:53:10 PM) veebers: it's the same build number all over
(05:53:53 PM) kohsuke: I'm pretty sure that's it
(05:54:01 PM) kohsuke: let me think of other ways to prove this
(05:54:27 PM) veebers: sure
(05:54:36 PM) kohsuke: try /job/dx-autopilot-run/869/label=1EBEE0FF-DAC9-11DF-BBDA-64A98C34D485/parentBuild/
(05:54:43 PM) kohsuke: and I predict you'll see #868 in the UI
(05:54:45 PM) veebers: so, the public page there says: Test Result (258 failures / +189)
(05:55:16 PM) veebers: When I click that link in the private server it takes me to that report you saw in the screenshot
(05:55:43 PM) veebers: which says: .../869/testReport/
(05:55:52 PM) veebers: and any other link on that page references 869
(05:56:04 PM) veebers: so perhaps it's somewhere in the background that might be accessing a prev build?
(05:56:36 PM) veebers: i.e. whatever builds up the top graph bar (at the top of the page) in server end rendering?
(05:56:50 PM) kohsuke: does /job/dx-autopilot-run/869/ show gray ball?
(05:57:27 PM) veebers: no, it shows the default config
(05:57:37 PM) veebers: (yeah, something is wrong with the public facing one :P)
(05:59:29 PM) veebers: not sure why you can't click through
(06:00:40 PM) veebers: kohsuke: ah, looks like you are correct
(06:00:50 PM) veebers: I was looking in the wrong place
(06:01:01 PM) veebers: kohsuke: d'oh, thanks for pointing that out :)
(06:01:41 PM) kohsuke: OK, I understand what happened
(06:02:38 PM) veebers: so yeah, clicking on that config, I can see the line: Started by upstream project dx-autopilot-run build number 868
(06:04:37 PM) kohsuke: #869 really did have 258 failures, but for some reason Jenkins lost the record of it
(06:05:02 PM) kohsuke: and when it's displaying this to you, it's approximating the lost record by using the nearest build, that was #868
(06:05:20 PM) kohsuke: and that's why the public instance, which runs ancient version of Jenkins, reports NPE
(06:05:30 PM) kohsuke: this version doesn't have that approximation feature
(06:05:42 PM) kohsuke: veebers: BTW you really should upgrade that publicly facing instance
(06:06:00 PM) kohsuke: there have been some security advisories issued since then
(06:06:11 PM) veebers: kohsuke: Makes sense, will get onto that
(06:06:30 PM) kohsuke: I'm fixing this in the trunk so that it doesn't incorrectly approximate here
(06:06:36 PM) veebers: nice
2012-06-07 18:15:08 -07:00
Kohsuke Kawaguchi d8d5305311 fixed NPE 2012-06-07 17:47:02 -07:00
Nicolas De Loof a06acd9096 [FIXED JENKINS-14038] consider requested context when building Run.url 2012-06-07 11:47:37 +02:00
Kohsuke Kawaguchi 182f7bee5c [STAPLER-17] Fixed MIME type of JSON to application/json 2012-06-06 16:45:02 -07:00
Kohsuke Kawaguchi ebc6af72e9 Improved the mechanism of how we store passwords hashed. 2012-06-06 16:31:35 -07:00
Kohsuke Kawaguchi 6ab4691eff Merge remote-tracking branch 'origin/master' 2012-06-05 20:31:10 -07:00
Kohsuke Kawaguchi 372e8cb650 the trunk is toward 1.469-SNAPSHOT 2012-06-05 20:30:58 -07:00
Kohsuke Kawaguchi d3f233ddf4 Merge branch 'pull-428'
Moved the changelog entry to the trunk part.
2012-06-05 18:22:43 -07:00
Kohsuke Kawaguchi 17317bb4ca supported more complex relative path 2012-06-05 18:16:27 -07:00
Vincent Latombe ec5812c82e In ListView, wrap the list of jobs inside a scrollable div.
When managing instances with lots of jobs, the size of the view
configuration screen becomes huge because there is one line per job on
the instance.
2012-06-05 15:55:37 -07:00
Kohsuke Kawaguchi 658fd226ba allowed plugins to implement subtypes of the Search class to provide different search implementations 2012-06-05 15:51:35 -07:00
Kohsuke Kawaguchi e334748cb3 doc improvement 2012-06-05 15:40:11 -07:00
Kohsuke Kawaguchi ddd6867125 Completed the new extension point.
Adding a test and fixed a broken databinding (because of SCM vs Scm)
2012-06-05 15:23:09 -07:00
Nicolas De loof 6da5894f49 Merge pull request #491 from ndeloof/JENKINS-13909
[JENKINS-13909] don't keep legacy *.hpi when uploading a plugin
2012-06-05 00:51:52 -07:00
Ryan Campbell 5a9f2c55d5 Hide the advanced tab if user doesn't can't UPLOAD_PLUGINS or CONFIGURE_UPDATECENTER 2012-06-04 16:36:31 -05:00