Commit Graph
11799 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi ff1214fc8b the trunk is toward 1.453-SNAPSHOT 2012-02-13 14:22:07 -08:00
Kohsuke Kawaguchi 1ac4872ecd maintain() should assign buildable stuff to executors.
This came out of the conversation with Nicolas.

When QueueTaskDispatcher vetos the assignment, a buildable item might
stay buildable and unexecuted. Ane he found that it doesn't get retried,
despite the MaintainTask class that attempts to do so.

The issue is that the maintain() method actually doesn't try to assign
buildable tasks to executors. That happens inside the pop() method.
I think this goes against the original design of the maintain() method,
which is a giant synchronized block that moves all the relevant actors
from one state to another.

So I'm moving this code into the maintain method. In this way,
MaintainTask will automatically reattempt to assign buildable items
to executors, and scheduleMaintenance() and maintain() will really
do the same thing, and it solves the original problem.
2012-02-13 10:35:22 -08:00
Kohsuke Kawaguchi 8e9d60855e doc changes 2012-02-13 10:35:22 -08:00
Hayato ITO dd75293fd5 fix no proxy host config behavior 2012-02-13 20:41:12 +09:00
Kohsuke Kawaguchi a71d037b84 Revisited the way Guice creates an injector during unit test
The motivation of this is to enable test code to inject components from Jenkins, which means we need a single Injector that can see all of those, including @TestExtension and regular @Extension. Then I realized that the current implementation is broken, as it creates two independent Injectors. This has other undesirable side effects like @TestExtension components not being able to inject @Extensions, etc.

I briefly experimented with hierarchical Injectors (where we first create Injector that loads @Extension then create another that loads @TestExtension as a child), but this was hard to get right as we have no control over which ExtensionFinder gets instantiated first --- we'd be at the mercy of SezPoz.

So the eventual approach is to allow a single GuiceFinder to recognize multiple annotations. This also works well with our using child injector for installing plugins without restart
2012-02-09 12:18:05 -08:00
Kohsuke Kawaguchi 1472ce133b added a convenience method that replaces just one item in the list 2012-02-09 11:59:50 -08:00
Kohsuke Kawaguchi 4378e878ae [FIXED JENKINS-12680] the onOffline method wasn't called for abrupt client termination 2012-02-09 09:35:35 -08:00
Kohsuke Kawaguchi 482b433333 If the destDir is available as a file, this fails in a weird way 2012-02-09 09:34:59 -08:00
Kohsuke Kawaguchi f2ceb6d768 added callbacks to notify when a node goes temporarily offlien 2012-02-09 09:34:58 -08:00
Kohsuke Kawaguchi dd0f362ef8 Follow-up fix to 968c19dfc9
removing static is a binary incompatible change.
2012-02-08 08:45:34 -08:00
Kohsuke Kawaguchi f461f5609b Merge remote branch 'origin/master' 2012-02-08 08:43:43 -08:00
Kohsuke Kawaguchi 82a7da7195 Added additional converters. 2012-02-08 08:03:37 -08:00
Kohsuke Kawaguchi 1774927de2 Updating tests to work since these tests now require full-blown Jenkins
environment.
2012-02-08 07:19:11 -08:00
Kohsuke Kawaguchi 19817fb773 Fixing test failures 2012-02-08 15:02:19 +01:00
Seiji Sogabe 968c19dfc9 should be static. 2012-02-07 00:18:31 +09:00
Kohsuke Kawaguchi acad637198 merged pull request #342 2012-02-06 14:52:44 +01:00
Kohsuke Kawaguchi 7028097b2e Updated to Groovy 1.8.5 2012-02-06 14:48:32 +01:00
Christoph Kutzinski 679105cb18 Fixed several compiler warnings 2012-02-05 22:36:07 +01:00
Christoph Kutzinski b816be6000 [FIXED JENKINS-10458] broken links to test results if test name contains # or ? 2012-02-02 22:34:48 +01:00
Seiji Sogabe 991785054d Merge pull request #344 from ohtake/fix-crontab
Fixes for crontab and proposals to hashed crontab
2012-02-02 02:37:05 -08:00
Kohsuke Kawaguchi 4a2c185973 the trunk is toward 1.452-SNAPSHOT 2012-01-30 17:36:37 -08:00
OHTAKE Tomohiro fda370b54e Set day of week hash range to [0,6] for better distribution 2012-01-30 09:02:24 +09:00
OHTAKE Tomohiro 8e8d925c38 Hash @midnight around midnight 2012-01-30 09:02:24 +09:00
OHTAKE Tomohiro 20249e4adc [FIXED JENKINS-12357] Crontab#ceil may stuck in an infinite loop or may return an incorrect value if day of week is 7 (=0, Sunday)
To use @Test(timeout), inheritance from TestCase should be removed
2012-01-30 09:02:23 +09:00
OHTAKE Tomohiro c24238ebbe Fix method name 2012-01-30 09:02:22 +09:00
OHTAKE Tomohiro f49c912acd Eliminate duplication of crontab lower/upper bounds
They look different, but had been same. See 921359c125
2012-01-30 09:02:21 +09:00
OHTAKE Tomohiro 240c381bb8 [FIXED JENKINS-12388] Add tests for JENKINS-12388 2012-01-30 09:02:20 +09:00
Jesse Farinacci fa2908b460 each node row should have id= also; support Keyboard Shortcut Plugin 2012-01-29 17:23:05 -05:00
Jesse Farinacci 806fb3a49b name != displayName 2012-01-29 15:05:13 -05:00
Seiji Sogabe 939d13c86c Updated japanese translations. 2012-01-29 11:14:26 +09:00
Kohsuke Kawaguchi a2a9c9e8fb I think this reflects the intent better without making me uneasy about double-counting. 2012-01-28 15:15:48 -08:00
ikikko f9b6d299eb move handling code to behavior rule file 2012-01-29 01:22:41 +09:00
ikikko 7dab4b4484 handling shortcut key only when firing 'keydown' event 2012-01-29 01:22:40 +09:00
Kamil Kisiel 7932446685 Document use of literal_eval for Python API 2012-01-27 17:26:21 -08:00
Kohsuke Kawaguchi b8eb513710 Revert "Revert "Don't provision more slaves when some are coming online.""
This reverts commit 47c520b13b.

I see it clearly now. I was bit concerned about double-counting,
because one expects that totalSnapshot (total # of executors)
includes idle executors. But this is not the case, and in any way
this code should be read as (x==0 && y==0 && z==0) not (x+y+z==0)
conceptually. So reverting my revert.
2012-01-27 17:22:29 -08:00
Kohsuke Kawaguchi 47c520b13b Revert "Don't provision more slaves when some are coming online."
This reverts commit 5a95baff35.
Oops, I don't know about this. More comments in
https://github.com/jenkinsci/jenkins/pull/362
2012-01-27 17:20:36 -08:00
Kohsuke Kawaguchi da9d415adc doc improvement 2012-01-27 17:20:19 -08:00
Kohsuke Kawaguchi 51b11637a6 doc improvement 2012-01-27 17:20:18 -08:00
Kohsuke Kawaguchi c99fc315dd [FIXED JENKINS-8152]
Formatting error in the rootDN inference code. It shouldn't include
attribute name.
2012-01-27 17:20:18 -08:00
Kohsuke Kawaguchi d7659971dc co-locating IntelliJ version with Eclipse version since they are the same thing written in two different languages 2012-01-27 17:19:55 -08:00
Ryan Campbell 5a95baff35 Don't provision more slaves when some are coming online.
The needsSomeWhenNoneAtAll ought to take into account nodes which are coming online, especially when a cloud returns slaves which are not connected. This is fixed by adding the idleSnapshot, which takes connecting slaves into account (totalSnapshot does not).
2012-01-27 11:08:45 -06:00
Kohsuke Kawaguchi 65339ffef4 The build command -c option was incorrectly relying on a constant. 2012-01-26 14:36:18 -08:00
vjuranek dfc7cc08d6 Merge pull request #343 from vjuranek/delete_whole_matrix
Waiting for review for more then 15 days, so mering myself.
2012-01-26 07:49:19 -08:00
Nicolas De Loof e013b564c8 fix scope to stop Idea complaining about missing dependences 2012-01-25 14:37:37 +01:00
Jesse Farinacci 580d8f2db5 [FIXED JENKINS-12518] job rows in view should have id= for easy access 2012-01-25 00:38:56 -05:00
Kohsuke Kawaguchi c8577921cb the trunk is toward 1.451-SNAPSHOT 2012-01-24 11:42:18 -08:00
Vojtech Juranek f8387f441d Added actual user who started the build. 2012-01-23 15:27:04 +01:00
Kohsuke Kawaguchi 3a5b72ce57 [FIXED JENKINS-12490] auto-complete the copy new node page 2012-01-22 15:35:56 -08:00
Kohsuke Kawaguchi 07d1779db6 convenient base class 2012-01-22 15:34:06 -08:00
Kohsuke Kawaguchi f082dab284 Integrated a newer version that fixes groovy view reloading problem. 2012-01-20 15:48:18 -08:00