Commit Graph
1882 Commits
Author SHA1 Message Date
Jesse Glick ec9d809ddd [FIXED JENKINS-16918] Use HTTP 405 when POST is required. 2013-08-09 19:57:56 -04:00
Kohsuke Kawaguchi 7232798611 [FIXED JENKINS-19124]
Added another attribute 'checkDependsOn' on <input> elements (akin to
'fillDependsOn', etc) to list up the other dependency controls, and
insert appropriate onchange events.

'checkUrl' is now just the stem portion of the URL to invoke, and
the client script builds up the query parameters.
2013-08-08 16:24:09 -07:00
Kohsuke Kawaguchi 69ce5d7d6c the trunk is toward 1.528-SNAPSHOT 2013-08-05 11:55:48 -07:00
lvotypko 850f55f077 Fix NullPointerException which is possible in concurrent builds. 2013-08-05 13:12:00 +02:00
lvotypko 6aaf6db458 Fix failure of tests 2013-08-04 10:43:58 +02:00
Jesse Glick 69fe8f30c8 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-08-02 16:12:33 -04:00
Jesse Glick af2c899452 Ignoring currently failing tests. 2013-08-02 16:12:03 -04:00
Oliver Gondža 72901837db [FIXED 10539] Preserve backslash in Matrix buildstep properties 2013-08-02 21:55:43 +02:00
Jesse Glick 50cda8ca19 Merge pull request #848 from Vlatombe/improve-search
Improve search to look for items inside ItemGroup
2013-08-02 12:44:49 -07:00
Jesse Glick 8697ec2947 JUnit 4. 2013-08-02 14:16:38 -04:00
Kohsuke Kawaguchi 6588f42904 [FIXED JENKINS-19042]
Added a new overloaded version that works on a project.

Updated CoreEnvironmentContributor accordingly.
2013-08-01 14:54:29 -07:00
Oliver Gondža f18f89d6a0 Avoid deprecated junit.framework.Assert, use org.junit.Assert instead 2013-08-01 15:50:42 +02:00
Vojtěch Juránek 96edfca548 Merge pull request #888 from lvotypko/ProjectTest
Add tests for Project class
2013-07-31 16:31:04 -07:00
Vojtěch Juránek 55f196aa20 Merge pull request #887 from lvotypko/NodeTest
Add tests for Node class
2013-07-31 16:30:23 -07:00
lvotypko e9af33f970 Add tests for Node class 2013-07-31 11:26:02 +02:00
lvotypko 68612c4a5f Add tests for Project class 2013-07-31 10:04:55 +02:00
Kohsuke Kawaguchi 7e07fab467 Revert "Hotfix for test failure from d90d47d1b76ebb5d753e919afefb5d2457664da2."
This reverts commit 1a6f3dfa76.
forgot to add this file
2013-07-30 09:24:06 -07:00
Jesse Glick 1a6f3dfa76 Hotfix for test failure from d90d47d1b7. 2013-07-29 23:32:47 -04:00
Kohsuke Kawaguchi bf68530857 the trunk is toward 1.527-SNAPSHOT 2013-07-29 19:38:10 -07:00
Kohsuke Kawaguchi d90d47d1b7 [FIXED JENKINS-18289]
The code is smart enough to compute a minimum set of builds to remove to
restore order consistency.
2013-07-29 18:39:58 -07:00
Jesse Glick d1d524863c [FIXED JENKINS-18895] MavenModuleSetBuild.getResult is expensive. 2013-07-29 16:06:18 -04:00
Kohsuke Kawaguchi d7dc26ae28 Merge remote-tracking branch 'origin/master' 2013-07-29 10:46:57 -07:00
Kohsuke Kawaguchi 0cbae2c0cf the trunk is toward 1.526-SNAPSHOT 2013-07-29 10:44:39 -07:00
Kohsuke Kawaguchi 26c845c968 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-07-29 10:41:54 -07:00
Jesse Glick d5eb4a7182 testBasicWorkflow is just not reliable, it seems. 2013-07-29 13:31:58 -04:00
Kohsuke Kawaguchi 397c63b2ff Merge branch 'pull-761'
Conflicts:
	test/src/test/java/hudson/model/QueueTest.java
2013-07-26 21:42:57 -07:00
Kohsuke Kawaguchi 09cf96f33c Merge pull request #854 from ikedam/feature/JENKINS-18643-1
[FIXED JENKINS-18643] Make tests run on Windows (line break character, query parameters for file schema)
2013-07-26 21:18:06 -07:00
Kohsuke Kawaguchi ba432da2b5 Merge pull request #880 from evilmilo/master
[FIXED JENKINS-18813] Add/RemoveTrigger now works
2013-07-26 21:08:51 -07:00
Jesse Glick 2152cf478e [FIXED JENKINS-18918] From plugins we must use target/ not target/classes/ to unpack Maven.
Also cleaning up variable names to be less misleading.

Note that new File("target") is really a bad idea since we cannot predict the CWD in effect when Maven is run.
(From the standard bin/mvn launcher, it seems that it will always be *some* Maven project at least.
This may not be true for Maven run embedded from various tools.)
But leaving that as is for now, since it is not clear how else we would find the project location.
(new File(env.description().getTestClass().getProtectionDomain().getCodeSource().getLocation().toURI()).getParentFile() might work but it is pretty hacky.)
2013-07-24 18:16:18 -04:00
Jesse Glick 68f1fa281f Comment about probable bug. 2013-07-24 18:09:10 -04:00
Jesse Glick e0a3a1ddf5 [FIXED JENKINS-18178] Reverting an inessential part of the fix of JENKINS-16301 since it broke some Maven builds.
Apparently the Maven 2 process factory fails to adequately insulate the Maven process from Jenkins library dependencies;
if you specify a build extension that can override dependencies used by Jenkins core classes!
A real fix would involve changing class loader delegation, since presumably similar bugs could still occur.
2013-07-24 16:22:48 -04:00
Jesse Glick 74d57de91b Misleading comment. 2013-07-24 15:11:56 -04:00
mcdonan edf932be37 [FIXED JENKINS-18813] Add/RemoveTrigger now works
Ensure the addTrigger and removeTrigger methods only use methods that are
supported by DescribableList. This means no indexed operations are
supported, so use only Iterator#remove and Collection#add

Add Integration Tests to ensure methods work as expected
2013-07-24 15:00:03 +01:00
Olivier Lamy 2a31fc8835 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-07-24 10:52:30 +10:00
Olivier Lamy 941e83fae1 [JENKINS-15935] Can't build using maven 3.1.0 latest release candidate
Merge branch 'maven-3.1.0' for maven 3.1.0 support in Maven Integration Plugin
2013-07-24 10:16:20 +10:00
Jesse Glick be158b4b2a [FIXED JENKINS-18898] ToolInstallation.getHome may be null, and buildEnvVars must take that into account. 2013-07-23 19:48:43 -04:00
Kohsuke Kawaguchi 807e3c81d4 Marking them as a bad example.
See https://groups.google.com/forum/#!topic/jenkinsci-dev/yf8i1v5XSDg
2013-07-22 18:09:17 -07:00
Olivier Lamy c4e7b58aee upgrade project test to be able to run with maven 3.1.0 2013-07-22 20:37:40 +10:00
Mark Waite 253f928209 Fix many of the javadoc unresolved @link warnings 2013-07-20 13:28:54 -06:00
Olivier Lamy 565586f8e3 will be better with adding files :-) 2013-07-20 13:30:32 +10:00
Olivier Lamy 0a53e45d7f prepare test suite for mvn 3.1.x 2013-07-20 13:30:13 +10:00
Olivier Lamy 10522f205c add 3.1.0 distrib for testing 2013-07-20 13:21:18 +10:00
Olivier Lamy 09f831ad95 test with < 3.0.3 for not eventspy version 2013-07-20 13:19:50 +10:00
Olivier Lamy 8f4dc07f82 add groupId and maven build with setRunHeadless( true ): prevent too many coffee on osx! 2013-07-19 23:42:30 +10:00
Jesse Glick c572146b26 [FIXED JENKINS-17302] Corrected GET of a View to serialize the View, not an anonymous inner class.
Also ensuring that Jenkins configuration is saved after new XML is POSTed.
2013-07-18 18:04:18 -04:00
Oliver Gondža 3e45ce9a2c [FIXED JENKINS-18485] Use correct node permissions in remote API
From now on user needs:
  Computer.CREATE to use 'create-node' CLI command
  Computer.DELETE to use 'delete-node' CLI command
  Computer.CONFIGURE to use 'update-node' CLI command and its REST alternative
  Computer.READ to use 'get-node' CLI command and its REST alternative
2013-07-18 14:24:30 +02:00
Kohsuke Kawaguchi bf80986734 Replacing org.kohsuke.gmaven by org.codehaus.gmaven 2013-07-17 17:49:56 -07:00
Kohsuke Kawaguchi 92c2503b1a This work around no longer necessary,
... as the newer Groovy compiler produces the proper enclosing class
infromation.
2013-07-17 16:41:12 -07:00
Kohsuke Kawaguchi bd256acda9 Fixing a test failure in RelativePathTest
It turns out that Groovy compiler we use to compile src/test/groovy was
not properly generating the 'enclosing class' information inside
*.class, which was causing the load failure of the descriptors marked
by @TestExtension in test code.

To fix this and forestall other possible GMaven related issues, I
decided to bump up the GMaven version. As it turns out, Codehaus GMaven
had ceased the development of the 1.x branch, so I initially tried 2.x
release line.

The 2.x release line got rid of the stub generation functionality, which
we badly need for annotation processing. It instead recommend using
Eclipse compiler to jointly compile Java and Groovy source code
together, but when I tried to compile our tests, it failed to properly
handle nested classes. The compiler quality appears quite premature.

I was then going back to GMaven 1.5, the last 1.x release. I took this
opportunity to rebase my local patches in org.kohsuke.gmaven to the
latest release, which in my mind gets justified now that the upstream
has ceased the development.

My local patch to GMaven is captured in GMAVEN-3 and GMAVEN-4
(see http://jira.codehaus.org/browse/GMAVEN-3 and
http://jira.codehaus.org/browse/GMAVEN-4).

GMAVEN-4 is claimed to be fixed, but when I tried to compile our source
tree I discovered that its handling of nested types breaks the generated
stub code.

In the end, I managed to patch gmaven and posted 1.5-jenkins-1.

The bottom line is, we can now use @TestExtension correctly with Groovy
tests. Also on the upside, we can get rid of org.kohsuke.gmaven and
avoid the current confusion situation of using two GMaven plugins.

I'll make a follow-up change to remove org.kohsuke.gmaven from elsewhere
in our POM.
2013-07-17 16:41:12 -07:00
Kohsuke Kawaguchi eec271d76d Groovy compiler doesn't seem to put the enclosing class information in the class file. 2013-07-17 16:41:12 -07:00