Commit Graph
404 Commits
Author SHA1 Message Date
Jesse Glick c9cf3b67bb Retain hudsonRules/jenkinsRules for now, as many scripts in core & plugins directly modify this hash. 2012-08-21 22:13:59 -04:00
Jesse Glick e3266eb8d5 Run deprecated behaviors at position 0. 2012-08-21 22:13:20 -04:00
Jesse Glick fbb77a8ef8 Changed meaning of priority in Behaviour.specify.
Callers seem to expect that priority behaviors are applied before any behaviors in other selectors.
2012-08-21 20:59:41 -04:00
Jesse Glick 81bdb4be8e Updated to Behaviour.specify. 2012-08-21 20:39:04 -04:00
Jesse Glick 19e2a0127f Addition of Behaviour.specify, and basic test updates. 2012-08-21 20:06:34 -04:00
Jesse Glick f39fbdb312 [JENKINS-14495] Refined fix - needed to pull uniqueness check out of apply() fn in case we were being passed an Array of nodes.
Fixes test failures introduced by  dbb100d, and adds a test for it now that I know it can be done.
2012-08-03 15:46:32 -04:00
Jesse Glick dbb100da58 [FIXED JENKINS-14495] Hetero lists not working correctly after adding elements.
Unlike [JENKINS-14514] this is a true fix rather than a workaround (now removed), and is more general.
cjo9900 discovered that behaviors were being redundantly registered (as of 1.474 the monolithic JS is broken up);
this caused some behaviors to be run repeatedly on the same elements, breaking reasonable expectations of some behaviors.
The ideal fix would be to change Behavior.register to be idempotent: for example, key it by selector, then maintain a set of distinct behavior functions for each.
Unfortunately some adjuncts directly call Behavior.list.unshift, bypassing register(...), which would be tricky to intercept (would need to make a mock of Array).
The known one cases are in core, but it is possible plugin adjuncts do this too, in which case it would be incompatible to (say) change the Array<Map<String,Behavior>> to a Map<String,Array<Behavior>>.
Instead, permitting redundant registrations as before, and just silently skipping all but the first at runtime when applying behaviors.
Beware that since adjuncts are loaded from multiple places, different JS function objects are registered each time, so a naive set of behavior functions does not work;
have to identify functions by their toString in order to ensure that each is run only once.
(Currently once _per selector_, conceivably >1x per element; could if necessary be refined to make sure a given behavior is only run once on a given element during one call to applySubtree even if the element matches multiple selectors.)
2012-08-03 12:53:48 -04:00
Jesse Glick b98b57038c Link fix. 2012-07-31 11:50:03 -04:00
lvotypko ff612d29c0 Add clock_anime.git into folder 16x16 too 2012-07-31 16:39:59 +02:00
lvotypko 98f0e9fc92 Show in view scheduled jobs 2012-07-31 11:55:13 +02:00
Kohsuke Kawaguchi 0427b1449b refactored 2012-07-31 16:30:33 +09:00
Kohsuke Kawaguchi 7db5fb34aa refactored 2012-07-31 16:30:33 +09:00
Jesse Glick 680fd480c3 Corrected a misleading comment. 2012-07-27 16:51:28 -04:00
Kohsuke Kawaguchi 83c0a6f12c these help files were in a wrong location 2012-07-23 14:44:54 -07:00
Kohsuke Kawaguchi 31bda5786a making this more discoverable 2012-07-23 14:10:16 -07:00
Kohsuke Kawaguchi 57a4c02cda Merge branch 'pull-506' 2012-06-29 20:21:28 -07:00
Kohsuke Kawaguchi 30837d8903 Better encapsulation of JavaScript.
Don't expose stuff that need not be exposed.
2012-06-29 20:19:23 -07:00
Kohsuke Kawaguchi 96442cd9cd splitting JavaScript into smaller fragments for better maintainability.
One of the problems with the current way Jenkins puts JavaScripts is that most everything is in a single file. It doesn't highlight the relationship between those fragments and their corresponding tag files.

So I'm experimenting with moving out these fragments into individual JavaScript files co-located with the tag file. They then get loaded into the page via <st:adjunct>. Each script is served with unique URL such that the browser will not even have to try conditional GET when loading different pages, so this should prevent the performance problem caused by the fact that there are now lots of <script> tags in the page.

 If for some reason even this turns out to be a problem, we can always add additional build steps to concatenate them all.
2012-06-28 15:24:53 -07:00
Kohsuke Kawaguchi 02854d87bd Wrong variable name 2012-06-22 17:45:17 -07:00
Kohsuke Kawaguchi d318bbae5b Added code to assist form-element-path plugin 2012-06-22 17:41:30 -07:00
Kohsuke Kawaguchi 74bea665c6 copy & keep CSS class names 2012-06-22 17:41:30 -07:00
Kohsuke Kawaguchi 7c5efe367b deprecating 'fooButton' class in favor of 'foo-button'
This makes it consistent with other buttons like repeatable-add-button, and use of '-' prevents name collisions with form names, and make all of those UI controls addressible in the same namespace
2012-06-22 17:41:30 -07:00
Alberto Gragera 581b8256b1 Make Jenkins stop polling resources if the page is not visible (and if the browser supports Page Visibility API), restoring pollings when the page becomes visible again. This will make tabs in the background to not consume resources 2012-06-22 12:55:02 +02:00
Kohsuke Kawaguchi bc0b850510 Merge branch 'pull-434.2' 2012-06-11 15:23:28 -07:00
Kohsuke Kawaguchi 72fbaba275 Refactored existing static list into CoreEnvironmentContributor. 2012-06-11 15:21:57 -07:00
Kohsuke Kawaguchi 17317bb4ca supported more complex relative path 2012-06-05 18:16:27 -07:00
Kohsuke Kawaguchi d72a9a2bc5 fixed a bug in the neighbor field discovery.
Previously, the code was "find the nearby element of the expected @name,
then make sure it has gotten the right parent."

So if the structure is like:

  {/* outer object */
      name: "parent-name",  /* A */

      child1: {/* inner object */
        name: "child-name" /* B */
      },

      child2: {/* inner object */
        name: "child-name" /* C */
      }
  }

... and if we are looking for "../name", it finds B, and it gets
rejected, so we won't be able to find A, which is what we are supposed
to find.

With this change, we keep trying until we find the right one,
so the above case will correctly return A.
2012-06-05 18:16:27 -07:00
Vincent Latombe ec5812c82e In ListView, wrap the list of jobs inside a scrollable div.
When managing instances with lots of jobs, the size of the view
configuration screen becomes huge because there is one line per job on
the instance.
2012-06-05 15:55:37 -07:00
Kohsuke Kawaguchi fe0c718e39 Integrated the new animation GIF images that have more transparent background.
Going beyond this requires CSS animation.
2012-05-30 17:49:56 -07:00
Kohsuke Kawaguchi f9a8630f1c call layout updater when we touch DOM 2012-05-30 16:50:03 -07:00
Kohsuke Kawaguchi 32cba8f245 One more file to be removed for LDAP 2012-05-30 10:40:02 -07:00
Kohsuke Kawaguchi 18963ee9af [FIXED JENKINS-13625]
In the end, proper fix requires having a filter that tracks
GZipOutputStream.
2012-05-23 20:11:58 -07:00
Ariel Peltz 7a84ab1d34 Fix for annoying typo in custom workspace help 2012-05-17 10:57:53 +03:00
Kohsuke Kawaguchi 7a4858d65f [FIXED JENKINS-12585] restrict where sessions are created.
If a resource with 'Set-Cookie' header is cached (either by intermediary
like HTTP proxy and reverse proxy, or by the browser), it'll cause
identity swap / session mix-up as discussed in this ticket.

I suspect this was caused by HttpSessionContextIntegrationFilter2, which
is the only code path that attempts to create a session when a request
to a static resource is made.

So I'm disabling the creation of session in
HttpSessionContextIntegrationFilter2. This in turn requires that we
have sessions already created when the authentication was successful and
people need to login (or else the login will have no effect.)

We already do so in layout.jelly, so any request that renders a Jenkins
page would have a session, but I've also added it in
AuthenticationProcessingFilter2, which ensures that a successful login
does have a session.
2012-05-03 17:56:13 -07:00
Kohsuke Kawaguchi 749f4ffadf Merge remote-tracking branch 'origin/publisher' 2012-04-25 22:56:03 -07:00
OHTAKE Tomohiro 815c42c458 [FIXED JENKINS-13578] 'sortbottom' was sorted to the top 2012-04-25 09:59:27 +09:00
Kohsuke Kawaguchi 58267c4672 added scorll-into-view capability 2012-04-19 17:52:07 +02:00
Kohsuke Kawaguchi d2d7e43eee by default, try to preserve the order 2012-04-19 17:52:07 +02:00
Kohsuke Kawaguchi 28bcaea860 unused arguments 2012-04-19 17:52:07 +02:00
Kohsuke Kawaguchi 07477567d2 this is shorter 2012-04-19 17:52:07 +02:00
Kohsuke Kawaguchi 570d974568 hopefully giving it a name made it easier to understand what it means 2012-04-19 17:52:07 +02:00
Kohsuke Kawaguchi 11f8ac0875 adding animation 2012-04-19 17:52:07 +02:00
Kohsuke Kawaguchi 085ae79e5b this needs to trigger the relayout 2012-04-19 17:52:06 +02:00
Kohsuke Kawaguchi 8f16967ad5 make sure the newly added portion is always visible 2012-04-19 17:52:06 +02:00
Kohsuke Kawaguchi aef3cf3acf converting publishers to a drop-down menu to save real estate 2012-04-19 17:52:06 +02:00
Vincent Latombe 3c5d7cc38a [Fix JENKINS-13195] New Breadcrumb bar covers search suggestions
Adjust z-index for #search-box-completion to appear over the breadcrumb
2012-03-22 19:42:21 +01:00
Seiji Sogabe bc75390479 i18n & l10n(ja) for ProjectNamingStrategy 2012-03-14 00:52:42 +09:00
OHTAKE Tomohiro 6c5a9fc9bf Re-implement findElementsBySelector using Prototype.Selector
http://jenkins.local/job/JOBNAME/configure will become
10%-faster in Chrome 14 and 20%-faster in IE 9.
2012-03-05 16:42:07 -08:00
OHTAKE Tomohiro 4535b18333 IE compatibility
$(e).next() may return undefined.
If 2nd argument of insertBefore is undefined,
IE9 complains "SCRIPT87: Invalid argument".
To insert newChild at the end, 2nd argument should be null.
http://www.w3.org/TR/2000/REC-DOM-Level-2-Core-20001113/core.html#ID-952280727
2012-03-05 16:37:13 -08:00
imod a2d9bac03d define new extension point to define ProjectNamingStrategy and add two implementations: Default and Pattern 2012-03-04 11:11:39 +01:00