but crumb.wrap only worked with hash.. now support Array as well.
This fixes ajax update of Build History when CSRF protection is turned on.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29597 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r29309 | kohsuke | 2010-03-26 14:44:45 -0700 (Fri, 26 Mar 2010) | 1 line
Work around for http://n4.nabble.com/hudson-logging-LogRecorderManagerTest-failing-tp1589811p1589811.html
........
r29310 | kohsuke | 2010-03-26 14:45:29 -0700 (Fri, 26 Mar 2010) | 1 line
unnecessary boxing
........
r29311 | kohsuke | 2010-03-26 16:00:41 -0700 (Fri, 26 Mar 2010) | 1 line
fixed a stability in the test.
........
r29421 | kohsuke | 2010-03-29 11:40:37 -0700 (Mon, 29 Mar 2010) | 1 line
improving the test stability
........
r29449 | kohsuke | 2010-03-29 18:08:26 -0700 (Mon, 29 Mar 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_353
........
r29451 | kohsuke | 2010-03-29 18:08:46 -0700 (Mon, 29 Mar 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
r29459 | kohsuke | 2010-03-29 19:20:42 -0700 (Mon, 29 Mar 2010) | 1 line
updated changelog as a part of the release
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29490 71c3de6d-444a-0410-be80-ed276b4c234a
1) in onblur handler, simply restore old form.onsubmit rather than adding
another wrapper to call the old handler (which can result in a deep call
stack if several comboboxes are used prior to form submission).
2) in onsubmit handler when focused, only call the original onsubmit when
the dropdown is not showing (ie don't call it when we intercept the submit
to just select an item from the list and return false)
I didn't figure out exactly why, but the current code could result in the
original form.onsubmit handler not being called on form submission when
multiple comboboxes are used. This simplification seems to resolve the issue.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29149 71c3de6d-444a-0410-be80-ed276b4c234a
This is done by uniquifying groups of radiobutton names using Behavior rules,
then converting back to original names before form submission in buildFormTree.
Added some unit tests for f:repeatable, covering basic usage, minimum parameter,
simple radio buttons and f:radioBlock.
Fixed handling of minimum parameter in f:repeatable, since the new test failed :-)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29065 71c3de6d-444a-0410-be80-ed276b4c234a
takes more than 100ms. (mousedown on item makes text field lose focus, which
does a setTimeout to hide dropdown after 100ms.. it mouseup doesn't happen
before this, onclick is never triggered. Now using onmousedown to immediately
trigger select of item)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28703 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r28543 | kohsuke | 2010-03-12 16:07:55 -0800 (Fri, 12 Mar 2010) | 1 line
fixed a regression caused by HUDSON-5780
........
r28544 | kohsuke | 2010-03-12 16:09:25 -0800 (Fri, 12 Mar 2010) | 1 line
fixed a regression caused by HUDSON-5780
........
r28545 | kohsuke | 2010-03-12 16:24:14 -0800 (Fri, 12 Mar 2010) | 1 line
fixed a regression caused by HUDSON-5780
........
r28546 | kohsuke | 2010-03-12 16:52:36 -0800 (Fri, 12 Mar 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_350
........
r28548 | kohsuke | 2010-03-12 16:52:58 -0800 (Fri, 12 Mar 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
r28551 | kohsuke | 2010-03-12 17:36:02 -0800 (Fri, 12 Mar 2010) | 1 line
updated changelog as a part of the release
........
r28625 | abayer | 2010-03-15 09:54:14 -0700 (Mon, 15 Mar 2010) | 1 line
Fixing regression that resulted in all but latest build artifacts getting deleted
........
r28627 | kohsuke | 2010-03-15 10:09:52 -0700 (Mon, 15 Mar 2010) | 1 line
touch up
........
r28628 | kohsuke | 2010-03-15 10:10:23 -0700 (Mon, 15 Mar 2010) | 1 line
another pointless array conversion
........
r28629 | kohsuke | 2010-03-15 10:45:13 -0700 (Mon, 15 Mar 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_351
........
r28631 | kohsuke | 2010-03-15 10:45:50 -0700 (Mon, 15 Mar 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
r28635 | kohsuke | 2010-03-15 11:29:03 -0700 (Mon, 15 Mar 2010) | 1 line
updated changelog as a part of the release
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28639 71c3de6d-444a-0410-be80-ed276b4c234a
https://www.dev.java.net/svn/hudson/branches/rc
........
r28303 | kohsuke | 2010-03-05 18:05:22 -0800 (Fri, 05 Mar 2010) | 1 line
version number isn't always parseable
........
r28305 | kohsuke | 2010-03-05 18:55:21 -0800 (Fri, 05 Mar 2010) | 1 line
fixed a test failure
........
r28306 | kohsuke | 2010-03-05 19:21:37 -0800 (Fri, 05 Mar 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_349
........
r28308 | kohsuke | 2010-03-05 19:21:58 -0800 (Fri, 05 Mar 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
r28315 | kohsuke | 2010-03-05 20:04:32 -0800 (Fri, 05 Mar 2010) | 1 line
updated changelog as a part of the release
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28403 71c3de6d-444a-0410-be80-ed276b4c234a
and initialize via hudson-behavior rules. Now f:editableComboBox works in
repeatable content such as a build step (or any f:hetero-list or f:repeatable).
createComboBox still accepts an ID parameter for compatibility, but this form
is now deprecated.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28338 71c3de6d-444a-0410-be80-ed276b4c234a
Merged revisions 27137,27564,27566-27567,27578,27586,27599,27603,27606-27609,27611,27616,27626-27632,27640,27654-27656,27687,27701,27801,27816,27819,27843-27845,28087,28158-28161 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/HUDSON-2137
........
r27137 | kohsuke | 2010-02-08 08:46:16 -0800 (Mon, 08 Feb 2010) | 1 line
experimenting with abstractions
........
r27564 | kohsuke | 2010-02-16 07:58:26 -0800 (Tue, 16 Feb 2010) | 1 line
bundling makes it easier for caller to handle ConsoleAnnotator
........
r27566 | kohsuke | 2010-02-16 08:49:48 -0800 (Tue, 16 Feb 2010) | 1 line
this should work with Runs, not AbstractBuilds
........
r27567 | kohsuke | 2010-02-16 08:54:06 -0800 (Tue, 16 Feb 2010) | 1 line
simplified
........
r27578 | kohsuke | 2010-02-16 12:26:11 -0800 (Tue, 16 Feb 2010) | 1 line
still a work in progress, but committing once to pull in trunk changes
........
r27586 | kohsuke | 2010-02-16 14:35:37 -0800 (Tue, 16 Feb 2010) | 1 line
making more progress
........
r27599 | kohsuke | 2010-02-16 19:22:01 -0800 (Tue, 16 Feb 2010) | 2 lines
hooking up the side that writes annotations.
still a work in progress.
........
r27603 | kohsuke | 2010-02-16 23:43:35 -0800 (Tue, 16 Feb 2010) | 3 lines
what appears to me as the first cut of hooking up the reader side of the annotations.
I haven't even run it yet --- this just passed the compilation, and I'm calling it a day.
........
r27606 | kohsuke | 2010-02-17 09:15:16 -0800 (Wed, 17 Feb 2010) | 1 line
demo instance hook up
........
r27607 | kohsuke | 2010-02-17 11:27:02 -0800 (Wed, 17 Feb 2010) | 3 lines
one more utility method.
I never understood what the point of letting the skip method skip less.
........
r27608 | kohsuke | 2010-02-17 11:56:23 -0800 (Wed, 17 Feb 2010) | 3 lines
- moved LargeText subtype to its own class
- skipping log output was done incorrectly --- it had to skip N bytes where it was skipping N chars.
- hooked up console annotations for completed builds.
........
r27609 | kohsuke | 2010-02-17 12:01:46 -0800 (Wed, 17 Feb 2010) | 1 line
copyright header
........
r27611 | kohsuke | 2010-02-17 13:18:10 -0800 (Wed, 17 Feb 2010) | 1 line
introduced a mechanism to register extension during an unit test.
........
r27616 | kohsuke | 2010-02-17 13:38:12 -0800 (Wed, 17 Feb 2010) | 1 line
test case for console annotations
........
r27626 | kohsuke | 2010-02-17 15:23:06 -0800 (Wed, 17 Feb 2010) | 1 line
removing test ConsoleAnnotator as I write tests as tests
........
r27627 | kohsuke | 2010-02-17 16:06:13 -0800 (Wed, 17 Feb 2010) | 1 line
added a multi-phase cooperative locking mechanism useful during the debugging
........
r27628 | kohsuke | 2010-02-17 16:06:41 -0800 (Wed, 17 Feb 2010) | 1 line
testing progressive log annotation
........
r27629 | kohsuke | 2010-02-17 16:20:32 -0800 (Wed, 17 Feb 2010) | 1 line
adding a test for ConsoleAnnotation that's explicitly placed.
........
r27630 | kohsuke | 2010-02-17 16:23:02 -0800 (Wed, 17 Feb 2010) | 1 line
removing test ConsoleAnnotation as I write tests as tests
........
r27631 | kohsuke | 2010-02-17 16:28:50 -0800 (Wed, 17 Feb 2010) | 1 line
tweaking the abstraction a bit.
........
r27632 | kohsuke | 2010-02-17 16:44:21 -0800 (Wed, 17 Feb 2010) | 1 line
parameterized the context type so that this can be used in places other than the build console output, such as polling logs, slave logs, and so on.
........
r27640 | kohsuke | 2010-02-17 17:27:52 -0800 (Wed, 17 Feb 2010) | 1 line
bug fix
........
r27654 | kohsuke | 2010-02-17 22:53:04 -0800 (Wed, 17 Feb 2010) | 1 line
doc improvement
........
r27655 | kohsuke | 2010-02-17 22:53:59 -0800 (Wed, 17 Feb 2010) | 1 line
doc improvement
........
r27656 | kohsuke | 2010-02-17 23:10:42 -0800 (Wed, 17 Feb 2010) | 1 line
test case for adjacent tags
........
r27687 | kohsuke | 2010-02-19 14:39:21 -0800 (Fri, 19 Feb 2010) | 1 line
introduced a facotry and descriptor. This allows them to define configuration pages, allow users to disable/enable them, plus define custom behaviors.
........
r27701 | kohsuke | 2010-02-19 18:23:52 -0800 (Fri, 19 Feb 2010) | 1 line
defining a mechanism for ConsoleAnnotatorFactory and ConsoleAnnotationDescriptor to define script.js and have them imported into the console output page
........
r27801 | kohsuke | 2010-02-22 11:59:16 -0800 (Mon, 22 Feb 2010) | 1 line
now embedding annotations inside the console output log file.
........
r27816 | kohsuke | 2010-02-22 15:45:04 -0800 (Mon, 22 Feb 2010) | 1 line
introduced a convenience method for unit tests
........
r27819 | kohsuke | 2010-02-22 17:37:05 -0800 (Mon, 22 Feb 2010) | 5 lines
As an example of using embedded console annotations, implementing Ant target invocation outlines.
It might be better to make the concept of outline more generally reusable, so that different kinds of outlines can be placed into the same container element for a single hierarchical representation.
Still a work in progress.
........
r27843 | kohsuke | 2010-02-23 16:12:13 -0800 (Tue, 23 Feb 2010) | 1 line
for now, disable this for production usage, until I work out a better UI.
........
r27844 | kohsuke | 2010-02-23 19:08:00 -0800 (Tue, 23 Feb 2010) | 1 line
started working on annotating exception.
........
r27845 | kohsuke | 2010-02-23 19:08:33 -0800 (Tue, 23 Feb 2010) | 1 line
more TODOs for myself
........
r28087 | kohsuke | 2010-03-01 10:03:55 -0800 (Mon, 01 Mar 2010) | 1 line
formatting changes
........
r28158 | kohsuke | 2010-03-02 17:00:00 -0800 (Tue, 02 Mar 2010) | 1 line
ConsoleAnnotation and ConsoleAnnotator are too confusing.
........
r28159 | kohsuke | 2010-03-02 17:02:02 -0800 (Tue, 02 Mar 2010) | 1 line
doc improvement
........
r28160 | kohsuke | 2010-03-02 17:05:14 -0800 (Tue, 02 Mar 2010) | 1 line
more doc improvements.
........
r28161 | kohsuke | 2010-03-02 17:11:59 -0800 (Tue, 02 Mar 2010) | 1 line
more doc improvement
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28173 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r28000 | kohsuke | 2010-02-26 17:58:13 -0800 (Fri, 26 Feb 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_348
........
r28002 | kohsuke | 2010-02-26 17:58:32 -0800 (Fri, 26 Feb 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
r28007 | kohsuke | 2010-02-26 18:45:28 -0800 (Fri, 26 Feb 2010) | 1 line
updated changelog as a part of the release
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28010 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r27681 | kohsuke | 2010-02-19 11:14:43 -0800 (Fri, 19 Feb 2010) | 3 lines
Allow nearby elements to include itself, and don't let the failure in the check URL evaluation kill of the entire JavaScript processing.
This problem is noticed with the findbugs plugin, which uses a field name as a parameter instead of the 'value' parameter name.
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27682 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r27441 | kohsuke | 2010-02-12 16:47:05 -0800 (Fri, 12 Feb 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_346
........
r27443 | kohsuke | 2010-02-12 16:47:17 -0800 (Fri, 12 Feb 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
r27447 | kohsuke | 2010-02-12 17:28:50 -0800 (Fri, 12 Feb 2010) | 1 line
updated changelog as a part of the release
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27449 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r27147 | kohsuke | 2010-02-08 11:10:47 -0800 (Mon, 08 Feb 2010) | 1 line
[FIXED HUDSON-5536] in 1.345 and added a test case.
........
r27149 | kohsuke | 2010-02-08 12:01:18 -0800 (Mon, 08 Feb 2010) | 1 line
added a backward compatibility measure to expose variables in both forms
........
r27150 | kohsuke | 2010-02-08 12:02:19 -0800 (Mon, 08 Feb 2010) | 1 line
forgot to commit this(?)
........
r27151 | kohsuke | 2010-02-08 12:24:51 -0800 (Mon, 08 Feb 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_345
........
r27153 | kohsuke | 2010-02-08 12:25:04 -0800 (Mon, 08 Feb 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27154 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r27047 | kohsuke | 2010-02-05 14:07:35 -0800 (Fri, 05 Feb 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_344
........
r27049 | kohsuke | 2010-02-05 14:07:55 -0800 (Fri, 05 Feb 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
r27053 | kohsuke | 2010-02-05 17:05:11 -0800 (Fri, 05 Feb 2010) | 1 line
updated changelog as a part of the release
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27059 71c3de6d-444a-0410-be80-ed276b4c234a