Commit Graph
17505 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 6d081fafc4 This property can be null causing HtmlUnit to fail.
In event-debug.js, there's an overloaded toString() method.

    toString: function() {
         return "CustomEvent: " + "'" + this.type  + "', " +
             "context: " + this.scope;

    }

When the problem happens, "this.scope" points to a DataSourceBase object, and apparently at that time this._sName is null, and it causes a failure in ScriptableObject.getDefaultValue(), at the final "fall through to error" portion (see below)

----
Enclosed exception:
net.sourceforge.htmlunit.corejs.javascript.EcmaError: TypeError: Cannot find default value for object. (http://localhost:46994/static/43c91e29/scripts/yui/event/event-debug.js#385)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.constructError(ScriptRuntime.java:3652)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.constructError(ScriptRuntime.java:3630)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.typeError(ScriptRuntime.java:3658)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.typeError1(ScriptRuntime.java:3670)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptableObject.getDefaultValue(ScriptableObject.java:829)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptableObject.getDefaultValue(ScriptableObject.java:748)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.add(ScriptRuntime.java:2558)
	at net.sourceforge.htmlunit.corejs.javascript.Interpreter.do_add(Interpreter.java:3060)
	at script.(http://localhost:46994/static/43c91e29/scripts/yui/event/event-debug.js:385)
	at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpret(Interpreter.java:879)
	at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.call(InterpretedFunction.java:164)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptableObject.getDefaultValue(ScriptableObject.java:808)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptableObject.getDefaultValue(ScriptableObject.java:748)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.add(ScriptRuntime.java:2558)
	at net.sourceforge.htmlunit.corejs.javascript.Interpreter.do_add(Interpreter.java:3060)
	at script.(http://localhost:46994/static/43c91e29/scripts/yui/event/event-debug.js:114)
	at script.(http://localhost:46994/static/43c91e29/scripts/yui/event/event-debug.js:2258)
	at script.(http://localhost:46994/static/43c91e29/scripts/yui/datasource/datasource-debug.js:79)
	at script.(http://localhost:46994/static/43c91e29/scripts/yui/datasource/datasource-debug.js:2302)
	at script.(http://localhost:46994/static/43c91e29/scripts/yui/autocomplete/autocomplete-debug.js:18)
	at script.createSearchBox(http://localhost:46994/static/43c91e29/scripts/hudson-behavior.js:1711)
	at script.(script in http://localhost:46994//login from (4, 3626) to (4, 3663):4)
	at net.sourceforge.htmlunit.corejs.javascript.Interpreter.interpret(Interpreter.java:879)
	at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.call(InterpretedFunction.java:164)
	at net.sourceforge.htmlunit.corejs.javascript.ContextFactory.doTopCall(ContextFactory.java:427)
	at com.gargoylesoftware.htmlunit.javascript.HtmlUnitContextFactory.doTopCall(HtmlUnitContextFactory.java:263)
	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:3058)
	at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.exec(InterpretedFunction.java:175)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$5.doRun(JavaScriptEngine.java:415)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$HtmlUnitContextAction.run(JavaScriptEngine.java:522)
	at net.sourceforge.htmlunit.corejs.javascript.Context.call(Context.java:529)
	at net.sourceforge.htmlunit.corejs.javascript.ContextFactory.call(ContextFactory.java:536)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.execute(JavaScriptEngine.java:424)
	at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine.execute(JavaScriptEngine.java:399)
	at com.gargoylesoftware.htmlunit.html.HtmlPage.executeJavaScriptIfPossible(HtmlPage.java:892)
	at com.gargoylesoftware.htmlunit.html.HtmlScript.executeInlineScriptIfNeeded(HtmlScript.java:309)
	at com.gargoylesoftware.htmlunit.html.HtmlScript.executeScriptIfNeeded(HtmlScript.java:364)
	at com.gargoylesoftware.htmlunit.html.HtmlScript$1.execute(HtmlScript.java:223)
	at com.gargoylesoftware.htmlunit.html.HtmlScript.onAllChildrenAddedToPage(HtmlScript.java:238)
----

So this quick fix gets us around.

I think the root cause of the problem is that ScriptableObject.getDefaultValue() should treat null as the primitive value, but I'm bit scared to make that change right now.
2011-09-23 19:42:21 -07:00
Kohsuke Kawaguchi 3c278df8d3 Fixed the test failure. There's no beta module in YUI 2.9, and we got some old plugins that's specifying beta for modules that have graduated. 2011-09-23 17:35:21 -07:00
Kohsuke Kawaguchi a7bafdd946 storage might not be available after all 2011-09-23 17:00:37 -07:00
Richard Mortimer 5f4fdb0b7d [FIXED JENKINS-11013] NOT_BUILT & other build status are reported inconsistently 2011-09-23 15:54:15 -07:00
Richard Mortimer 089440f9d8 JENKINS-11013 NOT_BUILT & other build status are reported inconsistently
Do not class a NOT_BUILT result as a completed build when calculating
unstable/back to normal build transitions. It should be treated in the
same way as an ABORTED build.
2011-09-23 15:53:28 -07:00
Richard Mortimer fd9d680c74 JENKINS-11013 NOT_BUILT & other build status are reported inconsistently
The parent matrix build console output does not record the build status for
each job. That is useful to get a quick feel for the status of each job and
the order of execution/completion.
2011-09-23 15:53:28 -07:00
Richard Mortimer c444b42b14 JENKINS-11013 NOT_BUILT & other build status are reported inconsistently
Matrix build tooltip reports a pending/queued build as "skipped"
2011-09-23 15:53:28 -07:00
Richard Mortimer ab2cd0e4ad JENKINS-11013 NOT_BUILT & other build status are reported inconsistently
The rss/atom build result feeds report status as "?"
2011-09-23 15:53:28 -07:00
Richard Mortimer eea6d8327b JENKINS-11013 NOT_BUILT & other build status are reported inconsistently
The tooltip for the grey ball is "Pending" when it should be "Not built".
2011-09-23 15:53:28 -07:00
OHTAKE Tomohiro c2bdbd3d15 Arrows in sortable tables only appear in the first row. 2011-09-23 15:48:36 -07:00
OHTAKE Tomohiro 675902a84c [FIXED JENKINS-203] Store sortable table state into local storage. 2011-09-23 15:48:36 -07:00
OHTAKE Tomohiro 30af566074 Add YUI Storage Utility 2011-09-23 15:48:35 -07:00
OHTAKE Tomohiro 0e2fd16810 Update YUI from 2.5.2 to 2.9.0 2011-09-23 15:48:35 -07:00
Kohsuke Kawaguchi 013daf6772 Merge pull request #255 from jieryn/patch-1
Remove excessively old change log information, replace with a link to the current stuff.
2011-09-23 15:37:37 -07:00
Kohsuke Kawaguchi 18c7da3445 not sure how it crept in 2011-09-23 15:36:47 -07:00
Kohsuke Kawaguchi 1b546d9699 [FIXED JENKINS-8751] integrated the Guice branch.
Classes marked as @Extension are now instantiated by Guice.
2011-09-23 15:18:44 -07:00
Kohsuke Kawaguchi 74358e7086 Merge branch 'guice' 2011-09-23 15:17:06 -07:00
Kohsuke Kawaguchi 8c95d32086 added another convenience method 2011-09-23 15:16:59 -07:00
Kohsuke Kawaguchi 29589ba569 should be using ID here since class name is not necessarily unique 2011-09-23 15:16:59 -07:00
Kohsuke Kawaguchi 5d903514bd improve error recovery behaviour 2011-09-23 15:16:33 -07:00
Kohsuke Kawaguchi 81d525b3bf I'm ultimately not using this code, but this pattern of inspecting binding beforehand appears useful, so I'm keeping it in record 2011-09-23 15:16:32 -07:00
Olivier Lamy 24b86a2c66 changelog for Permission check added when viewing configuration of computer set. 2011-09-23 22:14:00 +03:00
Olivier Lamy 4386a8aa31 Merge pull request #254 from PaulSandoz/master
Permission check added when viewing configuration of computer set.
2011-09-23 12:12:10 -07:00
Olivier Lamy 02e73849da changelog for JENKINS-10851 2011-09-23 22:06:48 +03:00
Olivier Lamy 968442b844 Merge pull request #256 from Batmat/JENKINS-10851
[JENKINS-10851] Re-excluding Xalan as it makes Jenkins KO with IBM JVM
2011-09-23 12:04:34 -07:00
Baptiste Mathus b817ebda90 [JENKINS-10851] Reverting part of 1fd7fb2c11 : excluding xalan because its presence makes Jenkins KO on IBM JVM. 2011-09-23 20:49:37 +02:00
Jesse Farinacci 653f70bdc4 Remove excessively old change log information, replace with a link to the current stuff. 2011-09-23 13:55:13 -03:00
Paul Sandoz 29c5354110 Permission to view configure page of computer set. 2011-09-23 13:35:29 +02:00
Werner Beroux 8b54bc4374 Improve weather icons display a clear progression.
The weather icons now show a clear progression from good to bad builds.
See the Wiki currently on https://github.com/wernight/jenkins/wiki for more
details.
2011-09-23 11:34:34 +01:00
Kohsuke Kawaguchi 7218250b43 Can't use stock Guice because Maven uses a patched version. 2011-09-22 21:38:13 -07:00
Kohsuke Kawaguchi 0ce4b12447 Ant returns 0 if the archive doesn't record the access mode 2011-09-22 21:02:11 -07:00
Kohsuke Kawaguchi 9127640c28 Exposed methods to invalidate update center JSON data. 2011-09-22 14:45:22 -07:00
Seiji Sogabe 1f0ed962b2 Merge pull request #252 from aitortxu/master
Fix "Desactivao" is "Desactivado"
2011-09-22 10:41:12 -07:00
Aitor Alzola 45dbab7b17 Fix "Desactivao" is "Desactivado" 2011-09-22 19:36:17 +02:00
Kohsuke Kawaguchi c1451269c3 follow up merge fixes 2011-09-21 22:00:38 -07:00
Kohsuke Kawaguchi e17760256e merged with the latest trunk 2011-09-21 21:41:57 -07:00
Seiji Sogabe 5b3990e5e3 [JENKINS-11068] Do not check if port is not entered. 2011-09-22 12:07:45 +09:00
Seiji Sogabe dff61b86fe fixed ja. 2011-09-22 11:55:34 +09:00
Seiji Sogabe f67476c3b9 updated changelog fot JENKINS-11051,11052 2011-09-21 15:42:00 +09:00
Seiji Sogabe 96fa4c4bab [FIXED JENKINS-11068] Port on HTTP Proxy Configure accepts characters except the digits 2011-09-21 15:35:49 +09:00
Kohsuke Kawaguchi e0f6a7a9b4 the trunk is toward 1.433-SNAPSHOT 2011-09-20 09:56:44 -07:00
Kohsuke Kawaguchi bfa5b2c397 creating an RC branch 2011-09-20 09:56:40 -07:00
Stephen Connolly 1eb0c64abb Somebody was forgetting to close the stream and the resulting signature was therefore at the mercy of the buffer's flush in order to determine whether the signature was correct or not. 2011-09-20 12:58:36 +02:00
Seiji Sogabe 7f62a91a8f [FIXED JENKINS-11051]Broken link in help text of HTTP Proxy Configuration 2011-09-20 18:10:20 +09:00
Seiji Sogabe da7debde91 [FIXED JENKINS-11052] Broken help button for Log Recorders 2011-09-20 17:40:57 +09:00
Seiji Sogabe c6b54ff4be [JENKINS-11056] fixed japanese translation. 2011-09-20 17:06:14 +09:00
Seiji Sogabe 61b572e4a4 Merge pull request #249 from fredg02/master
[FIXED JENKINS-11056] env-vars.html and their translations should be updated
2011-09-20 00:46:09 -07:00
Kohsuke Kawaguchi 9ce4d7c3a1 merged back the RC branch 2011-09-19 18:37:00 -07:00
Kohsuke Kawaguchi e1d4b80ffd updated changelog as a part of the release 2011-09-19 18:36:34 -07:00
Kohsuke Kawaguchi 42c814a2bc toward the next release 2011-09-19 17:34:20 -07:00