Jerome Lacoste
9768125371
JENKINS-8707 make changelog.html pass w3c validator
2011-02-07 10:36:54 +01:00
Jerome Lacoste
dce0d2aff0
merge changelog.html fixes from kk
2011-02-07 10:33:26 +01:00
Jerome Lacoste
1d650570c3
JENKINS-8707 make changelog.html pass w3c validator
2011-02-07 10:25:43 +01:00
Dave Brosius
e7d0ba58d8
Classes that derive from FederatedIdentity are put into the session and should therefore be serializable
2011-02-05 19:31:24 -05:00
Dave Brosius
6bd3f83cb1
remove needless null check, subject isn't null (from above)
2011-02-05 19:21:57 -05:00
Dave Brosius
6201362a5f
don't use reference comparisons with Booleans
2011-02-05 19:19:13 -05:00
Dave Brosius
5571e430d1
remove wasteful duplicate method calls
2011-02-05 19:16:24 -05:00
Dave Brosius
5abb484957
method parms should document the types of values they expect
2011-02-05 19:08:22 -05:00
Dave Brosius
bf7cbca22b
guard against npes
2011-02-05 18:59:54 -05:00
Dave Brosius
2cfd939358
don't use synchronized collections in a local-only context
2011-02-05 18:51:13 -05:00
Dave Brosius
9e32311e2f
use %n for new lines in format strings
2011-02-05 18:39:54 -05:00
Dave Brosius
3c952fc7eb
remove unused code
2011-02-05 18:30:46 -05:00
Brian Atkinson
1d1c18890f
Fix a conditional bug: if the remote end supports pipe throttling, make
...
sure to use the right type of pipe window.
2011-02-05 13:30:10 -06:00
Jerome Lacoste
2e47359a6e
JENKINS-8702 unit tests improvements
...
hudson.UDPBroadcastThread#testMulticast hangs when the network isn't enabled on my Linux box: joinGroup throws IOException and the ready lock isn't released.
This ready lock is only used in the tests.
2011-02-05 13:58:47 +01:00
Jerome Lacoste
826d9ddb3d
JENKINS-8702 improve unit tests. Some core tests are cluttering the output with unuseful logs
2011-02-05 12:24:05 +01:00
Jerome Lacoste
02851236d5
JENKINS-8702 improve unit tests. FilePathTest#testCopy2 isn't a test it has no assertions.
...
It is slow and take 10sec on my compiter. Disabling it. One could remove it I guess.
2011-02-05 12:01:48 +01:00
Jerome Lacoste
b4717d2515
JENKINS-8702 improve unit tests. UpdateCenterTest depends on online resource and takes too long. Fix this
2011-02-05 11:43:07 +01:00
Kohsuke Kawaguchi
63f67f30bd
Fixing the messed up marker tags.
...
Looks like I broke this in d88df7eac5
2011-02-04 23:36:27 -08:00
Kohsuke Kawaguchi
1f8551d02b
explaining how to write this file
2011-02-04 23:32:44 -08:00
Jerome Lacoste
58166dfb2b
Merge remote branch 'upstream/master'
...
Reapplied 329a020188
Conflicts:
core/src/main/java/hudson/widgets/HistoryWidget.java
2011-02-05 07:38:58 +01:00
Kohsuke Kawaguchi
85a8dd009a
[FIXED JENKINS-4756] recording the pull request #33 from Janick Reynders
2011-02-04 21:29:36 -08:00
Kohsuke Kawaguchi
f88a2ba333
Merge branch 'JENKINS-4756'
...
* JENKINS-4756:
minor touch up
FIXED JENKINS-4756 the executor number was not always unique. Computer.executors.size() does not provide a unique number within one Computer.
2011-02-04 21:28:12 -08:00
Kohsuke Kawaguchi
36d9b56250
minor touch up
2011-02-04 21:28:01 -08:00
Kohsuke Kawaguchi
6c521259e2
[FIXED JENKINS-8660] recording the fix from Jerome Lacoste.
2011-02-04 21:15:03 -08:00
Kohsuke Kawaguchi
691f230519
Merge branch 'JENKINS-8660'
...
* JENKINS-8660:
fail more gracefully if the header is not provided.
JENKINS-8660: loading the build history cause an NPE on the History Widget
2011-02-04 21:12:49 -08:00
Kohsuke Kawaguchi
329a020188
fail more gracefully if the header is not provided.
2011-02-04 20:34:09 -08:00
Kohsuke Kawaguchi
fd93cf05df
Recording the fix in HUDSON-8656.
...
Yes, this is HUDSON-8656 and not JENKINS-8656.
2011-02-04 20:23:20 -08:00
Kohsuke Kawaguchi
f8515e96fe
Merge branch 'HUDSON-8656' of https://github.com/nairb774/jenkins
2011-02-04 20:18:23 -08:00
Kohsuke Kawaguchi
91f79062dc
Recording c628bdd32b
2011-02-04 20:10:02 -08:00
Kohsuke Kawaguchi
758aedf885
Merge commit 'c628bdd32be8fdf0f663b373836585498e1ecaa1'
...
* commit 'c628bdd32be8fdf0f663b373836585498e1ecaa1':
First pass at a fix for JENKINS-8592.
2011-02-04 20:07:39 -08:00
Kohsuke Kawaguchi
73a8007d43
[JENKINS-8592] let the writer end know if the reader end of the pipe
...
failed.
2011-02-04 20:06:53 -08:00
Kohsuke Kawaguchi
469610225d
[FIXED JENKINS-3935] add build description to feeds.
...
(recording the previous commit 9d7d0d753d by Richie Vos)
2011-02-04 18:32:13 -08:00
Brian Atkinson
c628bdd32b
First pass at a fix for JENKINS-8592.
...
The problem is that the sending side has no way of knowing when the
receiving side has hung up. So when the receiving side hangs up we should
be able to read till the stream runs out, then close. Not the optimal
solution, but one that should work for now.
http://issues.jenkins-ci.org/browse/JENKINS-8592
2011-02-04 18:46:04 -06:00
Brian Atkinson
f134bd68b9
Add two exact tests for HUDSON-8656.
2011-02-04 18:45:12 -06:00
Brian Atkinson
e7eac75978
This adds a test from HUDSON-8656, and is likely related to issues found in
...
HUDSON-8401.
This grouping of tests targets all Sunday to *another day of week* cron
tabs. There are likely other pairs that could be tested, but this seemed to
work out most of the bugs.
2011-02-04 18:45:12 -06:00
Richie Vos
9d7d0d753d
Add the build's description to the build feed
2011-02-04 16:49:45 -06:00
Olivier Lamy
4cce11efb3
update changelog for 8676
2011-02-04 23:45:38 +01:00
Olivier Lamy
774f655398
Merge branch 'lacostej-pull5' of https://github.com/lacostej/jenkins
2011-02-04 23:41:00 +01:00
Jerome Lacoste
9005eb665f
JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change)
...
After thinking about it, I don't want to deal with hudsonslave here. jenkinsslave should be found anyway, so that code path should not have been triggered.
And cleaning up residual services isn't jenkins job. Otherwise both can't coexist.
2011-02-04 22:36:11 +01:00
Jerome Lacoste
f40b4ffbc8
JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change)
...
After thinking about it, I don't want to deal with hudsonslave here. jenkinsslave should be found anyway, so that code path should not have been triggered.
And cleaning up residual services isn't jenkins job. Otherwise both can't coexist.
2011-02-04 22:34:26 +01:00
Jerome Lacoste
3106a80bcf
Merge remote branch 'upstream/master'
2011-02-04 21:37:39 +01:00
Jerome Lacoste
a70f6b19ae
JENKINS-8698 HudsonTestCase sometimes fails with NPE in tearDown() while trying to free htmlunit resources
...
Not really sure what is happening, but I don't think the build should fail here.
So let's try to be more resiliant (try twice loading the page) and don't fail if the exception occurs again.
2011-02-04 21:36:25 +01:00
Nathan Parry
a88920aab7
Fix JENKINS-8196
...
Persist a user-requested offline status for a slave across
restarts. Previously slaves would come back online if the server
was restarted while they were marked 'temporarily offline'.
I believe this also addresses JENKINS-7934 and JENKINS-7805
which look like duplicates.
2011-02-04 12:09:40 -08:00
Andrew Bayer
d990fbb3f1
Merge branch 'lacostej-pull4' of https://github.com/lacostej/jenkins into lacostej-lacostej-pull4
2011-02-04 11:51:26 -08:00
Andrew Bayer
657c48777e
Merge branch 'lacostej-pull3' of https://github.com/lacostej/jenkins into lacostej-lacostej-pull3
2011-02-04 11:45:59 -08:00
Jerome Lacoste
4077b5da1c
Merge remote branch 'upstream/master'
2011-02-04 20:33:22 +01:00
alanharder
c3e7be3461
update some images to use ci.jenkins-ci.org,
...
add "since 1.378" in one changelog item
2011-02-04 10:43:30 -08:00
Jerome Lacoste
020a4ee92a
JENKINS-8686 IO stream copies are not done properly.
...
Some more work:
* reviewed some callers
* took note that some classes have been moved into stapler
* used IOUtil.closeQuietly() in a few places
2011-02-04 15:34:26 +01:00
Jerome Lacoste
bfbaf2c9d9
JENKINS-8686 IO stream copies are not done properly.
...
First pass at making sure we don't stop copying when the reader reads 0 characters.
I will now also review the callers for our internal code, and check if we can use IOUtils methods instead.
2011-02-04 15:34:07 +01:00
Kohsuke Kawaguchi
9c01038ab5
[FIXED JENKINS-5784] logrotate script for RPM/openSUSE bug fix
2011-02-03 23:50:20 -08:00