Commit Graph
17505 Commits
Author SHA1 Message Date
mindless 114a00bdb1 Some people see PingThread terminating slaves with running builds
( http://hudson.361315.n4.nabble.com/Regarding-the-IOException2-ChannelClosedException-many-of-us-has-been-seeing-lately-td2280769.html ).
Increase defaults to ping every 10 min with 4 min timeout (was every 5 min with 1 min timeout),
and add system properties that can override these defaults or disable ping thread.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32664 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-09 18:09:17 +00:00
rseguy 63047163e4 Added some more explanations for when no file is actually uploaded.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32656 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-09 12:26:03 +00:00
mindless 0908fd4424 [FIXED HUDSON-6923] add data attribute with numeric duration for proper sorting
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32584 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-08 06:14:30 +00:00
kohsuke 3ffa939891 Show outline structure for Ant execution in the console output view.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32581 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-08 01:44:34 +00:00
kohsuke ef4f9c9c31 Initialized merge tracking via "svnmerge" with revisions "1-32578" from
https://www.dev.java.net/svn/hudson/branches/rc


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32580 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-08 00:27:17 +00:00
kohsuke 9c349ecac5 made the concurrency easily customizable
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32575 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-08 00:26:01 +00:00
kohsuke 52838e1313 doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32559 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-07 18:24:31 +00:00
kohsuke 8cb24423cc Merged revisions 32496,32499,32501,32505 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r32496 | kohsuke | 2010-07-05 11:27:25 -0700 (Mon, 05 Jul 2010) | 1 line
  
  integrated a fix for SECURITY-4
........
  r32499 | kohsuke | 2010-07-05 14:19:34 -0700 (Mon, 05 Jul 2010) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_365
........
  r32501 | kohsuke | 2010-07-05 14:19:48 -0700 (Mon, 05 Jul 2010) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r32505 | kohsuke | 2010-07-05 15:29:51 -0700 (Mon, 05 Jul 2010) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32558 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-07 18:07:53 +00:00
kohsuke b2664abddd since we check both the queue and executors, waiting for 100msx5 is probably a waste of time.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32537 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-07 01:47:55 +00:00
kohsuke 3befa41492 indentation fix
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32536 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-07 01:45:12 +00:00
kohsuke 236a4136b7 disable DNS multicast support during tests for performance and correctness.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32534 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-07 00:56:02 +00:00
kohsuke c7a5a555e5 added additional methods to expose the pending state.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32533 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 23:34:20 +00:00
kohsuke 04ec9159c6 when updating list box options dynamically, try to preserve the current selection. The only case this doesn't make sense is when the server explicitly tells us the value to select.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32532 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 23:15:21 +00:00
kohsuke ecfbd6a0d4 better documenting my intention in rev.32528.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32531 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 22:45:26 +00:00
kohsuke 142c31bcba support "../foo" to refer to the "foo" parameter of the parent scope (the scope in the sense of the structured form submission.)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32530 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 22:40:42 +00:00
kohsuke 5e736c213d "Hudson is loading" page didn't take the user back to the same page.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32529 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 22:18:53 +00:00
kohsuke e9463136f2 follow up to rev.31906. I think this was breaking the atomicity.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32528 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 22:17:55 +00:00
kohsuke fe042a4998 <li class=rfe>
Hudson can now remotely install JDK on Windows slaves when connecting via the
    "Let Hudson control this Windows slave as a Windows service" mode.
  <li class=rfe>
    The "Let Hudson control this Windows slave as a Windows service" mode now allows the same Windows slave
    to be used by multiple Hudson masters.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32525 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 17:46:53 +00:00
kohsuke 941559c98c [FIXED HUDSON-6034] plain text console output needs to filter out inline console annotations
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32514 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-06 02:12:06 +00:00
StevenGBrown cdbe303dd2 [FIXED HUDSON-6897] The file parameter name is now encoded before used within the download URL.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32431 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-01 13:57:25 +00:00
StevenGBrown a0c958b61f [FIXED HUDSON-6896] The correct file name is now provided when a file parameter is uploaded via the CLI.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32421 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-01 13:30:12 +00:00
mindless 09ffe933d1 [FIXED HUDSON-6779] When a MavenModuleSetBuild is deleted, delete its contained
module builds too.. this avoids orphaned module builds that then get looked at
in determining the overall result for the prior ModuleSetBuild.. possibly
mysteriously changing the displayed result for that prior build, with no visual
indication as to why (this part just fixed in r32410.. build page will now list
all module builds, so you can see/delete the orphaned module build).


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32411 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-01 02:05:00 +00:00
mindless 5ce25186a1 An aggregator style build doesn't necessarily have only 1 build per module,
contrary to comment in this jelly.. you can trigger a build of an individual
module from hudson UI.  Refactor this jelly to use the current style most
of the time, and the multi-build style whenever needed.
This will help those affected by HUDSON-6779 as the orphaned builds will
now be visible on the build page, so you can click on and then delete them.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32410 71c3de6d-444a-0410-be80-ed276b4c234a
2010-07-01 01:58:12 +00:00
mindless 67a3c8a5bf remove !=false on canDelete call.. thought this would provide backward compatibility,
but jelly does get AbstractMethod error (not null) if instance doesn't implement the
canDelete method, so I'll just release a new version of nested view plugin..


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32398 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 19:07:54 +00:00
mindless 257aa0d992 use "command" as name for shell/batchfile textarea in the form,
so the @DataBoundConstructor on these classes can work.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32397 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 17:37:12 +00:00
kohsuke 570e3e6bc0 added another convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32396 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 15:45:26 +00:00
kohsuke 66b9d9baaf fixed a possible security issue (SECURITY-3)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32394 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 15:31:02 +00:00
StevenGBrown f756ddae48 [FIXED HUDSON-6889] FileParameterValue now creates the directory that the file parameter is copied into, since DiskFileItem does not.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32393 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 15:21:33 +00:00
StevenGBrown a85f563950 Fixed the file parameter description help URL (TODO.html does not exist).
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32390 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-30 14:18:48 +00:00
mindless bbf53fc98b add system property to set auto refresh interval
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32336 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-28 22:31:48 +00:00
abayer e875b968dc Adding metrics profile
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32330 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-28 20:48:12 +00:00
kohsuke 395206eb85 Merged revisions 32297,32299,32305 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r32297 | kohsuke | 2010-06-25 17:34:56 -0700 (Fri, 25 Jun 2010) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_364
........
  r32299 | kohsuke | 2010-06-25 17:35:15 -0700 (Fri, 25 Jun 2010) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r32305 | kohsuke | 2010-06-25 21:37:44 -0700 (Fri, 25 Jun 2010) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32326 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-28 17:44:22 +00:00
mindless 9083e5d6e6 [HUDSON-6849] revert r32272.. might as well keep URLs a little shorter
until/unless this issue is better understood.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32325 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-28 03:18:23 +00:00
mindless af20a4dc2b [FIXED HUDSON-6862] Update Ant fileset link from
http://ant.apache.org/manual/CoreTypes/fileset.html
to
http://ant.apache.org/manual/Types/fileset.html
in core and several plugins, changing to a translation parameter where possible.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32324 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-27 21:09:33 +00:00
mindless 6ce5b797cc [FIXED HUDSON-6832] Hide some sidepanel links that should not be shown in
user-private views.  Use it="${app}" for Manage Hudson and New Job links,
so these check the proper permission.  Replaced !it.isDefault() check
with new ViewGroup.canDelete API call.. Hudson ViewGroup uses isDefault()
for this method; MyViewsProperty checks views.size() > 1 so link is
hidden when there is only one user-private view.
Used !=false in jelly for backward compatibility (if a plugin implements
ViewGroup but does not have canDelete, null!=false will result in true).


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32319 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-27 18:31:50 +00:00
kutzi 40ffa913f8 [FIXED HUDSON-6543] use last 3 builds to calculate estimated remaining build time
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32310 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-26 13:37:56 +00:00
km f1b4cf47de [FIXED HUDSON-6849]
Go to getDescriptorByName rather than getDescriptor to get the help files. This is useful in
situations where Hudson instance is not the root of the webapp.



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32272 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 23:03:56 +00:00
jglick 2ccc5f4883 [HUDSON-6577] Explain how to use negative lookahead.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32268 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 14:26:04 +00:00
kohsuke ca1f11595c Initialized merge tracking via "svnmerge" with revisions "1-32261" from
https://www.dev.java.net/svn/hudson/branches/rc


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32263 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 02:01:32 +00:00
kohsuke 3216dface6 [FIXED HUDSON-6819] Here is the race condition that induces this problem.
- Task X becomes buildable
- Thread E1 enters the pop() method, assigns X to an executor E2.
  Note that at this point X is not removed from the buildables list yet
- Thread E1 goes to offer.event.block and blocks, losing the lock
- Thread E3 enters the pop() method, assigns X to anogher executor E4.
  This is possible because X is still in the buildables list.
- Thread E3 goes to offer.event.block  and blocks, losing the lock.
- Thread E2 wakes up, obtains the lock and execute the rest of the
  pop() method. It decides that it's assigned X, it removes X from
  the buildables list.
- Thread E2 leaves the pop() method, loses the lock, and starts building X
- Thread E4  wakes up, obtains the lock, and executes the rest of the
  pop() method. It decides that it's assigned X. It tries to remove X
  from the buildables list. This remove operation becomes no-op,
  but we don't check that.
- Thread E4 leaves the pop(), and start building X.

Thus we end up building X twice.

To avoid this problem, I've introduced the 4th state "pending", and moves BuildableItem from buildables to pendings as soon as we assigned it to the executor. New BuildableItem cannot be created
while its another copy is either in the buildables or pendings state.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32258 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 01:40:12 +00:00
kohsuke b2df57e4f0 [FIXED HUDSON-6497] slightly revised the patch, to avoid using a boolean flag for a concurrency control. It affects the serialization format, and it's not concurrency safe.
Given the use case described in the bug, I wonder if it's better to have a different extension point (sort of like ComputerListener) that can contribute build variables to any builds going on in the system.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32257 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 00:47:03 +00:00
kohsuke 59317c93fb [HUDSON-6819] tweaking the implementation a bit so that the code never ever have multiple edges between the same src and dst.
Not that I was able to spot where the previous code did that, but this implementation is bit more straightforward.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32256 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-24 00:17:13 +00:00
kohsuke 46f7945813 value equality unnecessary
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32255 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-23 23:21:34 +00:00
kohsuke b38c53b8eb improving the error diagnostics.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32254 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-23 22:44:41 +00:00
jglick 33f7ed732f [FIXED HUDSON-6824] Statically held fields should be of type Localizable rather than String.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32240 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-22 20:10:59 +00:00
teilo 380d479dd5 [FIXED HUDSON-6525] commited user supplied path to hide password parameter in maven logs.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32227 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-22 12:10:04 +00:00
GLundh 0aaa0fa5b0 [FIXED HUDSON-6787] If a suitable truncable index cannot be found, force a trunc at maxTruncLength.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32224 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-22 09:24:08 +00:00
jglick b83a335e85 Fixed typo.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32205 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-21 16:52:34 +00:00
wyukawa ff9ece2299 fix link of Apache Ant FileSet URL
from http://ant.apache.org/manual/CoreTypes/fileset.html
to http://ant.apache.org/manual/Types/fileset.html

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32171 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-19 10:06:47 +00:00
wyukawa b0cdf1eb2e fix link of Apache Ant FileSet URL
from http://ant.apache.org/manual/CoreTypes/fileset.html
to http://ant.apache.org/manual/Types/fileset.html

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32164 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-19 06:45:26 +00:00