Commit Graph
17505 Commits
Author SHA1 Message Date
kohsuke 013758b2f5 [FIXED HUDSON-936] in 1.337 by moving out the start method from Executor.
Since not many code will own Executors, for now I didn't introduce any wrapper to hide the start method invocation.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24159 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-28 15:19:21 +00:00
kohsuke 53b8f8a518 [HUDSON-936] Applied the patch from pcc.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24149 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-28 00:56:25 +00:00
kohsuke bd775698b9 Merged revisions 24110-24112 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r24110 | kohsuke | 2009-11-25 17:14:49 -0800 (Wed, 25 Nov 2009) | 22 lines
  
  On my production server I started seeing a strange NPE
  like this:
  
  java.lang.NullPointerException
      at hudson.model.Label.contains(Label.java:277)
      at hudson.model.Queue$JobOffer.canTake(Queue.java:177)
      at hudson.model.Queue$ApplicableJobOfferList.(Queue.java:767)
      at hudson.model.Queue$ApplicableJobOfferList.(Queue.java:759)
      at hudson.model.Queue.pop(Queue.java:684)
      at hudson.model.Executor.grabJob(Executor.java:161)
      at hudson.model.Executor.run(Executor.java:103)
  
  The only possibility is that the getNodes() is returning null,
  and that's only possible if Label.getNodes() returns null,
  which in turn is only possible if the assignment to nodes
  is overwritten by the reset method before it's used as a
  return value.
  
  This fix should eliminate the possibility that the getNodes()
  method return null.
........
  r24111 | kohsuke | 2009-11-25 17:15:45 -0800 (Wed, 25 Nov 2009) | 2 lines
  
  Actually, getNodes() has another possibility of such a data race.
........
  r24112 | kohsuke | 2009-11-25 17:24:27 -0800 (Wed, 25 Nov 2009) | 1 line
  
  typo
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24127 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-26 09:10:31 +00:00
kohsuke 2d38b33630 Initialized merge tracking via "svnmerge" with revisions "1-24107" from
https://www.dev.java.net/svn/hudson/branches/rc


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24109 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-26 01:03:36 +00:00
kohsuke db986956ae Tests fail randomly where it forks Maven with:
ERROR: Maven JVM terminated unexpectedly with exit code 143


Perhaps it's hitting some resource limit? While I investigate the issue
falling back to single thread execution.



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24104 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-25 23:41:00 +00:00
kohsuke cf22345820 [FIXED HUDSON-4820] Fallback gracefully if JNA is not available.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24103 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-25 23:21:17 +00:00
mindless 49b47dc41e [FIXED HUDSON-4927] Send build status email to valid addresses rather than aborting
for one invalid address


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24091 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-25 16:40:25 +00:00
mindless 53a9f975ea use folder icon for "New View"
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24036 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-25 00:24:39 +00:00
kohsuke fdad6faa3f report the key milestone during the initialization.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24035 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 22:40:01 +00:00
kohsuke c9f90e508a This logging doesn't contribute much
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24033 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 22:01:22 +00:00
kohsuke fdc6701d39 use the system property to control the log level
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24028 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 19:40:10 +00:00
jglick 7fe28a4bcb Avoid gratuitous JDK 6 dependencies.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24024 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 17:43:25 +00:00
jglick 5b7c857cfd [HUDSON-4941] Log which file had an XML parse error to assist in diagnosis & fix.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24022 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 16:36:07 +00:00
javadude bf8c9fba1e Added try/catch in AbtractBuild checkout handling to allow SCM plugins that throw exceptions to be retried.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24010 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 05:33:09 +00:00
mindless 34c15c775e [FIXED HUDSON-1867] Add ability to delete users from Hudson
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24009 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 03:59:43 +00:00
kohsuke 51fa0395d4 [FIXED HUDSON-4830] in 1.336. Thanks for the patch!
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24007 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 02:41:52 +00:00
kohsuke 98fc005633 Smart JDK/Maven/Ant auto installers aren't available for existing tool configurations.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24005 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 02:07:14 +00:00
kohsuke 3b265adb70 wrong URL
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24003 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 01:39:49 +00:00
kohsuke fd13eee6d5 Merged revisions 23666-23667,23670,23711,23782-23785,23788,23809-23810,23817,23859,23870,23879,23899-23904,23906-23907,23909,23913 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/managed-startup

........
  r23666 | kohsuke | 2009-11-11 15:56:46 -0800 (Wed, 11 Nov 2009) | 1 line
  
  Reworked the initialization logic
........
  r23667 | kohsuke | 2009-11-11 16:01:56 -0800 (Wed, 11 Nov 2009) | 1 line
  
  fixed a failing test
........
  r23670 | kohsuke | 2009-11-11 16:42:32 -0800 (Wed, 11 Nov 2009) | 1 line
  
  use a non-snapshot
........
  r23711 | kohsuke | 2009-11-13 14:27:28 -0800 (Fri, 13 Nov 2009) | 1 line
  
  Session -> Reactor
........
  r23782 | kohsuke | 2009-11-17 10:35:14 -0800 (Tue, 17 Nov 2009) | 1 line
  
  Poorman's clone of JDK6 ServiceLoader.
........
  r23783 | kohsuke | 2009-11-17 10:56:25 -0800 (Tue, 17 Nov 2009) | 1 line
  
  Integrated the fatal support so that all errors are sent to the listener.
........
  r23784 | kohsuke | 2009-11-17 10:58:07 -0800 (Tue, 17 Nov 2009) | 1 line
  
  with the new reactor initialization, things are getting too verbose
........
  r23785 | kohsuke | 2009-11-17 11:18:45 -0800 (Tue, 17 Nov 2009) | 1 line
  
  failing to load jobs are non-fatal, too
........
  r23788 | kohsuke | 2009-11-17 13:18:59 -0800 (Tue, 17 Nov 2009) | 1 line
  
  logging the exception properly
........
  r23809 | kohsuke | 2009-11-17 18:45:47 -0800 (Tue, 17 Nov 2009) | 1 line
  
  releasing 1.1 as milestone
........
  r23810 | kohsuke | 2009-11-17 18:47:37 -0800 (Tue, 17 Nov 2009) | 2 lines
  
  - use a better idiom for building a sequence
  - use null display name to signify internal book-keeping tasks that's not worth displaying
........
  r23817 | kohsuke | 2009-11-18 07:54:17 -0800 (Wed, 18 Nov 2009) | 1 line
  
  removed accidental JDK6 dependency.
........
  r23859 | kohsuke | 2009-11-19 11:03:28 -0800 (Thu, 19 Nov 2009) | 1 line
  
  introducing the strategy pattern to hook into key decision making points during the start up
........
  r23870 | kohsuke | 2009-11-19 14:33:07 -0800 (Thu, 19 Nov 2009) | 1 line
  
  bug fix. These steps add additional tasks to the reactor, so they need to also prevent future milestones from getting attained.
........
  r23879 | kohsuke | 2009-11-19 16:54:59 -0800 (Thu, 19 Nov 2009) | 1 line
  
  moved the logic to the strategy.
........
  r23899 | kohsuke | 2009-11-20 09:32:13 -0800 (Fri, 20 Nov 2009) | 1 line
  
  handle duplicate plugins better
........
  r23900 | kohsuke | 2009-11-20 10:06:42 -0800 (Fri, 20 Nov 2009) | 1 line
  
  support pre-exploded plugin
........
  r23901 | kohsuke | 2009-11-20 10:49:04 -0800 (Fri, 20 Nov 2009) | 1 line
  
  making it a subtype
........
  r23902 | kohsuke | 2009-11-20 10:54:42 -0800 (Fri, 20 Nov 2009) | 1 line
  
  allow InitStrategy to skip some tasks
........
  r23903 | kohsuke | 2009-11-20 11:03:38 -0800 (Fri, 20 Nov 2009) | 1 line
  
  doc improvement.
........
  r23904 | kohsuke | 2009-11-20 11:03:49 -0800 (Fri, 20 Nov 2009) | 1 line
  
  no need to throw exceptions
........
  r23906 | kohsuke | 2009-11-20 11:17:34 -0800 (Fri, 20 Nov 2009) | 1 line
  
  debug switch to disable the automatic launch of slaves
........
  r23907 | kohsuke | 2009-11-20 11:25:15 -0800 (Fri, 20 Nov 2009) | 1 line
  
  added a magic object for cancelling all saves
........
  r23909 | kohsuke | 2009-11-20 11:29:53 -0800 (Fri, 20 Nov 2009) | 1 line
  
  moving initialization up
........
  r23913 | kohsuke | 2009-11-20 13:32:08 -0800 (Fri, 20 Nov 2009) | 1 line
  
  seeing heap space problem during tests
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23992 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-23 19:33:33 +00:00
kohsuke ef7768a0a9 Initialized merge tracking via "svnmerge" with revisions "1-23639" from
https://www.dev.java.net/svn/hudson/branches/managed-startup


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23991 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-23 19:06:23 +00:00
kohsuke 7335533d68 [FIXED HUDSON-4873] in 1.336
Matrix configuration builds should continue even when Hudson is about to shut down.
    (<a href="https://hudson.dev.java.net/issues/show_bug.cgi?id=4873">issue 4873</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23980 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-23 16:55:03 +00:00
kohsuke 686d1b9283 [HUDSON-4876] Compatibility for the caller. This is more convenient for Jelly scripts, too.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23979 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-23 15:00:31 +00:00
kohsuke a9f3c9c1e9 [FIXED HUDSON-4876] If restart is not supported, explain why.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23978 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-23 14:53:06 +00:00
mindless 57f34037d2 [FIXED HUDSON-4924] avoid exception if a plugin implementing LabelFinder
extension provides a null label.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23975 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-23 06:57:25 +00:00
mindless 3be4551e3b [FIXED HUDSON-1986] Update or remove lastSuccessful/lastStable symlinks on filesystem
as appropriate when a build is deleted.  Based on patch from xlv.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23973 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-22 23:02:55 +00:00
mindless b4af8a5a2a Fix createSymlink so it overwrites existing link properly if the existing
link points to a non-existent file/dir (in this case File.exists() returns
false, so it was not removed before creating new symlink).
This change also avoids exec of "rm -rf" when simple File.delete() succeeds.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23972 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-22 22:54:13 +00:00
mindless b86b2d7226 set logger name in LogRecords sent from LogTaskListener,
but also check for null logger name in LogRecorder to avoid
NPE from any other such case.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23971 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-22 22:52:00 +00:00
kohsuke 3008124e52 [FIXED HUDSON-4879] requires a full JRE, not just a headless JRE. Presumably fonts are only installed with full JRE since they aren't needed in a headless. This fix will be in 1.336.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23968 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-22 15:20:42 +00:00
kohsuke 06651a0e66 run tests with maven-junit-plugin for improved parallelism
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23940 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-21 15:56:40 +00:00
kohsuke 3f1f29aee1 Merged revisions 23932-23934 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23932 | kohsuke | 2009-11-20 23:58:03 -0800 (Fri, 20 Nov 2009) | 1 line
  
  gpg can take passphrase from a file by itself
........
  r23933 | kohsuke | 2009-11-21 00:01:53 -0800 (Sat, 21 Nov 2009) | 1 line
  
  merged the temporary change in the 1.335 tag
........
  r23934 | kohsuke | 2009-11-21 00:02:25 -0800 (Sat, 21 Nov 2009) | 1 line
  
  in case someone updates changelog.html while a release is in progress
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23936 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-21 08:07:33 +00:00
kohsuke 6bb99e4001 forgot to add this
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23931 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-21 07:54:42 +00:00
kohsuke 939cbe0576 Merged revisions 23928 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23928 | kohsuke | 2009-11-20 23:49:50 -0800 (Fri, 20 Nov 2009) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23930 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-21 07:50:40 +00:00
kohsuke 1922733709 Merged revisions 23918,23920 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23918 | kohsuke | 2009-11-20 14:44:46 -0800 (Fri, 20 Nov 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_335
........
  r23920 | kohsuke | 2009-11-20 14:44:57 -0800 (Fri, 20 Nov 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23921 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 22:54:18 +00:00
kohsuke 71dbf59b68 Merged revisions 23905 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23905 | kohsuke | 2009-11-20 11:12:13 -0800 (Fri, 20 Nov 2009) | 1 line
  
  running with a bigger heap as I started seeing random failures due to heap size
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23908 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 19:29:42 +00:00
kohsuke 9bd3053989 final tweak
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23897 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 17:12:49 +00:00
kohsuke 8b0d5cc263 make sure it just reads the passphrase from a file
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23896 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 16:52:47 +00:00
kohsuke 8ee465a450 Merged revisions 23890 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23890 | mindless | 2009-11-20 08:40:17 -0800 (Fri, 20 Nov 2009) | 2 lines
  
  [HUDSON-4894] merge r23889 to rc branch for 1.335
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23893 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 16:42:52 +00:00
mindless a96c6e02f8 [FIXED HUDSON-4894] match windows absolute path like C:/path as requested by torbent.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23889 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 16:14:51 +00:00
kohsuke da9cdc71b6 signing the repository
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23888 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 15:38:31 +00:00
sogabe 82f1cf97f9 Japanese localization
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23887 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 12:10:15 +00:00
kohsuke 2e3365a070 Improved the error diagnostics on the failure to establish connection with JNLP slaves early on.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23883 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 02:52:49 +00:00
kohsuke 63e48ae865 improved the diagnosability.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23882 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 01:49:03 +00:00
mindless b6600a3fbd User pages showed add/edit description link to users without permission to edit,
and guests were allowed to edit the user profile for anonymous user.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23881 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 01:33:09 +00:00
mindless 3a244cf8a0 Computer.CONFIGURE permission has existed for a long time, but it only shows the
configure link.. admin permission was needed to actually configure.
Fixed this so configuration can be done, and also hide the configure link for
master node unless you also have admin permission.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23880 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 00:55:07 +00:00
mindless c078a6c855 Improve display of cause of slaves being offline.
- Removed "failed to launch" message from ComputerLauncher/main.jelly
  This message was always shown, even if slave was offline for other reasons.
- Instead, added new OfflineCause.LaunchFailed which is set in SlaveComputer if channel
  is not set after calling launcher.  Now this shows the "failed to launch" message.
- Moved/copied existing translations for these strings to their new locations.
- Expanded message for in-demand strategy to say "will be relaunched when needed"
- Added text explanation and fixed display of exception for ChannelTermination cause
- Use class="warning" for default display of OfflineCause
- Added some @Override annotations


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23876 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-19 23:55:43 +00:00
mindless 991e7f8fdd [FIXED HUDSON-3890] Fix in-demand RetentionStrategy and more offline-slave fixes.
- Use isConnecting() instead of lastConnectActivity!=null in checking forceReconnect
  param.. var never resets to null, so this prevented forceReconnect==false from ever
  reconnecting (which broken in-demand strategy since 1.302 when it started using false)
- Only set ChannelTermination offline cause when the exception param is non-null.
  On orderly shutdown this was replacing the real cause of going offline.
- In setNode try to delegate to RetentionStrategy rather than calling connect directly.
  Reconfiguring a node was launching slave even if it wasn't needed per its strategy.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23875 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-19 23:37:45 +00:00
mindless 5f4d50dbfe Allow zero for inDemandDelay in RetentionStrategy.Demand.
Don't write "launching" in log if launch is not supported.
Don't need to call check() every minute for NOOP strategy.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23874 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-19 23:02:11 +00:00
mindless a8ffa18f8d fix a couple typos in comments
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23871 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-19 22:42:44 +00:00
kohsuke 37f4e3eac8 Merged revisions 23868 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23868 | kohsuke | 2009-11-19 14:30:20 -0800 (Thu, 19 Nov 2009) | 1 line
  
  Matrix build wasn't showing their full name in the executor list on the left.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23869 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-19 22:31:07 +00:00
kohsuke 5f7c8023a7 Gracefully detect the double loading of JNA instead of failing later with NoClassDefFoundError.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23864 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-19 22:24:43 +00:00