Commit Graph
17505 Commits
Author SHA1 Message Date
kohsuke 235db08eb4 improved cross referencing.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21698 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 02:29:49 +00:00
kohsuke 905796f3e7 bundling the latest version of trilead-ssh2
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21696 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 00:46:24 +00:00
kohsuke 4d3f914a93 adding cheaper tests.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21689 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 19:32:56 +00:00
kohsuke 200518006a refactoring the JDK installer to allow ssh-slaves to do this over SSH.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21687 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 18:53:31 +00:00
kohsuke 08c9928037 allow subtypes to be defined by plugins.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21686 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 18:12:52 +00:00
kohsuke c954bbd211 modified to tag the point where the RC was branched off
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21667 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 00:53:31 +00:00
kohsuke 4e5ca312b8 comment touch up
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21666 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 00:14:37 +00:00
kohsuke 77ef7e0184 A trouble-shooting on one of the production Hudson servers resulted in a thread infinitely hanging. Making the code defensive to avoid this problem.
"pool-10-thread-6 / waiting for hudson.remoting.Channel@39a5b0:winxpie7.sfbay.sun.com" Id=579896 WAITING on hudson.remoting.UserRequest@3b4670
	at java.lang.Object.wait(Native Method)
	-  waiting on hudson.remoting.UserRequest@3b4670
	at java.lang.Object.wait(Object.java:485)
	at hudson.remoting.Request.call(Request.java:116)
	at hudson.remoting.Channel.call(Channel.java:536)
	at hudson.slaves.SlaveComputer.setChannel(SlaveComputer.java:305)
	at hudson.plugins.sshslaves.SSHLauncher.startSlave(SSHLauncher.java:220)
	at hudson.plugins.sshslaves.SSHLauncher.launch(SSHLauncher.java:180)
	-  locked hudson.plugins.sshslaves.SSHLauncher@985bc4
	at hudson.slaves.SlaveComputer$1.call(SlaveComputer.java:175)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)

	Number of locked synchronizers = 1
	- java.util.concurrent.locks.ReentrantLock$NonfairSync@14f0686


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21665 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 00:14:21 +00:00
kohsuke 8a73c25000 Fixed the charset encoding handling when different encodings are involved between the master and slaves.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21664 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 23:52:25 +00:00
kohsuke 73f1b2ebac fixed a serialization form of Result so that it works like a value type.
See http://d.hatena.ne.jp/masanobuimai/20090911#1252684658

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21663 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 22:56:08 +00:00
abayer a06763a324 Rolling back r21576
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21662 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 20:36:31 +00:00
mindless 82f0feb999 Updates to use non-deprecated APIs, and add some @Override annotations
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21661 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 19:40:23 +00:00
mindless 2a67420162 fix indent
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21657 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 19:19:35 +00:00
mindless db93c57e03 Add @Override annotations, one copyright header and some tab->ws
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21655 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 19:10:57 +00:00
mindless 9fed9823f5 Add @Override annotations, remove unused imports,
add some copyright headers, some tab->ws


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21654 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 18:08:34 +00:00
pgweiss 7c2d1e9455 Don't fail the build when there is nothing to archive -- just warn -- provided system property hudson.tasks.ArtifactArchiver.warnOnEmpty=true
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21652 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 15:28:53 +00:00
dty 2a34cdafe6 [HUDSON-3677] First pass at providing read-only access to project configuration.
Defined a new permission, ExtendedRead, which can be enabled by specifying true
for the system property hudson.security.ExtendedReadPermission. Granting job
configuration permissions implies this permission.

	main/core/src/main/java/model/Item.java

Added plumbing for dynamic enabling and disabling of permissions at runtime.
This will be the basis for future UI based toggling of the availability of a
permission.

	main/core/src/main/java/hudson/security/Permission.java

Add the enabled state of a permission to the decision about whether a principal
has it or not. Only show a permission when it's enabled.

	main/core/src/main/java/hudson/security/GlobalMatrixAuthorizationStrategy.java

Allow access to config.xml when ExtendedRead is granted.

	main/core/src/main/java/hudson/model/Job.java

Don't show the save button if the user only has ExtendedRead.

	main/core/src/main/resources/hudson/model/Job/configure.jelly

Change the text of the Configure link in the side panel based on whether a user
has Configure or ExtendedRead permissions.

	main/core/src/main/resources/hudson/model/AbstractProject/sidepanel.jelly



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21626 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-12 08:13:00 +00:00
abayer 75ec5aef92 [FIXED HUDSON-4442] Empty or whitespace-only modules are now properly ignored by POM parser
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21610 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-11 15:06:22 +00:00
mindless 60993d8bef Revert r21459 until cvs is ready as a plugin.. for now it causes broken
help links and failures in HelpLinkTest.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21601 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 22:56:40 +00:00
abayer e69a370619 Belatedly adding a test in MavenMultiModuleTest, adding MavenJellyTest to test maven-plugin's Jelly scripts
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21600 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 22:38:57 +00:00
kohsuke 8d98e3929a [HUDSON-3814] associating this test case with the bug ID in question.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21587 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 21:50:57 +00:00
kohsuke fe94108490 adding a test case for http://www.nabble.com/tar.gz-becomes-.gz-after-Hudson-deployment-td25391364.html but failed to reproduce the problem.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21583 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 21:45:13 +00:00
kohsuke 13ac5a7edf perform syntax checks on Jelly scripts
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21577 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 20:45:23 +00:00
abayer 8f45c551e8 Adding top-level pluginManagement, pushing plugin definitions to there, making sure every plugin is invoked as at least groupId/artifactId in child poms
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21576 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 20:44:49 +00:00
kohsuke dfacf6eab5 delete the config file first, so that even if the request doesn't fully complete, the job won't be resurrected.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21575 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 20:40:25 +00:00
abayer 6cf4165a55 Adding version info for findbugs maven plugin
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21572 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 17:33:01 +00:00
mindless c3583afaff avoid a couple redundant save() calls in submit()
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21571 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 16:35:26 +00:00
mindless 55d7345706 Align/center "Master" in executor status the same as other slave headings (for mrooney)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21564 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 23:14:13 +00:00
redsolo b04ba7bf88 [HUDSON-4423] Added test case for issue
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21560 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 20:12:06 +00:00
mindless f8751b2001 [FIXED HUDSON-4366] move runSequentially checkbox outside the Axes optionalBlock.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21558 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 19:58:19 +00:00
mindless bf9c475fe6 [FIXED HUDSON-4405] trim remoteFS value to avoid hard-to-notice error
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21557 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 19:04:17 +00:00
mindless bcd7e87b0d [FIXED HUDSON-4392] call Util.rawEncode on slaveName in jnlp url
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21556 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 18:51:33 +00:00
mindless 3fc6d397ac [FIXED HUDSON-4402] s/rootUrl/rootURL/ to fix link in junit test results.
Also fixed 1 more in RunParameterValue.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21554 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 18:34:40 +00:00
mindless d47993cfc6 [FIXED HUDSON-4333] rename constructor param from defaultvalue to defaultValue
so it works properly with @DataBoundConstructor


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21553 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 17:40:51 +00:00
abayer c13c7f94f0 [FIXED HUDSON-4423] Properly setting blockBuildWhenUpstreamBuilding now
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21550 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 16:03:12 +00:00
mindless f7e9b4fbd1 Replace uses of /fieldCheck validator with clazz="required" client-side validation.
Marked Hudson.doFieldCheck as deprecated.
Also a few more escape->encodeURIComponent.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21549 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 01:27:07 +00:00
mindless 41b1ebd4d0 Add clazz attribute on f:textbox so clazz="number" or "positive-number"
can be used for client-side validation, and replaced some <input>
with f:textbox calls.  Also another encode->encodeURIComponent.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21548 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 01:15:12 +00:00
mindless 533b34e195 Change escape(this.value) and encode(this.value) calls in checkUrl attributes
to encodeURIComponent(this.value).  Escape is not sufficient, as it does not
encode +.  Function encode() in hudson-behavior.js is ok, but we can just use
a standard javascript function instead.
Marked encode() as deprecated.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21546 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 00:45:49 +00:00
mindless 3581170d28 change some <input> to use f:textbox or f:password
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21545 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 00:19:42 +00:00
mindless 03d15ffd34 Add class="required" client-side validator.
Added support for multiple client-side validators (class="required number"),
and for checkMessage=".." attribute to override default error message.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21538 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-08 17:28:21 +00:00
mindless 5491cb256a [Util.rawEncode] Change complicated if expression to simpler array lookup
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21537 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-08 17:26:13 +00:00
redsolo f2d1417e4d Added test for including summary.jelly files from job properties.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21531 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-07 22:06:13 +00:00
abayer a5f24cca93 [FIXED HUDSON-1066] Added call to MailSender in RunnerImpl.cleanUp so that mail gets sent for top-level Maven project as well as individual modules. Also, William the Conqueror won the Battle of Hastings in 1066. Just thought I'd mention that.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21509 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-06 22:47:54 +00:00
kohsuke 3f20513201 allow multi-level CLI target resolution, so that resolution of Run can piggy back on that of Job, and so on.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21497 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-05 23:31:17 +00:00
kohsuke cbf4b41080 made multiple @Argument work co-operatively.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21485 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-05 14:48:11 +00:00
mindless 22b729ff81 Add authentication support in hudson.Main (if username/password are included in
HUDSON_HOME URL, then include Authorization header in Hudson http requests).

Also moved Functions.isUnitTest to Main.isUnitTest, to remove dependency on
winstone.jar for running hudson.Main (Main uses EnvVars which checks isUnitTest
flag.. in Functions which uses servlet classes).

Updated http://wiki.hudson-ci.org/display/HUDSON/Monitoring+external+jobs
with info about required jars and authentication.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21479 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-05 04:49:03 +00:00
kohsuke 5eaec18e1b Merged revisions 21462,21464,21467 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r21462 | kohsuke | 2009-09-04 13:21:46 -0700 (Fri, 04 Sep 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_323
........
  r21464 | kohsuke | 2009-09-04 13:22:01 -0700 (Fri, 04 Sep 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r21467 | kohsuke | 2009-09-04 13:53:51 -0700 (Fri, 04 Sep 2009) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21477 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-05 00:38:09 +00:00
kohsuke b160e61e7b perhaps this is causing a build failure?
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21460 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-04 18:17:39 +00:00
gliptak 704807ffd2 Separating CVS functionality into a standalone plugin.
https://hudson.dev.java.net/issues/show_bug.cgi?id=3101

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21459 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-04 17:26:45 +00:00
kohsuke 940fc1c658 doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21450 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-04 01:30:37 +00:00